[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116928384 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -116,66 +116,53 @@ public Collection ass

[GitHub] [flink] snuyanzin commented on pull request #20655: [FLINK-23020][table-planner] Use FlinkDefaultRelMetadataProvider when accessing FlinkRelMetadataQuery from a different thread

2023-02-24 Thread via GitHub
snuyanzin commented on PR #20655: URL: https://github.com/apache/flink/pull/20655#issuecomment-1443615824 I read through the jira issue and from what I see there I feel a lack of test reproducing jira issue. Can we have such here to be sure that this is the actual root cause? -- This is

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116916563 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] zentol commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
zentol commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116916266 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map calculateScore(

[GitHub] [flink] zentol commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
zentol commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116916266 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map calculateScore(

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116904470 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the A

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116899011 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateSizeEstimates.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116894644 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/DefaultSlotAssigner.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] ChenZhongPu closed pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo

2023-02-24 Thread via GitHub
ChenZhongPu closed pull request #21989: [FLINK-31174][Doc] Resolve inconsistent data format between Learn-Flink Doc and flink-training-repo URL: https://github.com/apache/flink/pull/21989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116887448 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/AllocationsInfo.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softw

[jira] [Commented] (FLINK-12449) [Bitwise Functions] Add BIT_AND, BIT_OR functions supported in Table API and SQL

2023-02-24 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693172#comment-17693172 ] Ran Tao commented on FLINK-12449: - [~libenchao] Hi, benchao. can u help to review it?. t

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116881589 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -0,0 +1,199 @@ +/* + * Licensed to the A

[jira] [Closed] (FLINK-31114) Batch job fails with IllegalStateException when using adaptive batch scheduler

2023-02-24 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-31114. -- Resolution: Fixed > Batch job fails with IllegalStateException when using adaptive batch scheduler > -

[GitHub] [flink] snuyanzin commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-24 Thread via GitHub
snuyanzin commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1116870255 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java: ## @@ -71,7 +71,11 @@ public final

[jira] [Commented] (FLINK-31114) Batch job fails with IllegalStateException when using adaptive batch scheduler

2023-02-24 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693162#comment-17693162 ] Lijie Wang commented on FLINK-31114: Fixed via  master: b987ae18d0bc353c631bc54871b

[GitHub] [flink] wanglijie95 closed pull request #21963: [FLINK-31114][runtime] Set parallelism of job vertices in forward group at compilation phase

2023-02-24 Thread via GitHub
wanglijie95 closed pull request #21963: [FLINK-31114][runtime] Set parallelism of job vertices in forward group at compilation phase URL: https://github.com/apache/flink/pull/21963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] liuyongvs commented on a diff in pull request #21993: [FLINK-31166][table] Fix array_contains does not support null argumen…

2023-02-24 Thread via GitHub
liuyongvs commented on code in PR #21993: URL: https://github.com/apache/flink/pull/21993#discussion_r1116473617 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java: ## @@ -71,7 +71,11 @@ public final

[jira] [Updated] (FLINK-12449) [Bitwise Functions] Add BIT_AND, BIT_OR functions supported in Table API and SQL

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12449: --- Labels: auto-unassigned pull-request-available (was: auto-unassigned) > [Bitwise Functions]

[GitHub] [flink] flinkbot commented on pull request #22015: [FLINK-12449][table] Add BIT_AND, BIT_OR functions supported in Table API and SQL

2023-02-24 Thread via GitHub
flinkbot commented on PR #22015: URL: https://github.com/apache/flink/pull/22015#issuecomment-1443552696 ## CI report: * 8d809ef0677fe292c6803d502f67009680f1a272 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] chucheng92 opened a new pull request, #22015: [FLINK_12449] Add BIT_AND, BIT_OR functions supported in Table API and SQL

2023-02-24 Thread via GitHub
chucheng92 opened a new pull request, #22015: URL: https://github.com/apache/flink/pull/22015 ## What is the purpose of the change Add BIT_AND, BIT_OR function ## Brief change log BIT_AND, BIT_OR for table & sql ## Verifying this change ScalarFunctionsTest

[jira] [Commented] (FLINK-31206) Broken links on flink.apache.org

2023-02-24 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693137#comment-17693137 ] Zili Chen commented on FLINK-31206: --- [~martijnvisser] Thanks for your follow-ups! See

[jira] [Commented] (FLINK-22922) Migrate flink project website to Hugo

2023-02-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693132#comment-17693132 ] Chesnay Schepler commented on FLINK-22922: -- ??I see now we use `asf-site` for b

[jira] [Comment Edited] (FLINK-22922) Migrate flink project website to Hugo

2023-02-24 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693132#comment-17693132 ] Chesnay Schepler edited comment on FLINK-22922 at 2/24/23 10:47 AM: --

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116813631 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/JobSchedulingPlan.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Commented] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693131#comment-17693131 ] Martijn Visser commented on FLINK-31212: Ah good, thanks. [~godfreyhe] [~linco

[GitHub] [flink] rkhachatryan commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
rkhachatryan commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116811933 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map calculateS

[jira] [Commented] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693130#comment-17693130 ] Lyn Zhang commented on FLINK-31212: --- [~martijnvisser]  I select the wrong version and

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Affects Version/s: 1.16.1 (was: 1.8.4) > Data lost if window group after in

[jira] [Commented] (FLINK-28897) Fail to use udf in added jar when enabling checkpoint

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693125#comment-17693125 ] Martijn Visser commented on FLINK-28897: [~lsy] Thans for the clarification. Sho

[jira] [Commented] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693122#comment-17693122 ] Martijn Visser commented on FLINK-31212: [~zicat] You've selected affected versi

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[GitHub] [flink] jd-hatzenbuhler closed pull request #20808: [FLINK-28520][runtime] RestClient doesn't use SNI TLS extension

2023-02-24 Thread via GitHub
jd-hatzenbuhler closed pull request #20808: [FLINK-28520][runtime] RestClient doesn't use SNI TLS extension URL: https://github.com/apache/flink/pull/20808 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] jd-hatzenbuhler commented on pull request #20808: [FLINK-28520][runtime] RestClient doesn't use SNI TLS extension

2023-02-24 Thread via GitHub
jd-hatzenbuhler commented on PR #20808: URL: https://github.com/apache/flink/pull/20808#issuecomment-1443423734 Not needed anymore for our use case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] jd-hatzenbuhler closed pull request #20809: [FLINK-28521][runtime] Hostname verification for Rest SSL context

2023-02-24 Thread via GitHub
jd-hatzenbuhler closed pull request #20809: [FLINK-28521][runtime] Hostname verification for Rest SSL context URL: https://github.com/apache/flink/pull/20809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] jd-hatzenbuhler commented on pull request #20809: [FLINK-28521][runtime] Hostname verification for Rest SSL context

2023-02-24 Thread via GitHub
jd-hatzenbuhler commented on PR #20809: URL: https://github.com/apache/flink/pull/20809#issuecomment-1443423451 Not needed anymore for our use case -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Affects Version/s: 1.8.4 > Data lost if window group after interval left join > --

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[GitHub] [flink] gaborgsomogyi commented on pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
gaborgsomogyi commented on PR #22009: URL: https://github.com/apache/flink/pull/22009#issuecomment-1443403080 @MartijnVisser when then mentioned suggestions are fixed then it can go. Planning to track the changes and approve it when I think it's flawless. -- This is an automated message f

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that records in table_1 left join fail will be discard b

[GitHub] [flink] flinkbot commented on pull request #22014: [FLINK-31212][table-runtime] Emit join failed record realtime

2023-02-24 Thread via GitHub
flinkbot commented on PR #22014: URL: https://github.com/apache/flink/pull/22014#issuecomment-1443399829 ## CI report: * 8a57158552e5292046a5cb9c7e84eb78dc147110 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lyn Zhang updated FLINK-31212: -- Description:   I have a case in [^test.sql] that some records in table_1 left join fail will be disc

[jira] [Updated] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31212: --- Labels: pull-request-available (was: ) > Data lost if window group after interval left join

[GitHub] [flink] zicat opened a new pull request, #22014: [FLINK-31212][table-runtime] Emit join failed record realtime

2023-02-24 Thread via GitHub
zicat opened a new pull request, #22014: URL: https://github.com/apache/flink/pull/22014 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on e

[jira] [Created] (FLINK-31212) Data lost if window group after interval left join

2023-02-24 Thread Lyn Zhang (Jira)
Lyn Zhang created FLINK-31212: - Summary: Data lost if window group after interval left join Key: FLINK-31212 URL: https://issues.apache.org/jira/browse/FLINK-31212 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-29890) UDFs classloading from JARs in 1.16 is broken

2023-02-24 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693105#comment-17693105 ] dalongliu commented on FLINK-29890: --- [~charles-tan] Yes, Please see the issue https:/

[GitHub] [flink] flinkbot commented on pull request #22013: [hotfix] [docs] Replace deprecated option in jdbc connector of Chinese document

2023-02-24 Thread via GitHub
flinkbot commented on PR #22013: URL: https://github.com/apache/flink/pull/22013#issuecomment-1443377937 ## CI report: * 4402a8c072e1110ca2d965eacadd37d46ba42d90 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #547: [FLINK-31128] Add Create Table As for flink table store

2023-02-24 Thread via GitHub
JingsongLi commented on code in PR #547: URL: https://github.com/apache/flink-table-store/pull/547#discussion_r1116731188 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkCatalog.java: ## @@ -214,6 +221,53 @@ pub

[GitHub] [flink] Mr-Gump opened a new pull request, #22013: [hotfix] [docs] Replace deprecated option in jdbc connector of Chinese version

2023-02-24 Thread via GitHub
Mr-Gump opened a new pull request, #22013: URL: https://github.com/apache/flink/pull/22013 ## Brief change log - *Replace `lookup.cache.max-rows`(deprecated) with `lookup.partial-cache.max-rows` in `Connector Options` section* ## Verifying this change The change has been verif

[GitHub] [flink] HuangXingBo commented on a diff in pull request #21770: [FLINK-30277][python]Allow PYTHONPATH of Python Worker configurable

2023-02-24 Thread via GitHub
HuangXingBo commented on code in PR #21770: URL: https://github.com/apache/flink/pull/21770#discussion_r1116691854 ## docs/layouts/shortcodes/generated/execution_config_configuration.html: ## @@ -15,7 +15,7 @@ The max number of async i/o operation that the async loo

[GitHub] [flink-table-store] tsreaper commented on a diff in pull request #550: [FLINK-31178] Public Writer API

2023-02-24 Thread via GitHub
tsreaper commented on code in PR #550: URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1116726949 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/Table.java: ## @@ -84,6 +97,58 @@ public interface Table extends Serializable {

[GitHub] [flink] zentol commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
zentol commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116723072 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/StateLocalitySlotAssigner.java: ## @@ -157,13 +165,21 @@ public Map calculateScore(

[jira] [Commented] (FLINK-28897) Fail to use udf in added jar when enabling checkpoint

2023-02-24 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693099#comment-17693099 ] dalongliu commented on FLINK-28897: --- [~martijnvisser] It only impacts users who use th

[GitHub] [flink] dmvk commented on a diff in pull request #21981: [FLINK-21450][runtime] Support LocalRecovery by AdaptiveScheduler

2023-02-24 Thread via GitHub
dmvk commented on code in PR #21981: URL: https://github.com/apache/flink/pull/21981#discussion_r1116631711 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/JobSchedulingPlan.java: ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache Software Foundation (

[jira] [Closed] (FLINK-31206) Broken links on flink.apache.org

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31206. -- Resolution: Fixed > Broken links on flink.apache.org > > >

[jira] [Commented] (FLINK-31206) Broken links on flink.apache.org

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693095#comment-17693095 ] Martijn Visser commented on FLINK-31206: [~tison] Thanks for flagging it! https

[jira] [Assigned] (FLINK-31206) Broken links on flink.apache.org

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-31206: -- Assignee: Martijn Visser > Broken links on flink.apache.org > ---

[jira] [Updated] (FLINK-31206) Broken links on flink.apache.org

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31206: --- Component/s: Project Website > Broken links on flink.apache.org > --

[GitHub] [flink] Mr-Gump closed pull request #22011: Release-1.16

2023-02-24 Thread via GitHub
Mr-Gump closed pull request #22011: Release-1.16 URL: https://github.com/apache/flink/pull/22011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [flink] flinkbot commented on pull request #22012: [FLINK-30738] Disable verbose mode of CycloneDX plugin

2023-02-24 Thread via GitHub
flinkbot commented on PR #22012: URL: https://github.com/apache/flink/pull/22012#issuecomment-1443311357 ## CI report: * 28e4655c9edc1e64d2a083a18a032a21285918bf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22011: Release-1.16

2023-02-24 Thread via GitHub
flinkbot commented on PR #22011: URL: https://github.com/apache/flink/pull/22011#issuecomment-1443310718 ## CI report: * 4402a8c072e1110ca2d965eacadd37d46ba42d90 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30738) Disable verbose mode

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30738: --- Labels: pull-request-available (was: ) > Disable verbose mode > > >

[GitHub] [flink] Jiabao-Sun opened a new pull request, #22012: [FLINK-30738] Disable verbose mode of CycloneDX plugin

2023-02-24 Thread via GitHub
Jiabao-Sun opened a new pull request, #22012: URL: https://github.com/apache/flink/pull/22012 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-30738 > The plugin has verbose mode enabled by default. we can reduce some noise in the build o

[jira] [Closed] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-02-24 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31211. -- Resolution: Information Provided Please see https://flink.apache.org/2022/05/06/improvements-

[GitHub] [flink] Mr-Gump opened a new pull request, #22011: Release-1.16

2023-02-24 Thread via GitHub
Mr-Gump opened a new pull request, #22011: URL: https://github.com/apache/flink/pull/22011 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

[jira] [Updated] (FLINK-30069) Expected prune behavior for matches with same priority

2023-02-24 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30069: -- Description: When a pattern produces several matches with same priority, is it the expected behavior

[jira] [Updated] (FLINK-30069) Expected prune behavior for matches with same priority

2023-02-24 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30069: -- Description: When a pattern produces several matches with same priority, is it the expected behavior

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116696715 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -362,30 +358,35 @@ private void testSyncSavepointWithEndInp

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116694579 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1103,35 +1143,41 @@ private void testFailToConfirmCheckpo

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
1996fanrui commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116676401 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -1103,35 +1143,41 @@ private void testFailToConfirmCheckpo

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #550: [FLINK-31178] Public Writer API

2023-02-24 Thread via GitHub
JingsongLi commented on code in PR #550: URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1116681535 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/TableCommit.java: ## @@ -18,121 +18,47 @@ package org.apache.flink.table.s

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #550: [FLINK-31178] Public Writer API

2023-02-24 Thread via GitHub
JingsongLi commented on code in PR #550: URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1116680628 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/sink/TableCommit.java: ## @@ -18,121 +18,47 @@ package org.apache.flink.table.s

[GitHub] [flink] RocMarshal commented on a diff in pull request #21999: [FLINK-29816][streaming] Fix the bug that StreamTask doesn't handle exception during restoring

2023-02-24 Thread via GitHub
RocMarshal commented on code in PR #21999: URL: https://github.com/apache/flink/pull/21999#discussion_r1116679594 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java: ## @@ -368,17 +368,19 @@ void testCleanUpExceptionSuppressing() t

[GitHub] [flink-web] dannycranmer commented on a diff in pull request #611: Flink 1.15.4

2023-02-24 Thread via GitHub
dannycranmer commented on code in PR #611: URL: https://github.com/apache/flink-web/pull/611#discussion_r1116678086 ## docs/content/posts/2023-02-23-release-1.15.4.md: ## @@ -0,0 +1,152 @@ +--- +authors: +- danny: null + name: Danny Cranmer +date: "2023-02-23T17:00:00Z" +excerp

[GitHub] [flink-web] dannycranmer commented on a diff in pull request #611: Flink 1.15.4

2023-02-24 Thread via GitHub
dannycranmer commented on code in PR #611: URL: https://github.com/apache/flink-web/pull/611#discussion_r1116677449 ## docs/content/posts/2023-02-23-release-1.15.4.md: ## @@ -0,0 +1,152 @@ +--- +authors: +- danny: null + name: Danny Cranmer +date: "2023-02-23T17:00:00Z" Review

[jira] [Commented] (FLINK-12451) [Bitwise Functions] Add BIT_XOR function supported in Table API and SQL

2023-02-24 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693082#comment-17693082 ] Ran Tao commented on FLINK-12451: - [~sunjincheng121] hi, can u assign this ticket to me.

[jira] [Assigned] (FLINK-22091) env.java.home option didn't take effect in resource negotiator

2023-02-24 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-22091: - Assignee: Samrat Deb > env.java.home option didn't take effect in resource negotiator >

[jira] [Commented] (FLINK-22091) env.java.home option didn't take effect in resource negotiator

2023-02-24 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693077#comment-17693077 ] Danny Cranmer commented on FLINK-22091: --- Thanks [~samrat007] , have assigned to yo

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #550: [FLINK-31178] Public Writer API

2023-02-24 Thread via GitHub
JingsongLi commented on code in PR #550: URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1116672314 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/AppendOnlyFileStoreTable.java: ## @@ -131,7 +130,7 @@ public RecordReader createRe

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #550: [FLINK-31178] Public Writer API

2023-02-24 Thread via GitHub
JingsongLi commented on code in PR #550: URL: https://github.com/apache/flink-table-store/pull/550#discussion_r1116671101 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWrite.java: ## @@ -38,6 +39,8 @@ FileStoreWrite withIOMan

[GitHub] [flink-web] akalash commented on pull request #524: Add Buffer debloating blog post

2023-02-24 Thread via GitHub
akalash commented on PR #524: URL: https://github.com/apache/flink-web/pull/524#issuecomment-1443131108 > @akalash Didn't you want to ultimately complete this blog post? Oh, it is so a good point. I surely have to find time for this. -- This is an automated message from the Apache G

[GitHub] [flink] MartijnVisser commented on pull request #22009: [FLINK-31109][yarn] Support Hadoop proxy user when delegation token f…

2023-02-24 Thread via GitHub
MartijnVisser commented on PR #22009: URL: https://github.com/apache/flink/pull/22009#issuecomment-1443121593 @gaborgsomogyi So all there's left are the minor review comments and then it's ready to merge from your perspective? -- This is an automated message from the Apache Git Service.

[jira] [Updated] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-02-24 Thread leo.zhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leo.zhi updated FLINK-31211: Description: Checkpoint chk files can be deleted automic when the version of flink 1.13, but we upgert to

[jira] [Updated] (FLINK-18896) Translate "stateful-functions" page into Chinese

2023-02-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18896: --- Labels: pull-request-available (was: ) > Translate "stateful-functions" page into Chinese >

[GitHub] [flink-web] MartijnVisser commented on pull request #341: [FLINK-18896][docs-zh] Translate "stateful-functions" page into Chinese

2023-02-24 Thread via GitHub
MartijnVisser commented on PR #341: URL: https://github.com/apache/flink-web/pull/341#issuecomment-1443110385 Closing this PR since this documentation is no longer part of the Flink project website itself -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink-web] MartijnVisser closed pull request #341: [FLINK-18896][docs-zh] Translate "stateful-functions" page into Chinese

2023-02-24 Thread via GitHub
MartijnVisser closed pull request #341: [FLINK-18896][docs-zh] Translate "stateful-functions" page into Chinese URL: https://github.com/apache/flink-web/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink-web] MartijnVisser commented on pull request #346: Create Japanese Edition.

2023-02-24 Thread via GitHub
MartijnVisser commented on PR #346: URL: https://github.com/apache/flink-web/pull/346#issuecomment-1443108297 Closing this PR due to inactivity / other priorities -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-web] MartijnVisser closed pull request #346: Create Japanese Edition.

2023-02-24 Thread via GitHub
MartijnVisser closed pull request #346: Create Japanese Edition. URL: https://github.com/apache/flink-web/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [flink-web] MartijnVisser commented on pull request #521: [hotfix][docs] Fix link tags typo.

2023-02-24 Thread via GitHub
MartijnVisser commented on PR #521: URL: https://github.com/apache/flink-web/pull/521#issuecomment-1443103518 Resolved by the migration to Hugo via https://issues.apache.org/jira/browse/FLINK-22922 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [flink-web] MartijnVisser closed pull request #521: [hotfix][docs] Fix link tags typo.

2023-02-24 Thread via GitHub
MartijnVisser closed pull request #521: [hotfix][docs] Fix link tags typo. URL: https://github.com/apache/flink-web/pull/521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Created] (FLINK-31211) Flink chk files not delete automic after 1.13

2023-02-24 Thread leo.zhi (Jira)
leo.zhi created FLINK-31211: --- Summary: Flink chk files not delete automic after 1.13 Key: FLINK-31211 URL: https://issues.apache.org/jira/browse/FLINK-31211 Project: Flink Issue Type: Bug Affec

[GitHub] [flink-web] MartijnVisser commented on pull request #524: Add Buffer debloating blog post

2023-02-24 Thread via GitHub
MartijnVisser commented on PR #524: URL: https://github.com/apache/flink-web/pull/524#issuecomment-1443102780 @akalash Didn't you want to ultimately complete this blog post? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-web] MartijnVisser closed pull request #598: [hotfix] Fix typo in contribute-documentation

2023-02-24 Thread via GitHub
MartijnVisser closed pull request #598: [hotfix] Fix typo in contribute-documentation URL: https://github.com/apache/flink-web/pull/598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

<    1   2   3   >