[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142920457 ## docs/content/docs/dev/table/sql/describe.md: ## @@ -112,11 +112,11 @@ table_env = TableEnvironment.create(...) # register a table named "Orders"

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142919830 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2528,7 +2528,14 @@ class TableEnvironmentTest {

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142919231 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala: ## @@ -1060,6 +1060,61 @@ class

[GitHub] [flink] reswqa commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

reswqa commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142918984 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager

[GitHub] [flink] FangYongs commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

FangYongs commented on PR #7: URL: https://github.com/apache/flink/pull/7#issuecomment-1477305621 @fsk119 Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] FangYongs commented on pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

FangYongs commented on PR #1: URL: https://github.com/apache/flink/pull/1#issuecomment-1477305048 Thanks @libenchao Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703036#comment-17703036 ] zhang haoyan commented on FLINK-31495: -- I see,  but it is still very hard to look through all the

[jira] [Updated] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-24045: --- Fix Version/s: 1.15.5 (was: 1.16.0) >

[jira] [Commented] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703031#comment-17703031 ] Leonard Xu commented on FLINK-24045: The same test failed in release-1.15 again, although it fails

[GitHub] [flink] huwh commented on pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

huwh commented on PR #22196: URL: https://github.com/apache/flink/pull/22196#issuecomment-1477286542 Thanks @reswqa , squash some commits, and address the first comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Reopened] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reopened FLINK-24045: > KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure >

[GitHub] [flink] huwh commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

huwh commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142891394 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager

[jira] [Commented] (FLINK-24095) Elasticsearch7DynamicSinkITCase.testWritingDocuments fails due to socket timeout

[ https://issues.apache.org/jira/browse/FLINK-24095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703027#comment-17703027 ] Leonard Xu commented on FLINK-24095: {noformat} Mar 14 01:50:08 [ERROR]

[jira] [Created] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

Leonard Xu created FLINK-31531: -- Summary: Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure Key: FLINK-31531 URL: https://issues.apache.org/jira/browse/FLINK-31531 Project:

[GitHub] [flink] luoyuxia commented on a diff in pull request #21645: [FLINK-30556] Introduce the StaticPartitionFileSplitEnumerator

luoyuxia commented on code in PR #21645: URL: https://github.com/apache/flink/pull/21645#discussion_r1142880392 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/StaticPartitionFileSplitEnumerator.java: ## @@ -0,0 +1,154 @@ +/* + *

[GitHub] [flink] FangYongs commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

FangYongs commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142874300 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -0,0 +1,77 @@ + + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] FangYongs commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

FangYongs commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142873836 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkDriver.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[jira] [Created] (FLINK-31530) For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle

xingyuan cheng created FLINK-31530: -- Summary: For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle Key: FLINK-31530 URL:

[GitHub] [flink] flinkbot commented on pull request #22229: support oraclecatalog

flinkbot commented on PR #9: URL: https://github.com/apache/flink/pull/9#issuecomment-1477257633 ## CI report: * fc38434942b13ac692b5145d1e4fa1b6aeb79624 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] complone opened a new pull request, #22229: support oraclecatalog

complone opened a new pull request, #9: URL: https://github.com/apache/flink/pull/9 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] lincoln-lil commented on pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

lincoln-lil commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1477251531 @luoyuxia seems the latest change failed to pass the style check, PTAL otherwise +1 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

lincoln-lil commented on code in PR #22166: URL: https://github.com/apache/flink/pull/22166#discussion_r1142868437 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -169,17 +171,46 @@ abstract class PlannerBase(

[jira] [Updated] (FLINK-31479) Close blocking iterators in tests

[ https://issues.apache.org/jira/browse/FLINK-31479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31479: --- Labels: pull-request-available (was: ) > Close blocking iterators in tests >

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted

[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703016#comment-17703016 ] Junhan Yang commented on FLINK-30719: - Hi, I spent a while investigating on this, and I still

[GitHub] [flink] lindong28 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

lindong28 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1142856743 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java: ## @@ -153,6 +153,8 @@ public

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #220: [FLINK-31325] Improve performance of Swing

Fanoid commented on code in PR #220: URL: https://github.com/apache/flink-ml/pull/220#discussion_r1142859028 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java: ## @@ -289,36 +303,40 @@ public void endInput() throws Exception { Map

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703014#comment-17703014 ] Feng Jin commented on FLINK-31259: -- [~zjureel] [~fsk119]  Sorry, the description in the document is not

[jira] [Resolved] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-31486. -- Resolution: Fixed > Using KeySelector in IterationBody causes ClassCastException >

[jira] [Commented] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703005#comment-17703005 ] Dong Lin commented on FLINK-31486: -- Merged to apache/flink-ml master branch

[jira] [Assigned] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31486: Assignee: Jiang Xin > Using KeySelector in IterationBody causes ClassCastException >

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #222: [FLINK-31029] Fix bug when using quantile in KbinsDiscretizer

Fanoid commented on code in PR #222: URL: https://github.com/apache/flink-ml/pull/222#discussion_r1142849665 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizer.java: ## @@ -220,22 +220,46 @@ private static double[][]

[GitHub] [flink] liuyongvs commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

liuyongvs commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142850269 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink-ml] lindong28 merged pull request #226: [FLINK-31486] Get the KeySelector with UserClassLoader

lindong28 merged PR #226: URL: https://github.com/apache/flink-ml/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703004#comment-17703004 ] Darcy Lin commented on FLINK-31259: --- [~fsk119] I generally agree with your conclusions. I see that in

[jira] [Comment Edited] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703002#comment-17703002 ] Shengkai Fang edited comment on FLINK-31259 at 3/21/23 3:03 AM:

[GitHub] [flink-ml] lindong28 commented on pull request #226: [FLINK-31486] Get the KeySelector with UserClassLoader

lindong28 commented on PR #226: URL: https://github.com/apache/flink-ml/pull/226#issuecomment-1477218565 Thanks for the PR! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17703002#comment-17703002 ] Shengkai Fang commented on FLINK-31259: --- [~zjureel]  Thanks for pointing out the correct

[jira] [Updated] (FLINK-31433) Make SchemaChange serializable

[ https://issues.apache.org/jira/browse/FLINK-31433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31433: --- Labels: pull-request-available (was: ) > Make SchemaChange serializable >

[jira] [Closed] (FLINK-31432) Introduce a special StoreWriteOperator to deal with schema changes

[ https://issues.apache.org/jira/browse/FLINK-31432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-31432. --- Resolution: Fixed master: 556443f098252a98610a03450ed8ad2a661f27dd > Introduce a special

[GitHub] [flink] chucheng92 commented on pull request #22220: [FLINK-31500][table-planner] Move SqlAlterTableSchema conversion logic to SqlAlterTableSchemaConverter

chucheng92 commented on PR #0: URL: https://github.com/apache/flink/pull/0#issuecomment-1477207123 @wuchong PTAL. how about reuse previous AlterSchemaConverter? or we extract the convert utils from AlterSchemaConverter and shrink in SqlAlterTableConverter. -- This is an

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702999#comment-17702999 ] Fang Yong commented on FLINK-31259: --- Thanks [~fsk119] I found some differences between your

[jira] [Comment Edited] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702994#comment-17702994 ] Shengkai Fang edited comment on FLINK-31259 at 3/21/23 2:25 AM: I

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702994#comment-17702994 ] Shengkai Fang commented on FLINK-31259: --- I apologize for the delay in my response. After

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702988#comment-17702988 ] zlzhang0122 commented on FLINK-31495: - IMHO this is not a problem, if you mouseover the selection,

[jira] [Updated] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-31524: - Issue Type: Technical Debt (was: Bug) > StreamDependencyTests.test_add_python_file failed >

[jira] [Assigned] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reassigned FLINK-31524: Assignee: Xingbo Huang > StreamDependencyTests.test_add_python_file failed >

[jira] [Updated] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-31524: - Priority: Major (was: Blocker) > StreamDependencyTests.test_add_python_file failed >

[jira] [Commented] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702985#comment-17702985 ] Xingbo Huang commented on FLINK-31524: -- [~mapohl] Thanks a lot for reporting this issue. The

[jira] [Commented] (FLINK-31424) NullPointer when using StatementSet for multiple sinks

[ https://issues.apache.org/jira/browse/FLINK-31424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702977#comment-17702977 ] Jane Chan commented on FLINK-31424: --- I opened a PR, and it would be great if you could help to review

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142753109 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142751406 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142751304 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750735 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750566 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750315 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream

[GitHub] [flink-web] JingGe commented on pull request #624: remove Jekyll toc

JingGe commented on PR #624: URL: https://github.com/apache/flink-web/pull/624#issuecomment-1476876332 @MartijnVisser Would you like to check if I did it right? Thanks! Just saw weird `{% toc %}` while reading Flink blogs, e.g. https://flink.apache.org/2022/02/22/scala-free-in-one-fifteen/

[GitHub] [flink] flinkbot commented on pull request #22228: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

flinkbot commented on PR #8: URL: https://github.com/apache/flink/pull/8#issuecomment-1476799487 ## CI report: * 1df0da7d5379ee6bcd44869a42688af76f820eac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31049) Add support for Kafka record headers to KafkaSink

[ https://issues.apache.org/jira/browse/FLINK-31049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31049: --- Labels: KafkaSink pull-request-available (was: KafkaSink) > Add support for Kafka record

[GitHub] [flink] AlexAxeman opened a new pull request, #22228: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

AlexAxeman opened a new pull request, #8: URL: https://github.com/apache/flink/pull/8 ## What is the purpose of the change The default `org.apache.flink.connector.kafka.sink.KafkaSink` does not support adding Kafka record headers when using

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702861#comment-17702861 ] Matthias Pohl commented on FLINK-31490: --- There is something that looks like a hickup of 5s in the

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702858#comment-17702858 ] Matthias Pohl commented on FLINK-31490: --- hm, the server logs show that the session were stopped:

[jira] [Commented] (FLINK-31509) REST Service missing sessionAffinity causes job run failure with HA cluster

[ https://issues.apache.org/jira/browse/FLINK-31509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702823#comment-17702823 ] Emmanuel Leroy commented on FLINK-31509: [~bgeng777]  I agree ideally the Service should only

[GitHub] [flink] flinkbot commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

flinkbot commented on PR #7: URL: https://github.com/apache/flink/pull/7#issuecomment-1476417025 ## CI report: * 9f45c13538ab75fbbd0d6b9238a92709ef2833bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] libenchao commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

libenchao commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142076440 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkDriver.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-31523) Merge query files and processing in sql client and gateway

[ https://issues.apache.org/jira/browse/FLINK-31523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31523: --- Labels: pull-request-available (was: ) > Merge query files and processing in sql client

[GitHub] [flink] FangYongs opened a new pull request, #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

FangYongs opened a new pull request, #7: URL: https://github.com/apache/flink/pull/7 ## What is the purpose of the change There're .q files and script readers in client and gateway, which are quite similar. This PR aims to merge the .q files in gateway module and merge the

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

mbalassi commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142261346 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

mbalassi commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142261062 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

gyfora commented on PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#issuecomment-1476388021 > I've just had a deeper look at the test issues and here are my findings: > > * The originally used `createOrReplace` has the following semantics > > *

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142251396 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

gyfora commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142249645 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14 +58,14

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #549: [FLINK-31502] Limit the number of scale operations to reduce cluster churn

gyfora commented on code in PR #549: URL: https://github.com/apache/flink-kubernetes-operator/pull/549#discussion_r1142244157 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -86,6 +86,12 @@ Duration Interval at which periodic

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142241969 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142239563 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142241182 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date:

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142227595 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-31167) Verify that no exclusions were erroneously added to the japicmp plugin

[ https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-31167. --- Resolution: Fixed I guess it's reasonable considering that we used the same approach in the

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702760#comment-17702760 ] Matthias Pohl commented on FLINK-31490: --- ok, makes sense. FLINK-27848 is kind of strange, anyway,

[GitHub] [flink] LadyForest commented on pull request #22222: [FLINK-31424][table-planner] Fix NPE produced by multiple sink with local-global window aggregate

LadyForest commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-1476347631 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142213149 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142213149 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142211308 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702738#comment-17702738 ] Martijn Visser commented on FLINK-26088: [~mtfelisb] Are you still planning to work on this? >

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142173968 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraSplitEnumerator.java: ## @@ -0,0 +1,149 @@

[jira] [Commented] (FLINK-31033) UsingRemoteJarITCase.testUdfInRemoteJar failed with assertion

[ https://issues.apache.org/jira/browse/FLINK-31033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702720#comment-17702720 ] Matthias Pohl commented on FLINK-31033: ---

[jira] [Updated] (FLINK-31033) UsingRemoteJarITCase.testUdfInRemoteJar failed with assertion

[ https://issues.apache.org/jira/browse/FLINK-31033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31033: -- Affects Version/s: 1.17.0 > UsingRemoteJarITCase.testUdfInRemoteJar failed with assertion >

[jira] [Updated] (FLINK-31033) UsingRemoteJarITCase.testUdfInRemoteJar failed with assertion

[ https://issues.apache.org/jira/browse/FLINK-31033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31033: -- Priority: Critical (was: Major) > UsingRemoteJarITCase.testUdfInRemoteJar failed with

[jira] [Assigned] (FLINK-28372) Investigate Akka Artery

[ https://issues.apache.org/jira/browse/FLINK-28372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-28372: -- Assignee: Ferenc Csaky > Investigate Akka Artery > --- > >

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17702707#comment-17702707 ] Chesnay Schepler commented on FLINK-31490: -- I think we only use such an argument if the bug was

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142134134 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraEnumeratorStateSerializer.java: ## @@ -0,0

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142134134 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/enumerator/CassandraEnumeratorStateSerializer.java: ## @@ -0,0

[GitHub] [flink] chucheng92 commented on a diff in pull request #22207: FLINK-31510. Use getMemorySize instead of getMemory.

chucheng92 commented on code in PR #22207: URL: https://github.com/apache/flink/pull/22207#discussion_r1141590982 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -670,22 +670,22 @@ private ClusterSpecification validateClusterResources(

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142115352 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -75,54 +77,68 @@ public

[GitHub] [flink] chucheng92 commented on a diff in pull request #22215: [FLINK-31507][table] Move execution logic of ShowOperation out from TableEnvironmentImpl

chucheng92 commented on code in PR #22215: URL: https://github.com/apache/flink/pull/22215#discussion_r1141572379 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowTablesOperation.java: ## @@ -104,4 +112,33 @@ public String

[GitHub] [flink] chucheng92 commented on pull request #22215: [FLINK-31507][table] Move execution logic of ShowOperation out from TableEnvironmentImpl

chucheng92 commented on PR #22215: URL: https://github.com/apache/flink/pull/22215#issuecomment-1476227930 > Yes, @chucheng92 , the new implementation also sorts the table list (in the useLike block). Sorry, found that in the useLike block. looks good from my side -- This is an

[GitHub] [flink] wuchong commented on pull request #22215: [FLINK-31507][table] Move execution logic of ShowOperation out from TableEnvironmentImpl

wuchong commented on PR #22215: URL: https://github.com/apache/flink/pull/22215#issuecomment-1476225146 Yes, @chucheng92 , the new implementation also sorts the table list (in the useLike block). -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] chucheng92 commented on pull request #22215: [FLINK-31507][table] Move execution logic of ShowOperation out from TableEnvironmentImpl

chucheng92 commented on PR #22215: URL: https://github.com/apache/flink/pull/22215#issuecomment-1476215855 @snuyanzin pls see master: https://github.com/apache/flink/blob/master/flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java

[GitHub] [flink] snuyanzin commented on pull request #22215: [FLINK-31507][table] Move execution logic of ShowOperation out from TableEnvironmentImpl

snuyanzin commented on PR #22215: URL: https://github.com/apache/flink/pull/22215#issuecomment-1476209570 @chucheng92 may be I missed something, however I wonder if it's not sorted here

[GitHub] [flink] flinkbot commented on pull request #22226: [FLINK-31214][python] Add support for new cli option -py.pythonpath

flinkbot commented on PR #6: URL: https://github.com/apache/flink/pull/6#issuecomment-1476200355 ## CI report: * 1d39a4bcdc056fe8a3fdba4dfdb241c4e9cdea52 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22225: [FLINK-31511][doc-zh] Update the document sql_functions_zh.yml and fix some parts in sql_functions.yml

flinkbot commented on PR #5: URL: https://github.com/apache/flink/pull/5#issuecomment-1476200141 ## CI report: * 70219eace890cdf087455e8453984c099a08bd41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   3   >