[GitHub] [flink] jaumebecks commented on pull request #20343: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2023-03-27 Thread via GitHub
jaumebecks commented on PR #20343: URL: https://github.com/apache/flink/pull/20343#issuecomment-1486296425 > > Shall we close this PR and move the conversation to [apache/flink-connector-kafka#5](https://github.com/apache/flink-connector-kafka/pull/5)? > > yes please. We're removing t

[jira] [Commented] (FLINK-31550) Replace deprecated TableSchema with Schema in OperationConverterUtils

2023-03-27 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705828#comment-17705828 ] Aitozi commented on FLINK-31550: Is this stale? {{OperationConverterUtils}} do not use {

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-27 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1150039863 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to th

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-27 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1150039863 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to th

[jira] [Created] (FLINK-31634) FLIP-301: Hybrid Shuffle supports Remote Storage

2023-03-27 Thread Yuxin Tan (Jira)
Yuxin Tan created FLINK-31634: - Summary: FLIP-301: Hybrid Shuffle supports Remote Storage Key: FLINK-31634 URL: https://issues.apache.org/jira/browse/FLINK-31634 Project: Flink Issue Type: New Fe

[GitHub] [flink] lincoln-lil merged pull request #22278: [hotfix][doc][table] Fix the incorrect syntax description for explain statement set

2023-03-27 Thread via GitHub
lincoln-lil merged PR #22278: URL: https://github.com/apache/flink/pull/22278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] wuchong commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable

2023-03-27 Thread via GitHub
wuchong commented on PR #22255: URL: https://github.com/apache/flink/pull/22255#issuecomment-1486172353 @chucheng92 , yes, as I mentioned in the JIRA issue, this effort is to make it easier for us to remove the deprecated interfaces. -- This is an automated message from the Apache Git Se

[jira] [Created] (FLINK-31633) Hive dialect can't order by an unselected column

2023-03-27 Thread luoyuxia (Jira)
luoyuxia created FLINK-31633: Summary: Hive dialect can't order by an unselected column Key: FLINK-31633 URL: https://issues.apache.org/jira/browse/FLINK-31633 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-31625) Memory and computation inefficiency in KBinsDiscretizer

2023-03-27 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31625: - Description: In KBinsDiscretizer, the main computation `findBinEdgesWithXXXStrategy` is accomplished in

[jira] [Updated] (FLINK-31625) Memory and computation inefficiency in KBinsDiscretizer

2023-03-27 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31625: - Description: In KBinsDiscretizer, the main computation `findBinEdgesWithXXXStrategy` is accomplished in

[jira] [Updated] (FLINK-31625) Memory and computation inefficiency in KBinsDiscretizer

2023-03-27 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31625: - Summary: Memory and computation inefficiency in KBinsDiscretizer (was: Possbile OOM in KBinsDiscretizer

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-27 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1149970443 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to th

[GitHub] [flink] liuyongvs commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-27 Thread via GitHub
liuyongvs commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1149969980 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to th

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
Ge commented on code in PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#discussion_r1149969126 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java: ## @@ -140,7 +141,7 @@ private RowData cha

[GitHub] [flink] fsk119 commented on a diff in pull request #22277: [FLINK-31621][table] Add built-in ARRAY_REVERSE function.

2023-03-27 Thread via GitHub
fsk119 commented on code in PR #22277: URL: https://github.com/apache/flink/pull/22277#discussion_r1149963539 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayReverseFunction.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the A

[GitHub] [flink] FangYongs commented on pull request #22259: [FLINK-31522] Introduce FlinkResultSet for jdbc driver

2023-03-27 Thread via GitHub
FangYongs commented on PR #22259: URL: https://github.com/apache/flink/pull/22259#issuecomment-1486112232 Thanks @libenchao , updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-31281) PythonFunctionRunner doesn't extend AutoCloseable but implements close

2023-03-27 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao closed FLINK-31281. --- Resolution: Not A Problem > PythonFunctionRunner doesn't extend AutoCloseable but implements close > ---

[jira] [Commented] (FLINK-31281) PythonFunctionRunner doesn't extend AutoCloseable but implements close

2023-03-27 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705762#comment-17705762 ] Ran Tao commented on FLINK-31281: - got it. i will close it.[~mapohl]  > PythonFunctionR

[jira] [Created] (FLINK-31632) watermark aligned idle source can't resume

2023-03-27 Thread haishui (Jira)
haishui created FLINK-31632: --- Summary: watermark aligned idle source can't resume Key: FLINK-31632 URL: https://issues.apache.org/jira/browse/FLINK-31632 Project: Flink Issue Type: Bug Co

[jira] [Updated] (FLINK-31623) Change to uniform sampling in DataStreamUtils#sample method

2023-03-27 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fan Hong updated FLINK-31623: - Description: Current implementation employs two-level sampling method. However, when data instances are

[GitHub] [flink-ml] Fanoid opened a new pull request, #227: Fix DataStreamUtils#sample to uniform sampling.

2023-03-27 Thread via GitHub
Fanoid opened a new pull request, #227: URL: https://github.com/apache/flink-ml/pull/227 ## What is the purpose of the change This modification will resolve the issue with `DataStreamUtils#sample` by implementing uniform sampling. The current implementation utilizes a two-l

[jira] [Assigned] (FLINK-31240) Reduce the overhead of conversion between DataStream and Table

2023-03-27 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31240: Assignee: Yunfeng Zhou (was: Jiang Xin) > Reduce the overhead of conversion between DataStream a

[jira] [Commented] (FLINK-31240) Reduce the overhead of conversion between DataStream and Table

2023-03-27 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705739#comment-17705739 ] Dong Lin commented on FLINK-31240: -- [~yunfengzhou] Can you explain the impact of this p

[GitHub] [flink] jiangxin369 closed pull request #22034: [FLINK-31240][table] Reduce the overhead of conversion between DataStream and Table

2023-03-27 Thread via GitHub
jiangxin369 closed pull request #22034: [FLINK-31240][table] Reduce the overhead of conversion between DataStream and Table URL: https://github.com/apache/flink/pull/22034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (FLINK-31612) ClassNotFoundException when using GCS path as HA directory

2023-03-27 Thread 陳昌倬
[ https://issues.apache.org/jira/browse/FLINK-31612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705738#comment-17705738 ] ChangZhuo Chen (陳昌倬) commented on FLINK-31612: -- We have confirmed this PR c

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-03-27 Thread via GitHub
tzulitai commented on PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#issuecomment-1486051189 hey @Ge, thanks for opening this PR! In addition to these changes, I think we have to let `ReducingUpsertSink` implement `TwoPhaseCommittingSink` as well. Expla

[GitHub] [flink] FangYongs commented on pull request #22233: [FLINK-31538][jdbc-driver] Supports parse catalog/database and properties for uri

2023-03-27 Thread via GitHub
FangYongs commented on PR #22233: URL: https://github.com/apache/flink/pull/22233#issuecomment-1486041523 Thanks @libenchao I have introduced utils for jdbc driver and add invalid uri tests, please help to review again when you're free -- This is an automated message from the Apache Git S

[jira] [Comment Edited] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705651#comment-17705651 ] Tzu-Li (Gordon) Tai edited comment on FLINK-31305 at 3/28/23 12:22 AM: ---

[GitHub] [flink] tzulitai closed pull request #22282: [BP-1.16][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai closed pull request #22282: [BP-1.16][FLINK-31305] Propagate producer exceptions outside of mailbox execut… URL: https://github.com/apache/flink/pull/22282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] tzulitai commented on pull request #22282: [BP-1.16][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai commented on PR #22282: URL: https://github.com/apache/flink/pull/22282#issuecomment-1486034250 Manually merged via `df6c4345d2e1b321cd77e74aa2b028b482b69f3c` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink] tzulitai closed pull request #22283: [BP-1.17][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai closed pull request #22283: [BP-1.17][FLINK-31305] Propagate producer exceptions outside of mailbox execut… URL: https://github.com/apache/flink/pull/22283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] tzulitai commented on pull request #22283: [BP-1.17][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai commented on PR #22283: URL: https://github.com/apache/flink/pull/22283#issuecomment-1486033896 Manually merged via `b8a9fe5a9942fb6cf11ed56a807d68d375339259` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [flink-connector-kafka] RamanVerma commented on a diff in pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-27 Thread via GitHub
RamanVerma commented on code in PR #15: URL: https://github.com/apache/flink-connector-kafka/pull/15#discussion_r1149828787 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/FlinkKafkaInternalProducerITCase.java: ## @@ -81,12 +81,64 @@ void testInitTr

[GitHub] [flink] flinkbot commented on pull request #22283: [BP-1.17][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
flinkbot commented on PR #22283: URL: https://github.com/apache/flink/pull/22283#issuecomment-1485834817 ## CI report: * b8a9fe5a9942fb6cf11ed56a807d68d375339259 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22282: [BP-1.16][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
flinkbot commented on PR #22282: URL: https://github.com/apache/flink/pull/22282#issuecomment-1485833924 ## CI report: * df6c4345d2e1b321cd77e74aa2b028b482b69f3c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] mas-chen opened a new pull request, #22283: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
mas-chen opened a new pull request, #22283: URL: https://github.com/apache/flink/pull/22283 …or so that checkpoints can correctly fail This closes #22150. 1.17 backport for https://github.com/apache/flink/pull/22150 -- This is an automated message from the Apache Git Service.

[GitHub] [flink] mas-chen opened a new pull request, #22282: [BP-1.16][FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
mas-chen opened a new pull request, #22282: URL: https://github.com/apache/flink/pull/22282 …or so that checkpoints can correctly fail This closes #22150. 1.16 backport for https://github.com/apache/flink/pull/22150 -- This is an automated message from the Apache Git Service.

[GitHub] [flink] cnauroth commented on pull request #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
cnauroth commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1485814066 Thank you, @MartijnVisser . I've updated the pull request with additional NOTICE entries, and I've removed the previous changes in the licenses sub-directory. -- This is an automated

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
tzulitai commented on code in PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#discussion_r1149707598 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java: ## @@ -140,7 +141,7 @@ private RowData c

[jira] [Assigned] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-31620: --- Assignee: Alex Sorokoumov > ReducingUpsertWriter does not flush the wrapped

[jira] [Updated] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31620: Affects Version/s: 1.16.1 1.17.0 > ReducingUpsertWriter doe

[jira] [Updated] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-31620: Priority: Critical (was: Major) > ReducingUpsertWriter does not flush the wrapped

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
tzulitai commented on code in PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#discussion_r1149707598 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java: ## @@ -140,7 +141,7 @@ private RowData c

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
tzulitai commented on code in PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#discussion_r1149707598 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/ReducingUpsertWriter.java: ## @@ -140,7 +141,7 @@ private RowData c

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-27 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1149689034 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -951,6 +949,138 @@ void testConsistentMaxParallelism()

[jira] [Comment Edited] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705651#comment-17705651 ] Tzu-Li (Gordon) Tai edited comment on FLINK-31305 at 3/27/23 7:07 PM:

[jira] [Commented] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-27 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705651#comment-17705651 ] Tzu-Li (Gordon) Tai commented on FLINK-31305: - Merged for {{apache/flink:mai

[GitHub] [flink] tzulitai closed pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai closed pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut… URL: https://github.com/apache/flink/pull/22150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tzulitai commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1149672884 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -397,6 +413,20 @@ private void registerMetricSync

[GitHub] [flink] tzulitai commented on pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai commented on PR #22150: URL: https://github.com/apache/flink/pull/22150#issuecomment-1485694332 +1, LGTM. Thanks for addressing my comment @mas-chen! Merging this now ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] MartijnVisser commented on pull request #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
MartijnVisser commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1485682027 The CI fails on the licensing check, see https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=47622&view=logs&j=bea52777-eaf8-5663-8482-18fbc3630e81&t=d6e79740-7cf7

[GitHub] [flink] MartijnVisser commented on pull request #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
MartijnVisser commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1485678955 > According to the [Licensing](https://cwiki.apache.org/confluence/display/FLINK/Licensing) guide, there is supposed to be a license file per bundled dependency in the shaded jar

[GitHub] [flink] flinkbot commented on pull request #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
flinkbot commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1485624997 ## CI report: * 91bdbf1e6183857335f91d75892b1aa11f5e2dcf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] mas-chen commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
mas-chen commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1149625493 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -89,7 +90,7 @@ private final KafkaRecordSeri

[GitHub] [flink] cnauroth commented on pull request #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
cnauroth commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1485609009 I'd appreciate getting some guidance on anything more required in the licenses directory. According to the [Licensing](https://cwiki.apache.org/confluence/display/FLINK/Licensing) guide,

[jira] [Updated] (FLINK-31631) Upgrade GCS connector to 2.2.11.

2023-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31631: --- Labels: pull-request-available (was: ) > Upgrade GCS connector to 2.2.11. > ---

[GitHub] [flink] cnauroth opened a new pull request, #22281: [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11.

2023-03-27 Thread via GitHub
cnauroth opened a new pull request, #22281: URL: https://github.com/apache/flink/pull/22281 ## What is the purpose of the change Upgrade GCS connector to 2.2.11. ## Brief change log Upgrade the [GCS Connector](https://github.com/GoogleCloudDataproc/hadoop-connectors/tree

[jira] [Created] (FLINK-31631) Upgrade GCS connector to 2.2.11.

2023-03-27 Thread Chris Nauroth (Jira)
Chris Nauroth created FLINK-31631: - Summary: Upgrade GCS connector to 2.2.11. Key: FLINK-31631 URL: https://issues.apache.org/jira/browse/FLINK-31631 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-31631) Upgrade GCS connector to 2.2.11.

2023-03-27 Thread Chris Nauroth (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705466#comment-17705466 ] Chris Nauroth commented on FLINK-31631: --- I have a patch in progress for this. > U

[jira] [Created] (FLINK-31630) Support max-age for checkpoints during last-state upgrades

2023-03-27 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31630: -- Summary: Support max-age for checkpoints during last-state upgrades Key: FLINK-31630 URL: https://issues.apache.org/jira/browse/FLINK-31630 Project: Flink Issue

[GitHub] [flink] tzulitai commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-27 Thread via GitHub
tzulitai commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1149544856 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -89,7 +90,7 @@ private final KafkaRecordSeri

[GitHub] [flink-connector-jdbc] matriv commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

2023-03-27 Thread via GitHub
matriv commented on code in PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1149470690 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/CrateDBCatalog.java: ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software

[jira] [Assigned] (FLINK-26972) Support spot instance in Flink Kubernetes operator

2023-03-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-26972: -- Assignee: Rodrigo Meneses > Support spot instance in Flink Kubernetes operator >

[jira] [Assigned] (FLINK-31614) Upgrade autoscaling example to 1.17.0 image

2023-03-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31614: -- Assignee: Xin Li > Upgrade autoscaling example to 1.17.0 image >

[jira] [Commented] (FLINK-31614) Upgrade autoscaling example to 1.17.0 image

2023-03-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705411#comment-17705411 ] Gyula Fora commented on FLINK-31614: sure [~xxxinli1]  > Upgrade autoscaling exampl

[GitHub] [flink-connector-jdbc] matriv commented on pull request #29: [FLINK-31551] Add support for CrateDB

2023-03-27 Thread via GitHub
matriv commented on PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#issuecomment-1485352867 Thx a lot both of you for the review. I'll try to address the comments soon and ask for another round. @eskabetxe True, CrateDB is very similar in connectivity with Postg

[jira] [Commented] (FLINK-31553) Choose Catalog, non-url based

2023-03-27 Thread Marios Trivyzas (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705407#comment-17705407 ] Marios Trivyzas commented on FLINK-31553: - [~libenchao]  [~eskabetxe] Please tak

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
tzulitai commented on PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#issuecomment-1485347238 @Ge this looks like a bug, so likely yes. Lets only open the backport PRs after this is reviewed and merged. -- This is an automated message from the Apache Git Service.

[GitHub] [flink-shaded] snuyanzin commented on a diff in pull request #119: Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1149426694 ## flink-shaded-guava-30/pom.xml: ## @@ -35,7 +35,7 @@ under the License. jar -30.1.1-jre +31.1-jre Review Comment: Since we updat

[GitHub] [flink] tzulitai commented on pull request #20343: [FLINK-25916][connector-kafka] Using upsert-kafka with a flush buffer…

2023-03-27 Thread via GitHub
tzulitai commented on PR #20343: URL: https://github.com/apache/flink/pull/20343#issuecomment-1485343974 > Shall we close this PR and move the conversation to https://github.com/apache/flink-connector-kafka/pull/5? yes please. We're removing the Kafka connector code from `apache/flink

[GitHub] [flink-shaded] snuyanzin commented on a diff in pull request #119: Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1149426694 ## flink-shaded-guava-30/pom.xml: ## @@ -35,7 +35,7 @@ under the License. jar -30.1.1-jre +31.1-jre Review Comment: Since we updat

[jira] [Closed] (FLINK-31577) Upgrade documentation to improve Operator

2023-03-27 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31577. -- Resolution: Fixed merged to main 6893c88057e7f8af3e0308f69a5de4465fcb20b4 > Upgrade documentation to

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #553: [FLINK-31577] Improve the upgrade documentation for k8s operator

2023-03-27 Thread via GitHub
gyfora merged PR #553: URL: https://github.com/apache/flink-kubernetes-operator/pull/553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

2023-03-27 Thread via GitHub
eskabetxe commented on code in PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1149378449 ## flink-connector-jdbc/archunit-violations/6b9ab1b0-c14d-4667-bab5-407b81fba98b: ## @@ -26,6 +26,12 @@ org.apache.flink.connector.jdbc.catalog.PostgresCat

[jira] [Commented] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705392#comment-17705392 ] Martijn Visser commented on FLINK-30772: [~mapohl] The PR was already there, but

[jira] [Updated] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30772: --- Affects Version/s: 1.18.0 (was: 1.17.0) > Update Flink Shaded dep

[jira] [Updated] (FLINK-30772) Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30772: --- Description: It would be smart to update the Flink Shaded components to their latest version

[GitHub] [flink-web] XComp commented on pull request #626: [FLINK-31627][docs] Updates docker command for website built

2023-03-27 Thread via GitHub
XComp commented on PR #626: URL: https://github.com/apache/flink-web/pull/626#issuecomment-1485251362 That's a good point: The error only occurs when trying to move the files into the `./content*` directories. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink-web] MartijnVisser commented on pull request #626: [FLINK-31627][docs] Updates docker command for website built

2023-03-27 Thread via GitHub
MartijnVisser commented on PR #626: URL: https://github.com/apache/flink-web/pull/626#issuecomment-1485249342 > We didn't have to set users and all that back when we used docker for building the website with jekyll. Why do we need this now? Because we didn't copy files with Jekyll, bu

[jira] [Updated] (FLINK-31620) ReducingUpsertWriter does not flush the wrapped writer

2023-03-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31620: --- Labels: pull-request-available (was: ) > ReducingUpsertWriter does not flush the wrapped wr

[GitHub] [flink-connector-kafka] Gerrrr commented on pull request #17: [FLINK-31620] Flush wrapped writer

2023-03-27 Thread via GitHub
Ge commented on PR #17: URL: https://github.com/apache/flink-connector-kafka/pull/17#issuecomment-1485245549 @tzulitai Do we need to port this patch to 1.16 and 1.17? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink-web] zentol commented on pull request #626: [FLINK-31627][docs] Updates docker command for website built

2023-03-27 Thread via GitHub
zentol commented on PR #626: URL: https://github.com/apache/flink-web/pull/626#issuecomment-1485243780 This is what we did in the past: ``` docker run --rm --volume="$PWD:/srv/flink-web" --expose=4000 -p 4000:4000 -it ruby:2.6.0 bash -c "cd /srv/flink-web && gem install bundler && ./bu

[GitHub] [flink-web] XComp commented on pull request #626: [FLINK-31627][docs] Updates docker command for website built

2023-03-27 Thread via GitHub
XComp commented on PR #626: URL: https://github.com/apache/flink-web/pull/626#issuecomment-1485228095 That's actually a good question. I struggled to build the website and came across [this blog post](https://jtreminio.com/blog/running-docker-containers-as-current-host-user/#ok-so-what-actu

[GitHub] [flink-shaded] snuyanzin commented on a diff in pull request #119: Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1149338440 ## flink-shaded-jackson-parent/flink-shaded-jackson-2/src/main/resources/META-INF/NOTICE: ## @@ -6,11 +6,11 @@ The Apache Software Foundation (http://www.apache.or

[GitHub] [flink-shaded] snuyanzin commented on a diff in pull request #119: Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1149336887 ## flink-shaded-jackson-parent/flink-shaded-jackson-module-jsonSchema-2/src/main/resources/META-INF/NOTICE: ## @@ -6,8 +6,8 @@ The Apache Software Foundation (http

[GitHub] [flink-shaded] MartijnVisser closed pull request #117: [FLINK-30175][Build/Shaded] Bump snakeyaml from 1.31 to 1.33

2023-03-27 Thread via GitHub
MartijnVisser closed pull request #117: [FLINK-30175][Build/Shaded] Bump snakeyaml from 1.31 to 1.33 URL: https://github.com/apache/flink-shaded/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-shaded] MartijnVisser commented on pull request #119: Update Flink Shaded dependencies to the latest versions

2023-03-27 Thread via GitHub
MartijnVisser commented on PR #119: URL: https://github.com/apache/flink-shaded/pull/119#issuecomment-1485220723 @XComp Since you pinged on the Jira ticket, this PR was already open -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink-shaded] MartijnVisser commented on pull request #117: [FLINK-30175][Build/Shaded] Bump snakeyaml from 1.31 to 1.33

2023-03-27 Thread via GitHub
MartijnVisser commented on PR #117: URL: https://github.com/apache/flink-shaded/pull/117#issuecomment-1485221429 Superseded by https://github.com/apache/flink-shaded/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink-connector-jdbc] libenchao commented on a diff in pull request #29: [FLINK-31551] Add support for CrateDB

2023-03-27 Thread via GitHub
libenchao commented on code in PR #29: URL: https://github.com/apache/flink-connector-jdbc/pull/29#discussion_r1148393402 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/catalog/CrateDBTablePath.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Sof

[GitHub] [flink-connector-kafka] AlexAxeman commented on pull request #18: add kafka header support

2023-03-27 Thread via GitHub
AlexAxeman commented on PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#issuecomment-1485181973 @MartijnVisser @tzulitai -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #18: add kafka header support

2023-03-27 Thread via GitHub
boring-cyborg[bot] commented on PR #18: URL: https://github.com/apache/flink-connector-kafka/pull/18#issuecomment-1485180339 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[GitHub] [flink-connector-kafka] AlexAxeman opened a new pull request, #18: add kafka header support

2023-03-27 Thread via GitHub
AlexAxeman opened a new pull request, #18: URL: https://github.com/apache/flink-connector-kafka/pull/18 ## What is the purpose of the change The default `org.apache.flink.connector.kafka.sink.KafkaSink` does not support adding Kafka record headers when using KafkaRecordSerializationS

[GitHub] [flink-web] zentol commented on pull request #626: [FLINK-31627][docs] Updates docker command for website built

2023-03-27 Thread via GitHub
zentol commented on PR #626: URL: https://github.com/apache/flink-web/pull/626#issuecomment-1485176356 I assumed this to be an issue with my local docker setup. We didn't have to set users and all that back when we used docker for building the website with jekyll. Why do we need this

[GitHub] [flink] DavidLiu001 commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…

2023-03-27 Thread via GitHub
DavidLiu001 commented on code in PR #22241: URL: https://github.com/apache/flink/pull/22241#discussion_r1149296225 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java: ## @@ -44,6 +44,8 @@ public Fat

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1149294805 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlRowConstructor.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apac

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-03-27 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1149294185 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/PreValidateReWriter.scala: ## @@ -330,7 +331,7 @@ object PreValidateReWriter

[jira] [Resolved] (FLINK-18996) Avoid disorder for time interval join

2023-03-27 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-18996. - Resolution: Fixed > Avoid disorder for time interval join >

[jira] [Commented] (FLINK-18996) Avoid disorder for time interval join

2023-03-27 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705363#comment-17705363 ] lincoln lee commented on FLINK-18996: - fixed in master: 2e7f63948cfff7445648aa17b6f3

[jira] [Commented] (FLINK-31614) Upgrade autoscaling example to 1.17.0 image

2023-03-27 Thread Xin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705360#comment-17705360 ] Xin Li commented on FLINK-31614: May I try this one as a starter? [flink-kubernetes-oper

[GitHub] [flink] lincoln-lil merged pull request #22014: [FLINK-18996][table-runtime] Emit join failed record realtime

2023-03-27 Thread via GitHub
lincoln-lil merged PR #22014: URL: https://github.com/apache/flink/pull/22014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

  1   2   3   >