[GitHub] [flink] FangYongs commented on pull request #22362: [FLINK-31544][jdbc-driver] Introduce database metadata for jdbc driver

2023-04-05 Thread via GitHub
FangYongs commented on PR #22362: URL: https://github.com/apache/flink/pull/22362#issuecomment-1498529894 Hi @libenchao Please help to review this PR when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] liuyongvs commented on a diff in pull request #19873: [FLINK-27891][Table] Add ARRAY_APPEND and ARRAY_PREPEND functions

2023-04-05 Thread via GitHub
liuyongvs commented on code in PR #19873: URL: https://github.com/apache/flink/pull/19873#discussion_r1159302878 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayAppendPrependTypeStrategy.java: ## @@ -0,0 +1,55 @@ +/* + *

[GitHub] [flink] mas-chen commented on pull request #22291: [FLINK-31632] Fix maxAllowedWatermark arithmetic overflow when the source is idle

2023-04-05 Thread via GitHub
mas-chen commented on PR #22291: URL: https://github.com/apache/flink/pull/22291#issuecomment-1498516945 > > arithmetic overflow when the source is idle" or something similar? > > Absolutely! "[[FLINK-31632](https://issues.apache.org/jira/browse/FLINK-31632)] Fix maxAllowedWatermark

[GitHub] [flink] mas-chen commented on a diff in pull request #22291: [FLINK-31632] Fix maxAllowedWatermark arithmetic overflow when the source is idle

2023-04-05 Thread via GitHub
mas-chen commented on code in PR #22291: URL: https://github.com/apache/flink/pull/22291#discussion_r1159300038 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java: ## @@ -167,6 +167,9 @@ public void

[jira] [Commented] (FLINK-24785) Relocate RocksDB's log under flink log directory by default

2023-04-05 Thread jinghaihang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709211#comment-17709211 ] jinghaihang commented on FLINK-24785: - [~yunta] ,Thanks for your reply. I agree with you and 

[jira] [Commented] (FLINK-31742) Replace deprecated TableSchema in flink-table-planner test

2023-04-05 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709210#comment-17709210 ] Ran Tao commented on FLINK-31742: - [~icshuo] Yes. i changed the issue name. we can replace these old

[jira] [Updated] (FLINK-31742) Replace deprecated TableSchema in flink-table-planner test

2023-04-05 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31742: Description: we can try to remove deprecated TableSchema and use Schema & ResolvedSchema to replace it.

[jira] [Updated] (FLINK-31742) Replace deprecated TableSchema in flink-table-planner test

2023-04-05 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31742: Summary: Replace deprecated TableSchema in flink-table-planner test (was: Remove deprecated TableSchema

[GitHub] [flink] flinkbot commented on pull request #22362: [FLINK-31544][jdbc-driver] Introduce database metadata for jdbc driver

2023-04-05 Thread via GitHub
flinkbot commented on PR #22362: URL: https://github.com/apache/flink/pull/22362#issuecomment-1498505826 ## CI report: * e37ef659f2937d871f9e26af1235edd142d736e8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31742) Remove deprecated TableSchema in flink-table-planner test

2023-04-05 Thread Shuo Cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709203#comment-17709203 ] Shuo Cheng commented on FLINK-31742: Hi, [~lemonjing] , changes of public API generally should not

[jira] [Updated] (FLINK-31544) Introduce FlinkDatabaseMetaData for jdbc driver

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31544: --- Labels: pull-request-available (was: ) > Introduce FlinkDatabaseMetaData for jdbc driver >

[GitHub] [flink] FangYongs opened a new pull request, #22362: [FLINK-31544][jdbc-driver] Introduce database metadata for jdbc driver

2023-04-05 Thread via GitHub
FangYongs opened a new pull request, #22362: URL: https://github.com/apache/flink/pull/22362 ## What is the purpose of the change This PR aims to introduce database meta for jdbc driver ## Brief change log - Added `FlinkDatabaseMeta` - Added

[jira] [Reopened] (FLINK-28198) CassandraConnectorITCase fails with timeout

2023-04-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reopened FLINK-28198: - > CassandraConnectorITCase fails with timeout > ---

[jira] [Commented] (FLINK-28198) CassandraConnectorITCase fails with timeout

2023-04-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709197#comment-17709197 ] Sergey Nuyanzin commented on FLINK-28198: - still reproduced for 1.16

[GitHub] [flink] flinkbot commented on pull request #22361: [FLINK-31670][doc] Using v3.0.0-docs branch for es connector docs build.

2023-04-05 Thread via GitHub
flinkbot commented on PR #22361: URL: https://github.com/apache/flink/pull/22361#issuecomment-1498462140 ## CI report: * a1679e3923606de92788a5837e9142b27b1d4a47 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] huwh commented on a diff in pull request #22308: [FLINK-31518][Runtime / REST] Fix StandaloneHaServices#getClusterRestEndpointLeaderRetreiver to return correct rest port

2023-04-05 Thread via GitHub
huwh commented on code in PR #22308: URL: https://github.com/apache/flink/pull/22308#discussion_r1159255563 ## flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/component/DefaultDispatcherResourceManagerComponentFactory.java: ## @@ -176,6 +176,10 @@ public

[GitHub] [flink] haishui126 commented on pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

2023-04-05 Thread via GitHub
haishui126 commented on PR #22291: URL: https://github.com/apache/flink/pull/22291#issuecomment-1498458381 > @haishui126 can we add a more meaningful commit message such as "[FLINK-XYZ] Fix maxAllowedWatermark arithmetic overflow when the source is idle" or something similar?

[jira] [Updated] (FLINK-31670) ElasticSearch connector's document was not incorrect linked to external repo

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31670: --- Labels: pull-request-available (was: ) > ElasticSearch connector's document was not

[GitHub] [flink] reswqa opened a new pull request, #22361: [FLINK-31670][doc] Using v3.0.0-docs branch for es connector docs build.

2023-04-05 Thread via GitHub
reswqa opened a new pull request, #22361: URL: https://github.com/apache/flink/pull/22361 ## What is the purpose of the change *In the [doc](https://nightlies.apache.org/flink/flink-docs-master/docs/connectors/datastream/elasticsearch/), It still use "flink-version" for

[jira] [Commented] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-04-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709178#comment-17709178 ] luoyuxia commented on FLINK-31689: -- [~jirawech.s] Assign to you~ You can tried in your local and pr

[jira] [Assigned] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-04-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-31689: Assignee: jirawech.s (was: luoyuxia) > Filesystem sink fails when parallelism of compactor

[jira] [Assigned] (FLINK-31689) Filesystem sink fails when parallelism of compactor operator changed

2023-04-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-31689: Assignee: luoyuxia > Filesystem sink fails when parallelism of compactor operator changed >

[jira] [Assigned] (FLINK-31741) Supports data conversion according to type for executor

2023-04-05 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-31741: -- Assignee: Fang Yong > Supports data conversion according to type for executor >

[GitHub] [flink] flinkbot commented on pull request #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-05 Thread via GitHub
flinkbot commented on PR #22360: URL: https://github.com/apache/flink/pull/22360#issuecomment-1498449680 ## CI report: * dcbaa06d17c31c7d5f9eaff064ea3849fd1b1670 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] FangYongs commented on pull request #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-05 Thread via GitHub
FangYongs commented on PR #22360: URL: https://github.com/apache/flink/pull/22360#issuecomment-1498448558 Hi @libenchao Please help to review this PR when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (FLINK-31741) Supports data conversion according to type for executor

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31741: --- Labels: pull-request-available (was: ) > Supports data conversion according to type for

[GitHub] [flink] FangYongs opened a new pull request, #22360: [FLINK-31741][jdbc-driver] Support data converter for value in statement result

2023-04-05 Thread via GitHub
FangYongs opened a new pull request, #22360: URL: https://github.com/apache/flink/pull/22360 ## What is the purpose of the change This PR aims to convert string value in `StatementResult` to different value for `ResultSet` ## Brief change log - Added

[jira] [Created] (FLINK-31742) Remove deprecated TableSchema in flink-table-planner test

2023-04-05 Thread Ran Tao (Jira)
Ran Tao created FLINK-31742: --- Summary: Remove deprecated TableSchema in flink-table-planner test Key: FLINK-31742 URL: https://issues.apache.org/jira/browse/FLINK-31742 Project: Flink Issue Type:

[jira] [Updated] (FLINK-31732) flink-ml-uber module should include statefun as a dependency

2023-04-05 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang updated FLINK-31732: -- Component/s: Library / Machine Learning > flink-ml-uber module should include statefun as a

[jira] [Closed] (FLINK-31732) flink-ml-uber module should include statefun as a dependency

2023-04-05 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang closed FLINK-31732. - Resolution: Won't Fix We leave state-fun as a third party dependency for now. > flink-ml-uber

[jira] [Commented] (FLINK-31610) Refactoring of LocalBufferPool

2023-04-05 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709173#comment-17709173 ] Rui Fan commented on FLINK-31610: - Thanks [~akalash]  driving this JIRA, and thanks [~Weijie Guo]

[GitHub] [flink] huwh commented on a diff in pull request #22305: [FLINK-31443][runtime] Maintain redundant taskmanagers to speed up failover

2023-04-05 Thread via GitHub
huwh commented on code in PR #22305: URL: https://github.com/apache/flink/pull/22305#discussion_r1159241282 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/RequiredRedundantResource.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

[GitHub] [flink] haishui126 commented on a diff in pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

2023-04-05 Thread via GitHub
haishui126 commented on code in PR #22291: URL: https://github.com/apache/flink/pull/22291#discussion_r1159239249 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java: ## @@ -167,6 +167,9 @@ public void

[jira] [Commented] (FLINK-31530) For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle

2023-04-05 Thread xingyuan cheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709170#comment-17709170 ] xingyuan cheng commented on FLINK-31530: [~jark] Hello, when we implement the CDAS whole

[jira] [Commented] (FLINK-27128) Broadcast stream Iteration closeWith failed starting version 1.12.2

2023-04-05 Thread LiJun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709167#comment-17709167 ] LiJun commented on FLINK-27128: --- it is apparently a bug from my point of view.  why  is this issue pending

[GitHub] [flink] xintongsong commented on a diff in pull request #22330: [FLINK-31635][network] Support writing records to the new tiered store architecture

2023-04-05 Thread via GitHub
xintongsong commented on code in PR #22330: URL: https://github.com/apache/flink/pull/22330#discussion_r1159213039 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/tieredstore/upstream/TieredStoreMode.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the

[GitHub] [flink] reswqa commented on a diff in pull request #22306: [FLINK-31447][runtime] Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager

2023-04-05 Thread via GitHub
reswqa commented on code in PR #22306: URL: https://github.com/apache/flink/pull/22306#discussion_r1159228040 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultSlotStatusSyncerTest.java: ## @@ -114,6 +114,64 @@ void testAllocateSlot()

[GitHub] [flink] huwh commented on pull request #22306: [FLINK-31447][runtime] Aligning unit tests of FineGrainedSlotManager with DeclarativeSlotManager

2023-04-05 Thread via GitHub
huwh commented on PR #22306: URL: https://github.com/apache/flink/pull/22306#issuecomment-1498409854 Thanks @reswqa , I have updated this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (FLINK-31741) Supports data conversion according to type for executor

2023-04-05 Thread Fang Yong (Jira)
Fang Yong created FLINK-31741: - Summary: Supports data conversion according to type for executor Key: FLINK-31741 URL: https://issues.apache.org/jira/browse/FLINK-31741 Project: Flink Issue

[GitHub] [flink] mas-chen commented on pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

2023-04-05 Thread via GitHub
mas-chen commented on PR #22291: URL: https://github.com/apache/flink/pull/22291#issuecomment-1498406007 @haishui126 can we add a more meaningful commit message such as "[FLINK-XYZ] Fix maxAllowedWatermark arithmetic overflow when the source is idle" or something similar? -- This is an

[GitHub] [flink] mas-chen commented on a diff in pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

2023-04-05 Thread via GitHub
mas-chen commented on code in PR #22291: URL: https://github.com/apache/flink/pull/22291#discussion_r1159221918 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java: ## @@ -167,6 +167,9 @@ public void

[jira] [Commented] (FLINK-31729) Unexpected UPDATE_BEFORE output record in LEFT OUTER JOIN

2023-04-05 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709152#comment-17709152 ] luoyuxia commented on FLINK-31729: -- [~smiralex] Thanks for reporting. But I'm wondering why there's

[GitHub] [flink] zoltar9264 commented on pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-05 Thread via GitHub
zoltar9264 commented on PR #21822: URL: https://github.com/apache/flink/pull/21822#issuecomment-1498381893 Hi @curcur and @rkhachatryan , can you help us review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (FLINK-31301) Unsupported nested columns in column list of insert statement

2023-04-05 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-31301: --- Assignee: Aitozi > Unsupported nested columns in column list of insert statement >

[jira] [Commented] (FLINK-31301) Unsupported nested columns in column list of insert statement

2023-04-05 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709149#comment-17709149 ] lincoln lee commented on FLINK-31301: - [~aitozi] welcome for contributing! assigned to you >

[GitHub] [flink] gaoyunhaii commented on a diff in pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-04-05 Thread via GitHub
gaoyunhaii commented on code in PR #21736: URL: https://github.com/apache/flink/pull/21736#discussion_r1159187859 ## flink-test-utils-parent/flink-migration-test-utils/src/main/java/org/apache/flink/test/migration/MigrationTestsSnapshotGenerator.java: ## @@ -0,0 +1,253 @@ +/* +

[GitHub] [flink] mas-chen commented on a diff in pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

2023-04-05 Thread via GitHub
mas-chen commented on code in PR #22291: URL: https://github.com/apache/flink/pull/22291#discussion_r1159178247 ## flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java: ## @@ -83,6 +83,22 @@ void

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159168995 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159168995 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #16: [FLINK-30859] Externalize confluent avro related code

2023-04-05 Thread via GitHub
mas-chen commented on code in PR #16: URL: https://github.com/apache/flink-connector-kafka/pull/16#discussion_r1159166591 ## flink-formats-confluent/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroFormatFactory.java:

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159161297 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java: ## @@ -145,7 +145,7 @@ public

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159159130 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159159130 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
Ge commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159155943 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] Gerrrr commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
Ge commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159122981 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptionsUtil.java: ## @@ -145,7 +145,7 @@ public static

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#discussion_r1159113822 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaTableITCase.java: ## @@ -388,6 +391,201 @@ public void

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai commented on PR #22: URL: https://github.com/apache/flink-connector-kafka/pull/22#issuecomment-1498264961 cc @twalthr @dawidwys @Ge for review, thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-31740) Allow setting boundedness for upsert-kafka SQL connector

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31740: --- Labels: pull-request-available (was: ) > Allow setting boundedness for upsert-kafka SQL

[GitHub] [flink-connector-kafka] tzulitai opened a new pull request, #22: [FLINK-31740] [upsert-kafka] Allows setting boundedness for SQL Upsert Kafka Connector

2023-04-05 Thread via GitHub
tzulitai opened a new pull request, #22: URL: https://github.com/apache/flink-connector-kafka/pull/22 This is a "follow-up" to previous work in https://github.com/apache/flink/pull/21808 that added boundedness options for the SQL Kafka Connector. This PR does the same for the SQL Upsert

[jira] [Created] (FLINK-31740) Allow setting boundedness for upsert-kafka SQL connector

2023-04-05 Thread Tzu-Li (Gordon) Tai (Jira)
Tzu-Li (Gordon) Tai created FLINK-31740: --- Summary: Allow setting boundedness for upsert-kafka SQL connector Key: FLINK-31740 URL: https://issues.apache.org/jira/browse/FLINK-31740 Project: Flink

[GitHub] [flink] nateab closed pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-04-05 Thread via GitHub
nateab closed pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE URL: https://github.com/apache/flink/pull/22313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] nateab commented on pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-04-05 Thread via GitHub
nateab commented on PR #22313: URL: https://github.com/apache/flink/pull/22313#issuecomment-1498155014 @zentol Thanks for the suggestion, i was able to get it working now after building it on the command line. @twalthr Yes I believe you are correct. Here is a new PR that has

[GitHub] [flink] nateab commented on a diff in pull request #22313: [FLINK-31660][connector-kafka] fix kafka connector pom so ITCases run in IDE

2023-04-05 Thread via GitHub
nateab commented on code in PR #22313: URL: https://github.com/apache/flink/pull/22313#discussion_r1159018047 ## flink-connectors/flink-connector-kafka/pom.xml: ## @@ -225,6 +241,23 @@ under the License. + +

[GitHub] [flink] flinkbot commented on pull request #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-04-05 Thread via GitHub
flinkbot commented on PR #22359: URL: https://github.com/apache/flink/pull/22359#issuecomment-1498148518 ## CI report: * c96df5042093ce7ee8ab284888d627a554c5746e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] nateab opened a new pull request, #22359: [FLINK-31660][table] add jayway json path dependency to table-planner

2023-04-05 Thread via GitHub
nateab opened a new pull request, #22359: URL: https://github.com/apache/flink/pull/22359 ## What is the purpose of the change This PR adds the `json-path` dependency to the table-planner pom so that `ITCases` in the kafka connector module can run in the Intellij IDE. This is due to

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #16: [FLINK-30859] Externalize confluent avro related code

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #16: URL: https://github.com/apache/flink-connector-kafka/pull/16#discussion_r1158843434 ## flink-formats-confluent/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroFormatFactory.java:

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #16: [FLINK-30859] Externalize confluent avro related code

2023-04-05 Thread via GitHub
mas-chen commented on code in PR #16: URL: https://github.com/apache/flink-connector-kafka/pull/16#discussion_r1158835180 ## flink-formats-confluent/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroFormatFactory.java:

[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #16: [FLINK-30859] Externalize confluent avro related code

2023-04-05 Thread via GitHub
tzulitai commented on code in PR #16: URL: https://github.com/apache/flink-connector-kafka/pull/16#discussion_r1158798008 ## flink-formats-confluent/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroFormatFactory.java:

[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.

2023-04-05 Thread via GitHub
dmvk commented on PR #22350: URL: https://github.com/apache/flink/pull/22350#issuecomment-1497788210 For the UX comments: I'm not a UX person, and this is good enough for the demo purpose (it was not meant for serious usage, that's what REST API is for). We touched on this a few weeks back

[GitHub] [flink-connector-elasticsearch] reswqa closed pull request #56: [Do Not Merge] Test V3.0 CI

2023-04-05 Thread via GitHub
reswqa closed pull request #56: [Do Not Merge] Test V3.0 CI URL: https://github.com/apache/flink-connector-elasticsearch/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-31739) ElasticSearch and Cassandra connector v3.0 branch's CI is not working properly

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31739: --- Labels: pull-request-available (was: ) > ElasticSearch and Cassandra connector v3.0

[GitHub] [flink-connector-cassandra] boring-cyborg[bot] commented on pull request #6: [FLINK-31739][ci] Reuse ci.yml in flink-connector-shared-utils.

2023-04-05 Thread via GitHub
boring-cyborg[bot] commented on PR #6: URL: https://github.com/apache/flink-connector-cassandra/pull/6#issuecomment-1497771418 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This

[GitHub] [flink-connector-cassandra] reswqa opened a new pull request, #6: [FLINK-31739][ci] Reuse ci.yml in flink-connector-shared-utils.

2023-04-05 Thread via GitHub
reswqa opened a new pull request, #6: URL: https://github.com/apache/flink-connector-cassandra/pull/6 Use the common `ci.yml` in `flink-connector-shared-utils` for v3.0 branch's workflows instead of standalone yml. -- This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (FLINK-31518) HighAvailabilityServiceUtils resolves wrong webMonitorAddress in Standalone mode

2023-04-05 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708995#comment-17708995 ] Samrat Deb commented on FLINK-31518: [~huwh] please review the pr in free time  >

[jira] [Resolved] (FLINK-31214) Add support for new command line option -py.pythonpath

2023-04-05 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samrat Deb resolved FLINK-31214. Resolution: Fixed master :- f8b0834fb83b7d17ac9eeaf09f2f6cea070c978a > Add support for new

[jira] [Created] (FLINK-31739) ElasticSearch and Cassandra connector v3.0 branch's CI is not working properly

2023-04-05 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-31739: -- Summary: ElasticSearch and Cassandra connector v3.0 branch's CI is not working properly Key: FLINK-31739 URL: https://issues.apache.org/jira/browse/FLINK-31739 Project:

[GitHub] [flink-connector-aws] Samrat002 commented on pull request #47: [FLINK-30481][FLIP-277] GlueCatalog Implementation

2023-04-05 Thread via GitHub
Samrat002 commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1497724491 > 2. Can we create e2e tests using localstack or something similar? I have not looked to see if anything exist created separate jira to add e2e

[GitHub] [flink-training] JosemyAB closed pull request #57: Implementation of oficial exercises

2023-04-05 Thread via GitHub
JosemyAB closed pull request #57: Implementation of oficial exercises URL: https://github.com/apache/flink-training/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] mohsenrezaeithe commented on pull request #21849: [FLINK-30596][Runtime/REST] Fix duplicate jobs when submitting with the same jobId

2023-04-05 Thread via GitHub
mohsenrezaeithe commented on PR #21849: URL: https://github.com/apache/flink/pull/21849#issuecomment-1497710031 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] akalash closed pull request #19018: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRecycleMul

2023-04-05 Thread via GitHub
akalash closed pull request #19018: [FLINK-25819][runtime] Reordered requesting and recycling buffers in order to avoid race condition in testIsAvailableOrNotAfterRequestAndRecycleMultiSegments URL: https://github.com/apache/flink/pull/19018 -- This is an automated message from the Apache

[GitHub] [flink] akalash closed pull request #17825: Test case for remapping keygroups

2023-04-05 Thread via GitHub
akalash closed pull request #17825: Test case for remapping keygroups URL: https://github.com/apache/flink/pull/17825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash closed pull request #16471: [FLINK-22893][tests] Wait for all task running before externalized ch…

2023-04-05 Thread via GitHub
akalash closed pull request #16471: [FLINK-22893][tests] Wait for all task running before externalized ch… URL: https://github.com/apache/flink/pull/16471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] akalash closed pull request #16224: Added LoadRebalancePartitioner in order to select the freest subparti…

2023-04-05 Thread via GitHub
akalash closed pull request #16224: Added LoadRebalancePartitioner in order to select the freest subparti… URL: https://github.com/apache/flink/pull/16224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-05 Thread via GitHub
reta commented on code in PR #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1158673505 ## .github/workflows/weekly.yml: ## @@ -26,7 +26,7 @@ jobs: if: github.repository_owner == 'apache' strategy: matrix: -flink:

[GitHub] [flink-connector-opensearch] reta opened a new pull request, #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix

2023-04-05 Thread via GitHub
reta opened a new pull request, #16: URL: https://github.com/apache/flink-connector-opensearch/pull/16 Fixing the compilation issue for 1.18 (see please https://github.com/apache/flink-connector-opensearch/actions/runs/4615625503/jobs/8159702829). ``` Error:

[jira] [Commented] (FLINK-31301) Unsupported nested columns in column list of insert statement

2023-04-05 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708948#comment-17708948 ] Aitozi commented on FLINK-31301: Hello [~lincoln.86xy], I want to contribute to this ticket and I have

[GitHub] [flink-connector-pulsar] reswqa commented on pull request #42: [hotfix] Improve CI trigger and cancel strategy

2023-04-05 Thread via GitHub
reswqa commented on PR #42: URL: https://github.com/apache/flink-connector-pulsar/pull/42#issuecomment-1497627697 Thanks @tisonkun, the explanation of the `Concurrency strategy` in this PR is very useful  -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] dmvk commented on pull request #22350: [FLINK-31471] Allow setting JobResourceRequirements through WEB UI.

2023-04-05 Thread via GitHub
dmvk commented on PR #22350: URL: https://github.com/apache/flink/pull/22350#issuecomment-1497623195 Thanks for the review Chesnay, I've addressed the comments and scheduled some follow-ups. PTAL -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #22358: [FLINK-31738] Prevent name clash in generated clients

2023-04-05 Thread via GitHub
flinkbot commented on PR #22358: URL: https://github.com/apache/flink/pull/22358#issuecomment-1497621576 ## CI report: * 8db2f4bab4db12d8c90208cbb4b09b8ff3d61a30 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] zentol commented on pull request #22356: WARNING: An illegal reflective access operation has occurred

2023-04-05 Thread via GitHub
zentol commented on PR #22356: URL: https://github.com/apache/flink/pull/22356#issuecomment-1497617569 See https://flink.apache.org/getting-help/. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zentol closed pull request #22356: WARNING: An illegal reflective access operation has occurred

2023-04-05 Thread via GitHub
zentol closed pull request #22356: WARNING: An illegal reflective access operation has occurred URL: https://github.com/apache/flink/pull/22356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31738) FlameGraphTypeQueryParameter#Type clashes with java.reflect.Type in generated clients

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31738: --- Labels: pull-request-available (was: ) > FlameGraphTypeQueryParameter#Type clashes with

[GitHub] [flink] zentol opened a new pull request, #22358: [FLINK-31738] Prevent name clash in generated clients

2023-04-05 Thread via GitHub
zentol opened a new pull request, #22358: URL: https://github.com/apache/flink/pull/22358 Generating a client with the openapi generators causes compile errors because the generated file imports java.reflect.Type, but also the generated "Type" model. For convenience it would be neat

[jira] [Commented] (FLINK-31470) Introduce integration tests for Externalized Declarative Resource Management

2023-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708937#comment-17708937 ] David Morávek commented on FLINK-31470: --- master: d4e3b6646f389eeb395a4dbb951d13bab02cb8db >

[jira] [Resolved] (FLINK-31470) Introduce integration tests for Externalized Declarative Resource Management

2023-04-05 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek resolved FLINK-31470. --- Fix Version/s: 1.18.0 Resolution: Fixed > Introduce integration tests for

[jira] [Created] (FLINK-31738) FlameGraphTypeQueryParameter#Type clashes with java.reflect.Type in generated clients

2023-04-05 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-31738: Summary: FlameGraphTypeQueryParameter#Type clashes with java.reflect.Type in generated clients Key: FLINK-31738 URL: https://issues.apache.org/jira/browse/FLINK-31738

[GitHub] [flink] dmvk merged pull request #22343: [FLINK-31470] Add integration tests for Externalized Declarative Reso…

2023-04-05 Thread via GitHub
dmvk merged PR #22343: URL: https://github.com/apache/flink/pull/22343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30989) Configuration table.exec.spill-compression.block-size not take effect in batch job

2023-04-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-30989: --- Fix Version/s: 1.16.2 > Configuration table.exec.spill-compression.block-size not take effect in >

[jira] [Updated] (FLINK-30989) Configuration table.exec.spill-compression.block-size not take effect in batch job

2023-04-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-30989: --- Fix Version/s: 1.17.1 > Configuration table.exec.spill-compression.block-size not take effect in >

[jira] [Commented] (FLINK-30989) Configuration table.exec.spill-compression.block-size not take effect in batch job

2023-04-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17708930#comment-17708930 ] Weijie Guo commented on FLINK-30989: Summary: Fixed streaming module: master(1.18) via

  1   2   3   >