[GitHub] [flink] wanglijie95 commented on a diff in pull request #22413: [FLINK-31832][runtime] Add benchmarks for end to end restarting tasks

2023-05-23 Thread via GitHub
wanglijie95 commented on code in PR #22413: URL: https://github.com/apache/flink/pull/22413#discussion_r1201634745 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/e2e/HandleGlobalFailureAndRestartAllTasksBenchmark.java: ## @@ -0,0 +1,119 @@ +/* + * Li

[GitHub] [flink] liuyongvs commented on a diff in pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-05-23 Thread via GitHub
liuyongvs commented on code in PR #22324: URL: https://github.com/apache/flink/pull/22324#discussion_r1201647742 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -435,6 +435,16 @@ public class ExecutionConfigO

[GitHub] [flink] liuyongvs commented on a diff in pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-05-23 Thread via GitHub
liuyongvs commented on code in PR #22324: URL: https://github.com/apache/flink/pull/22324#discussion_r1201649136 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -435,6 +435,16 @@ public class ExecutionConfigO

[GitHub] [flink] liuyongvs commented on a diff in pull request #22324: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-05-23 Thread via GitHub
liuyongvs commented on code in PR #22324: URL: https://github.com/apache/flink/pull/22324#discussion_r1201649136 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java: ## @@ -435,6 +435,16 @@ public class ExecutionConfigO

[GitHub] [flink] liuyongvs commented on pull request #22312: [FLINK-31677][table] Add built-in MAP_ENTRIES function.

2023-05-23 Thread via GitHub
liuyongvs commented on PR #22312: URL: https://github.com/apache/flink/pull/22312#issuecomment-1558666079 hi @snuyanzin ci passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (FLINK-32158) Unify the getMultiInputOperatorDefaultMeta and getOneInputOperatorDefaultMeta methods into the same getInputOperatorDefaultMeta method

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32158: --- Component/s: Table SQL / Planner > Unify the getMultiInputOperatorDefaultMeta and getOneInpu

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-23 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1201664511 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,40 @@ public void open(

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22010: [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi…

2023-05-23 Thread via GitHub
xuzhiwen1255 commented on code in PR #22010: URL: https://github.com/apache/flink/pull/22010#discussion_r1201668515 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/SequenceGenerator.java: ## @@ -65,33 +71,40 @@ public void open(

[jira] [Created] (FLINK-32160) CompactOperator cannot continue from checkpoint because of java.util.NoSuchElementException

2023-05-23 Thread Jira
Michał Fijołek created FLINK-32160: -- Summary: CompactOperator cannot continue from checkpoint because of java.util.NoSuchElementException Key: FLINK-32160 URL: https://issues.apache.org/jira/browse/FLINK-32160

[jira] [Updated] (FLINK-32160) CompactOperator cannot continue from checkpoint because of java.util.NoSuchElementException

2023-05-23 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-32160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Fijołek updated FLINK-32160: --- Environment: Flink 1.16/1.17 on k8s (flink-kubernetes-operator v.1.4.0), s3 (was: Flink 1.1

[GitHub] [flink-web] Thesharing opened a new pull request, #652: [FLINK-32051] Fix broken documentation links in Flink blogs

2023-05-23 Thread via GitHub
Thesharing opened a new pull request, #652: URL: https://github.com/apache/flink-web/pull/652 This pull request fixes broken documentation links in Flink blogs. For more details, please see FLINK-32051. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-32051) Fix broken documenation links in Flink blogs

2023-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32051: --- Labels: pull-request-available (was: ) > Fix broken documenation links in Flink blogs > ---

[GitHub] [flink-web] Thesharing opened a new pull request, #653: [FLINK-31945] Fix missing title in the table of contents of the blogs

2023-05-23 Thread via GitHub
Thesharing opened a new pull request, #653: URL: https://github.com/apache/flink-web/pull/653 This pull request fixes missing title in the table of contents of the blogs. For more details, please see FLINK-31945. -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (FLINK-31945) Table of contents in the blogs of the project website is missing some titles

2023-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31945: --- Labels: pull-request-available (was: ) > Table of contents in the blogs of the project webs

[jira] [Updated] (FLINK-32051) Fix broken documentation links in Flink blogs

2023-05-23 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhilong Hong updated FLINK-32051: - Summary: Fix broken documentation links in Flink blogs (was: Fix broken documenation links in F

[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725272#comment-17725272 ] Martijn Visser commented on FLINK-31095: [~linqyd218] Did you end up getting thi

[GitHub] [flink] zentol merged pull request #22616: [FLINK-32149][tests] Remove trivial mockito usages

2023-05-23 Thread via GitHub
zentol merged PR #22616: URL: https://github.com/apache/flink/pull/22616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] zentol merged pull request #22617: [FLINK-32152][tests] Consolidate mocking library usage

2023-05-23 Thread via GitHub
zentol merged PR #22617: URL: https://github.com/apache/flink/pull/22617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-32152) Consolidate mocking library usage

2023-05-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-32152. Resolution: Fixed master: 99add045846b0efcbf9a1c89db4132e1c99af4d4 > Consolidate mocking

[jira] [Closed] (FLINK-32149) Remove some trivial mocking usages

2023-05-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-32149. Resolution: Fixed master: 291414f9cde3f178a3ea3d6c6ef1d5f3dc3fa9c3 > Remove some trivial

[GitHub] [flink] wanglijie95 opened a new pull request, #22627: [hotfix][doc] Use the flink-connector-jdbc v3.1 branch docs

2023-05-23 Thread via GitHub
wanglijie95 opened a new pull request, #22627: URL: https://github.com/apache/flink/pull/22627 ## What is the purpose of the change Currently, the lastest stable flink-connector-jdbc branch is v3.1, we should use the doc in that branch. ## Verifying this change Only change docs,

[GitHub] [flink] zentol commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection interface

2023-05-23 Thread via GitHub
zentol commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1201729146 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/AbstractLeaderElectionService.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink] zentol commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection interface

2023-05-23 Thread via GitHub
zentol commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1201735087 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/AbstractLeaderElectionService.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink] flinkbot commented on pull request #22627: [hotfix][doc] Use the flink-connector-jdbc v3.1 branch docs

2023-05-23 Thread via GitHub
flinkbot commented on PR #22627: URL: https://github.com/apache/flink/pull/22627#issuecomment-1558748393 ## CI report: * 11d2bd3f7b1519199ea929fe57141f4a5c2c9bf6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] snuyanzin commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-05-23 Thread via GitHub
snuyanzin commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1190413352 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -84,6 +84,12 @@ ${project.version} test +

[jira] [Commented] (FLINK-32130) previous checkpoint will be broke by the subsequent incremental checkpoint

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725282#comment-17725282 ] Roman Khachatryan commented on FLINK-32130: --- Thanks [~Feifan Wang]  > previou

[jira] [Commented] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2023-05-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725281#comment-17725281 ] Sergey Nuyanzin commented on FLINK-27284: - same issue with testScaleDown https:/

[GitHub] [flink] zentol commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection interface

2023-05-23 Thread via GitHub
zentol commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1201761208 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElectionService.java: ## @@ -32,87 +29,49 @@ */ public class TestingLeaderElection

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725286#comment-17725286 ] Feifan Wang commented on FLINK-29913: - Sorry I didn't notice this ticket earlier so

[GitHub] [flink] zentol commented on a diff in pull request #22404: [FLINK-31797][runtime] Moves LeaderElection creation into HighAvailabilityServices

2023-05-23 Thread via GitHub
zentol commented on code in PR #22404: URL: https://github.com/apache/flink/pull/22404#discussion_r1201787892 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java: ## @@ -240,13 +241,13 @@ public CompletableFuture globalCleanupAsync(Jo

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-05-23 Thread via GitHub
dannycranmer commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1201711292 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSourceBuilder.java: ## @@ -0,0 +1,92 @@ +/* +

[jira] [Updated] (FLINK-32043) SqlClient session unrecoverable once one wrong setting occurred

2023-05-23 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-32043: Priority: Critical (was: Major) > SqlClient session unrecoverable once one wrong setting occurred > -

[jira] [Commented] (FLINK-31828) List field in a POJO data stream results in table program compilation failure

2023-05-23 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725311#comment-17725311 ] Aitozi commented on FLINK-31828: Any sql guys can help verify this fix ? > List field i

[jira] [Commented] (FLINK-32160) CompactOperator cannot continue from checkpoint because of java.util.NoSuchElementException

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725319#comment-17725319 ] Martijn Visser commented on FLINK-32160: [~lzljs3620320] Do you have any insight

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725336#comment-17725336 ] Roman Khachatryan commented on FLINK-29913: --- Thanks for the proposal [~Feifan

[jira] [Updated] (FLINK-32161) Migrate and remove some legacy ExternalResource

2023-05-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32161: --- Affects Version/s: 1.18.0 > Migrate and remove some legacy ExternalResource > --

[jira] [Created] (FLINK-32161) Migrate and remove some legacy ExternalResource

2023-05-23 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-32161: -- Summary: Migrate and remove some legacy ExternalResource Key: FLINK-32161 URL: https://issues.apache.org/jira/browse/FLINK-32161 Project: Flink Issue Type: Techn

[GitHub] [flink] XComp commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection interface

2023-05-23 Thread via GitHub
XComp commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1202068871 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/AbstractLeaderElectionService.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Fou

[jira] [Created] (FLINK-32162) Misleading log message due to missing null check

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32162: Summary: Misleading log message due to missing null check Key: FLINK-32162 URL: https://issues.apache.org/jira/browse/FLINK-32162 Project: Flink Issu

[jira] [Updated] (FLINK-32162) Misleading log message due to missing null check

2023-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32162: --- Labels: pull-request-available (was: ) > Misleading log message due to missing null check >

[GitHub] [flink] xintongsong closed pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager

2023-05-23 Thread via GitHub
xintongsong closed pull request #22352: [FLINK-31639][network] Introduce tiered store memory manager URL: https://github.com/apache/flink/pull/22352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Closed] (FLINK-31639) Introduce tiered store memory manager

2023-05-23 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-31639. Fix Version/s: 1.18.0 Resolution: Done master (1.18): c6d7747eaef166fb7577de55cb2943fa5408d

[GitHub] [flink] dmvk commented on a diff in pull request #22628: [FLINK-32162] Only log error if an error occurred

2023-05-23 Thread via GitHub
dmvk commented on code in PR #22628: URL: https://github.com/apache/flink/pull/22628#discussion_r1202135895 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1182,7 +1182,10 @@ public CompletableFuture updateJobResourceRequirements(

[GitHub] [flink] flinkbot commented on pull request #22628: [FLINK-32162] Only log error if an error occurred

2023-05-23 Thread via GitHub
flinkbot commented on PR #22628: URL: https://github.com/apache/flink/pull/22628#issuecomment-1559117082 ## CI report: * 437fc7e4ecb949686e6ebd3ce50de7f57594d493 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-32056) Update the used Pulsar connector in flink-python to 4.0.0

2023-05-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-32056. --- Fix Version/s: 1.18.0 1.17.2 Resolution: Fixed Fixed in: - master via fbf7b91424ec

[GitHub] [flink] liuyongvs opened a new pull request, #22629: [FLINK-31664][table] Add ARRAY_INTERSECT function

2023-05-23 Thread via GitHub
liuyongvs opened a new pull request, #22629: URL: https://github.com/apache/flink/pull/22629 - What is the purpose of the change This is an implementation of ARRAY_INTERSECT - Brief change log ARRAY_INTERSECT for Table API and SQL ``` Returns an array of the element

[GitHub] [flink] liuyongvs commented on pull request #22629: [FLINK-31664][table] Add ARRAY_INTERSECT function

2023-05-23 Thread via GitHub
liuyongvs commented on PR #22629: URL: https://github.com/apache/flink/pull/22629#issuecomment-1559161153 hi @dawidwys do you have time to help review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (FLINK-32056) Update the used Pulsar connector in flink-python to 4.0.0

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32056: --- Priority: Critical (was: Major) > Update the used Pulsar connector in flink-python to 4.0.0

[GitHub] [flink] flinkbot commented on pull request #22629: [FLINK-31664][table] Add ARRAY_INTERSECT function

2023-05-23 Thread via GitHub
flinkbot commented on PR #22629: URL: https://github.com/apache/flink/pull/22629#issuecomment-1559168847 ## CI report: * c9a4a54f5ac5b6dccdd762ac13955f8bea8dd577 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725387#comment-17725387 ] Feifan Wang commented on FLINK-29913: - One overhead I can see is that it will use mo

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #22: [FLINK-30790] Add DatabaseExtension with TableManaged for testing

2023-05-23 Thread via GitHub
eskabetxe commented on PR #22: URL: https://github.com/apache/flink-connector-jdbc/pull/22#issuecomment-1559224399 @MartijnVisser any news for merging this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Created] (FLINK-32163) Support the same application run multiple jobs in HA mode

2023-05-23 Thread melin (Jira)
melin created FLINK-32163: - Summary: Support the same application run multiple jobs in HA mode Key: FLINK-32163 URL: https://issues.apache.org/jira/browse/FLINK-32163 Project: Flink Issue Type: New F

[GitHub] [flink] dmvk commented on a diff in pull request #22564: [FLINK-31891][runtime] Introduce AdaptiveScheduler per-task failure enrichment/labeling

2023-05-23 Thread via GitHub
dmvk commented on code in PR #22564: URL: https://github.com/apache/flink/pull/22564#discussion_r1202299569 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/ExceptionHistoryEntry.java: ## @@ -132,6 +132,22 @@ private ExceptionHistoryEntry(

[GitHub] [flink] dmvk commented on a diff in pull request #22564: [FLINK-31891][runtime] Introduce AdaptiveScheduler per-task failure enrichment/labeling

2023-05-23 Thread via GitHub
dmvk commented on code in PR #22564: URL: https://github.com/apache/flink/pull/22564#discussion_r1202308510 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java: ## @@ -1992,4 +2035,120 @@ public DummyState getState() {

[jira] [Created] (FLINK-32164) LifecycleState count metrics are not reported correctly by namespace

2023-05-23 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-32164: -- Summary: LifecycleState count metrics are not reported correctly by namespace Key: FLINK-32164 URL: https://issues.apache.org/jira/browse/FLINK-32164 Project: Flink

[jira] [Updated] (FLINK-32164) LifecycleState count metrics are not reported correctly by namespace

2023-05-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-32164: --- Issue Type: Bug (was: Improvement) > LifecycleState count metrics are not reported correctly by nam

[GitHub] [flink] zentol commented on pull request #22618: [FLINK-32153][build] Limit powermock to core/runtime

2023-05-23 Thread via GitHub
zentol commented on PR #22618: URL: https://github.com/apache/flink/pull/22618#issuecomment-1559362927 yeah I've noticed it already; my guess is the mockito-core exclusion isn't working as it should. Will fix that later. -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (FLINK-32163) Support the same application run multiple jobs in HA mode

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725412#comment-17725412 ] Martijn Visser commented on FLINK-32163: [~melin] The ticket is unclear for me.

[jira] [Comment Edited] (FLINK-32163) Support the same application run multiple jobs in HA mode

2023-05-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725412#comment-17725412 ] Martijn Visser edited comment on FLINK-32163 at 5/23/23 1:33 PM: -

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725413#comment-17725413 ] Nicolas Fraison commented on FLINK-32012: - [~gyfora], I started an implementatio

[jira] [Updated] (FLINK-32165) Improve observability of fine-grained resource management

2023-05-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32165: - Summary: Improve observability of fine-grained resource management (was: Improve observ

[jira] [Created] (FLINK-32165) Improve observability ofd fine-grained resource management

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32165: Summary: Improve observability ofd fine-grained resource management Key: FLINK-32165 URL: https://issues.apache.org/jira/browse/FLINK-32165 Project: Flink

[jira] [Created] (FLINK-32166) Show unassigned/total TM resources in web ui

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32166: Summary: Show unassigned/total TM resources in web ui Key: FLINK-32166 URL: https://issues.apache.org/jira/browse/FLINK-32166 Project: Flink Issue Ty

[jira] [Created] (FLINK-32167) Log dynamic slot creation on task manager

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32167: Summary: Log dynamic slot creation on task manager Key: FLINK-32167 URL: https://issues.apache.org/jira/browse/FLINK-32167 Project: Flink Issue Type:

[jira] [Created] (FLINK-32168) Log required/available resources in RM

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32168: Summary: Log required/available resources in RM Key: FLINK-32168 URL: https://issues.apache.org/jira/browse/FLINK-32168 Project: Flink Issue Type: Su

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725418#comment-17725418 ] Roman Khachatryan commented on FLINK-29913: --- {quote}On a 64-bit system, about

[jira] [Updated] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-29913: -- Priority: Major (was: Minor) > Shared state would be discarded by mistake when maxCon

[jira] [Updated] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-29913: -- Affects Version/s: 1.17.0 > Shared state would be discarded by mistake when maxConcurr

[jira] [Updated] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-29913: -- Fix Version/s: 1.16.2 1.17.2 > Shared state would be discarded by m

[jira] [Assigned] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-29913: - Assignee: Feifan Wang > Shared state would be discarded by mistake when maxConc

[GitHub] [flink-web] Thesharing commented on pull request #652: [FLINK-32051] Fix broken documentation links in Flink blogs

2023-05-23 Thread via GitHub
Thesharing commented on PR #652: URL: https://github.com/apache/flink-web/pull/652#issuecomment-1559436745 > +1, I met this same issue at flink blog. But why insert some blanks in some one doc? Thanks for the reply. It's because without these blanks, the links in the corresponding pa

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725423#comment-17725423 ] Gyula Fora commented on FLINK-32012: [~nfraison.datadog] , I don't think it's possib

[GitHub] [flink-connector-jdbc] boring-cyborg[bot] commented on pull request #50: [hotfix] Backport some docs-related fixes to v3.1

2023-05-23 Thread via GitHub
boring-cyborg[bot] commented on PR #50: URL: https://github.com/apache/flink-connector-jdbc/pull/50#issuecomment-1559480963 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [flink] dmvk commented on a diff in pull request #22608: [FLINK-31893][runtime] Introduce AdaptiveBatchScheduler failure enrichment/labeling

2023-05-23 Thread via GitHub
dmvk commented on code in PR #22608: URL: https://github.com/apache/flink/pull/22608#discussion_r1202413078 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## @@ -91,6 +96,28 @@ void setUp() { taskRestartE

[GitHub] [flink] dmvk commented on a diff in pull request #22608: [FLINK-31893][runtime] Introduce AdaptiveBatchScheduler failure enrichment/labeling

2023-05-23 Thread via GitHub
dmvk commented on code in PR #22608: URL: https://github.com/apache/flink/pull/22608#discussion_r1202427606 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java: ## @@ -91,6 +96,28 @@ void setUp() { taskRestartE

[jira] [Created] (FLINK-32169) Show allocated slots on TM page

2023-05-23 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-32169: Summary: Show allocated slots on TM page Key: FLINK-32169 URL: https://issues.apache.org/jira/browse/FLINK-32169 Project: Flink Issue Type: Sub-task

[GitHub] [flink] wanglijie95 closed pull request #22627: [hotfix][doc] Use the flink-connector-jdbc v3.1 branch docs

2023-05-23 Thread via GitHub
wanglijie95 closed pull request #22627: [hotfix][doc] Use the flink-connector-jdbc v3.1 branch docs URL: https://github.com/apache/flink/pull/22627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] zentol commented on a diff in pull request #22628: [FLINK-32162] Only log error if an error occurred

2023-05-23 Thread via GitHub
zentol commented on code in PR #22628: URL: https://github.com/apache/flink/pull/22628#discussion_r1202484203 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java: ## @@ -1182,7 +1182,10 @@ public CompletableFuture updateJobResourceRequirements(

[GitHub] [flink] zentol merged pull request #22628: [FLINK-32162] Only log error if an error occurred

2023-05-23 Thread via GitHub
zentol merged PR #22628: URL: https://github.com/apache/flink/pull/22628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-32162) Misleading log message due to missing null check

2023-05-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-32162. Resolution: Fixed master: fadde2a378aac4293676944dd513291919a481e3 > Misleading log messa

[jira] [Updated] (FLINK-32162) Misleading log message due to missing null check

2023-05-23 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32162: - Priority: Minor (was: Major) > Misleading log message due to missing null check > -

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725450#comment-17725450 ] Nicolas Fraison commented on FLINK-32012: - But the whole point of this request w

[jira] [Comment Edited] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725450#comment-17725450 ] Nicolas Fraison edited comment on FLINK-32012 at 5/23/23 3:05 PM:

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725453#comment-17725453 ] Gyula Fora commented on FLINK-32012: Yes you are right. But this is already handled

[jira] [Commented] (FLINK-32012) Operator failed to rollback due to missing HA metadata

2023-05-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725466#comment-17725466 ] Gyula Fora commented on FLINK-32012: I think you are on the right track. But we shou

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725470#comment-17725470 ] Feifan Wang commented on FLINK-29913: - Thanks for the clarification [~roman] !  {quo

[jira] [Comment Edited] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725470#comment-17725470 ] Feifan Wang edited comment on FLINK-29913 at 5/23/23 3:45 PM:

[GitHub] [flink] XComp commented on a diff in pull request #22384: [FLINK-31776][runtime] Introduces LeaderElection interface

2023-05-23 Thread via GitHub
XComp commented on code in PR #22384: URL: https://github.com/apache/flink/pull/22384#discussion_r1202637964 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderElection.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #606: [FLINK-31684] Report autoscaling metrics before metric window is full

2023-05-23 Thread via GitHub
mxm opened a new pull request, #606: URL: https://github.com/apache/flink-kubernetes-operator/pull/606 The metrics get reported only after the metric window is full. This is not helpful for observability after rescaling. We need to make sure that metrics are reported even when the metric wi

[jira] [Updated] (FLINK-31684) Autoscaler metrics are only visible after metric window is full

2023-05-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31684: --- Labels: pull-request-available (was: ) > Autoscaler metrics are only visible after metric w

[GitHub] [flink] lzshlzsh commented on a diff in pull request #22612: [FLINK-32139][connector/hbase] Using strongly increasing nanosecond timestamp and DeleteColumn type to fix data accidental deletio

2023-05-23 Thread via GitHub
lzshlzsh commented on code in PR #22612: URL: https://github.com/apache/flink/pull/22612#discussion_r1202716866 ## flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java: ## @@ -0,0 +1,43 @@ +/* + * Licens

[GitHub] [flink] lzshlzsh commented on a diff in pull request #22612: [FLINK-32139][connector/hbase] Using strongly increasing nanosecond timestamp and DeleteColumn type to fix data accidental deletio

2023-05-23 Thread via GitHub
lzshlzsh commented on code in PR #22612: URL: https://github.com/apache/flink/pull/22612#discussion_r1202716866 ## flink-connectors/flink-connector-hbase-base/src/test/java/org/apache/flink/connector/hbase/util/HBaseTimestampGeneratorTest.java: ## @@ -0,0 +1,43 @@ +/* + * Licens

[jira] [Created] (FLINK-32170) Continue metric collection on intermittant job restarts

2023-05-23 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-32170: -- Summary: Continue metric collection on intermittant job restarts Key: FLINK-32170 URL: https://issues.apache.org/jira/browse/FLINK-32170 Project: Flink

[GitHub] [flink] snuyanzin opened a new pull request, #22630: [hotfix] Use https://repo.maven.apache.org in maven-utils.sh

2023-05-23 Thread via GitHub
snuyanzin opened a new pull request, #22630: URL: https://github.com/apache/flink/pull/22630 ## What is the purpose of the change The idea is to use `https://repo.maven.apache.org` (same as `maven-wrapper.properties`) to download maven via `maven-utils.sh` since connection to `ht

[GitHub] [flink] flinkbot commented on pull request #22630: [hotfix] Use https://repo.maven.apache.org in maven-utils.sh

2023-05-23 Thread via GitHub
flinkbot commented on PR #22630: URL: https://github.com/apache/flink/pull/22630#issuecomment-1559869076 ## CI report: * abba63af11465e74c8b5ffc08cbaa622e8666064 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-connector-kafka] RamanVerma commented on a diff in pull request #29: [FLINK-32021][Connectors/Kafka] Improvement the Javadoc for SpecifiedOffsetsInitializer and TimestampOffsetsInitial

2023-05-23 Thread via GitHub
RamanVerma commented on code in PR #29: URL: https://github.com/apache/flink-connector-kafka/pull/29#discussion_r1202797216 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/enumerator/initializer/SpecifiedOffsetsInitializer.java: ## @@ -38,6 +38,10

[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-05-23 Thread Sylvia Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725539#comment-17725539 ] Sylvia Lin commented on FLINK-31095: Yeah, it's working! Thanks! I can close the tic

[jira] [Closed] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-05-23 Thread Sylvia Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylvia Lin closed FLINK-31095. -- Resolution: Not A Bug > FileSink doesn't work with s3a on EKS > -

[jira] [Commented] (FLINK-29913) Shared state would be discarded by mistake when maxConcurrentCheckpoint>1

2023-05-23 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725569#comment-17725569 ] Roman Khachatryan commented on FLINK-29913: --- Got it, thanks for clarifying. 

[GitHub] [flink] kurtostfeld closed pull request #22586: [FLINK-31880][tests] Fixes unit test so it will pass regardless of ti…

2023-05-23 Thread via GitHub
kurtostfeld closed pull request #22586: [FLINK-31880][tests] Fixes unit test so it will pass regardless of ti… URL: https://github.com/apache/flink/pull/22586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

  1   2   >