[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-08 Thread via GitHub
ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1223913567 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/NonSplittingRegexEnumerator.java: ## @@ -0,0 +1,102 @@ +/* +

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-08 Thread via GitHub
ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1223912208 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/NonSplittingRegexEnumerator.java: ## @@ -0,0 +1,102 @@ +/* +

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
gaborgsomogyi commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223906441 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licens

[GitHub] [flink] snuyanzin commented on a diff in pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-08 Thread via GitHub
snuyanzin commented on code in PR #22624: URL: https://github.com/apache/flink/pull/22624#discussion_r1223904857 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionMiscITLegacyCase.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed to t

[GitHub] [flink] flinkbot commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-06-08 Thread via GitHub
flinkbot commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1584051749 ## CI report: * a449bd831938f1179255c64bc96793b0891aa44d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] liuyongvs opened a new pull request, #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-06-08 Thread via GitHub
liuyongvs opened a new pull request, #22745: URL: https://github.com/apache/flink/pull/22745 - What is the purpose of the change This is an implementation of MAP_FROM_ENTRIES - Brief change log MAP_FROM_ENTRIES for Table API and SQL ``` map_from_entries(map) - Retur

[GitHub] [flink] luoyuxia commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-08 Thread via GitHub
luoyuxia commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1223891576 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSource.java: ## @@ -269,10 +271,35 @@ private SourceProvid

[jira] [Closed] (FLINK-31790) Filesystem batch sink should also respect to the PartitionCommitPolicy

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-31790. Resolution: Fixed master: 31e17bd13ef7f6cc4799441f8d6b1029f1468e6b > Filesystem batch sink should also re

[GitHub] [flink] luoyuxia merged pull request #22387: [FLINK-31790] Respect the PartitionCommitPolicy for batch Filesystem …

2023-06-08 Thread via GitHub
luoyuxia merged PR #22387: URL: https://github.com/apache/flink/pull/22387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-08 Thread via GitHub
ruanhang1993 commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1223886235 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSource.java: ## @@ -269,10 +271,35 @@ private SourcePr

[jira] [Closed] (FLINK-32055) Migrate all subclasses of BatchAbstractTestBase to JUnit5

2023-06-08 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-32055. - Fix Version/s: 1.18.0 Resolution: Done > Migrate all subclasses of BatchAbstractTestBase to JUnit

[GitHub] [flink] luoyuxia closed pull request #22741: Flink 31413 final fix failure

2023-06-08 Thread via GitHub
luoyuxia closed pull request #22741: Flink 31413 final fix failure URL: https://github.com/apache/flink/pull/22741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Closed] (FLINK-32059) Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-06-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-32059. -- Resolution: Fixed > Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and > batch.sql.join

[jira] [Updated] (FLINK-32059) Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-06-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32059: --- Fix Version/s: 1.18.0 > Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and > batch.sq

[jira] [Commented] (FLINK-32059) Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-06-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730825#comment-17730825 ] Weijie Guo commented on FLINK-32059: master(1.18) via a86b89b4223ee125c6427e6e8ebc88

[GitHub] [flink] snuyanzin commented on a diff in pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-08 Thread via GitHub
snuyanzin commented on code in PR #22717: URL: https://github.com/apache/flink/pull/22717#discussion_r1223880824 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayConcatFunction.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

[GitHub] [flink] reswqa merged pull request #22579: [FLINK-32059] Migrate subclasses of BatchAbstractTestBase in batch.sql.agg and batch.sql.join to JUnit5

2023-06-08 Thread via GitHub
reswqa merged PR #22579: URL: https://github.com/apache/flink/pull/22579 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223879529 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] snuyanzin commented on a diff in pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-08 Thread via GitHub
snuyanzin commented on code in PR #22717: URL: https://github.com/apache/flink/pull/22717#discussion_r1223879213 ## docs/data/sql_functions.yml: ## @@ -646,6 +646,9 @@ collection: - sql: ARRAY_UNION(array1, array2) table: haystack.arrayUnion(array) description: Retu

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223878792 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223877338 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223876233 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223876105 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[jira] [Commented] (FLINK-32239) Unify TestJvmProcess and TestProcessBuilder

2023-06-08 Thread Samrat Deb (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730817#comment-17730817 ] Samrat Deb commented on FLINK-32239: Hi [~chesnay] ,  Can i pick this minor improve

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223870641 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223870641 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223870388 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] pvary commented on a diff in pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pvary commented on code in PR #22694: URL: https://github.com/apache/flink/pull/22694#discussion_r1223869035 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/security/token/HiveDelegationTokenProvider.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to th

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223868769 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionReaderTest.java: ## @@ -0,0 +1,203 @@ +/* + * License

[GitHub] [flink] flinkbot commented on pull request #22744: [FLINK-29802][state] Changelog supports native savepoint

2023-06-08 Thread via GitHub
flinkbot commented on PR #22744: URL: https://github.com/apache/flink/pull/22744#issuecomment-1583990457 ## CI report: * e9987683f0c11781cb1d446132d79c526e7cc0c1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22743: [FLINK-26515][test] Add exception handling for RetryingExecutorTest#testDiscardOnTimeout

2023-06-08 Thread via GitHub
flinkbot commented on PR #22743: URL: https://github.com/apache/flink/pull/22743#issuecomment-1583986101 ## CI report: * 5a516e3f557f00b4ae30e04aed939942cdd6c599 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29802) ChangelogStateBackend supports native savepoint

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29802: --- Labels: pull-request-available (was: ) > ChangelogStateBackend supports native savepoint >

[GitHub] [flink] masteryhx opened a new pull request, #22744: [FLINK-29802][state] Changelog supports native savepoint

2023-06-08 Thread via GitHub
masteryhx opened a new pull request, #22744: URL: https://github.com/apache/flink/pull/22744 ## What is the purpose of the change - Supports native savepoint for ChangelogStateBackend ## Brief change log - Trigger native savepoint of internal state backend man

[jira] [Updated] (FLINK-26515) RetryingExecutorTest. testDiscardOnTimeout failed on azure

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26515: --- Labels: auto-deprioritized-major pull-request-available test-stability (was: auto-depriorit

[GitHub] [flink] masteryhx opened a new pull request, #22743: [FLINK-26515][test] Add exception handling for RetryingExecutorTest#testDiscardOnTimeout

2023-06-08 Thread via GitHub
masteryhx opened a new pull request, #22743: URL: https://github.com/apache/flink/pull/22743 ## What is the purpose of the change - Add exception handling machnism to make the exception visiable when RetryingExecutorTest#testDiscardOnTimeout timeouts ## Brief ch

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223835048 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223830277 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/LogicalFile.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] luoyuxia commented on a diff in pull request #22249: [FLINK-17398][connector/filesystem] Filesystem sources support flexible path reading

2023-06-08 Thread via GitHub
luoyuxia commented on code in PR #22249: URL: https://github.com/apache/flink/pull/22249#discussion_r1223819746 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/enumerate/NonSplittingRegexEnumerator.java: ## @@ -0,0 +1,102 @@ +/* + * Li

[GitHub] [flink] liuyongvs commented on pull request #22143: [FLINK-31377][table] Fix array_contains ArrayData.ElementGetter shoul…

2023-06-08 Thread via GitHub
liuyongvs commented on PR #22143: URL: https://github.com/apache/flink/pull/22143#issuecomment-1583953198 hi @luoyuxia will you have time to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
TanYuxin-tyx commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223820584 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/TestingNettyServiceProducer.java: ## @@ -0,0 +1,80 @@ +/* + * Lice

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223810138 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to

[GitHub] [flink] reswqa commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
reswqa commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223798313 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionReaderTest.java: ## @@ -0,0 +1,203 @@ +/* + * Licensed to

[GitHub] [flink] WencongLiu closed pull request #22307: [FLINK-31643][core] Introduce a temporary configuration to enable the tiered store architecture for hybrid shuffle

2023-06-08 Thread via GitHub
WencongLiu closed pull request #22307: [FLINK-31643][core] Introduce a temporary configuration to enable the tiered store architecture for hybrid shuffle URL: https://github.com/apache/flink/pull/22307 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [flink] WencongLiu closed pull request #22121: [FLINK-27051] fix CompletedCheckpoint.DiscardObject.discard is not idempotent

2023-06-08 Thread via GitHub
WencongLiu closed pull request #22121: [FLINK-27051] fix CompletedCheckpoint.DiscardObject.discard is not idempotent URL: https://github.com/apache/flink/pull/22121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] WencongLiu closed pull request #22318: [FLINK-27637][flink-streaming-java] Optimize the log information when the asynchronous part of checkpoint is canceled

2023-06-08 Thread via GitHub
WencongLiu closed pull request #22318: [FLINK-27637][flink-streaming-java] Optimize the log information when the asynchronous part of checkpoint is canceled URL: https://github.com/apache/flink/pull/22318 -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Closed] (FLINK-32291) Hive E2E test fails consistently

2023-06-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-32291. --- Resolution: Duplicate > Hive E2E test fails consistently > > >

[jira] [Commented] (FLINK-32291) Hive E2E test fails consistently

2023-06-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730794#comment-17730794 ] Rui Fan commented on FLINK-32291: - It's duplicated with FLINK-32294, and it has been fix

[GitHub] [flink] WencongLiu commented on pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
WencongLiu commented on PR #22342: URL: https://github.com/apache/flink/pull/22342#issuecomment-1583894707 Thanks for the careful review of @reswqa and @TanYuxin-tyx ! 😄 I've made a round of changes, please take a lock when you have time! -- This is an automated message from the Apache G

[jira] [Assigned] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32294: --- Assignee: Yuxia Luo > The CI fails due to HiveITCase > -- > >

[jira] [Commented] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730793#comment-17730793 ] Rui Fan commented on FLINK-32294: - Thanks a lot for your quick feedback, let me try it n

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223784984 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/LogicalFile.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [flink] pan3793 commented on pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-08 Thread via GitHub
pan3793 commented on PR #22694: URL: https://github.com/apache/flink/pull/22694#issuecomment-1583885964 Is it designed to support multi-HMS in a single application? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Comment Edited] (FLINK-30660) move SQLClientHiveITCase and TestHiveCatalogFactory to flink-connector-hive e2e

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730791#comment-17730791 ] luoyuxia edited comment on FLINK-30660 at 6/9/23 2:55 AM: -- Sorr

[jira] [Commented] (FLINK-30660) move SQLClientHiveITCase and TestHiveCatalogFactory to flink-connector-hive e2e

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730791#comment-17730791 ] luoyuxia commented on FLINK-30660: -- Sorry for that. It turns out that I miss the last o

[jira] [Comment Edited] (FLINK-30660) move SQLClientHiveITCase and TestHiveCatalogFactory to flink-connector-hive e2e

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730791#comment-17730791 ] luoyuxia edited comment on FLINK-30660 at 6/9/23 2:55 AM: -- Sorr

[jira] [Comment Edited] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730790#comment-17730790 ] luoyuxia edited comment on FLINK-32294 at 6/9/23 2:52 AM: -- mast

[jira] [Updated] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-32294: - Fix Version/s: 1.18.0 > The CI fails due to HiveITCase > -- > >

[jira] [Closed] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-32294. Resolution: Fixed master: eacd5c1d90c98349a35c25dc420eb59eec7bf698 [~fanrui] Should fix. You can try to r

[jira] [Updated] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32294: --- Labels: pull-request-available (was: ) > The CI fails due to HiveITCase > -

[GitHub] [flink-connector-pulsar] Samrat002 commented on pull request #51: [FLINK-32176] Exclude snakeyaml from pulsar-client-all to mitigate CVE-2022-1471

2023-06-08 Thread via GitHub
Samrat002 commented on PR #51: URL: https://github.com/apache/flink-connector-pulsar/pull/51#issuecomment-1583879236 Thank you @tisonkun, @syhily taking time in reviewing the small change. my intension was to exclude snakeyaml and mitigate vulnerablity, I missed to see the added unn

[GitHub] [flink] luoyuxia merged pull request #22740: [FLINK-32294][e2e] Fix HiveITCase failure

2023-06-08 Thread via GitHub
luoyuxia merged PR #22740: URL: https://github.com/apache/flink/pull/22740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730789#comment-17730789 ] luoyuxia commented on FLINK-32294: -- [~fanrui] Thanks for reporting.  > The CI fails du

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223779099 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223776437 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache

[GitHub] [flink] luoyuxia closed pull request #22739: fix hive e2e test failure

2023-06-08 Thread via GitHub
luoyuxia closed pull request #22739: fix hive e2e test failure URL: https://github.com/apache/flink/pull/22739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223775173 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManagerBase.java: ## @@ -0,0 +1,282 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Zakelly commented on a diff in pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-08 Thread via GitHub
Zakelly commented on code in PR #22590: URL: https://github.com/apache/flink/pull/22590#discussion_r1223773671 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/FileMergingSnapshotManager.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
TanYuxin-tyx commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223761576 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/TieredStorageNettyServiceImpl.java: ## @@ -0,0 +1,191 @@ +/* + * L

[jira] [Commented] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730785#comment-17730785 ] Rui Fan commented on FLINK-32294: - Hi [~yuxia] , I'm working on FLINK-30585[1], it's rel

[GitHub] [flink-connector-shared-utils] leonardBang merged pull request #14: [hotfix] Parameter '--message' is required for SVN delete command

2023-06-08 Thread via GitHub
leonardBang merged PR #14: URL: https://github.com/apache/flink-connector-shared-utils/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223768558 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionReaderTest.java: ## @@ -0,0 +1,203 @@ +/* + * License

[jira] [Created] (FLINK-32294) The CI fails due to HiveITCase

2023-06-08 Thread Rui Fan (Jira)
Rui Fan created FLINK-32294: --- Summary: The CI fails due to HiveITCase Key: FLINK-32294 URL: https://issues.apache.org/jira/browse/FLINK-32294 Project: Flink Issue Type: Bug Components: Co

[jira] [Updated] (FLINK-32188) Support to "where" query with a fixed-value array and simplify condition for an array-type filed.

2023-06-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-32188: - Summary: Support to "where" query with a fixed-value array and simplify condition for an array-type file

[jira] [Closed] (FLINK-32292) TableUtils.getRowTypeInfo fails to get type information of Tuple

2023-06-08 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed FLINK-32292. Resolution: Fixed > TableUtils.getRowTypeInfo fails to get type information of Tuple > ---

[jira] [Updated] (FLINK-32188) Support to "where" query and simplify condition for an array-type filed of temporary table with a fixed-value array.

2023-06-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-32188: - Summary: Support to "where" query and simplify condition for an array-type filed of temporary table with

[GitHub] [flink] zhougit86 commented on pull request #22624: [FLINK-32132][table-planner] Cast function CODEGEN does not work as e…

2023-06-08 Thread via GitHub
zhougit86 commented on PR #22624: URL: https://github.com/apache/flink/pull/22624#issuecomment-1583841476 @luoyuxia please find the test case in the commit, when the "cast( a as bigint)" function's input type is "STRING().notNull()", we suppose to get a null value. but now it returns a defa

[jira] [Commented] (FLINK-32292) TableUtils.getRowTypeInfo fails to get type information of Tuple

2023-06-08 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730784#comment-17730784 ] Dong Lin commented on FLINK-32292: -- Merged to apache/flink-ml master branch 0b6b7f70e45

[GitHub] [flink-ml] zhipeng93 opened a new pull request, #242: [FLINK-32293] Support sparse vector with long index

2023-06-08 Thread via GitHub
zhipeng93 opened a new pull request, #242: URL: https://github.com/apache/flink-ml/pull/242 ## What is the purpose of the change Add support for sparse vector with long as index and double as value. ## Brief change log - Renamed `SparseVector` as `SparseIntDoubleVector`, `Den

[jira] [Updated] (FLINK-32293) Support vector with long index

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32293: --- Labels: pull-request-available (was: ) > Support vector with long index > -

[jira] [Assigned] (FLINK-32292) TableUtils.getRowTypeInfo fails to get type information of Tuple

2023-06-08 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-32292: Assignee: Zhipeng Zhang > TableUtils.getRowTypeInfo fails to get type information of Tuple >

[jira] [Updated] (FLINK-32188) Support to "where" query and simplify condition for an array-type filed of temporary table.

2023-06-08 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xin Chen updated FLINK-32188: - Summary: Support to "where" query and simplify condition for an array-type filed of temporary table. (w

[GitHub] [flink-ml] lindong28 merged pull request #241: [FLINK-32292] Fix TableUtils.getRowTypeInfo when the input contains Tuple

2023-06-08 Thread via GitHub
lindong28 merged PR #241: URL: https://github.com/apache/flink-ml/pull/241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink-ml] lindong28 commented on pull request #241: [FLINK-32292] Fix TableUtils.getRowTypeInfo when the input contains Tuple

2023-06-08 Thread via GitHub
lindong28 commented on PR #241: URL: https://github.com/apache/flink-ml/pull/241#issuecomment-1583838532 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] flinkbot commented on pull request #22742: [FLINK-30629][Client/Job Submission] Increase clientHeartbeatTimeout to 1 second

2023-06-08 Thread via GitHub
flinkbot commented on PR #22742: URL: https://github.com/apache/flink/pull/22742#issuecomment-1583837770 ## CI report: * 96d5d46ed9d0a4ff84f1d6dee053b4647716131f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-08 Thread Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17730783#comment-17730783 ] Liu commented on FLINK-30629: - [~Sergey Nuyanzin] Fixed. Please review the code. Thanks. >

[GitHub] [flink] Myracle opened a new pull request, #22742: [FLINK-30629][Client/Job Submission] Increase clientHeartbeatTimeout to 1 second

2023-06-08 Thread via GitHub
Myracle opened a new pull request, #22742: URL: https://github.com/apache/flink/pull/22742 ## What is the purpose of the change *Increase clientHeartbeatTimeout to 1 second to avoid shutting down the job in ClientHeartbeatTest.* ## Brief change log - *Increase clientHe

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-08 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1223745155 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyConnectionWriterImpl.java: ## @@ -0,0 +1,60 @@ +/* + * Licensed

[GitHub] [flink] SinBex commented on a diff in pull request #21634: [FLINK-30480][runtime] Add benchmarks for adaptive batch scheduler.

2023-06-08 Thread via GitHub
SinBex commented on code in PR #21634: URL: https://github.com/apache/flink/pull/21634#discussion_r1223745121 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/benchmark/SchedulerBenchmarkUtils.java: ## @@ -103,17 +113,55 @@ public static ExecutionGraph createAnd

[jira] [Updated] (FLINK-32293) Support vector with long index

2023-06-08 Thread Zhipeng Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhipeng Zhang updated FLINK-32293: -- Component/s: Library / Machine Learning > Support vector with long index > ---

[jira] [Created] (FLINK-32293) Support vector with long index

2023-06-08 Thread Zhipeng Zhang (Jira)
Zhipeng Zhang created FLINK-32293: - Summary: Support vector with long index Key: FLINK-32293 URL: https://issues.apache.org/jira/browse/FLINK-32293 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-32292) TableUtils.getRowTypeInfo fails to get type information of Tuple

2023-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32292: --- Labels: pull-request-available (was: ) > TableUtils.getRowTypeInfo fails to get type inform

[GitHub] [flink-ml] zhipeng93 opened a new pull request, #241: [FLINK-32292] Fix TableUtils.getRowTypeInfo when the input contains Tuple

2023-06-08 Thread via GitHub
zhipeng93 opened a new pull request, #241: URL: https://github.com/apache/flink-ml/pull/241 ## What is the purpose of the change Fix TableUtils.getRowTypeInfo when the input contains Tuple ## Brief change log *(for example:)* - Use `ExternalTypeInfo.of(..)` when the

[jira] [Created] (FLINK-32292) TableUtils.getRowTypeInfo fails to get type information of Tuple

2023-06-08 Thread Zhipeng Zhang (Jira)
Zhipeng Zhang created FLINK-32292: - Summary: TableUtils.getRowTypeInfo fails to get type information of Tuple Key: FLINK-32292 URL: https://issues.apache.org/jira/browse/FLINK-32292 Project: Flink

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric V2

2023-06-08 Thread via GitHub
morhidi commented on PR #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617#issuecomment-1583711883 @mxm @gyfora this is my second attempt on adding the `RECOMMENDED_PARALLELISM` let me know what you think -- This is an automated message from the Apache Git Service. T

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #617: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-08 Thread via GitHub
morhidi opened a new pull request, #617: URL: https://github.com/apache/flink-kubernetes-operator/pull/617 ## What is the purpose of the change It is beneficial to report the recommended parallelism and overlay it with the current parallelism on the same chart when auto scaler is runn

[GitHub] [flink] flinkbot commented on pull request #22741: Flink 31413 final fix failure

2023-06-08 Thread via GitHub
flinkbot commented on PR #22741: URL: https://github.com/apache/flink/pull/22741#issuecomment-1583656598 ## CI report: * 0dde2279a8457a2e79b95f2c01e8837725df29bd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22741: Flink 31413 final fix failure

2023-06-08 Thread via GitHub
luoyuxia opened a new pull request, #22741: URL: https://github.com/apache/flink/pull/22741 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] flinkbot commented on pull request #22740: [hotfix][e2e] Fix HiveITCase failure

2023-06-08 Thread via GitHub
flinkbot commented on PR #22740: URL: https://github.com/apache/flink/pull/22740#issuecomment-1583644884 ## CI report: * 7a43c44f6b01237de02bb4a3443be8c3d4238ce0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22740: [hotfix][e2e] Fix HiveITCase failure

2023-06-08 Thread via GitHub
luoyuxia opened a new pull request, #22740: URL: https://github.com/apache/flink/pull/22740 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] flinkbot commented on pull request #22739: fix hive e2e test failure

2023-06-08 Thread via GitHub
flinkbot commented on PR #22739: URL: https://github.com/apache/flink/pull/22739#issuecomment-1583617435 ## CI report: * c2c0195b268f8e13f0e9778bda9ca3f19831169c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

  1   2   3   >