[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-27 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1243246177 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -728,6 +731,7 @@ private C

[GitHub] [flink] twalthr commented on a diff in pull request #22842: [FLINK-32261]-table-Add-MAP_UNION-function

2023-06-27 Thread via GitHub
twalthr commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1243252360 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apa

[jira] [Commented] (FLINK-23620) Introduce proper YAML parsing to Flink's configuration

2023-06-27 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737499#comment-17737499 ] Junrui Li commented on FLINK-23620: --- Hi [~autophagy], are you still working on this is

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243174207 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/ImmediateCheckpointingAfterAllTasksFinishedITCase.java: ## @@ -0,0 +1,147 @@ +/* + * Licensed to the

[jira] [Closed] (FLINK-32228) Bump testcontainers to 1.18.2

2023-06-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32228. -- Resolution: Fixed > Bump testcontainers to 1.18.2 > - > >

[GitHub] [flink-web] MartijnVisser merged pull request #654: Add JDBC v3.1.1 for Flink 1.16.x and Flink 1.17.x

2023-06-27 Thread via GitHub
MartijnVisser merged PR #654: URL: https://github.com/apache/flink-web/pull/654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser merged pull request #658: [hotfix] Fix the wrong link in contribute code page

2023-06-27 Thread via GitHub
MartijnVisser merged PR #658: URL: https://github.com/apache/flink-web/pull/658 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser merged pull request #648: [hotfix] Minor grammar fixes

2023-06-27 Thread via GitHub
MartijnVisser merged PR #648: URL: https://github.com/apache/flink-web/pull/648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser merged pull request #629: English sentence correction

2023-06-27 Thread via GitHub
MartijnVisser merged PR #629: URL: https://github.com/apache/flink-web/pull/629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser commented on pull request #604: Apache Flink Google Cloud PubSub Connector 3.0.0

2023-06-27 Thread via GitHub
MartijnVisser commented on PR #604: URL: https://github.com/apache/flink-web/pull/604#issuecomment-1608966649 Superseded by 3.0.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink-web] MartijnVisser merged pull request #621: Remove hard-coded flink/scala binary version , and fix documentation build instructions

2023-06-27 Thread via GitHub
MartijnVisser merged PR #621: URL: https://github.com/apache/flink-web/pull/621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink-web] MartijnVisser closed pull request #604: Apache Flink Google Cloud PubSub Connector 3.0.0

2023-06-27 Thread via GitHub
MartijnVisser closed pull request #604: Apache Flink Google Cloud PubSub Connector 3.0.0 URL: https://github.com/apache/flink-web/pull/604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink-web] MartijnVisser merged pull request #615: Fix typo

2023-06-27 Thread via GitHub
MartijnVisser merged PR #615: URL: https://github.com/apache/flink-web/pull/615 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Comment Edited] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737459#comment-17737459 ] Sergey Nuyanzin edited comment on FLINK-30629 at 6/27/23 7:43 AM:

[jira] [Commented] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737504#comment-17737504 ] Sergey Nuyanzin commented on FLINK-32441: - [~srichter] it looks it starts appear

[GitHub] [flink] twalthr commented on a diff in pull request #22558: [FLINK-28744][table] Upgrade Calcite to 1.31.0

2023-06-27 Thread via GitHub
twalthr commented on code in PR #22558: URL: https://github.com/apache/flink/pull/22558#discussion_r1243287053 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CastFunctionITCase.java: ## @@ -526,7 +526,7 @@ private static List allTypesBa

[jira] [Commented] (FLINK-32268) KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737510#comment-17737510 ] Sergey Nuyanzin commented on FLINK-32268: - probably another variation of https:/

[jira] [Comment Edited] (FLINK-32268) KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737510#comment-17737510 ] Sergey Nuyanzin edited comment on FLINK-32268 at 6/27/23 7:56 AM:

[jira] [Updated] (FLINK-31724) SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf /opt/flink/checkpoint/*" returned non-zero exit code 1

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-31724: -- Priority: Major (was: Critical) > SqlClientITCase.testMatchRecognize fails with "bash -c rm -

[jira] [Commented] (FLINK-31724) SqlClientITCase.testMatchRecognize fails with "bash -c rm -rf /opt/flink/checkpoint/*" returned non-zero exit code 1

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737511#comment-17737511 ] Qingsheng Ren commented on FLINK-31724: --- I checked the log but didn't find anythin

[jira] [Created] (FLINK-32445) BlobStore.closeAndCleanupAllData doesn't do any close action

2023-06-27 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32445: - Summary: BlobStore.closeAndCleanupAllData doesn't do any close action Key: FLINK-32445 URL: https://issues.apache.org/jira/browse/FLINK-32445 Project: Flink

[jira] [Assigned] (FLINK-32268) KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-32268: - Assignee: Qingsheng Ren > KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp fail

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-27 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737524#comment-17737524 ] Chesnay Schepler commented on FLINK-32379: -- If it works, go ahead. > Skip arch

[jira] [Assigned] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-27 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-32379: Assignee: Sergey Nuyanzin (was: Sergey Nuyanzin) > Skip archunit tests in java1X

[jira] [Assigned] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-27 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-32379: Assignee: Sergey Nuyanzin (was: Chesnay Schepler) > Skip archunit tests in java1

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22878: [hotfix] [flink-parquet] Print stacktrace when reporting statistics failed

2023-06-27 Thread via GitHub
wanglijie95 commented on code in PR #22878: URL: https://github.com/apache/flink/pull/22878#discussion_r1243336650 ## flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/utils/ParquetFormatStatisticsReportUtil.java: ## @@ -81,7 +81,7 @@ public static Table

[GitHub] [flink] zentol commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-06-27 Thread via GitHub
zentol commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1243343382 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001

[jira] [Assigned] (FLINK-32391) YARNSessionFIFOITCase.checkForProhibitedLogContents fails on AZP

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-32391: - Assignee: Konstantin Knauf > YARNSessionFIFOITCase.checkForProhibitedLogContents fails

[jira] [Assigned] (FLINK-32270) Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-32270: - Assignee: Konstantin Knauf > Heartbeat timeout in AggregateReduceGroupingITCase.testAgg

[jira] (FLINK-31664) Add ARRAY_INTERSECT supported in SQL & Table API

2023-06-27 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31664 ] jackylau deleted comment on FLINK-31664: -- was (Author: jackylau): [~Sergey Nuyanzin] ok, thanks for your explain. i will contact the author first > Add ARRAY_INTERSECT supported in SQL & Table

[GitHub] [flink] afedulov commented on pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-27 Thread via GitHub
afedulov commented on PR #21774: URL: https://github.com/apache/flink/pull/21774#issuecomment-1609058160 Arghhh, this example is broken 🙄 @reswqa The issue is that the original function miscalculates the distance by making it 10 times larger than it is supposed to be based on the time e

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243361973 ## flink-python/pyflink/table/expression.py: ## @@ -1519,6 +1519,13 @@ def array_union(self, array) -> 'Expression': """ return _binary_op("arrayUnio

[GitHub] [flink] StefanRRichter opened a new pull request, #22879: [FLINK-32441] Fix DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore

2023-06-27 Thread via GitHub
StefanRRichter opened a new pull request, #22879: URL: https://github.com/apache/flink/pull/22879 ## What is the purpose of the change Fixes test `DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore` that was using the wrong executor to acknowlege a checkpoint. T

[jira] [Updated] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32441: --- Labels: pull-request-available test-stability (was: test-stability) > DefaultSchedulerTest#

[jira] [Assigned] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter reassigned FLINK-32441: -- Assignee: Stefan Richter > DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfte

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243398481 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayComparableElementTypeStrategy.java: ## @@ -0,0 +1,147 @@ +/* + *

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243399978 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ComparabilityUtils.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot commented on pull request #22879: [FLINK-32441] Fix DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore

2023-06-27 Thread via GitHub
flinkbot commented on PR #22879: URL: https://github.com/apache/flink/pull/22879#issuecomment-1609100787 ## CI report: * 35812bfe4491ba11b979d534147484fb9a9b7869 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243400750 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ComparabilityUtils.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-32392) Several jobs failed on AZP with No space left on device

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737541#comment-17737541 ] Qingsheng Ren commented on FLINK-32392: --- Backport to 1.17: 0740649c714b50b83572f14

[jira] [Updated] (FLINK-32392) Several jobs failed on AZP with No space left on device

2023-06-27 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren updated FLINK-32392: -- Fix Version/s: 1.18.0 1.16.3 1.17.2 > Several jobs faile

[GitHub] [flink-web] klion26 commented on pull request #658: [hotfix] Fix the wrong link in contribute code page

2023-06-27 Thread via GitHub
klion26 commented on PR #658: URL: https://github.com/apache/flink-web/pull/658#issuecomment-1609126954 @MartijnVisser thanks for the review and merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] jiangxin369 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
jiangxin369 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243423393 ## docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -277,11 +277,10 @@ task with the number of new subtasks equal to the number of running

[GitHub] [flink] swuferhong opened a new pull request, #22880: [WIP] Don't merge, just for CI test

2023-06-27 Thread via GitHub
swuferhong opened a new pull request, #22880: URL: https://github.com/apache/flink/pull/22880 ## What is the purpose of the change CI test for https://issues.apache.org/jira/browse/FLINK-18356 ## Brief change log ## Verifying this change ## Does this pull r

[GitHub] [flink] flinkbot commented on pull request #22880: [WIP] Don't merge, just for CI test

2023-06-27 Thread via GitHub
flinkbot commented on PR #22880: URL: https://github.com/apache/flink/pull/22880#issuecomment-1609163175 ## CI report: * 73154a85dd96453d338cb1e09e51d37b22fd1f75 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted

2023-06-27 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737558#comment-17737558 ] Junhan Yang commented on FLINK-30719: - Looks like there is still no any proposed fix

[jira] [Commented] (FLINK-31673) Add E2E tests for flink jdbc driver

2023-06-27 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737560#comment-17737560 ] Yang Wang commented on FLINK-31673: --- The new introduced e2e test is failing. Could you

[GitHub] [flink] reswqa commented on pull request #21774: [FLINK-28227][connectors] Migrate o.a.f.streaming.examples to the new Source API

2023-06-27 Thread via GitHub
reswqa commented on PR #21774: URL: https://github.com/apache/flink/pull/21774#issuecomment-1609191262 Well, from my point of view, how to generate data here is not what users really want to care about. We just need to maintain a self consistent logic. So It is ok for me to choose both opti

[jira] [Commented] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737569#comment-17737569 ] Stefan Richter commented on FLINK-30859: [~tzulitai] I think you forgot to remov

[jira] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859 ] Stefan Richter deleted comment on FLINK-30859: was (Author: srichter): [~tzulitai] I think you forgot to remove some code here: https://github.com/apache/flink/blob/149a5e34c1ed8d8943c90

[GitHub] [flink] pnowojski commented on a diff in pull request #22879: [FLINK-32441] Fix DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore

2023-06-27 Thread via GitHub
pnowojski commented on code in PR #22879: URL: https://github.com/apache/flink/pull/22879#discussion_r1243517624 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/DefaultSchedulerTest.java: ## @@ -891,7 +891,7 @@ store, new StandaloneCheckpointIDCounter()))

[jira] (FLINK-31673) Add E2E tests for flink jdbc driver

2023-06-27 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31673 ] Yang Wang deleted comment on FLINK-31673: --- was (Author: fly_in_gis): The new introduced e2e test is failing. Could you please have a look?   https://dev.azure.com/apache-flink/98463496-1af2-4

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243561691 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -479,4 +480,165 @@ private Stream array

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #19: [FLINK-32353] update archunit violations for prod and test code with flink-1.18 rules

2023-06-27 Thread via GitHub
echauchot commented on PR #19: URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1609303291 > > Maybe we should add tests against flink master snapshot ? Right now there is only 1.16.x 1.17.x in PRs > > added 1.18-SNAPSHOT tests Got it, the failure

[GitHub] [flink-kubernetes-operator] ashangit commented on pull request #622: [FLINK-32012] Provide rollback feature on savepoint upgrade mode if HA missing and JM never started

2023-06-27 Thread via GitHub
ashangit commented on PR #622: URL: https://github.com/apache/flink-kubernetes-operator/pull/622#issuecomment-1609313144 There was an issue with new set of commits due to `deployConfig` being created too early and missing the potential reset of spec in case of `rolling_back` Unittest up

[jira] [Closed] (FLINK-32389) [Dependabot] Bump guava from 27.0.1-jre to 32.0.0-jre

2023-06-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32389. -- Fix Version/s: 1.18.0 Resolution: Fixed Fixed in apache/flink:master - 6ebd9f3a5c9b387a

[GitHub] [flink] dependabot[bot] closed pull request #22784: Bump guava from 27.0.1-jre to 32.0.0-jre in /flink-formats/flink-orc

2023-06-27 Thread via GitHub
dependabot[bot] closed pull request #22784: Bump guava from 27.0.1-jre to 32.0.0-jre in /flink-formats/flink-orc URL: https://github.com/apache/flink/pull/22784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [flink] dependabot[bot] commented on pull request #22784: Bump guava from 27.0.1-jre to 32.0.0-jre in /flink-formats/flink-orc

2023-06-27 Thread via GitHub
dependabot[bot] commented on PR #22784: URL: https://github.com/apache/flink/pull/22784#issuecomment-1609323113 Looks like com.google.guava:guava is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737605#comment-17737605 ] Martijn Visser commented on FLINK-32441: Other occurrences: https://dev.azure.c

[GitHub] [flink] MartijnVisser closed pull request #21402: Name defination suggestion for this doc

2023-06-27 Thread via GitHub
MartijnVisser closed pull request #21402: Name defination suggestion for this doc URL: https://github.com/apache/flink/pull/21402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] MartijnVisser closed pull request #21246: Update json.md

2023-06-27 Thread via GitHub
MartijnVisser closed pull request #21246: Update json.md URL: https://github.com/apache/flink/pull/21246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243602098 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -0,0 +1,43 @@ +/* + * Lice

[GitHub] [flink] MartijnVisser commented on pull request #21630: [FLINK-30166][Connector/FileSystem] Refactor tests that use the deprecated StreamingFileSink instead of FileSink

2023-06-27 Thread via GitHub
MartijnVisser commented on PR #21630: URL: https://github.com/apache/flink/pull/21630#issuecomment-1609337377 > Very sorry for missing the message, I’ll have a look soon. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243602598 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -0,0 +1,43 @@ +/* + * Lice

[GitHub] [flink] dawidwys commented on a diff in pull request #22730: [FLINK-32257]-table-Add-ARRAY_MAX-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22730: URL: https://github.com/apache/flink/pull/22730#discussion_r1243604546 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayElementOutputTypeStrategy.java: ## @@ -0,0 +1,43 @@ +/* + * Lice

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243613710 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/ArrayOfStringArgumentTypeStrategy.java: ## @@ -0,0 +1,94 @@ +/* + * L

[GitHub] [flink] RocMarshal commented on pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2023-06-27 Thread via GitHub
RocMarshal commented on PR #20990: URL: https://github.com/apache/flink/pull/20990#issuecomment-1609371415 Hi, @snuyanzin @MartijnVisser Could you help to review it in your free time? Thank you~ -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Created] (FLINK-32446) MongoWriter should regularly check whether the last write time is greater than the specified time.

2023-06-27 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-32446: -- Summary: MongoWriter should regularly check whether the last write time is greater than the specified time. Key: FLINK-32446 URL: https://issues.apache.org/jira/browse/FLINK-32446

[jira] [Commented] (FLINK-32446) MongoWriter should regularly check whether the last write time is greater than the specified time.

2023-06-27 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737621#comment-17737621 ] Jiabao Sun commented on FLINK-32446: [~Leonard] Can you help assign this ticket to m

[GitHub] [flink-connector-gcp-pubsub] MartijnVisser commented on pull request #13: [FLINK-32031] Flink GCP Connector having issues with Conscrypt library

2023-06-27 Thread via GitHub
MartijnVisser commented on PR #13: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/13#issuecomment-1609378121 @jayadeep-jayaraman Thanks for the PR! Just for my understanding, is Conscrypt a requirement when using newer Dataproc clusters? -- This is an automated message f

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-27 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737623#comment-17737623 ] yuanfenghu commented on FLINK-23190: [~loyi] 我认为有些缺陷,我之前也做过类似的工作,比如 > Make task-slo

[jira] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-27 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190 ] yuanfenghu deleted comment on FLINK-23190: was (Author: JIRAUSER296932): [~loyi] 我认为有些缺陷,我之前也做过类似的工作,比如 > Make task-slot allocation much more evenly > ---

[jira] [Assigned] (FLINK-32270) Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP

2023-06-27 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-32270: - Assignee: Roman Khachatryan (was: Konstantin Knauf) > Heartbeat timeout in Agg

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-27 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737625#comment-17737625 ] yuanfenghu commented on FLINK-23190: loyi  I think there are still some problems, m

[jira] [Commented] (FLINK-32391) YARNSessionFIFOITCase.checkForProhibitedLogContents fails on AZP

2023-06-27 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737624#comment-17737624 ] Ferenc Csaky commented on FLINK-32391: -- Hey! I can take a look at this, feel free t

[jira] [Updated] (FLINK-32031) Flink GCP Connector having issues with Conscrypt library

2023-06-27 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32031: --- Fix Version/s: gcp-pubsub-3.0.2 > Flink GCP Connector having issues with Conscrypt library >

[jira] [Assigned] (FLINK-32391) YARNSessionFIFOITCase.checkForProhibitedLogContents fails on AZP

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-32391: --- Assignee: Ferenc Csaky (was: Konstantin Knauf) > YARNSessionFIFOITCase.checkForPro

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243647774 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Ap

[jira] [Commented] (FLINK-32391) YARNSessionFIFOITCase.checkForProhibitedLogContents fails on AZP

2023-06-27 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737629#comment-17737629 ] Sergey Nuyanzin commented on FLINK-32391: - thanks [~ferenc-csaky]  assigned to y

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243651135 ## docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -277,11 +277,10 @@ task with the number of new subtasks equal to the number of running ta

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-27 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1243650264 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -758,6 +762,15 @@ private

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243653679 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -502,6 +503,20 @@ public CompletableFuture updateTaskExecutionState(

[GitHub] [flink] lindong28 commented on a diff in pull request #22670: [FLINK-28386][runtime] Trigger an immediate checkpoint after all sinks finished

2023-06-27 Thread via GitHub
lindong28 commented on code in PR #22670: URL: https://github.com/apache/flink/pull/22670#discussion_r1243250725 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java: ## @@ -236,6 +239,16 @@ public SchedulerBase( this.exceptionHistory =

[jira] [Commented] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-27 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737632#comment-17737632 ] yuanfenghu commented on FLINK-23190: [~loyi]  I think there are other issues to cons

[jira] [Comment Edited] (FLINK-23190) Make task-slot allocation much more evenly

2023-06-27 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737625#comment-17737625 ] yuanfenghu edited comment on FLINK-23190 at 6/27/23 12:32 PM:

[GitHub] [flink] StefanRRichter merged pull request #22879: [FLINK-32441] Fix DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore

2023-06-27 Thread via GitHub
StefanRRichter merged PR #22879: URL: https://github.com/apache/flink/pull/22879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

[jira] [Commented] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17737642#comment-17737642 ] Stefan Richter commented on FLINK-32441: Fixed in master 0c787f5. > DefaultSche

[jira] [Closed] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-32441. -- Resolution: Fixed > DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails wit

[GitHub] [flink] dawidwys commented on a diff in pull request #22785: [FLINK-32259]-table-Add-ARRAY_JOIN-function

2023-06-27 Thread via GitHub
dawidwys commented on code in PR #22785: URL: https://github.com/apache/flink/pull/22785#discussion_r1243696355 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArrayJoinFunction.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Ap

[jira] [Updated] (FLINK-32441) DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore fails with timeout on AZP

2023-06-27 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32441: - Fix Version/s: 1.18.0 > DefaultSchedulerTest#testTriggerCheckpointAndCompletedAfterStore

[jira] [Closed] (FLINK-32347) Exceptions from the CompletedCheckpointStore are not registered by the CheckpointFailureManager

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-32347. -- Resolution: Fixed > Exceptions from the CompletedCheckpointStore are not registered by the >

[jira] [Updated] (FLINK-32347) Exceptions from the CompletedCheckpointStore are not registered by the CheckpointFailureManager

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-32347: --- Fix Version/s: 1.18.0 > Exceptions from the CompletedCheckpointStore are not registered by t

[GitHub] [flink] XComp commented on pull request #22865: [FLINK-32421][test] EmbeddedLeaderServiceTest.testConcurrentRevokeLeadershipAndShutdown is not properly implemented

2023-06-27 Thread via GitHub
XComp commented on PR #22865: URL: https://github.com/apache/flink/pull/22865#issuecomment-1609483525 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] XComp commented on pull request #22873: [FLINK-32419][runtime] Removal of obsolete/unused classes/interfaces/fields

2023-06-27 Thread via GitHub
XComp commented on PR #22873: URL: https://github.com/apache/flink/pull/22873#issuecomment-1609491086 force-push after I rebased to the most-recent version of FLINK-32409 that fixed CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (FLINK-32326) Disable WAL in RocksDBWriteBatchWrapper by default

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-32326: --- Fix Version/s: 1.18.0 (was: 1.19.0) > Disable WAL in RocksDBWriteBatc

[jira] [Closed] (FLINK-32345) Improve parallel download of RocksDB incremental state

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-32345. -- Resolution: Fixed > Improve parallel download of RocksDB incremental state > -

[jira] [Closed] (FLINK-32326) Disable WAL in RocksDBWriteBatchWrapper by default

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-32326. -- Resolution: Fixed > Disable WAL in RocksDBWriteBatchWrapper by default > -

[jira] [Updated] (FLINK-32345) Improve parallel download of RocksDB incremental state

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-32345: --- Fix Version/s: 1.18.0 (was: 1.19.0) > Improve parallel download of Ro

[jira] [Updated] (FLINK-32410) Allocate hash-based collections with sufficient capacity for expected size

2023-06-27 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-32410: --- Fix Version/s: 1.18.0 (was: 1.19.0) > Allocate hash-based collections

[jira] [Assigned] (FLINK-32446) MongoWriter should regularly check whether the last write time is greater than the specified time.

2023-06-27 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-32446: -- Assignee: Jiabao Sun > MongoWriter should regularly check whether the last write time is grea

  1   2   3   >