[jira] [Commented] (FLINK-32520) FlinkDeployment recovered states from an obsolete savepoint when performing an upgrade

[ https://issues.apache.org/jira/browse/FLINK-32520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739822#comment-17739822 ] Gyula Fora commented on FLINK-32520: Would it be possible to send the entire operato

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251577433 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -932,38 +1064,71 @@ void runTestWithManuallyTriggeredE

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251576723 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -597,14 +676,30 @@ void testOnLeaderInformationChange

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251550146 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -425,59 +425,72 @@ private void onRevokeLeadershipInternal

[jira] [Commented] (FLINK-15571) Create a Redis Streams Connector for Flink

[ https://issues.apache.org/jira/browse/FLINK-15571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739820#comment-17739820 ] Martijn Visser commented on FLINK-15571: Is there anyone who still wants to work

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22806: [FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

1996fanrui commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1251571234 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java: ## @@ -220,8 +223,20 @@ void sendEventToSourceOperator(int

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLINK-31380][table] FLIP-297: Support enhanced show catalogs syntax

chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1619594892 @wuchong hi, Jark. Another PR [ShowFunctions](https://github.com/apache/flink/pull/22903) has been merged, I picked some common logics and rebased mater, can u help to review this PR?

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251551929 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -349,22 +380,42 @@ void testProperCleanupOnLeaderElec

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251550146 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -425,59 +425,72 @@ private void onRevokeLeadershipInternal

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1251547821 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java: ## @@ -220,8 +223,20 @@ void sendEventToSourceOperator(int su

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1251547228 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,153 @@ +/* + * Licensed to the A

[GitHub] [flink] flinkbot commented on pull request #22939: [FLINK-32474][table] Support time travel in table planner

flinkbot commented on PR #22939: URL: https://github.com/apache/flink/pull/22939#issuecomment-1619576836 ## CI report: * a9697f009ce12b52395d5a10245029350b1531a5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [connectors/common] increase the robustness of announceCombinedWatermark to cover the case task failover

LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1251543678 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java: ## @@ -220,8 +223,20 @@ void sendEventToSourceOperator(int su

[jira] [Commented] (FLINK-23620) Introduce proper YAML parsing to Flink's configuration

[ https://issues.apache.org/jira/browse/FLINK-23620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739806#comment-17739806 ] Zhu Zhu commented on FLINK-23620: - Thanks for volunteering! [~JunRuiLi] I have assigned

[jira] [Assigned] (FLINK-23620) Introduce proper YAML parsing to Flink's configuration

[ https://issues.apache.org/jira/browse/FLINK-23620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-23620: --- Assignee: Junrui Li (was: Mika Naylor) > Introduce proper YAML parsing to Flink's configuration >

[GitHub] [flink] XComp commented on a diff in pull request #22844: [FLINK-31784][runtime] Adds multi-component support to DefaultLeaderElectionService

XComp commented on code in PR #22844: URL: https://github.com/apache/flink/pull/22844#discussion_r1251536978 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -425,59 +425,72 @@ private void onRevokeLeadershipInternal

[jira] [Updated] (FLINK-32474) Support time travel in table planner

[ https://issues.apache.org/jira/browse/FLINK-32474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32474: --- Labels: pull-request-available (was: ) > Support time travel in table planner > --

[GitHub] [flink] hackergin opened a new pull request, #22939: [FLINK-32474][table] Support time travel in table planner

hackergin opened a new pull request, #22939: URL: https://github.com/apache/flink/pull/22939 ## What is the purpose of the change *Support time travel * ## Brief change log - *When validating, parse the Snapshot information to obtain the Schema correspondin

[jira] [Updated] (FLINK-32420) Watermark aggregation performance is poor when watermark alignment is enabled and parallelism is high

[ https://issues.apache.org/jira/browse/FLINK-32420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32420: Parent: FLINK-32524 Issue Type: Sub-task (was: Improvement) > Watermark aggregation performance i

[jira] [Updated] (FLINK-32506) Add the watermark aggregation benchmark for source coordinator

[ https://issues.apache.org/jira/browse/FLINK-32506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-32506: Parent: FLINK-32524 Issue Type: Sub-task (was: Improvement) > Add the watermark aggregation bench

[jira] [Created] (FLINK-32524) Improve the watermark aggregation performance when enabling the watermark alignment

Rui Fan created FLINK-32524: --- Summary: Improve the watermark aggregation performance when enabling the watermark alignment Key: FLINK-32524 URL: https://issues.apache.org/jira/browse/FLINK-32524 Project: Fl

[jira] [Commented] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739797#comment-17739797 ] Tzu-Li (Gordon) Tai commented on FLINK-32455: - FYI preview PR for the fast w

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #35: [FLINK-32450] Update Kafka CI setup to latest version for PRs and nightly builds

tzulitai commented on PR #35: URL: https://github.com/apache/flink-connector-kafka/pull/35#issuecomment-1619536054 Build against Flink 1.18 will be fixed with this PR: https://github.com/apache/flink-connector-kafka/pull/39 -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-32453) flink-connector-kafka does not build against Flink 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32453: --- Labels: pull-request-available (was: ) > flink-connector-kafka does not build against Flink

[jira] [Closed] (FLINK-32462) Kafka shouldn't rely on Flink-Shaded

[ https://issues.apache.org/jira/browse/FLINK-32462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-32462. --- Resolution: Fixed > Kafka shouldn't rely on Flink-Shaded > -

[jira] [Updated] (FLINK-32462) Kafka shouldn't rely on Flink-Shaded

[ https://issues.apache.org/jira/browse/FLINK-32462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-32462: Fix Version/s: kafka-3.0.1 kafka-3.1.0 > Kafka shouldn't rely o

[jira] [Assigned] (FLINK-32462) Kafka shouldn't rely on Flink-Shaded

[ https://issues.apache.org/jira/browse/FLINK-32462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-32462: --- Assignee: Martijn Visser > Kafka shouldn't rely on Flink-Shaded > -

[jira] [Commented] (FLINK-32462) Kafka shouldn't rely on Flink-Shaded

[ https://issues.apache.org/jira/browse/FLINK-32462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739795#comment-17739795 ] Tzu-Li (Gordon) Tai commented on FLINK-32462: - Merged to {{{}apache/flink-co

[GitHub] [flink-connector-kafka] tzulitai closed pull request #36: [FLINK-32462] Pin the used shaded version of Guava and Jackson in the Kafka connector

tzulitai closed pull request #36: [FLINK-32462] Pin the used shaded version of Guava and Jackson in the Kafka connector URL: https://github.com/apache/flink-connector-kafka/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-32506) Add the watermark aggregation benchmark for source coordinator

[ https://issues.apache.org/jira/browse/FLINK-32506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739793#comment-17739793 ] Rui Fan commented on FLINK-32506: - Merged via: b402108f9bc468ed5223a5d73ea0bfcfa0085cfe

[GitHub] [flink] 1996fanrui merged pull request #22921: [FLINK-32506][connectors/common] Add the benchmark for watermark aggregation when enabling the watermark alignment

1996fanrui merged PR #22921: URL: https://github.com/apache/flink/pull/22921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] 1996fanrui commented on pull request #22921: [FLINK-32506][connectors/common] Add the benchmark for watermark aggregation when enabling the watermark alignment

1996fanrui commented on PR #22921: URL: https://github.com/apache/flink/pull/22921#issuecomment-1619503606 Thanks a lot @RocMarshal and @pnowojski 's review and the great suggestion, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1619500479 @snuyanzin it's ok now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #36: [FLINK-32462] Pin the used shaded version of Guava and Jackson in the Kafka connector

tzulitai commented on PR #36: URL: https://github.com/apache/flink-connector-kafka/pull/36#issuecomment-1619494936 thanks, merging this ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Comment Edited] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739787#comment-17739787 ] Tzu-Li (Gordon) Tai edited comment on FLINK-32455 at 7/4/23 4:36 AM: -

[jira] [Commented] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739787#comment-17739787 ] Tzu-Li (Gordon) Tai commented on FLINK-32455: - One (quick) fix for now might

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251467377 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,9 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns a

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1619462048 > This query fails with NullPointerException > > ```sql > SELECT map_union(MAP[1, 2], MAP[CAST(NULL AS INT), 3]); > ``` key = CAST(NULL AS INT) is ok now.

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1619461436 @snuyanzin key = CAST(NULL AS INT) is ok now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Comment Edited] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739785#comment-17739785 ] Tzu-Li (Gordon) Tai edited comment on FLINK-32455 at 7/4/23 4:14 AM: -

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1251458008 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

[jira] [Comment Edited] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739785#comment-17739785 ] Tzu-Li (Gordon) Tai edited comment on FLINK-32455 at 7/4/23 4:13 AM: -

[jira] [Commented] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739785#comment-17739785 ] Tzu-Li (Gordon) Tai commented on FLINK-32455: - [~gaoyunhaii] sorry for the s

[GitHub] [flink] Baibaiwuguo commented on pull request #22805: [FLINK-32365][orc]get orc table statistics in parallel

Baibaiwuguo commented on PR #22805: URL: https://github.com/apache/flink/pull/22805#issuecomment-1619436709 I changed some of the logic. The task read the file footer in parallel and calculate the file footer in serial. I add the doc for the newly added option. I need you to review it whe

[GitHub] [flink] luoyuxia commented on a diff in pull request #22888: [FLINK-32355][table] Support to list procedures

luoyuxia commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1251439733 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowProcedures.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1619418179 hi @snuyanzin fix your reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] liuyongvs commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

liuyongvs commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1251436429 ## flink-python/pyflink/table/expressions.py: ## @@ -503,6 +503,25 @@ def map_from_arrays(key, value) -> Expression: return _binary_op("mapFromArrays", key, valu

[GitHub] [flink] liuyongvs commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

liuyongvs commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1251435754 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java: ## @@ -553,6 +553,23 @@ public static ApiExpression mapFromArrays(Objec

[GitHub] [flink] chucheng92 commented on a diff in pull request #22888: [FLINK-32355][table] Support to list procedures

chucheng92 commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1251416413 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowProcedures.java: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [flink] chucheng92 commented on pull request #22888: [FLINK-32355][table] Support to list procedures

chucheng92 commented on PR #22888: URL: https://github.com/apache/flink/pull/22888#issuecomment-1619411033 Looks good. +1 for the PR. @luoyuxia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] luoyuxia commented on pull request #22888: [FLINK-32355][table] Support to list procedures

luoyuxia commented on PR #22888: URL: https://github.com/apache/flink/pull/22888#issuecomment-1619410323 @chucheng92 Thanks. I got you. I have updated it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] luoyuxia commented on a diff in pull request #22888: [FLINK-32355][table] Support to list procedures

luoyuxia commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1251429935 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -455,6 +455,46 @@ SqlShowFunctions SqlShowFunctions() : } } +/** +* Parses a s

[GitHub] [flink] Tartarus0zm commented on pull request #22934: [FLINK-32516][table] Support to parse [CREATE OR ] REPLACE TABLE AS statement

Tartarus0zm commented on PR #22934: URL: https://github.com/apache/flink/pull/22934#issuecomment-1619401824 > @Tartarus0zm Thanks for updating. I left minor comment about the typo. PTAL @luoyuxia I have fix the typo, PTAL -- This is an automated message from the Apache Git Service.

[GitHub] [flink] FangYongs commented on pull request #22938: [FLINK-32512] Don't register resource to user resource manager when creating temporary function

FangYongs commented on PR #22938: URL: https://github.com/apache/flink/pull/22938#issuecomment-1619400179 Hi @fsk119 @lsyldliu Please help to review this PR when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [flink] FangYongs commented on pull request #22768: [FLINK-32309][sql-gateway] Use independent resource manager for table environment

FangYongs commented on PR #22768: URL: https://github.com/apache/flink/pull/22768#issuecomment-1619399347 @fsk119 As we discussed, I have create another PR [22938](https://github.com/apache/flink/pull/22938) for temporary function, please help to review it, thanks -- This is an automated

[GitHub] [flink] flinkbot commented on pull request #22938: [FLINK-32512] Don't register resource to user resource manager when creating temporary function

flinkbot commented on PR #22938: URL: https://github.com/apache/flink/pull/22938#issuecomment-1619395706 ## CI report: * 12c78711cd122059d99b738b7b43fedd7d9fbd50 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hanyuzheng7 commented on pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

hanyuzheng7 commented on PR #22917: URL: https://github.com/apache/flink/pull/22917#issuecomment-1619395595 > hi @hanyuzheng7 , you may don't understand the real problem when you reviewed. i submit the comments before, just for convenient to review. if you test empty array in sql-client. yo

[GitHub] [flink] luoyuxia commented on pull request #22888: [FLINK-32355][table] Support to list procedures

luoyuxia commented on PR #22888: URL: https://github.com/apache/flink/pull/22888#issuecomment-1619394409 @luoyuxia Thanks for your review. I hope I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] luoyuxia commented on a diff in pull request #22934: [FLINK-32516][table] Support to parse [CREATE OR ] REPLACE TABLE AS statement

luoyuxia commented on code in PR #22934: URL: https://github.com/apache/flink/pull/22934#discussion_r1251418124 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlReplaceTableAs.java: ## @@ -0,0 +1,279 @@ +/* + * Licensed to the Apache Software Foun

[jira] [Updated] (FLINK-32512) SHOW JARS should not show the jars for temporary function

[ https://issues.apache.org/jira/browse/FLINK-32512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32512: --- Labels: pull-request-available (was: ) > SHOW JARS should not show the jars for temporary f

[GitHub] [flink] FangYongs opened a new pull request, #22938: [FLINK-32512] Don't register resource to user resource manager when creating temporary function

FangYongs opened a new pull request, #22938: URL: https://github.com/apache/flink/pull/22938 ## What is the purpose of the change When flink perform `create temporary function` or `create system function` with a jar file, it will register the jar file to `ResourceManager` and add it

[GitHub] [flink] chucheng92 commented on pull request #22888: [FLINK-32355][table] Support to list procedures

chucheng92 commented on PR #22888: URL: https://github.com/apache/flink/pull/22888#issuecomment-1619387796 @luoyuxia hi, yuxia. I leave a few minor comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] luoyuxia commented on a diff in pull request #22888: [FLINK-32355][table] Support to list procedures

luoyuxia commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1251413200 ## flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowProcedures.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [flink-benchmarks] 1996fanrui commented on a diff in pull request #77: [FLINK-32506][connectors/common] Add the benchmark for watermark aggregation

1996fanrui commented on code in PR #77: URL: https://github.com/apache/flink-benchmarks/pull/77#discussion_r1251410570 ## src/main/java/org/apache/flink/benchmark/WatermarkAggregationBenchmark.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [flink] chucheng92 commented on a diff in pull request #22888: [FLINK-32355][table] Support to list procedures

chucheng92 commented on code in PR #22888: URL: https://github.com/apache/flink/pull/22888#discussion_r1246541234 ## flink-table/flink-sql-parser/src/main/codegen/includes/parserImpls.ftl: ## @@ -455,6 +455,46 @@ SqlShowFunctions SqlShowFunctions() : } } +/** +* Parses a

[GitHub] [flink] liuyongvs commented on pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

liuyongvs commented on PR #22917: URL: https://github.com/apache/flink/pull/22917#issuecomment-1619368240 hi @dawidwys add the udf test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] WencongLiu commented on a diff in pull request #22807: [FLINK-31645][network] Introduce the PartitionFileReader and DiskIOSchduler

WencongLiu commented on code in PR #22807: URL: https://github.com/apache/flink/pull/22807#discussion_r1251400447 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -0,0 +1,451 @@ +/* + * Licensed to t

[GitHub] [flink] WencongLiu commented on a diff in pull request #22807: [FLINK-31645][network] Introduce the PartitionFileReader and DiskIOSchduler

WencongLiu commented on code in PR #22807: URL: https://github.com/apache/flink/pull/22807#discussion_r1251400927 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskIOScheduler.java: ## @@ -0,0 +1,451 @@ +/* + * Licensed to t

[GitHub] [flink] liuyongvs commented on pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

liuyongvs commented on PR #22917: URL: https://github.com/apache/flink/pull/22917#issuecomment-1619355997 > .withFunction(CreateEmptyArray.class) > .testResult(call("CreateEmptyArray").arrayMax(), "ARRAY_MAX(CreateEmptyArray())", null, DataTypes.INT()) @dawidwys good suggestion, i

[GitHub] [flink] liuyongvs commented on pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

liuyongvs commented on PR #22917: URL: https://github.com/apache/flink/pull/22917#issuecomment-1619348688 hi @hanyuzheng7 , you may don't understand the real problem when you reviewed. i submit the comments before, just for convenient to review. if you test empty array in sql-client. y

[GitHub] [flink] luoyuxia commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel

luoyuxia commented on PR #22928: URL: https://github.com/apache/flink/pull/22928#issuecomment-1619334297 Btw, next time, please name the pr title with the format `[FLINK-xxx][xxx] xxx `. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (FLINK-32473) Introduce base interfaces for time travel

[ https://issues.apache.org/jira/browse/FLINK-32473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32473. -- Resolution: Fixed master: 0be92626ea741c681619896ab86696e1d0bde665 Thanks for the pr. > Introduce b

[GitHub] [flink] luoyuxia merged pull request #22928: [FLINK-32473] Introduce base interfaces for time travel

luoyuxia merged PR #22928: URL: https://github.com/apache/flink/pull/22928 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Resolved] (FLINK-32310) Support enhanced show functions syntax

[ https://issues.apache.org/jira/browse/FLINK-32310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32310. -- Fix Version/s: 1.18.0 Resolution: Fixed master: c090846e5d73a718b32ca5ddfa920d69edf57d61 Than

[GitHub] [flink] luoyuxia merged pull request #22903: [FLINK-32310][table] Support enhanced show functions syntax

luoyuxia merged PR #22903: URL: https://github.com/apache/flink/pull/22903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] hanyuzheng7 commented on pull request #22917: [FLINK-32498][table] Fix the problem of array_max return type, it sho…

hanyuzheng7 commented on PR #22917: URL: https://github.com/apache/flink/pull/22917#issuecomment-1619300730 Although after adding this test case, all test can pass. But the sql-client also report error. https://github.com/apache/flink/assets/135176127/f968c8bd-1079-4b19-86d9-4151e9a97

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739728#comment-17739728 ] Sergey Nuyanzin commented on FLINK-18356: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739727#comment-17739727 ] Sergey Nuyanzin commented on FLINK-18356: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-18356) flink-table-planner Exit code 137 returned from process

[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739725#comment-17739725 ] Sergey Nuyanzin commented on FLINK-18356: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-26974) Python EmbeddedThreadDependencyTests.test_add_python_file failed on azure

[ https://issues.apache.org/jira/browse/FLINK-26974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17739724#comment-17739724 ] Sergey Nuyanzin commented on FLINK-26974: - https://dev.azure.com/apache-flink/ap

[jira] [Created] (FLINK-32523) NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted fails with timeout on AZP

Sergey Nuyanzin created FLINK-32523: --- Summary: NotifyCheckpointAbortedITCase.testNotifyCheckpointAborted fails with timeout on AZP Key: FLINK-32523 URL: https://issues.apache.org/jira/browse/FLINK-32523

[GitHub] [flink] hackergin commented on pull request #22928: [FLINK-32473] Introduce base interfaces for time travel

hackergin commented on PR #22928: URL: https://github.com/apache/flink/pull/22928#issuecomment-1618989013 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] snuyanzin commented on a diff in pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

snuyanzin commented on code in PR #22745: URL: https://github.com/apache/flink/pull/22745#discussion_r1251035724 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapFromEntriesFunction.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1618981779 > Is it legal for the key of the map to be null? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251178840 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,9 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns an

[GitHub] [flink] snuyanzin commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

snuyanzin commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1618976415 This query fails with NullPointerException ```sql SELECT map_union(MAP[1, 2], MAP[CAST(NULL AS INT), 3]); ``` -- This is an automated message from the Apache Git Service.

[GitHub] [flink] hanyuzheng7 commented on pull request #22785: [FLINK-32259][table] Add built-in ARRAY_JOIN function.

hanyuzheng7 commented on PR #22785: URL: https://github.com/apache/flink/pull/22785#issuecomment-1618965798 > Sorry, I meant an empty array 🤦 NP, thank you for reviewing my code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1251168614 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

snuyanzin commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1251168614 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/MapUnionFunction.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the A

[jira] [Resolved] (FLINK-32438) Merge AbstractZooKeeperHaServices and ZooKeeperMultipleComponentLeaderElectionHaServices

[ https://issues.apache.org/jira/browse/FLINK-32438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32438. --- Fix Version/s: 1.18.0 Resolution: Fixed master: a7bd6de71dea56307ca9240fee0c6000d1199

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251161421 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,121 @@ +/* + * Licensed to t

[GitHub] [flink] XComp merged pull request #22868: [FLINK-32438][runtime] Merges AbstractZooKeeperHaServices with ZooKeeperMultipleComponentLeaderElectionHaServices

XComp merged PR #22868: URL: https://github.com/apache/flink/pull/22868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Resolved] (FLINK-32436) Remove obsolete LeaderContender.getDescription method

[ https://issues.apache.org/jira/browse/FLINK-32436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32436. --- Fix Version/s: 1.18.0 Resolution: Fixed master: 310d85950b80f7f775617983df2d82b9c6224

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251159004 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,9 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns a

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251156118 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,9 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns an

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251154815 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,11 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251141458 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,11 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns an

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251141458 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,11 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns an

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251137626 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,11 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1251137626 ## docs/data/sql_functions.yml: ## @@ -643,6 +643,11 @@ collection: - sql: ARRAY_REVERSE(haystack) table: haystack.arrayReverse() description: Returns

  1   2   3   4   >