[jira] [Comment Edited] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741151#comment-17741151 ] Rui Fan edited comment on FLINK-32496 at 7/8/23 3:35 AM: - Thanks for the

[jira] [Resolved] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-32496. - Fix Version/s: 1.18.0 1.16.3 1.17.2 Resolution: Fixed >

[GitHub] [flink] 1996fanrui merged pull request #22969: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui merged PR #22969: URL: https://github.com/apache/flink/pull/22969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22969: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui commented on PR #22969: URL: https://github.com/apache/flink/pull/22969#issuecomment-1626677563 Thanks @mas-chen and @RocMarshal for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-32565) Support cast from BYTES to DOUBLE

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741230#comment-17741230 ] Hanyu Zheng commented on FLINK-32565: - [~martijnvisser] can you please assign this ticket to 

[jira] [Commented] (FLINK-32564) Support cast from BYTES to BIGINT

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741229#comment-17741229 ] Hanyu Zheng commented on FLINK-32564: - [~martijnvisser] can you please assign this ticket to 

[jira] [Updated] (FLINK-32564) Support cast from BYTES to BIGINT

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32564: Summary: Support cast from BYTES to BIGINT (was: Support cast BYTES to BIGINT) > Support cast

[jira] [Updated] (FLINK-32565) Support cast from BYTES to DOUBLE

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32565: Summary: Support cast from BYTES to DOUBLE (was: Support cast BYTES to DOUBLE) > Support cast

[jira] [Comment Edited] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741203#comment-17741203 ] Hanyu Zheng edited comment on FLINK-32261 at 7/8/23 2:26 AM: - [~Sergey

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1626496365 Returns a map created by merging at least one map. These maps should have a common map type. If there are overlapping keys, the value from 'map2' will overwrite the value from

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1626411229 @snuyanzin solve all comments and rebase again and pass ci test and ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Resolved] (FLINK-32547) Add missing doc for Timestamp support in ProtoBuf format

2023-07-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-32547. Fix Version/s: 1.18.0 1.17.2 Resolution: Fixed Fixed via -

[GitHub] [flink] libenchao merged pull request #22970: [FLINK-32547][docs] Add missing doc for Timestamp support in ProtoBuf…

2023-07-07 Thread via GitHub
libenchao merged PR #22970: URL: https://github.com/apache/flink/pull/22970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32565) Support cast BYTES to DOUBLE

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32565: Description: We are undertaking a task that requires casting from the BYTES type to DOUBLE. In

[jira] [Created] (FLINK-32565) Support cast BYTES to DOUBLE

2023-07-07 Thread Hanyu Zheng (Jira)
Hanyu Zheng created FLINK-32565: --- Summary: Support cast BYTES to DOUBLE Key: FLINK-32565 URL: https://issues.apache.org/jira/browse/FLINK-32565 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-32564) Support cast BYTES to BIGINT

2023-07-07 Thread Hanyu Zheng (Jira)
Hanyu Zheng created FLINK-32564: --- Summary: Support cast BYTES to BIGINT Key: FLINK-32564 URL: https://issues.apache.org/jira/browse/FLINK-32564 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-26191) Incorrect license in Elasticsearch connectors

2023-07-07 Thread Morey Straus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741214#comment-17741214 ] Morey Straus commented on FLINK-26191: -- Elastic 7.10.2 (not just client) has a [number of

[GitHub] [flink] liuyongvs commented on pull request #22745: [FLINK-31691][table] Add built-in MAP_FROM_ENTRIES function.

2023-07-07 Thread via GitHub
liuyongvs commented on PR #22745: URL: https://github.com/apache/flink/pull/22745#issuecomment-1626345629 Hi @snuyanzin fix your review. will you look it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1626320500 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #22971: Bump stylelint from 14.8.5 to 15.10.1 in /flink-runtime-web/web-dashboard

2023-07-07 Thread via GitHub
flinkbot commented on PR #22971: URL: https://github.com/apache/flink/pull/22971#issuecomment-1626309175 ## CI report: * c74b8f0c2c60ee10a42f630453f7cd73c2833a73 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256557291 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256556083 ## docs/data/sql_functions_zh.yml: ## @@ -712,6 +712,12 @@ conversion: 特别是匿名的内联数据类型没有可序列化的字符串表示。在这种情况下返回 `NULL`。 collection: + - sql: ARRAY_SLICE(array,

[GitHub] [flink] dependabot[bot] opened a new pull request, #22971: Bump stylelint from 14.8.5 to 15.10.1 in /flink-runtime-web/web-dashboard

2023-07-07 Thread via GitHub
dependabot[bot] opened a new pull request, #22971: URL: https://github.com/apache/flink/pull/22971 Bumps [stylelint](https://github.com/stylelint/stylelint) from 14.8.5 to 15.10.1. Release notes Sourced from https://github.com/stylelint/stylelint/releases;>stylelint's releases.

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1626282954 > i noticed there are a couple of minor things to improve may I ask you to do it before merge? no problem, I will fix them -- This is an automated message from the Apache

[jira] [Comment Edited] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741203#comment-17741203 ] Hanyu Zheng edited comment on FLINK-32261 at 7/7/23 10:15 PM: -- [~Sergey

[jira] [Commented] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-07-07 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741203#comment-17741203 ] Hanyu Zheng commented on FLINK-32261: - [~Sergey Nuyanzin] I think it's a good suggestion. It's ok to

[GitHub] [flink-connector-jdbc] dependabot[bot] opened a new pull request, #69: Bump h2 from 2.1.210 to 2.2.220 in /flink-connector-jdbc

2023-07-07 Thread via GitHub
dependabot[bot] opened a new pull request, #69: URL: https://github.com/apache/flink-connector-jdbc/pull/69 Bumps [h2](https://github.com/h2database/h2database) from 2.1.210 to 2.2.220. Release notes Sourced from https://github.com/h2database/h2database/releases;>h2's releases.

[jira] [Commented] (FLINK-32261) Add MAP_UNION support in SQL & Table API

2023-07-07 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741199#comment-17741199 ] Sergey Nuyanzin commented on FLINK-32261: - Thanks for the question. Let's not look at spark

[GitHub] [flink-docker] daniel-packard commented on pull request #158: [ADD-SYMLINKS] Add symlinks for FLINK_VERSION to FLINK_RELEASE jars

2023-07-07 Thread via GitHub
daniel-packard commented on PR #158: URL: https://github.com/apache/flink-docker/pull/158#issuecomment-1626128157 I appreciate you taking a look, and sharing with the community! In the meantime, we will pin our flink base image versions to the patch version (e.g. `1.16.2`) --

[jira] [Resolved] (FLINK-32035) SQL Client should support HTTPS with built-in JDK certificates

2023-07-07 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise resolved FLINK-32035. -- Fix Version/s: 1.18.0 Resolution: Implemented > SQL Client should support HTTPS with

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1626003520 i noticed there are a couple of minor things to improve may I ask you to do it before merge? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256395360 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256394724 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/ArraySliceFunction.java: ## @@ -0,0 +1,81 @@ +/* + * Licensed to the

[GitHub] [flink] tweise merged pull request #22810: [FLINK-32035][sql-client] Support HTTPS endpoints in SQL Client gateway mode

2023-07-07 Thread via GitHub
tweise merged PR #22810: URL: https://github.com/apache/flink/pull/22810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256382229 ## docs/data/sql_functions_zh.yml: ## @@ -712,6 +712,12 @@ conversion: 特别是匿名的内联数据类型没有可序列化的字符串表示。在这种情况下返回 `NULL`。 collection: + - sql: ARRAY_SLICE(array,

[GitHub] [flink] snuyanzin commented on a diff in pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on code in PR #22834: URL: https://github.com/apache/flink/pull/22834#discussion_r1256382229 ## docs/data/sql_functions_zh.yml: ## @@ -712,6 +712,12 @@ conversion: 特别是匿名的内联数据类型没有可序列化的字符串表示。在这种情况下返回 `NULL`。 collection: + - sql: ARRAY_SLICE(array,

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1256335928 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CommonMapInputTypeStrategy.java: ## @@ -0,0 +1,113 @@ +/* + *

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1625929844 @snuyanzin do you think it is ok now? I let CommonMapInputTypeStrategy and CommonArrayInputTypeStrategy as subclass extends CommonCollectionInputTypeStrategy. -- This is an

[GitHub] [flink] hanyuzheng7 commented on a diff in pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on code in PR #22842: URL: https://github.com/apache/flink/pull/22842#discussion_r1256335928 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/CommonMapInputTypeStrategy.java: ## @@ -0,0 +1,113 @@ +/* + *

[jira] [Commented] (FLINK-32496) Sources with idleness and alignment always wait for alignment when part of multiple sources is idle

2023-07-07 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741151#comment-17741151 ] Rui Fan commented on FLINK-32496: - Thanks for the reporting and review, merged via : 0e69a7b 1.16 :

[GitHub] [flink] 1996fanrui merged pull request #22968: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui merged PR #22968: URL: https://github.com/apache/flink/pull/22968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22968: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui commented on PR #22968: URL: https://github.com/apache/flink/pull/22968#issuecomment-1625757036 Thanks for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1625748261 @snuyanzin rebased and pass ci test, it ready to merge, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-connector-opensearch] lilyevsky commented on pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-07-07 Thread via GitHub
lilyevsky commented on PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1625707386 So you can merge it now? After you do, I am going to build locally the latest version and do my own tests. -- This is an automated message from the Apache Git

[GitHub] [flink] hanyuzheng7 commented on pull request #22842: [FLINK-32261][table] Add built-in MAP_UNION function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1625673575 @snuyanzin do you think it's ok now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] hlteoh37 commented on pull request #22901: [FLINK-32469][REST] Improve checkpoint REST APIs for programmatic access

2023-07-07 Thread via GitHub
hlteoh37 commented on PR #22901: URL: https://github.com/apache/flink/pull/22901#issuecomment-1625594873 Added doc strings and fixed a typo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741083#comment-17741083 ] Martijn Visser commented on FLINK-32563: [~echauchot] The _testing.yml is the testing

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 3:14 PM: --

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 3:13 PM: --

[GitHub] [flink] hanyuzheng7 commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
hanyuzheng7 commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1625534330 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-28743) Support validating the determinism for StreamPhysicalMatchRecognize

2023-07-07 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741069#comment-17741069 ] Timo Walther commented on FLINK-28743: -- [~lincoln.86xy] I'm wondering whether we should still

[jira] [Updated] (FLINK-32551) Provide the possibility to take a savepoint when deleting a flinkdeployment

2023-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32551: --- Labels: pull-request-available (was: ) > Provide the possibility to take a savepoint when

[GitHub] [flink-kubernetes-operator] ashangit opened a new pull request, #627: [FLINK-32551] Add option to take a savepoint on flinkdeployment/flinksessionjob deletion

2023-07-07 Thread via GitHub
ashangit opened a new pull request, #627: URL: https://github.com/apache/flink-kubernetes-operator/pull/627 ## What is the purpose of the change This pull request add an option `savepointOnDeletion` on `JobSpec` to indicate if the operator must take a savepoint on

[GitHub] [flink] flinkbot commented on pull request #22970: [FLINK-32547][docs] Add missing doc for Timestamp support in ProtoBuf…

2023-07-07 Thread via GitHub
flinkbot commented on PR #22970: URL: https://github.com/apache/flink/pull/22970#issuecomment-1625485254 ## CI report: * af3f780b883e0ebbf1344a3d7d367c3b9d467e63 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] libenchao commented on pull request #22970: [FLINK-32547][docs] Add missing doc for Timestamp support in ProtoBuf…

2023-07-07 Thread via GitHub
libenchao commented on PR #22970: URL: https://github.com/apache/flink/pull/22970#issuecomment-1625480868 @maosuhan @laughingman7743 could you help to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (FLINK-32547) Add missing doc for Timestamp support in ProtoBuf format

2023-07-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-32547: -- Assignee: Benchao Li > Add missing doc for Timestamp support in ProtoBuf format >

[jira] [Updated] (FLINK-32547) Add missing doc for Timestamp support in ProtoBuf format

2023-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32547: --- Labels: pull-request-available (was: ) > Add missing doc for Timestamp support in ProtoBuf

[GitHub] [flink] libenchao opened a new pull request, #22970: [FLINK-32547][docs] Add missing doc for Timestamp support in ProtoBuf…

2023-07-07 Thread via GitHub
libenchao opened a new pull request, #22970: URL: https://github.com/apache/flink/pull/22970 … format ## What is the purpose of the change Add missing doc. ## Brief change log ## Verifying this change ## Does this pull request potentially affect one

[GitHub] [flink] 1996fanrui commented on pull request #22968: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui commented on PR #22968: URL: https://github.com/apache/flink/pull/22968#issuecomment-1625479722 Hi @RocMarshal @mas-chen , this is the backporting of FLINK-32496 for release-1.16. Could you help take a look this PR in your free time? thanks~ 1.16 has a little conflicts

[jira] [Commented] (FLINK-31816) Refactor EmbeddedLeaderElectionService

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741054#comment-17741054 ] Matthias Pohl commented on FLINK-31816: --- I'm wondering whether a structure like this would make

[GitHub] [flink] 1996fanrui commented on pull request #22969: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui commented on PR #22969: URL: https://github.com/apache/flink/pull/22969#issuecomment-1625471760 Hi @RocMarshal @mas-chen , this is the backporting of FLINK-32496 for release-1.17. Could you help take a look this PR in your free time? thanks~ -- This is an automated message

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 1:49 PM: --

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 1:48 PM: --

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 1:47 PM: --

[jira] [Comment Edited] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot edited comment on FLINK-32563 at 7/7/23 1:47 PM: --

[jira] [Commented] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741045#comment-17741045 ] Etienne Chauchot commented on FLINK-32563: -- [~martijnvisser] > From the discussion thread I

[GitHub] [flink] XComp commented on pull request #22919: [FLINK-31837][runtime] Makes LeaderElectionDriver instantiation happen lazily

2023-07-07 Thread via GitHub
XComp commented on PR #22919: URL: https://github.com/apache/flink/pull/22919#issuecomment-1625422572 The inital force-push (https://github.com/apache/flink/commit/ea11496fc291e890f0ef9453b52a5c6701f43203) fixed a test failure. The second one was a rebase to master after FLINK-32502 was

[jira] [Resolved] (FLINK-32502) Remove AbstractLeaderElectionService

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32502. --- Fix Version/s: 1.18.0 Resolution: Fixed master:

[GitHub] [flink] XComp merged pull request #22959: [FLINK-32502][runtime] Remove the AbstractLeaderElectionService

2023-07-07 Thread via GitHub
XComp merged PR #22959: URL: https://github.com/apache/flink/pull/22959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32554) Facilitate slot isolation and resource management for global committer

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32554: --- Component/s: API / Core Connectors / Common > Facilitate slot isolation

[jira] [Commented] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-07-07 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740998#comment-17740998 ] Piotr Nowojski commented on FLINK-31238: [~mayuehappy] thanks for your work on this! Really nice

[jira] [Commented] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740995#comment-17740995 ] Hong Liang Teoh commented on FLINK-32508: - [~martijnvisser]  Sounds great! Always happy to

[jira] [Comment Edited] (FLINK-31816) Refactor EmbeddedLeaderElectionService

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740991#comment-17740991 ] Matthias Pohl edited comment on FLINK-31816 at 7/7/23 12:16 PM: {quote}

[jira] [Comment Edited] (FLINK-31816) Refactor EmbeddedLeaderElectionService

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740991#comment-17740991 ] Matthias Pohl edited comment on FLINK-31816 at 7/7/23 12:15 PM: {quote}

[jira] [Commented] (FLINK-31816) Refactor EmbeddedLeaderElectionService

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740991#comment-17740991 ] Matthias Pohl commented on FLINK-31816: --- > DefaultLeaderElectionService can be used as a generic

[GitHub] [flink-ml] jiangxin369 commented on pull request #246: [FLINK-32545] Improves the performance by optimizing row operations

2023-07-07 Thread via GitHub
jiangxin369 commented on PR #246: URL: https://github.com/apache/flink-ml/pull/246#issuecomment-1625322947 > @jiangxin369 Can you help update the configuration of these benchmarks so that they can run for e.g 30-60 seconds and validate the performance improvement of this PR? Sure, I

[jira] [Commented] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Ryan van Huuksloot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740989#comment-17740989 ] Ryan van Huuksloot commented on FLINK-32508: I don’t have time to work on this until the

[jira] [Commented] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740986#comment-17740986 ] Martijn Visser commented on FLINK-32508: [~liangtl] I've assigned it to you, but I thought

[jira] [Updated] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32508: --- Issue Type: New Feature (was: Technical Debt) > Flink-Metrics Prometheus - Native

[jira] [Updated] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32508: --- Priority: Major (was: Minor) > Flink-Metrics Prometheus - Native Histograms / Native

[jira] [Updated] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-32508: --- Fix Version/s: (was: 1.18.0) (was: 1.19.0) > Flink-Metrics

[jira] [Assigned] (FLINK-32508) Flink-Metrics Prometheus - Native Histograms / Native Counters

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-32508: -- Assignee: Hong Liang Teoh > Flink-Metrics Prometheus - Native Histograms / Native

[GitHub] [flink] flinkbot commented on pull request #22969: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
flinkbot commented on PR #22969: URL: https://github.com/apache/flink/pull/22969#issuecomment-1625227972 ## CI report: * 6dd46e28216fefd7d9305df6167d01d043e8e30a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22968: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
flinkbot commented on PR #22968: URL: https://github.com/apache/flink/pull/22968#issuecomment-1625226629 ## CI report: * 169a936c110441d80e35899247a20e5db7a743fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] 1996fanrui opened a new pull request, #22969: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui opened a new pull request, #22969: URL: https://github.com/apache/flink/pull/22969 backport FLINK-32496 to 1.17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] 1996fanrui opened a new pull request, #22968: [FLINK-32496][connectors/common] Fix the bug that source cannot resume after enabling the watermark alignment and idleness

2023-07-07 Thread via GitHub
1996fanrui opened a new pull request, #22968: URL: https://github.com/apache/flink/pull/22968 backport FLINK-32496 to 1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on pull request #22967: [FLINK-32556][runtime] Renames contenderID into componentId

2023-07-07 Thread via GitHub
XComp commented on PR #22967: URL: https://github.com/apache/flink/pull/22967#issuecomment-1625203184 There are two open PRs (#22959, #22919) which I plan to merge to `master` first. I will do a final rebase with the two PRs merged before doing a final pass over the code. -- This is an

[GitHub] [flink] XComp commented on a diff in pull request #22959: [FLINK-32502][runtime] Remove the AbstractLeaderElectionService

2023-07-07 Thread via GitHub
XComp commented on code in PR #22959: URL: https://github.com/apache/flink/pull/22959#discussion_r1255598263 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElection.java: ## @@ -56,4 +56,40 @@ public boolean hasLeadership(UUID

[GitHub] [flink-kubernetes-operator] ashangit commented on a diff in pull request #625: [FLINK-32529] Add startup probe for JM deployment

2023-07-07 Thread via GitHub
ashangit commented on code in PR #625: URL: https://github.com/apache/flink-kubernetes-operator/pull/625#discussion_r125636 ## flink-kubernetes-operator/src/test/java/org/apache/flink/kubernetes/operator/utils/FlinkUtilsTest.java: ## @@ -86,6 +89,43 @@ public void

[GitHub] [flink] AlexYinHan commented on a diff in pull request #22890: [FLINK-32072][checkpoint] Create and wire FileMergingSnapshotManager with TaskManagerServices

2023-07-07 Thread via GitHub
AlexYinHan commented on code in PR #22890: URL: https://github.com/apache/flink/pull/22890#discussion_r1255575331 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointStorageWorkerView.java: ## @@ -75,4 +77,14 @@ CheckpointStreamFactory

[jira] [Commented] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-07 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740961#comment-17740961 ] Martijn Visser commented on FLINK-32563: I think the ticket naming is slightly incorrect, since

[GitHub] [flink] snuyanzin commented on pull request #22834: [FLINK-32260][table] Add built-in ARRAY_SLICE function.

2023-07-07 Thread via GitHub
snuyanzin commented on PR #22834: URL: https://github.com/apache/flink/pull/22834#issuecomment-1625142400 Thanks for addressing comments >it's ok to rebase? yes, please rebase and let's be sure that all the tests are passing I can not find any more things, looks ok for me

[GitHub] [flink] XComp commented on a diff in pull request #22919: [FLINK-31837][runtime] Makes LeaderElectionDriver instantiation happen lazily

2023-07-07 Thread via GitHub
XComp commented on code in PR #22919: URL: https://github.com/apache/flink/pull/22919#discussion_r121339 ## flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/AbstractHaServices.java: ## @@ -119,23 +112,23 @@ public LeaderRetrievalService

[jira] [Updated] (FLINK-32020) Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2023-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32020: --- Labels: pull-request-available (was: ) > Enable Dynamic Partition Discovery by Default in

[GitHub] [flink-connector-kafka] loserwang1024 opened a new pull request, #40: [FLINK-32020] Enable Dynamic Partition Discovery by Default in Kafka Source based on FLIP-288

2023-07-07 Thread via GitHub
loserwang1024 opened a new pull request, #40: URL: https://github.com/apache/flink-connector-kafka/pull/40 ### What is the purpose of the change As described in

[jira] [Updated] (FLINK-32556) Renames contenderID into componentId

2023-07-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32556: --- Labels: pull-request-available (was: ) > Renames contenderID into componentId >

[GitHub] [flink] XComp commented on pull request #22967: [FLINK-32556][runtime] Renames contenderID into componentId

2023-07-07 Thread via GitHub
XComp commented on PR #22967: URL: https://github.com/apache/flink/pull/22967#issuecomment-1625136109 I went over the logs containing the term `contender` to address your comment. Additionally, the branch got rebased to most-recent `master` after FLINK-32381 got merged. -- This is an

[jira] [Resolved] (FLINK-32381) Replaces error handling functionality with onError method in MultipleComponentLeaderElectionDriver.Listener interface

2023-07-07 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32381. --- Fix Version/s: 1.18.0 Resolution: Fixed master:

[GitHub] [flink] XComp merged pull request #22935: [FLINK-32381][runtime] Replaces FatalErrorHandler by Listener.onError

2023-07-07 Thread via GitHub
XComp merged PR #22935: URL: https://github.com/apache/flink/pull/22935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin commented on a diff in pull request #22682: [FLINK-29319][table] Upgrade Calcite to 1.32.0

2023-07-07 Thread via GitHub
snuyanzin commented on code in PR #22682: URL: https://github.com/apache/flink/pull/22682#discussion_r1255522106 ## flink-table/flink-table-planner/pom.xml: ## @@ -300,7 +300,9 @@ under the License.

  1   2   >