[jira] [Updated] (FLINK-32627) Add support for dynamic time window function

2023-07-18 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-32627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 张一帆 updated FLINK-32627: Description: When using windows for calculations, when the logic is frequently modified and adjusted, the entire

[GitHub] [flink] wanglijie95 commented on pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-18 Thread via GitHub
wanglijie95 commented on PR #22966: URL: https://github.com/apache/flink/pull/22966#issuecomment-1641453889 Thanks for comments @lsyldliu. I 've addressed all comments, PTAL. Besides, I add probe side push down logic in the last commit, to get better performance -- This is an automated

[GitHub] [flink] Sxnan commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

2023-07-18 Thread via GitHub
Sxnan commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1266320558 ## flink-core/src/main/java/org/apache/flink/api/common/functions/Function.java: ## @@ -27,4 +28,16 @@ * method) interfaces that can be implemented via Java 8 lambdas.

[GitHub] [flink] Sxnan commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

2023-07-18 Thread via GitHub
Sxnan commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1266328740 ## flink-core/src/main/java/org/apache/flink/api/dag/Transformation.java: ## @@ -637,4 +637,16 @@ public int hashCode() { result = 31 * result + (int)

[GitHub] [flink] huacaicai closed pull request #19492: Update TimeWindow.java

2023-07-18 Thread via GitHub
huacaicai closed pull request #19492: Update TimeWindow.java URL: https://github.com/apache/flink/pull/19492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [flink] hackergin commented on pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-18 Thread via GitHub
hackergin commented on PR #22937: URL: https://github.com/apache/flink/pull/22937#issuecomment-1641407812 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #23020: [hotfix][streaming] Reactive sanity check for windowOperator's mergeable state.

2023-07-18 Thread via GitHub
flinkbot commented on PR #23020: URL: https://github.com/apache/flink/pull/23020#issuecomment-1641392989 ## CI report: * f6a7895163f3ad8d7663f3039156ccc26115743f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] leonardBang commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-18 Thread via GitHub
leonardBang commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1267521123 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/AbstractCatalogStore.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [flink] reswqa opened a new pull request, #23020: [hotfix][streaming] Reactive sanity check for windowOperator's mergeable state.

2023-07-18 Thread via GitHub
reswqa opened a new pull request, #23020: URL: https://github.com/apache/flink/pull/23020 ## What is the purpose of the change *Reactive sanity check for windowOperator's mergeable state.* ## Brief change log - *Remove todo in windowOperator.* - *Reactive

[GitHub] [flink] reswqa commented on pull request #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
reswqa commented on PR #23016: URL: https://github.com/apache/flink/pull/23016#issuecomment-1641387919 Thank you for your confirmation. I manually picked up the master(via https://github.com/apache/flink/commit/543091275f1f5cce00302053c1216907608cd40b). -- This is an automated message

[GitHub] [flink] reswqa commented on a diff in pull request #23000: [FLINK-32594][runtime] Use blocking ResultPartitionType if operator only outputs records on EOF

2023-07-18 Thread via GitHub
reswqa commented on code in PR #23000: URL: https://github.com/apache/flink/pull/23000#discussion_r1267509042 ## flink-core/src/main/java/org/apache/flink/api/common/functions/Function.java: ## @@ -27,4 +28,16 @@ * method) interfaces that can be implemented via Java 8

[GitHub] [flink] flinkbot commented on pull request #23019: [FLINK-32617][jdbc-driver] Return true or false for most methods in database meta data

2023-07-18 Thread via GitHub
flinkbot commented on PR #23019: URL: https://github.com/apache/flink/pull/23019#issuecomment-1641383493 ## CI report: * 06c0d147b7e96ebc4135d2206c89f1c2b36cea9d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32617) FlinkResultSetMetaData throw exception for most methods

2023-07-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32617: --- Labels: pull-request-available (was: ) > FlinkResultSetMetaData throw exception for most

[GitHub] [flink] FangYongs opened a new pull request, #23019: [FLINK-32617][jdbc-driver] Return true or false for most methods in database meta data

2023-07-18 Thread via GitHub
FangYongs opened a new pull request, #23019: URL: https://github.com/apache/flink/pull/23019 ## What is the purpose of the change This pr aims to return true or false in FlinkDatabaseMetaData instead of throwing exception. ## Brief change log - Return true or false

[GitHub] [flink] akinfelami commented on pull request #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
akinfelami commented on PR #23016: URL: https://github.com/apache/flink/pull/23016#issuecomment-1641375538 Looks like it does - https://github.com/apache/flink/blob/master/docs/content/docs/dev/table/tableApi.md#from -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] reswqa commented on pull request #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
reswqa commented on PR #23016: URL: https://github.com/apache/flink/pull/23016#issuecomment-1641371355 I wonder if this fix also apply to `master` branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] reswqa merged pull request #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
reswqa merged PR #23016: URL: https://github.com/apache/flink/pull/23016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #23018: Revert "[FLINK-28046][connectors] Mark SourceFunction interface as @deprecated"

2023-07-18 Thread via GitHub
flinkbot commented on PR #23018: URL: https://github.com/apache/flink/pull/23018#issuecomment-1641338245 ## CI report: * 1b03c7d5dd2d4f877f509ff2cdbc030ed641a3cf UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2023-07-18 Thread James Johnston (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744423#comment-17744423 ] James Johnston commented on FLINK-30483: I have some high-level questions/concerns about whether

[GitHub] [flink] james-johnston-thumbtack commented on pull request #21594: [FLINK-30483] [Formats] [Avro] Add avro format support for TIMESTAMP_LTZ

2023-07-18 Thread via GitHub
james-johnston-thumbtack commented on PR #21594: URL: https://github.com/apache/flink/pull/21594#issuecomment-1641319553 **I am uncertain if this is the right mapping.** In fact, my sense is that Flink has this completely backwards, even for the existing `TIMESTAMP WITHOUT TIME ZONE`

[GitHub] [flink] ruanhang1993 opened a new pull request, #23018: Revert "[FLINK-28046][connectors] Mark SourceFunction interface as @deprecated"

2023-07-18 Thread via GitHub
ruanhang1993 opened a new pull request, #23018: URL: https://github.com/apache/flink/pull/23018 ## What is the purpose of the change This PR reverts commit 07bf511a32b525f94d258daec347cf777b31bebb, which marks SourceFunction interface as @deprecated. We need to resolve all

[jira] (FLINK-32573) Translate "Custom Serialization for Managed State" page into Chinese

2023-07-18 Thread Guangdong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32573 ] Guangdong Liu deleted comment on FLINK-32573: --- was (Author: JIRAUSER298508): Assign to me. > Translate "Custom Serialization for Managed State" page into Chinese >

[GitHub] [flink] liugddx commented on a diff in pull request #22999: [FLINK-32573][docs-content.zh] Translate "Custom Serialization for Ma…

2023-07-18 Thread via GitHub
liugddx commented on code in PR #22999: URL: https://github.com/apache/flink/pull/22999#discussion_r1267487850 ## docs/content.zh/docs/dev/datastream/fault-tolerance/serialization/custom_serialization.md: ## @@ -24,26 +24,22 @@ specific language governing permissions and

[GitHub] [flink] leonardBang commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-18 Thread via GitHub
leonardBang commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1267487839 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/AbstractCatalogStore.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Hebella commented on pull request #23011: [WIP]Flush module

2023-07-18 Thread via GitHub
Hebella commented on PR #23011: URL: https://github.com/apache/flink/pull/23011#issuecomment-1641315316 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-29039) RowData produced by LineBytesInputFormat is reused, but DeserializationSchemaAdapter#Reader only shallow copies produced data, thus result will always be the last row

2023-07-18 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744421#comment-17744421 ] Hang Ruan commented on FLINK-29039: --- Hi, all. I would like to help. Please assign this issue to me.

[jira] [Commented] (FLINK-32573) Translate "Custom Serialization for Managed State" page into Chinese

2023-07-18 Thread Guangdong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744420#comment-17744420 ] Guangdong Liu commented on FLINK-32573: --- Assign to me. > Translate "Custom Serialization for

[jira] [Commented] (FLINK-32457) update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify the limitation

2023-07-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744419#comment-17744419 ] lincoln lee commented on FLINK-32457: - fixed in release-1.17:

[jira] [Closed] (FLINK-32457) update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify the limitation

2023-07-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32457. --- Assignee: lincoln lee > update current documentation of JSON_OBJECTAGG/JSON_ARRAYAGG to clarify the

[GitHub] [flink] leonardBang commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-18 Thread via GitHub
leonardBang commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1267484748 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] [flink] lincoln-lil merged pull request #22976: [FLINK-32457][table-planner] Add test cases of unsupported usage for JSON_OBJECTAGG & JSON_ARRAYAGG and also update docs

2023-07-18 Thread via GitHub
lincoln-lil merged PR #22976: URL: https://github.com/apache/flink/pull/22976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-32591) Update document of Kafka Source: Enable Dynamic Partition Discovery by Default in Kafka Source

2023-07-18 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang closed FLINK-32591. - > Update document of Kafka Source: Enable Dynamic Partition Discovery by > Default in Kafka Source

[jira] [Closed] (FLINK-31953) FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2023-07-18 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang closed FLINK-31953. - > FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source >

[GitHub] [flink-web] lindong28 commented on pull request #664: Allow content to expire

2023-07-18 Thread via GitHub
lindong28 commented on PR #664: URL: https://github.com/apache/flink-web/pull/664#issuecomment-1641293672 @MartijnVisser Do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-32619) ConfigOptions to support fallback configuration

2023-07-18 Thread Matt Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744413#comment-17744413 ] Matt Wang commented on FLINK-32619: --- hi, i saw flink  has supported this, like this: {code:java} /**

[jira] [Commented] (FLINK-32576) ProducerMergedPartitionFileIndex supports spilling to file

2023-07-18 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744412#comment-17744412 ] Weijie Guo commented on FLINK-32576: master(1.18) via 1786e2ddfd1a1df5e907f5719138f63e819cb1a3. >

[jira] [Closed] (FLINK-32576) ProducerMergedPartitionFileIndex supports spilling to file

2023-07-18 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-32576. -- Fix Version/s: 1.18.0 Resolution: Done > ProducerMergedPartitionFileIndex supports spilling to

[GitHub] [flink] reswqa merged pull request #22982: [FLINK-32576][network] ProducerMergedPartitionFileIndex supports caching regions and spilling regions to file

2023-07-18 Thread via GitHub
reswqa merged PR #22982: URL: https://github.com/apache/flink/pull/22982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] 1996fanrui commented on pull request #22854: [FLINK-32137] Added filtering of lambdas when building the flame graph

2023-07-18 Thread via GitHub
1996fanrui commented on PR #22854: URL: https://github.com/apache/flink/pull/22854#issuecomment-1641284334 > @1996fanrui added, please check that I did it correctly) not sure what do you mean by pasting a picture though. Hi @netvl , all pictures that you provided are removed the

[GitHub] [flink] flinkbot commented on pull request #23017: [hotfix] Fix the TieredStorageConsumerClientTest

2023-07-18 Thread via GitHub
flinkbot commented on PR #23017: URL: https://github.com/apache/flink/pull/23017#issuecomment-1641275292 ## CI report: * a545c46fe6fe2e1a8a21873b6712495efed97a4d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744409#comment-17744409 ] Wencong Liu commented on FLINK-32624: - Thanks [~lincoln.86xy] .  I've opened a hot fix. [[hotfix]

[GitHub] [flink] WencongLiu opened a new pull request, #23017: [hotfix] Fix the TieredStorageConsumerClientTest

2023-07-18 Thread via GitHub
WencongLiu opened a new pull request, #23017: URL: https://github.com/apache/flink/pull/23017 ## What is the purpose of the change *Fix the TieredStorageConsumerClientTest.* ## Does this pull request potentially affect one of the following parts: - Dependencies

[GitHub] [flink-web] lindong28 opened a new pull request, #664: Allow content to expire

2023-07-18 Thread via GitHub
lindong28 opened a new pull request, #664: URL: https://github.com/apache/flink-web/pull/664 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Commented] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744403#comment-17744403 ] Wencong Liu commented on FLINK-32624: - Sorry for the late reply, I'll take a look. [~lincoln.86xy] 

[jira] [Commented] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744399#comment-17744399 ] lincoln lee commented on FLINK-32624: - [~Wencong Liu] would you help to take a look? >

[jira] [Commented] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744396#comment-17744396 ] lincoln lee commented on FLINK-32624: - another failure:

[jira] [Created] (FLINK-32627) Add support for dynamic time window function

2023-07-18 Thread Jira
张一帆 created FLINK-32627: --- Summary: Add support for dynamic time window function Key: FLINK-32627 URL: https://issues.apache.org/jira/browse/FLINK-32627 Project: Flink Issue Type: Improvement

[GitHub] [flink] netvl commented on pull request #22854: [FLINK-32137] Added filtering of lambdas when building the flame graph

2023-07-18 Thread via GitHub
netvl commented on PR #22854: URL: https://github.com/apache/flink/pull/22854#issuecomment-1641023885 @1996fanrui added, please check that I did it correctly) not sure what do you mean by pasting a picture though. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] netvl commented on a diff in pull request #22854: [FLINK-32137] Added filtering of lambdas when building the flame graph

2023-07-18 Thread via GitHub
netvl commented on code in PR #22854: URL: https://github.com/apache/flink/pull/22854#discussion_r1267324770 ## flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/VertexFlameGraphFactoryTest.java: ## @@ -0,0 +1,80 @@ +package

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-07-18 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1267232851 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java: ## @@ -359,11 +357,12 @@ IncrementalRemoteKeyedStateHandle

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-07-18 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1267223874 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/DiscardRecordedStateObject.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22744: [FLINK-29802][state] Changelog supports native savepoint

2023-07-18 Thread via GitHub
rkhachatryan commented on code in PR #22744: URL: https://github.com/apache/flink/pull/22744#discussion_r1267187486 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -375,6 +378,51 @@

[GitHub] [flink] flinkbot commented on pull request #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
flinkbot commented on PR #23016: URL: https://github.com/apache/flink/pull/23016#issuecomment-1640562198 ## CI report: * 5c00999cacf0390275f1360d3487fb4424e11c01 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32626) Distinguish non-existent job from non-existent savepoint in Get Savepoint REST API

2023-07-18 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Cawley-Edwards updated FLINK-32626: -- Description: The current `GET /jobs/:jobid/savepoints/:triggerid` API

[GitHub] [flink] akinfelami opened a new pull request, #23016: [hotfix][docs] fix typo in table api operations

2023-07-18 Thread via GitHub
akinfelami opened a new pull request, #23016: URL: https://github.com/apache/flink/pull/23016 scan is misspelled as scane ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public

[GitHub] [flink-kubernetes-operator] seano288 commented on pull request #525: [FLINK-27491] Support env replacement in flink-kubernetes-operator

2023-07-18 Thread via GitHub
seano288 commented on PR #525: URL: https://github.com/apache/flink-kubernetes-operator/pull/525#issuecomment-1640549588 I was wondering if this is still in the works? If not, what is the recommended way to get variable replacement in the job args? -- This is an automated message from

[jira] [Updated] (FLINK-32626) Distinguish non-existent job from non-existent savepoint in Get Savepoint REST API

2023-07-18 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Cawley-Edwards updated FLINK-32626: -- Summary: Distinguish non-existent job from non-existent savepoint in Get

[jira] [Updated] (FLINK-32626) Distinguish non-existent job from non-existent savepoint in Get Savepoint REST API

2023-07-18 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Cawley-Edwards updated FLINK-32626: -- Description: The current `GET /jobs/:jobid/savepoints/:triggerid` API

[jira] [Created] (FLINK-32626) Get Savepoint REST API doesn't distinguish non-existent job from non-existent savepoint

2023-07-18 Thread Austin Cawley-Edwards (Jira)
Austin Cawley-Edwards created FLINK-32626: - Summary: Get Savepoint REST API doesn't distinguish non-existent job from non-existent savepoint Key: FLINK-32626 URL:

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-18 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1266970200 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/runtimefilter/RuntimeFilterOperatorGenerator.java: ## @@ -0,0 +1,153 @@ +/*

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #631: [FLINK-32606] Support FlinkVersion and Namespace level default configs

2023-07-18 Thread via GitHub
gyfora commented on PR #631: URL: https://github.com/apache/flink-kubernetes-operator/pull/631#issuecomment-1640476470 Thank you @mxm, I will add some user facing docs before merging this tomorrow -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] lsyldliu commented on a diff in pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

2023-07-18 Thread via GitHub
lsyldliu commented on code in PR #23012: URL: https://github.com/apache/flink/pull/23012#discussion_r1266950178 ## flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java: ## @@ -230,7 +230,7 @@ public void

[GitHub] [flink] wuchong commented on a diff in pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

2023-07-18 Thread via GitHub
wuchong commented on code in PR #23012: URL: https://github.com/apache/flink/pull/23012#discussion_r1266939659 ## flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/canal/CanalJsonDeserializationSchema.java: ## @@ -230,7 +230,7 @@ public void

[jira] [Updated] (FLINK-10212) REST API for listing all the available save points

2023-07-18 Thread Austin Cawley-Edwards (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Austin Cawley-Edwards updated FLINK-10212: -- Description: *Background* I'm one of the authors of the open-source Flink

[GitHub] [flink] flinkbot commented on pull request #23015: [FLINK-32625][tests] MiniClusterTestEnvironment supports customized MiniClusterResourceConfiguration

2023-07-18 Thread via GitHub
flinkbot commented on PR #23015: URL: https://github.com/apache/flink/pull/23015#issuecomment-1640388727 ## CI report: * e2939f518323ffdf2448a8eda7dd2a3e267081db UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32625) MiniClusterTestEnvironment supports customized MiniClusterResourceConfiguration

2023-07-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32625: --- Labels: pull-request-available (was: ) > MiniClusterTestEnvironment supports customized >

[GitHub] [flink] tisonkun opened a new pull request, #23015: [FLINK-32625][tests] MiniClusterTestEnvironment supports customized MiniClusterResourceConfiguration

2023-07-18 Thread via GitHub
tisonkun opened a new pull request, #23015: URL: https://github.com/apache/flink/pull/23015 ## What is the purpose of the change Connector tests can need to set a different configuration from the default one. ## Brief change log TRIVIAL. See the diff. ##

[jira] [Created] (FLINK-32625) MiniClusterTestEnvironment supports customized MiniClusterResourceConfiguration

2023-07-18 Thread Zili Chen (Jira)
Zili Chen created FLINK-32625: - Summary: MiniClusterTestEnvironment supports customized MiniClusterResourceConfiguration Key: FLINK-32625 URL: https://issues.apache.org/jira/browse/FLINK-32625 Project:

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
morhidi commented on PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#issuecomment-1640359880 Thanks Gyula, this is a significant improvement on the autoscaler! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot commented on pull request #23014: [FLINK-32623] Return correct vertex resource lower bound

2023-07-18 Thread via GitHub
flinkbot commented on PR #23014: URL: https://github.com/apache/flink/pull/23014#issuecomment-1640322851 ## CI report: * fa7a8595e89fa788c38b5b4fbfe501806766512c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32624: Description:

[jira] [Updated] (FLINK-32623) Rest api doesn't return minimum resource requirements correctly

2023-07-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32623: --- Labels: pull-request-available (was: ) > Rest api doesn't return minimum resource

[jira] [Created] (FLINK-32624) TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI

2023-07-18 Thread lincoln lee (Jira)
lincoln lee created FLINK-32624: --- Summary: TieredStorageConsumerClientTest.testGetNextBufferFromRemoteTier failed on CI Key: FLINK-32624 URL: https://issues.apache.org/jira/browse/FLINK-32624 Project:

[GitHub] [flink] gyfora opened a new pull request, #23014: [FLINK-32623] Return correct vertex resource lower bound

2023-07-18 Thread via GitHub
gyfora opened a new pull request, #23014: URL: https://github.com/apache/flink/pull/23014 ## What is the purpose of the change Return actual minimum parallelism bound instead of hardcoded 1. ## Verifying this change Extended existing unit tests to cover this case.

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
gyfora commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266831389 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -230,28 +222,24 @@

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
gyfora commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266830357 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java: ## @@ -93,4 +95,10 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
gyfora commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266829192 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java: ## @@ -93,4 +95,10 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
gyfora commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266827140 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@

[GitHub] [flink] wuchong commented on pull request #23012: [FLINK-32610][json] JSON format supports nested type projection pushdown

2023-07-18 Thread via GitHub
wuchong commented on PR #23012: URL: https://github.com/apache/flink/pull/23012#issuecomment-1640293239 The build is failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
gyfora commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266825520 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -69,19 +72,45 @@

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23001: [FLINK-32578][table-planner] Fix wrong plan which group by window time columns on a proctime window operator may result hang fo

2023-07-18 Thread via GitHub
lincoln-lil commented on code in PR #23001: URL: https://github.com/apache/flink/pull/23001#discussion_r1266723489 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/WindowUtil.scala: ## @@ -343,4 +369,59 @@ object WindowUtil { }

[jira] [Created] (FLINK-32623) Rest api doesn't return minimum resource requirements correctly

2023-07-18 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-32623: -- Summary: Rest api doesn't return minimum resource requirements correctly Key: FLINK-32623 URL: https://issues.apache.org/jira/browse/FLINK-32623 Project: Flink

[GitHub] [flink-kubernetes-operator] 1996fanrui commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
1996fanrui commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266798865 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java: ## @@ -69,19 +72,45

[GitHub] [flink] luoyuxia commented on a diff in pull request #22939: [FLINK-32474][table] Support time travel in table planner

2023-07-18 Thread via GitHub
luoyuxia commented on code in PR #22939: URL: https://github.com/apache/flink/pull/22939#discussion_r1266727886 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SnapshotScope.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-32571) Prebuild HBase testing docker image

2023-07-18 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744225#comment-17744225 ] Ferenc Csaky commented on FLINK-32571: -- After HBase 3.x is released and requires Hadoop 3.x it can

[GitHub] [flink-kubernetes-operator] 1996fanrui commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
1996fanrui commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266709748 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java: ## @@ -230,28 +222,24

[jira] [Closed] (FLINK-32613) Disable check for single rowtime attribute for sinks

2023-07-18 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-32613. Fix Version/s: 1.18.0 Resolution: Fixed Fixed in master:

[jira] [Commented] (FLINK-32622) Do not add mini-batch assigner operator if it is useless

2023-07-18 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744215#comment-17744215 ] Fang Yong commented on FLINK-32622: --- cc [~libenchao] [~zoudan] > Do not add mini-batch assigner

[jira] [Created] (FLINK-32622) Do not add mini-batch assigner operator if it is useless

2023-07-18 Thread Fang Yong (Jira)
Fang Yong created FLINK-32622: - Summary: Do not add mini-batch assigner operator if it is useless Key: FLINK-32622 URL: https://issues.apache.org/jira/browse/FLINK-32622 Project: Flink Issue

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #633: [FLINK-32589] Carry over parallelism overrides between spec changes

2023-07-18 Thread via GitHub
mxm commented on code in PR #633: URL: https://github.com/apache/flink-kubernetes-operator/pull/633#discussion_r1266728338 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java: ## @@ -332,29

[jira] [Updated] (FLINK-32621) Add metrics for DataGeneratorSource

2023-07-18 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-32621: --- Description: {{DataGeneratorSource}} use {{GeneratingIteratorSourceReader}} instead of

[jira] [Created] (FLINK-32621) Add metrics for DataGeneratorSource

2023-07-18 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-32621: -- Summary: Add metrics for DataGeneratorSource Key: FLINK-32621 URL: https://issues.apache.org/jira/browse/FLINK-32621 Project: Flink Issue Type: Technical Debt

[GitHub] [flink] flinkbot commented on pull request #23013: [FLINK-32620][sink] Migrate DiscardingSink to sinkv2.

2023-07-18 Thread via GitHub
flinkbot commented on PR #23013: URL: https://github.com/apache/flink/pull/23013#issuecomment-1640170063 ## CI report: * 6dfec2b4bbb4056c12aedc87e720076bd8c227c7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] reswqa commented on a diff in pull request #23013: [FLINK-32620][sink] Migrate DiscardingSink to sinkv2.

2023-07-18 Thread via GitHub
reswqa commented on code in PR #23013: URL: https://github.com/apache/flink/pull/23013#discussion_r1266730543 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/DiscardingSink.java: ## @@ -25,7 +25,9 @@ * A stream sink that ignores all

[GitHub] [flink-connector-hbase] ferenc-csaky closed pull request #13: [hotfix] Refactor to fix HBase E2E test run

2023-07-18 Thread via GitHub
ferenc-csaky closed pull request #13: [hotfix] Refactor to fix HBase E2E test run URL: https://github.com/apache/flink-connector-hbase/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #632: Test improvements

2023-07-18 Thread via GitHub
gyfora commented on PR #632: URL: https://github.com/apache/flink-kubernetes-operator/pull/632#issuecomment-1640159534 Thank you @mxm I will merge this after the namespace/flink version defaults, the test failure can be eliminated more easily afterwards :) -- This is an automated

[jira] [Updated] (FLINK-32620) Migrate DiscardingSink to sinkv2

2023-07-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32620: --- Labels: pull-request-available (was: ) > Migrate DiscardingSink to sinkv2 >

[GitHub] [flink] reswqa opened a new pull request, #23013: [FLINK-32620][sink] Migrate DiscardingSink to sinkv2.

2023-07-18 Thread via GitHub
reswqa opened a new pull request, #23013: URL: https://github.com/apache/flink/pull/23013 ## What is the purpose of the change *Migrate DiscardingSink to sinkv2.* ## Brief change log - *Migrate DiscardingSink to sinkv2.* ## Verifying this change

[GitHub] [flink] lsyldliu commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size befo

2023-07-18 Thread via GitHub
lsyldliu commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1266720189 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/runtimefilter/RuntimeFilterOperatorGenerator.java: ## @@ -0,0 +1,153 @@ +/* +

[jira] [Created] (FLINK-32620) Migrate DiscardingSink to sinkv2

2023-07-18 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-32620: -- Summary: Migrate DiscardingSink to sinkv2 Key: FLINK-32620 URL: https://issues.apache.org/jira/browse/FLINK-32620 Project: Flink Issue Type: Technical Debt

  1   2   >