[GitHub] [flink] lsyldliu commented on a diff in pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #22990: URL: https://github.com/apache/flink/pull/22990#discussion_r1271258887 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/ShuffledHashJoinTest.xml: ## @@ -129,14 +129,13 @@ LogicalProj

[GitHub] [flink] lsyldliu commented on a diff in pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #22990: URL: https://github.com/apache/flink/pull/22990#discussion_r1271258336 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala: ## @@ -45,11 +45,16 @@ import scala.annotati

[GitHub] [flink] LadyForest commented on pull request #23033: [FLINK-32634][table-api] Deprecate StreamRecordTimestamp and ExistingField

2023-07-21 Thread via GitHub
LadyForest commented on PR #23033: URL: https://github.com/apache/flink/pull/23033#issuecomment-1646503474 Hi @JingGe, thanks for your review. Could you help to merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [flink] FangYongs commented on a diff in pull request #23041: [FLINK-32407][table] Notify catalog modification listener for table ddl in CatalogManager

2023-07-21 Thread via GitHub
FangYongs commented on code in PR #23041: URL: https://github.com/apache/flink/pull/23041#discussion_r1271255786 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -806,6 +810,19 @@ public void createTable(

[jira] [Updated] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-07-21 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-31238: --- Attachment: image-2023-07-22-14-19-01-390.png > Use IngestDB to speed up Rocksdb rescaling recovery > -

[jira] [Commented] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-07-21 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745875#comment-17745875 ] Yue Ma commented on FLINK-31238: [~yunta]  ok , sorry for the delay:( > Use IngestDB to

[jira] [Commented] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-07-21 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745874#comment-17745874 ] Yue Ma commented on FLINK-31238: [~pnowojski] Sorry for missing your comment. The newly

[jira] [Updated] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-07-21 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-31238: --- Attachment: image-2023-07-22-14-16-31-856.png > Use IngestDB to speed up Rocksdb rescaling recovery > -

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-21 Thread via GitHub
ruanhang1993 commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271252379 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStoreFactory.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] flinkbot commented on pull request #23046: [FLINK-32287][docs] Add doc for truncate table statement

2023-07-21 Thread via GitHub
flinkbot commented on PR #23046: URL: https://github.com/apache/flink/pull/23046#issuecomment-1646496776 ## CI report: * 707875a1bfbe0561836ca5a7b43bb6eb8058a02e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32287) Add doc for truncate table statement

2023-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32287: --- Labels: pull-request-available (was: ) > Add doc for truncate table statement > ---

[GitHub] [flink] ruanhang1993 commented on pull request #23046: [FLINK-32287][docs] Add doc for truncate table statement

2023-07-21 Thread via GitHub
ruanhang1993 commented on PR #23046: URL: https://github.com/apache/flink/pull/23046#issuecomment-1646495678 @luoyuxia Please take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] ruanhang1993 opened a new pull request, #23046: [FLINK-32287][docs] Add doc for truncate table statement

2023-07-21 Thread via GitHub
ruanhang1993 opened a new pull request, #23046: URL: https://github.com/apache/flink/pull/23046 ## What is the purpose of the change Add doc for truncate table statement ## Brief change log Add doc for truncate table statement ## Verifying this change Th

[jira] [Closed] (FLINK-32491) Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuffle join

2023-07-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-32491. -- Resolution: Done > Introduce RuntimeFilterOperator to support runtime filter which can reduce > the s

[jira] [Commented] (FLINK-32491) Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuffle join

2023-07-21 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745872#comment-17745872 ] Lijie Wang commented on FLINK-32491: Done via master(1.18): 59850a91f96ddb5c58d8554b

[GitHub] [flink] wanglijie95 closed pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuffle jo

2023-07-21 Thread via GitHub
wanglijie95 closed pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuffle join URL: https://github.com/apache/flink/pull/23007 -- This is an automated message from the Apache Git Servic

[GitHub] [flink] wanglijie95 commented on pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuf

2023-07-21 Thread via GitHub
wanglijie95 commented on PR #23007: URL: https://github.com/apache/flink/pull/23007#issuecomment-1646454817 The CI failed because of a known issue [FLINK-32632](https://issues.apache.org/jira/browse/FLINK-32632). All table test cases passed, merged. -- This is an automated message from t

[GitHub] [flink] luoyuxia commented on a diff in pull request #22862: [FLINK-31575][hive] Avoid swapping table-planner-loader and table-pla…

2023-07-21 Thread via GitHub
luoyuxia commented on code in PR #22862: URL: https://github.com/apache/flink/pull/22862#discussion_r1271239389 ## flink-table/flink-table-planner-loader/src/main/java/org/apache/flink/table/planner/loader/PlannerModule.java: ## @@ -150,4 +160,30 @@ public PlannerFactory loadPla

[GitHub] [flink] luoyuxia commented on a diff in pull request #22862: [FLINK-31575][hive] Avoid swapping table-planner-loader and table-pla…

2023-07-21 Thread via GitHub
luoyuxia commented on code in PR #22862: URL: https://github.com/apache/flink/pull/22862#discussion_r1271239371 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/planner/utils/HiveCatalogUtils.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] lsyldliu commented on pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lsyldliu commented on PR #23035: URL: https://github.com/apache/flink/pull/23035#issuecomment-1646387239 @lincoln-lil Thanks for your review, I've updated it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink] lsyldliu commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1271222506 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkCalcMergeRule.scala: ## @@ -65,6 +66,23 @@ class FlinkCalcMerg

[GitHub] [flink] lsyldliu commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r127178 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/spec/DynamicTableSourceSpec.java: ## @@ -71,12 +72,25 @@ public Dynamic

[GitHub] [flink] lsyldliu commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1271222052 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuser.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [flink] lsyldliu commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1271221828 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuser.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Softwar

[jira] [Closed] (FLINK-32644) ts

2023-07-21 Thread weitianpei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weitianpei closed FLINK-32644. -- Resolution: Fixed > ts > -- > > Key: FLINK-32644 > URL: https://issues

[jira] [Created] (FLINK-32644) ts

2023-07-21 Thread weitianpei (Jira)
weitianpei created FLINK-32644: -- Summary: ts Key: FLINK-32644 URL: https://issues.apache.org/jira/browse/FLINK-32644 Project: Flink Issue Type: Bug Reporter: weitianpei -- This

[jira] [Assigned] (FLINK-31843) Select slots from SlotPool#freeSlots in bulk

2023-07-21 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-31843: -- Assignee: Weihua Hu > Select slots from SlotPool#freeSlots in bulk >

[jira] [Created] (FLINK-32643) Introduce off-heap shared state cache across stateful operators in TM

2023-07-21 Thread Fang Yong (Jira)
Fang Yong created FLINK-32643: - Summary: Introduce off-heap shared state cache across stateful operators in TM Key: FLINK-32643 URL: https://issues.apache.org/jira/browse/FLINK-32643 Project: Flink

[GitHub] [flink] flinkbot commented on pull request #23045: [FLINK-32628] Fix build_wheels_on_macos fails on AZP

2023-07-21 Thread via GitHub
flinkbot commented on PR #23045: URL: https://github.com/apache/flink/pull/23045#issuecomment-1646217924 ## CI report: * ea7622199e09500984ab8d9721501c08cb8433c6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] snuyanzin opened a new pull request, #23045: [FLINK-32628] Fix build_wheels_on_macos fails on AZP

2023-07-21 Thread via GitHub
snuyanzin opened a new pull request, #23045: URL: https://github.com/apache/flink/pull/23045 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] snuyanzin closed pull request #23044: [FLINK-32628] Fix build_wheels_on_macos fails on AZP

2023-07-21 Thread via GitHub
snuyanzin closed pull request #23044: [FLINK-32628] Fix build_wheels_on_macos fails on AZP URL: https://github.com/apache/flink/pull/23044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [flink] flinkbot commented on pull request #23044: [FLINK-32628] Reproduce

2023-07-21 Thread via GitHub
flinkbot commented on PR #23044: URL: https://github.com/apache/flink/pull/23044#issuecomment-1646162400 ## CI report: * 99976d7392fb41da7d74fa41bdbb18fe2c057429 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32628) build_wheels_on_macos fails on AZP

2023-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32628: --- Labels: pull-request-available (was: ) > build_wheels_on_macos fails on AZP > -

[GitHub] [flink] snuyanzin opened a new pull request, #23044: [FLINK-32628] Reproduce

2023-07-21 Thread via GitHub
snuyanzin opened a new pull request, #23044: URL: https://github.com/apache/flink/pull/23044 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[GitHub] [flink] flinkbot commented on pull request #23043: [python][docs] Fix broken syntax in Flink Table API query example

2023-07-21 Thread via GitHub
flinkbot commented on PR #23043: URL: https://github.com/apache/flink/pull/23043#issuecomment-1646093828 ## CI report: * 8c0660c70ccd22ccde0eb0934cddb45328b456f3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] deepyaman opened a new pull request, #23043: Fix broken syntax in Flink Table API query example

2023-07-21 Thread via GitHub
deepyaman opened a new pull request, #23043: URL: https://github.com/apache/flink/pull/23043 ## What is the purpose of the change The existing code results in an error: ``` Traceback (most recent call last): File "/tmp/ibis-testing-data/example.py", line 16, in

[GitHub] [flink] XComp commented on pull request #23042: [DRAFT][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-21 Thread via GitHub
XComp commented on PR #23042: URL: https://github.com/apache/flink/pull/23042#issuecomment-1646006632 Initially, I tried to download the debian package. But there, I ran into problems with the corresponding dependencies (I installed the required `containerd` dependency. But this one require

[GitHub] [flink] PatrickRen commented on a diff in pull request #23041: [FLINK-32407][table] Notify catalog modification listener for table ddl in CatalogManager

2023-07-21 Thread via GitHub
PatrickRen commented on code in PR #23041: URL: https://github.com/apache/flink/pull/23041#discussion_r1270896040 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java: ## @@ -806,6 +810,19 @@ public void createTable(

[jira] [Commented] (FLINK-32592) (Stream)ExEnv#initializeContextEnvironment isn't thread-safe

2023-07-21 Thread Fabio Wanner (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745668#comment-17745668 ] Fabio Wanner commented on FLINK-32592: -- We did a few hundred deployments and did no

[jira] [Resolved] (FLINK-32406) Notify catalog listener for database events

2023-07-21 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-32406. --- Resolution: Fixed > Notify catalog listener for database events > --

[jira] [Commented] (FLINK-32406) Notify catalog listener for database events

2023-07-21 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745666#comment-17745666 ] Qingsheng Ren commented on FLINK-32406: --- Merged to master: 151566d21e7051820182c13

[GitHub] [flink] PatrickRen merged pull request #23039: [FLINK-32406][table] Notify catalog modification listener for database ddl in CatalogManager

2023-07-21 Thread via GitHub
PatrickRen merged PR #23039: URL: https://github.com/apache/flink/pull/23039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] PatrickRen commented on pull request #23039: [FLINK-32406][table] Notify catalog modification listener for database ddl in CatalogManager

2023-07-21 Thread via GitHub
PatrickRen commented on PR #23039: URL: https://github.com/apache/flink/pull/23039#issuecomment-1645977239 The CI failed because of a known issue FLINK-32632. All table test cases passed so I'll give a green light -- This is an automated message from the Apache Git Service. To respond to

[jira] [Created] (FLINK-32642) The upsert mode doesn't work for the compound keys

2023-07-21 Thread jasonliangyc (Jira)
jasonliangyc created FLINK-32642: Summary: The upsert mode doesn't work for the compound keys Key: FLINK-32642 URL: https://issues.apache.org/jira/browse/FLINK-32642 Project: Flink Issue Type

[GitHub] [flink] wuchong commented on a diff in pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-21 Thread via GitHub
wuchong commented on code in PR #22990: URL: https://github.com/apache/flink/pull/22990#discussion_r1267669642 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/agg/batch/AggCodeGenHelper.scala: ## @@ -45,11 +45,16 @@ import scala.annotatio

[jira] [Comment Edited] (FLINK-32592) (Stream)ExEnv#initializeContextEnvironment isn't thread-safe

2023-07-21 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17744529#comment-17744529 ] Chesnay Schepler edited comment on FLINK-32592 at 7/21/23 4:05 PM: ---

[jira] [Closed] (FLINK-32592) (Stream)ExEnv#initializeContextEnvironment isn't thread-safe

2023-07-21 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-32592. Fix Version/s: 1.18.0 1.16.3 1.17.2 Resolution

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745645#comment-17745645 ] Matthias Pohl commented on FLINK-32632: --- Looks like relying on binaries for {{cri-

[GitHub] [flink] leonardBang commented on pull request #23039: [FLINK-32406][table] Notify catalog modification listener for database ddl in CatalogManager

2023-07-21 Thread via GitHub
leonardBang commented on PR #23039: URL: https://github.com/apache/flink/pull/23039#issuecomment-1645752251 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [flink] wanglijie95 commented on pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size before shuf

2023-07-21 Thread via GitHub
wanglijie95 commented on PR #23007: URL: https://github.com/apache/flink/pull/23007#issuecomment-1645742390 Thanks for review @lsyldliu . I 've addressed or reply all comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [flink] RyanSkraba commented on a diff in pull request #23006: [FLINK-32560][Scala] Deprecate all Scala API

2023-07-21 Thread via GitHub
RyanSkraba commented on code in PR #23006: URL: https://github.com/apache/flink/pull/23006#discussion_r1270790972 ## flink-scala/src/main/java/org/apache/flink/api/scala/typeutils/ScalaOptionSerializerSnapshot.java: ## @@ -24,7 +24,17 @@ import scala.Option; -/** A {@link T

[GitHub] [flink] FangYongs commented on pull request #23041: [FLINK-32407][table] Notify catalog modification listener for table ddl in CatalogManager

2023-07-21 Thread via GitHub
FangYongs commented on PR #23041: URL: https://github.com/apache/flink/pull/23041#issuecomment-1645711363 Hi @PatrickRen @leonardBang Please help to review this PR when you're free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [flink] hackergin commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-21 Thread via GitHub
hackergin commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1270754419 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogStoreFactory.java: ## @@ -108,7 +108,7 @@ public interface CatalogStoreFactor

[GitHub] [flink] ruanhang1993 commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-21 Thread via GitHub
ruanhang1993 commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1270736940 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogStoreFactory.java: ## @@ -108,7 +108,7 @@ public interface CatalogStoreFac

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270678144 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/runtimefilter/RuntimeFilterCodeGenerator.scala: ## @@ -0,0 +1,126 @@ +/* +

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270665499 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/GlobalRuntimeFilterBuilderOperator.java: ## @@ -0,0 +1,93 @@

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270663166 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/GlobalRuntimeFilterBuilderOperator.java: ## @@ -0,0 +1,93 @@

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270663166 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/GlobalRuntimeFilterBuilderOperator.java: ## @@ -0,0 +1,93 @@

[jira] [Assigned] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32632: - Assignee: Matthias Pohl > Run Kubernetes test is unstable on AZP >

[GitHub] [flink] JingGe commented on a diff in pull request #23033: [FLINK-32634][table-api] Deprecate StreamRecordTimestamp and ExistingField

2023-07-21 Thread via GitHub
JingGe commented on code in PR #23033: URL: https://github.com/apache/flink/pull/23033#discussion_r1270643521 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/sources/tsextractors/ExistingField.java: ## @@ -42,7 +42,12 @@ /** * Converts an existing {@l

[jira] [Commented] (FLINK-29459) Sink v2 has bugs in supporting legacy v1 implementations with global committer

2023-07-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745579#comment-17745579 ] Martijn Visser commented on FLINK-29459: [~gaoyunhaii] Should we restart the dis

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745574#comment-17745574 ] Matthias Pohl commented on FLINK-32632: --- It might be that it's caused by a Go-Lang

[GitHub] [flink] flinkbot commented on pull request #23042: [DRAFT][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-21 Thread via GitHub
flinkbot commented on PR #23042: URL: https://github.com/apache/flink/pull/23042#issuecomment-1645517942 ## CI report: * 4db2f3a771d63866314928fe5cc9da8635e4b5eb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32632: --- Labels: pull-request-available test-stability (was: test-stability) > Run Kubernetes test i

[GitHub] [flink] XComp opened a new pull request, #23042: [DRAFT][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-21 Thread via GitHub
XComp opened a new pull request, #23042: URL: https://github.com/apache/flink/pull/23042 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on e

[jira] [Commented] (FLINK-32641) json format supports pojo type

2023-07-21 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745572#comment-17745572 ] Martijn Visser commented on FLINK-32641: [~jackylau] Can you be a little more de

[GitHub] [flink] flinkbot commented on pull request #23041: [FLINK-32407][table] Notify catalog modification listener for table ddl in CatalogManager

2023-07-21 Thread via GitHub
flinkbot commented on PR #23041: URL: https://github.com/apache/flink/pull/23041#issuecomment-1645494845 ## CI report: * a1806d05012b40d65d0b2deb3ee836ce614ae7da UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32407) Notify catalog listener for table events

2023-07-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32407: --- Labels: pull-request-available (was: ) > Notify catalog listener for table events > ---

[GitHub] [flink] FangYongs opened a new pull request, #23041: [FLINK-32407][table] Notify catalog modification listener for table ddl in CatalogManager

2023-07-21 Thread via GitHub
FangYongs opened a new pull request, #23041: URL: https://github.com/apache/flink/pull/23041 ## What is the purpose of the change This PR aims to create event for table ddl and notify catalog modification listener in CatalogManager ## Brief change log - Create event for ta

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745565#comment-17745565 ] Matthias Pohl commented on FLINK-32632: --- There is an issue raised in the minikube

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745560#comment-17745560 ] Matthias Pohl commented on FLINK-32632: --- Ok, the issue is also appearing in 1.17:

[jira] [Created] (FLINK-32641) json format supports pojo type

2023-07-21 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-32641: - Summary: json format supports pojo type Key: FLINK-32641 URL: https://issues.apache.org/jira/browse/FLINK-32641 Project: Flink Issue Type: Improvement Co

[GitHub] [flink] wanglijie95 closed pull request #23040: try fix e2e_1

2023-07-21 Thread via GitHub
wanglijie95 closed pull request #23040: try fix e2e_1 URL: https://github.com/apache/flink/pull/23040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: is

[jira] [Resolved] (FLINK-32474) Support time travel in table planner

2023-07-21 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32474. -- Fix Version/s: 1.18.0 Resolution: Fixed master: 410b52a35a1941a6f80c9158bd3ecd439524c3f1 > Su

[jira] [Assigned] (FLINK-32287) Add doc for truncate table statement

2023-07-21 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia reassigned FLINK-32287: Assignee: Hang Ruan > Add doc for truncate table statement >

[GitHub] [flink] luoyuxia merged pull request #22939: [FLINK-32474][table] Support time travel in table planner

2023-07-21 Thread via GitHub
luoyuxia merged PR #22939: URL: https://github.com/apache/flink/pull/22939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] hackergin commented on pull request #22939: [FLINK-32474][table] Support time travel in table planner

2023-07-21 Thread via GitHub
hackergin commented on PR #22939: URL: https://github.com/apache/flink/pull/22939#issuecomment-1645359943 @luoyuxia Thanks for your review. The test completed, and failed since [FLINK-32632](https://issues.apache.org/jira/browse/FLINK-32632) -- This is an automated message from the Apach

[jira] [Commented] (FLINK-32287) Add doc for truncate table statement

2023-07-21 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745524#comment-17745524 ] Hang Ruan commented on FLINK-32287: --- I would like to help. Please assign this to me. T

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745522#comment-17745522 ] Matthias Pohl commented on FLINK-32632: --- Thanks for the hint. I assumed the watchd

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745520#comment-17745520 ] Sergey Nuyanzin commented on FLINK-32632: - [~mapohl] that's a bit strange behavi

[GitHub] [flink] flinkbot commented on pull request #23040: try fix e2e_1

2023-07-21 Thread via GitHub
flinkbot commented on PR #23040: URL: https://github.com/apache/flink/pull/23040#issuecomment-1645320754 ## CI report: * 4bc6f51a0e495e24879ca6966cb3cbeb5de7f0bc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-32632) Run Kubernetes test is unstable on AZP

2023-07-21 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745519#comment-17745519 ] Matthias Pohl commented on FLINK-32632: --- [~Sergey Nuyanzin] where did you find the

[GitHub] [flink] wanglijie95 opened a new pull request, #23040: try fix e2e_1

2023-07-21 Thread via GitHub
wanglijie95 opened a new pull request, #23040: URL: https://github.com/apache/flink/pull/23040 ## What is the purpose of the change try to fix [FLINK-32632](https://issues.apache.org/jira/browse/FLINK-32632). I guess it fails because the kubectl version is not compatible with the minikub

[jira] [Commented] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745496#comment-17745496 ] Maximilian Michels commented on FLINK-28046: Are there really any major feat

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lincoln-lil commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1270412921 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuser.java: ## @@ -0,0 +1,296 @@ +/* + * Licensed to the Apache Soft

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lincoln-lil commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1270410338 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkCalcMergeRule.scala: ## @@ -65,6 +66,23 @@ class FlinkCalcM

[GitHub] [flink] luoyuxia commented on pull request #22939: [FLINK-32474][table] Support time travel in table planner

2023-07-21 Thread via GitHub
luoyuxia commented on PR #22939: URL: https://github.com/apache/flink/pull/22939#issuecomment-1645227430 But I think it may well fail since [FLINK-32632](https://issues.apache.org/jira/browse/FLINK-32632), anyway, ping me after test complelte -- This is an automated message from the Apac

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270407081 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/util/RuntimeFilterUtils.java: ## @@ -0,0 +1,53 @@ +/* + * Li

[GitHub] [flink] wanglijie95 commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size b

2023-07-21 Thread via GitHub
wanglijie95 commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270404663 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/LocalRuntimeFilterBuilderOperator.java: ## @@ -0,0 +1,96 @@

[jira] [Comment Edited] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745490#comment-17745490 ] Alexander Fedulov edited comment on FLINK-28046 at 7/21/23 8:33 AM: --

[jira] [Comment Edited] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745490#comment-17745490 ] Alexander Fedulov edited comment on FLINK-28046 at 7/21/23 8:32 AM: --

[jira] [Comment Edited] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745490#comment-17745490 ] Alexander Fedulov edited comment on FLINK-28046 at 7/21/23 8:32 AM: --

[jira] [Commented] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745490#comment-17745490 ] Alexander Fedulov commented on FLINK-28046: --- This is how the subject of the or

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22975: [FLINK-31643][network] Introduce the configurations for tiered storage

2023-07-21 Thread via GitHub
TanYuxin-tyx commented on code in PR #22975: URL: https://github.com/apache/flink/pull/22975#discussion_r1270396604 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/GateBuffersSpecTest.java: ## @@ -143,17 +144,25 @@ void testCalculationWithC

[jira] [Comment Edited] (FLINK-28046) Annotate SourceFunction as deprecated

2023-07-21 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745490#comment-17745490 ] Alexander Fedulov edited comment on FLINK-28046 at 7/21/23 8:31 AM: --

[GitHub] [flink] huwh commented on pull request #22861: [FLINK-32387][runtime] InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

2023-07-21 Thread via GitHub
huwh commented on PR #22861: URL: https://github.com/apache/flink/pull/22861#issuecomment-1645183189 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23035: [FLINK-32608][table-planner] Support scan reusing with projection pushdown

2023-07-21 Thread via GitHub
lincoln-lil commented on code in PR #23035: URL: https://github.com/apache/flink/pull/23035#discussion_r1270274880 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/SourceAbilitySpec.java: ## @@ -58,6 +58,14 @@ public interface

[GitHub] [flink] lsyldliu commented on a diff in pull request #23007: [FLINK-32491][table-runtime] Introduce RuntimeFilterOperator to support runtime filter which can reduce the shuffle data size befo

2023-07-21 Thread via GitHub
lsyldliu commented on code in PR #23007: URL: https://github.com/apache/flink/pull/23007#discussion_r1270276722 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/runtimefilter/util/RuntimeFilterUtils.java: ## @@ -0,0 +1,53 @@ +/* + * Licen

[jira] [Commented] (FLINK-32638) CI build failed because e2e_1_ci throw error Bash exited with code '1'

2023-07-21 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745473#comment-17745473 ] Yunhong Zheng commented on FLINK-32638: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] WencongLiu commented on pull request #22975: [FLINK-31643][network] Introduce the configurations for tiered storage

2023-07-21 Thread via GitHub
WencongLiu commented on PR #22975: URL: https://github.com/apache/flink/pull/22975#issuecomment-1645155920 Thanks for the review 😄 @TanYuxin-tyx @reswqa . Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   >