[GitHub] [flink] ping-cai commented on a diff in pull request #22999: [FLINK-32573][docs-content.zh] Translate "Custom Serialization for Ma…

2023-07-22 Thread via GitHub
ping-cai commented on code in PR #22999: URL: https://github.com/apache/flink/pull/22999#discussion_r1271393189 ## docs/content.zh/docs/dev/datastream/fault-tolerance/serialization/custom_serialization.md: ## @@ -24,26 +24,22 @@ specific language governing permissions and limita

[jira] [Closed] (FLINK-32608) Improve source reusing with projection push down

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32608. --- Fix Version/s: 1.18.0 Resolution: Fixed fixed in master: c0044be734a74353ddb9768f7559aaf27c04

[jira] [Assigned] (FLINK-32608) Improve source reusing with projection push down

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-32608: --- Assignee: dalongliu > Improve source reusing with projection push down > --

[GitHub] [flink] wanglijie95 commented on pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
wanglijie95 commented on PR #22966: URL: https://github.com/apache/flink/pull/22966#issuecomment-1646757595 Thanks for review @lsyldliu @swuferhong ! I'll merge this PR once the CI done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (FLINK-32649) Mismatch label and value for prometheus reporter

2023-07-22 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-32649: -- Description: When runing unit test  'org.apache.flink.metrics.prometheus.PrometheusReporterTest#metric

[jira] [Commented] (FLINK-32458) support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate functions

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746022#comment-17746022 ] lincoln lee commented on FLINK-32458: - fixed in 1.17: f98969beba5b695da7fe06573b98f9

[jira] [Closed] (FLINK-32458) support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate functions

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32458. --- > support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate > functions > --

[jira] [Updated] (FLINK-32456) JSON_OBJECTAGG & JSON_ARRAYAGG cannot be used with other aggregate functions

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32456: Fix Version/s: 1.18.0 1.17.2 > JSON_OBJECTAGG & JSON_ARRAYAGG cannot be used wi

[jira] [Closed] (FLINK-32456) JSON_OBJECTAGG & JSON_ARRAYAGG cannot be used with other aggregate functions

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32456. --- Resolution: Fixed > JSON_OBJECTAGG & JSON_ARRAYAGG cannot be used with other aggregate functions > -

[jira] [Updated] (FLINK-32458) support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate functions

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32458: Fix Version/s: 1.17.2 > support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate

[GitHub] [flink] lincoln-lil merged pull request #23037: [FLINK-32456][table-planner] Support JSON_OBJECTAGG & JSON_ARRAYAGG use with other aggregate functions

2023-07-22 Thread via GitHub
lincoln-lil merged PR #23037: URL: https://github.com/apache/flink/pull/23037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271379545 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/RuntimeFilterITCase.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271379553 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.xml: ## @@ -0,0 +1,1022 @@

[GitHub] [flink] flinkbot commented on pull request #23053: [FLINK-32649][runtime/Metrics] fix the dimension order for promethues reporter

2023-07-22 Thread via GitHub
flinkbot commented on PR #23053: URL: https://github.com/apache/flink/pull/23053#issuecomment-1646740779 ## CI report: * d054a53fbb18cf068cc3dd79e1aba9ef500d5d6b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32649) Mismatch label and value for prometheus reporter

2023-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32649: --- Labels: pull-request-available (was: ) > Mismatch label and value for prometheus reporter >

[GitHub] [flink] chenyuzhi459 opened a new pull request, #23053: [FLINK-32649][runtime/Metrics] fix the dimension order for promethues reporter

2023-07-22 Thread via GitHub
chenyuzhi459 opened a new pull request, #23053: URL: https://github.com/apache/flink/pull/23053 ## What is the purpose of the change Fix promethues reporter mismatch dimension key&value, with different order of keys in variables as input. ## Brief change log

[jira] [Updated] (FLINK-32649) Mismatch label and value for prometheus reporter

2023-07-22 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chenyuzhi updated FLINK-32649: -- Component/s: Runtime / Metrics > Mismatch label and value for prometheus reporter > --

[jira] [Created] (FLINK-32649) Mismatch label and value for prometheus reporter

2023-07-22 Thread chenyuzhi (Jira)
chenyuzhi created FLINK-32649: - Summary: Mismatch label and value for prometheus reporter Key: FLINK-32649 URL: https://issues.apache.org/jira/browse/FLINK-32649 Project: Flink Issue Type: Bug

[GitHub] [flink] lsyldliu commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
lsyldliu commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271370331 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/RuntimeFilterITCase.java: ## @@ -0,0 +1,213 @@ +/* + * Licensed to th

[GitHub] [flink] flinkbot commented on pull request #23052: Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3

2023-07-22 Thread via GitHub
flinkbot commented on PR #23052: URL: https://github.com/apache/flink/pull/23052#issuecomment-1646725502 ## CI report: * e27438e326749973353c7703633a3be5c4058eb9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-26603) [Umbrella] Decouple Hive with Flink planner

2023-07-22 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-26603. -- Resolution: Fixed > [Umbrella] Decouple Hive with Flink planner >

[jira] [Updated] (FLINK-31607) Refactor the logic for HiveExecutableOperation

2023-07-22 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia updated FLINK-31607: - Parent: (was: FLINK-26603) Issue Type: Improvement (was: Sub-task) > Refactor the logic for

[jira] [Resolved] (FLINK-31575) Don't swap table-planner-loader and table-planner to use hive dialect

2023-07-22 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-31575. -- Fix Version/s: 1.18.0 Resolution: Fixed master: c868d2273086ab9c9deafe5936127ce858e2b1cf > Do

[GitHub] [flink] dependabot[bot] opened a new pull request, #23052: Bump org.apache.calcite:calcite-core from 1.16.0 to 1.32.0 in /flink-connectors/flink-sql-connector-hive-3.1.3

2023-07-22 Thread via GitHub
dependabot[bot] opened a new pull request, #23052: URL: https://github.com/apache/flink/pull/23052 Bumps [org.apache.calcite:calcite-core](https://github.com/apache/calcite) from 1.16.0 to 1.32.0. Commits https://github.com/apache/calcite/commit/413eded693a9087402cc1a6eefeca7a2

[GitHub] [flink] lsyldliu commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
lsyldliu commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271369261 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,678 @@ +/* + * Lice

[GitHub] [flink] wanglijie95 commented on pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
wanglijie95 commented on PR #22966: URL: https://github.com/apache/flink/pull/22966#issuecomment-1646717927 @lsyldliu I 've addressed or replied your comments, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271367309 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,678 @@ +/* + * L

[jira] [Closed] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-32646. --- Resolution: Fixed Fixed in master: 17be3716be42cd9dc5986e97ae222971d9d19be7 > The snapshot is null

[GitHub] [flink] lincoln-lil merged pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
lincoln-lil merged PR #23047: URL: https://github.com/apache/flink/pull/23047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] lincoln-lil commented on pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
lincoln-lil commented on PR #23047: URL: https://github.com/apache/flink/pull/23047#issuecomment-1646682203 The failed 'Kubernetes test' is tracked by FLINK-32632. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [flink] snuyanzin commented on a diff in pull request #23042: [FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-22 Thread via GitHub
snuyanzin commented on code in PR #23042: URL: https://github.com/apache/flink/pull/23042#discussion_r1271329473 ## flink-end-to-end-tests/test-scripts/common_kubernetes.sh: ## @@ -57,27 +57,32 @@ function setup_kubernetes_for_linux { # conntrack is required for minikube 1.

[GitHub] [flink] flinkbot commented on pull request #23051: [FLINK-32648][table] Reuse Calcite's `SqlWindowTableFunction`

2023-07-22 Thread via GitHub
flinkbot commented on PR #23051: URL: https://github.com/apache/flink/pull/23051#issuecomment-1646643167 ## CI report: * 210f42cc3ce46e193c9f8f1432e08bb528d38ed3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32648) Reuse Calcite's SqlWindowTableFunction

2023-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32648: --- Labels: pull-request-available (was: ) > Reuse Calcite's SqlWindowTableFunction > -

[GitHub] [flink] snuyanzin opened a new pull request, #23051: [FLINK-32648][table] Reuse Calcite's `SqlWindowTableFunction`

2023-07-22 Thread via GitHub
snuyanzin opened a new pull request, #23051: URL: https://github.com/apache/flink/pull/23051 ## What is the purpose of the change The PR is aiming to reuse Calcite's `SqlWindowTableFunction` for window table functions. One noticeable change is that for `SqlWindowTableFunction` it s

[jira] [Created] (FLINK-32648) Reuse Calcite's SqlWindowTableFunction

2023-07-22 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32648: --- Summary: Reuse Calcite's SqlWindowTableFunction Key: FLINK-32648 URL: https://issues.apache.org/jira/browse/FLINK-32648 Project: Flink Issue Type: Sub-

[GitHub] [flink] lsyldliu commented on pull request #23048: [FLINK-32279][table-runtime] Shuffle HashJoin support spill to disk when enable operator fusion codegen

2023-07-22 Thread via GitHub
lsyldliu commented on PR #23048: URL: https://github.com/apache/flink/pull/23048#issuecomment-1646637984 > Could you rebase this PR? And the compile is failed. done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Updated] (FLINK-30812) YARN with S3 resource storage fails for Hadoop 3.3.2

2023-07-22 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mate Czagany updated FLINK-30812: - Affects Version/s: 1.18.0 > YARN with S3 resource storage fails for Hadoop 3.3.2 > -

[jira] [Updated] (FLINK-30899) FileSystemTableSource with CSV format incorrectly selects fields if filtering for partition

2023-07-22 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mate Czagany updated FLINK-30899: - Affects Version/s: 1.18.0 > FileSystemTableSource with CSV format incorrectly selects fields if

[GitHub] [flink] leonardBang commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
leonardBang commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271318526 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java: ## @@ -196,4 +204,92 @@ public ClassLoader getUserClassLoa

[GitHub] [flink] leonardBang commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
leonardBang commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271315625 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStore.java: ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] leonardBang commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
leonardBang commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271314505 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/session/SessionManagerImpl.java: ## @@ -68,13 +73,16 @@ public class SessionMa

[GitHub] [flink] flinkbot commented on pull request #23050: [BP-1.16][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-22 Thread via GitHub
flinkbot commented on PR #23050: URL: https://github.com/apache/flink/pull/23050#issuecomment-1646622214 ## CI report: * 6bd2c37e8a588ef242c61bf38cc46986a7381195 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] leonardBang commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
leonardBang commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271314112 ## flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/bridge/java/internal/StreamTableEnvironmentImpl.java: ## @@ -115,8 +115,10 @@ pu

[GitHub] [flink] flinkbot commented on pull request #23049: [BP-1.17][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-22 Thread via GitHub
flinkbot commented on PR #23049: URL: https://github.com/apache/flink/pull/23049#issuecomment-1646620730 ## CI report: * f25e403e7fa8fa281d6cfbbdec8057610fbd55e5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] leonardBang commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
leonardBang commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271308957 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/TableEnvironment.java: ## @@ -387,9 +389,22 @@ default Table fromValues(AbstractDataTyp

[GitHub] [flink] XComp commented on pull request #23042: [DRAFT][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-22 Thread via GitHub
XComp commented on PR #23042: URL: https://github.com/apache/flink/pull/23042#issuecomment-1646616566 CI run succeeded with debug output enabled (see [CI run with initialization of 'Run Kubernetes Test'](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=51579&view=logs&

[GitHub] [flink] wuchong commented on pull request #23048: [FLINK-32279][table-runtime] Shuffle HashJoin support spill to disk when enable operator fusion codegen

2023-07-22 Thread via GitHub
wuchong commented on PR #23048: URL: https://github.com/apache/flink/pull/23048#issuecomment-1646614584 Could you rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Closed] (FLINK-32280) HashAgg support operator fusion codegen

2023-07-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-32280. --- Fix Version/s: 1.18.0 Assignee: dalongliu Resolution: Fixed Fixed in master: f500b593911614

[GitHub] [flink] wuchong merged pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-22 Thread via GitHub
wuchong merged PR #22990: URL: https://github.com/apache/flink/pull/22990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[GitHub] [flink] wuchong commented on a diff in pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-22 Thread via GitHub
wuchong commented on code in PR #22990: URL: https://github.com/apache/flink/pull/22990#discussion_r1271311790 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/join/ShuffledHashJoinTest.xml: ## @@ -129,14 +129,13 @@ LogicalProje

[jira] [Assigned] (FLINK-32429) Introduce CatalogStore in CatalogManager to support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-32429: -- Assignee: Feng Jin > Introduce CatalogStore in CatalogManager to support lazy initialization

[jira] [Assigned] (FLINK-32427) FLIP-295: Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-32427: -- Assignee: Feng Jin > FLIP-295: Support lazy initialization of catalogs and persistence of cat

[GitHub] [flink] lsyldliu commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-22 Thread via GitHub
lsyldliu commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1271296553 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,678 @@ +/* + * Lice

[jira] [Created] (FLINK-32647) Support config catalog store in python table environment

2023-07-22 Thread Feng Jin (Jira)
Feng Jin created FLINK-32647: Summary: Support config catalog store in python table environment Key: FLINK-32647 URL: https://issues.apache.org/jira/browse/FLINK-32647 Project: Flink Issue Type:

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's di

2023-07-22 Thread via GitHub
lincoln-lil commented on code in PR #23047: URL: https://github.com/apache/flink/pull/23047#discussion_r1271293985 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalTableSourceScan.scala: ## @@ -51,9 +52,21

[GitHub] [flink] lincoln-lil commented on a diff in pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's di

2023-07-22 Thread via GitHub
lincoln-lil commented on code in PR #23047: URL: https://github.com/apache/flink/pull/23047#discussion_r1271293985 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalTableSourceScan.scala: ## @@ -51,9 +52,21

[GitHub] [flink] lsyldliu commented on a diff in pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's diges

2023-07-22 Thread via GitHub
lsyldliu commented on code in PR #23047: URL: https://github.com/apache/flink/pull/23047#discussion_r1271292453 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalTableSourceScan.scala: ## @@ -51,9 +52,21 @@

[GitHub] [flink] flinkbot commented on pull request #23048: [FLINK-32279][table-runtime] Shuffle HashJoin support spill to disk when enable operator fusion codegen

2023-07-22 Thread via GitHub
flinkbot commented on PR #23048: URL: https://github.com/apache/flink/pull/23048#issuecomment-1646576619 ## CI report: * a93b3f84503adfd1a38d85b2adbaf2471c140d7e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] hackergin commented on pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
hackergin commented on PR #23047: URL: https://github.com/apache/flink/pull/23047#issuecomment-1646576159 @lincoln-lil Thanks for the fix pr. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Updated] (FLINK-32279) Shuffle HashJoin support spill to disk when enable operator fusion codegen

2023-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32279: --- Labels: pull-request-available (was: ) > Shuffle HashJoin support spill to disk when enable

[GitHub] [flink] lsyldliu opened a new pull request, #23048: [FLINK-32279][table-runtime] Shuffle HashJoin support spill to disk when enable operator fusion codegen

2023-07-22 Thread via GitHub
lsyldliu opened a new pull request, #23048: URL: https://github.com/apache/flink/pull/23048 ## What is the purpose of the change *For shuffle hash join, we don't support spill to disk currently if operator fusion codegen, so this PR main purpose is to fix the problem.* ## B

[GitHub] [flink] XComp commented on pull request #23042: [DRAFT][FLINK-32632][test] Fixes Minikube/cri-dockerd issue

2023-07-22 Thread via GitHub
XComp commented on PR #23042: URL: https://github.com/apache/flink/pull/23042#issuecomment-1646569547 The fixes worked in [this CI build](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=51570&view=logs&j=bea52777-eaf8-5663-8482-18fbc3630e81&t=43ba8ce7-ebbf-57cd-9163-44

[GitHub] [flink] lincoln-lil commented on pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
lincoln-lil commented on PR #23047: URL: https://github.com/apache/flink/pull/23047#issuecomment-1646568088 @lsyldliu this fix is as we discussed offline, could you help review it? cc @hackergin could you help confirm this when you have time? -- This is an automated message from the Apa

[GitHub] [flink] flinkbot commented on pull request #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
flinkbot commented on PR #23047: URL: https://github.com/apache/flink/pull/23047#issuecomment-1646567030 ## CI report: * b9cb606109b44eafae2f7270577ed02578e9e658 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32646: --- Labels: pull-request-available (was: ) > The snapshot is null in CatalogTable when query sp

[GitHub] [flink] lincoln-lil opened a new pull request, #23047: [FLINK-32646][table-planner] Fix TestTimeTravelCatalog missing snapshot version properties and add version to source table's digest

2023-07-22 Thread via GitHub
lincoln-lil opened a new pull request, #23047: URL: https://github.com/apache/flink/pull/23047 ## What is the purpose of the change The newly added `TestTimeTravelCatalog` didn't save the snapshot timestamp properly(which is used for testing the time travel feature). This is a bugfix pr

[jira] [Commented] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745916#comment-17745916 ] Vijaya Bhaskar V commented on FLINK-32645: -- After disabling batching of the mes

[jira] [Updated] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijaya Bhaskar V updated FLINK-32645: - Description: Found following issue with flink pulsar sink:   Flink pulsar sink is alwa

[jira] [Updated] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijaya Bhaskar V updated FLINK-32645: - Attachment: Screenshot 2023-07-22 at 3.45.21 PM-1.png > Flink pulsar sink is having poor

[jira] [Updated] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijaya Bhaskar V updated FLINK-32645: - Attachment: (was: Screenshot 2023-07-22 at 1.59.42 PM.png) > Flink pulsar sink is ha

[jira] [Updated] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijaya Bhaskar V updated FLINK-32645: - Attachment: Screenshot 2023-07-22 at 3.45.21 PM.png > Flink pulsar sink is having poor p

[jira] [Updated] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vijaya Bhaskar V updated FLINK-32645: - Attachment: Screenshot 2023-07-22 at 2.56.55 PM.png > Flink pulsar sink is having poor p

[jira] [Commented] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745914#comment-17745914 ] Feng Jin commented on FLINK-32646: -- +1,It should be an issue with the implementation of

[GitHub] [flink] hackergin commented on a diff in pull request #23036: [FLINK-32429][table] Support lazy initialization of catalogs and persistence of catalog configurations

2023-07-22 Thread via GitHub
hackergin commented on code in PR #23036: URL: https://github.com/apache/flink/pull/23036#discussion_r1271273694 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FileCatalogStoreFactory.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Soft

[jira] [Commented] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17745899#comment-17745899 ] lincoln lee commented on FLINK-32646: - Had a quick look at the issue, the `TestTimeT

[jira] [Assigned] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-32646: --- Assignee: lincoln lee > The snapshot is null in CatalogTable when query specify the time sn

[jira] [Created] (FLINK-32646) The snapshot is null in CatalogTable when query specify the time snapshot

2023-07-22 Thread dalongliu (Jira)
dalongliu created FLINK-32646: - Summary: The snapshot is null in CatalogTable when query specify the time snapshot Key: FLINK-32646 URL: https://issues.apache.org/jira/browse/FLINK-32646 Project: Flink

[GitHub] [flink] lsyldliu commented on pull request #22990: [FLINK-32280][table-runtime] HashAgg support operator fusion codegen

2023-07-22 Thread via GitHub
lsyldliu commented on PR #22990: URL: https://github.com/apache/flink/pull/22990#issuecomment-1646531006 @wuchong Thanks for reviewing, I've updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (FLINK-32645) Flink pulsar sink is having poor performance

2023-07-22 Thread Vijaya Bhaskar V (Jira)
Vijaya Bhaskar V created FLINK-32645: Summary: Flink pulsar sink is having poor performance Key: FLINK-32645 URL: https://issues.apache.org/jira/browse/FLINK-32645 Project: Flink Issue Ty

[jira] [Reopened] (FLINK-32644) ts

2023-07-22 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reopened FLINK-32644: > ts > -- > > Key: FLINK-32644 > URL: https://issues.apache.org/jira/b

[jira] [Closed] (FLINK-32644) ts

2023-07-22 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu closed FLINK-32644. -- Resolution: Invalid > ts > -- > > Key: FLINK-32644 > URL: https://issu