Re: [PR] [FLINK-XXXX][Connectors/Kafka] Fix memory leak in CachingTopicSelector [flink-connector-kafka]

2023-10-05 Thread via GitHub
boring-cyborg[bot] commented on PR #55: URL: https://github.com/apache/flink-connector-kafka/pull/55#issuecomment-1749891731 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

[PR] [FLINK-XXXX][Connectors/Kafka] Fix memory leak in CachingTopicSelector [flink-connector-kafka]

2023-10-05 Thread via GitHub
qbx2 opened a new pull request, #55: URL: https://github.com/apache/flink-connector-kafka/pull/55 # What is the purpose of the change In the CachingTopicSelector, there is possibility to cause memory leak when the internal logic fails to check cache size by race condition. (https://g

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
srpraneeth commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1348082819 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0,

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
srpraneeth commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1348082441 ## e2e-tests/data/autoscaler.yaml: ## @@ -41,6 +41,13 @@ spec: kubernetes.operator.job.autoscaler.stabilization.interval: "5s" kubernetes.

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
srpraneeth commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1348082332 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0,

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
srpraneeth commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1348079066 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0,

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
srpraneeth commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1348078891 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0,

[jira] [Updated] (FLINK-33020) OpensearchSinkTest.testAtLeastOnceSink timed out

2023-10-05 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-33020: --- Labels: pull-request-available stale-blocker (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-32667) Use standalone store and embedding writer for jobs with no-restart-strategy in session cluster

2023-10-05 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32667: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Commented] (FLINK-31275) Flink supports reporting and storage of source/sink tables relationship

2023-10-05 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772399#comment-17772399 ] Zhenqiu Huang commented on FLINK-31275: --- [~jark] This JIRA is mentioned in FLIP-31

Re: [PR] [FLINK-32353] [hotfix] build against last flink 1.16 and 1.17 and enable archunit only on main flink release [flink-connector-cassandra]

2023-10-05 Thread via GitHub
tzulitai commented on PR #19: URL: https://github.com/apache/flink-connector-cassandra/pull/19#issuecomment-1749692586 Hey @echauchot I'm trying to fix the same thing for the Kafka connector, but I could use your help on understanding the change here. What exactly is the change that

Re: [PR] [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11. [flink]

2023-10-05 Thread via GitHub
yigress commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1749662460 > There is now a patch available here at #23469. will it fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing

2023-10-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772385#comment-17772385 ] Tzu-Li (Gordon) Tai commented on FLINK-33104: - [~echauchot] this seems to be

[jira] [Comment Edited] (FLINK-33104) Nightly run for Flink Kafka connector fails due to architecture tests failing

2023-10-05 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772385#comment-17772385 ] Tzu-Li (Gordon) Tai edited comment on FLINK-33104 at 10/5/23 9:10 PM:

[jira] [Closed] (FLINK-33082) Azure Pipelines 4 is not responding on AZP

2023-10-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33082. --- Resolution: Won't Fix > Azure Pipelines 4 is not responding on AZP > ---

[jira] [Commented] (FLINK-33082) Azure Pipelines 4 is not responding on AZP

2023-10-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772384#comment-17772384 ] Sergey Nuyanzin commented on FLINK-33082: - yes, probably you are right, let's cl

Re: [PR] [FLINK-33159] [build] use variables in pom file for Java and Maven versions [flink]

2023-10-05 Thread via GitHub
ferenc-csaky commented on code in PR #23469: URL: https://github.com/apache/flink/pull/23469#discussion_r1347925648 ## flink-walkthroughs/flink-walkthrough-datastream-java/src/main/resources/archetype-resources/pom.xml: ## @@ -31,7 +31,6 @@ under the License.

[jira] [Updated] (FLINK-33187) Don't record duplicate event if no change

2023-10-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33187: --- Labels: pull-request-available (was: ) > Don't record duplicate event if no change > --

[PR] [FLINK-33187] Don't record duplicate event if no change [flink-kubernetes-operator]

2023-10-05 Thread via GitHub
clarax opened a new pull request, #683: URL: https://github.com/apache/flink-kubernetes-operator/pull/683 ## What is the purpose of the change https://issues.apache.org/jira/browse/FLINK-33187 Suppress duplicate event for scaling report within the interval defined by a new operator

[jira] [Commented] (FLINK-33011) Operator deletes HA data unexpectedly

2023-10-05 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772350#comment-17772350 ] Mason Chen commented on FLINK-33011: [~gyfora] could you backport this to 1.6? We ar

[jira] [Commented] (FLINK-33188) PyFlink MapState with Types.ROW() throws exception

2023-10-05 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772336#comment-17772336 ] Elkhan Dadashov commented on FLINK-33188: - After digging into the flink-python c

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-10-05 Thread via GitHub
flinkbot commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1749244900 ## CI report: * c49cdfbb3c297b076c752605f5ea9052390bafd5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-10-05 Thread via GitHub
gyfora opened a new pull request, #23490: URL: https://github.com/apache/flink/pull/23490 ## What is the purpose of the change Extend the current TypeExtraction + PojoSerializer logic to support handling Java Record classes. The main difference is the extra codepath needed to insta

[jira] [Updated] (FLINK-32380) Support Java records

2023-10-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32380: --- Labels: pull-request-available (was: ) > Support Java records > > >

Re: [PR] [FLINK-31631][FileSystems] Upgrade GCS connector to 2.2.11. [flink]

2023-10-05 Thread via GitHub
cnauroth commented on PR #22281: URL: https://github.com/apache/flink/pull/22281#issuecomment-1749192664 There is now a patch available here at #23469. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-33159] [build] use variables in pom file for Java and Maven versions [flink]

2023-10-05 Thread via GitHub
davidradl commented on PR #23469: URL: https://github.com/apache/flink/pull/23469#issuecomment-1749146500 @ferenc-csaky > In general I believe if we change these props it would worth to explore the whole codebase, so we do not leave any loose ends. I could not see any other places in

Re: [PR] [docs] Update Vendor Solutions [flink]

2023-10-05 Thread via GitHub
JingGe commented on PR #23482: URL: https://github.com/apache/flink/pull/23482#issuecomment-1749134264 @rmoff would you please rebase to solve the conflicts? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (FLINK-33187) Don't record duplicate event if no change

2023-10-05 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated FLINK-33187: Description: Problem: Some events are recorded repeatedly such as ScalingReport when autoscaling i

[jira] [Updated] (FLINK-33187) Don't record duplicate event if no change

2023-10-05 Thread Clara Xiong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Clara Xiong updated FLINK-33187: Summary: Don't record duplicate event if no change (was: Don't send duplicate event to Kafka if n

[jira] [Commented] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2023-10-05 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772246#comment-17772246 ] Jiang Xin commented on FLINK-33186: --- I'll take a look at it. > CheckpointAfterAllTas

Re: [PR] Update local_installation.md [flink]

2023-10-05 Thread via GitHub
arthurlee commented on code in PR #23240: URL: https://github.com/apache/flink/pull/23240#discussion_r1347477555 ## docs/content/docs/try-flink/local_installation.md: ## @@ -46,6 +46,8 @@ to have __Java 11__ installed. To check the Java version installed, type in your $ java -

Re: [PR] [FLINK-33159] [build] use variables in pom file for Java and Maven versions [flink]

2023-10-05 Thread via GitHub
davidradl commented on code in PR #23469: URL: https://github.com/apache/flink/pull/23469#discussion_r1347443841 ## pom.xml: ## @@ -1334,7 +1338,7 @@ under the License. -

Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]

2023-10-05 Thread via GitHub
davidradl commented on code in PR #23488: URL: https://github.com/apache/flink/pull/23488#discussion_r1347416170 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java: ## @@ -167,12 +170,19 @@ public ExecNodeContext

[jira] [Commented] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2023-10-05 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772212#comment-17772212 ] Dong Lin commented on FLINK-33186: -- cc [~xtsong]  > CheckpointAfterAllTasksFinishedIT

[jira] [Assigned] (FLINK-33186) CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished fails on AZP

2023-10-05 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-33186: Assignee: Jiang Xin > CheckpointAfterAllTasksFinishedITCase.testRestoreAfterSomeTasksFinished >

Re: [PR] [FLINK-31631][FileSystems] shade guava in gs-fs filesystem [flink]

2023-10-05 Thread via GitHub
flinkbot commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1748737680 ## CI report: * e8dd8ed7b93dec3e9d810be86dfbbe53345a6c54 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-31631][FileSystems] shade guava in gs-fs filesystem [flink]

2023-10-05 Thread via GitHub
singhravidutt opened a new pull request, #23489: URL: https://github.com/apache/flink/pull/23489 ## What is the purpose of the change Shade the guava version required specifically by google-cloud-storage. ## Brief change log Introduced dependency on guava version(`31.1-jr

[jira] [Updated] (FLINK-28518) Exception: AssertionError: Cannot add expression of different type to set in sub-query with ROW type

2023-10-05 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-28518: --- Fix Version/s: 1.18.0 > Exception: AssertionError: Cannot add expression of different type t

[jira] [Closed] (FLINK-28518) Exception: AssertionError: Cannot add expression of different type to set in sub-query with ROW type

2023-10-05 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-28518. -- Resolution: Fixed > Exception: AssertionError: Cannot add expression of different type to set

[jira] [Commented] (FLINK-28518) Exception: AssertionError: Cannot add expression of different type to set in sub-query with ROW type

2023-10-05 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772179#comment-17772179 ] Robert Metzger commented on FLINK-28518: This is the ticket for the calcite upgr

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772159#comment-17772159 ] Matthias Pohl commented on FLINK-33184: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772158#comment-17772158 ] Matthias Pohl commented on FLINK-28440: --- https://dev.azure.com/apache-flink/apache

[jira] [Comment Edited] (FLINK-33175) Nightly builds from S3 are not available for download, breaking all connector tests

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772150#comment-17772150 ] Matthias Pohl edited comment on FLINK-33175 at 10/5/23 10:03 AM: -

Re: [PR] [FLINK-33046][FLIP-333] Redesign Apache Flink website [flink-web]

2023-10-05 Thread via GitHub
dannycranmer commented on PR #676: URL: https://github.com/apache/flink-web/pull/676#issuecomment-1748518714 > Thank you for addressing my feedback. > > > Would you prefer it in both locations, or just under About? > > This is a very subjective question, there's no right or wron

[jira] [Updated] (FLINK-31278) exit code 137 (i.e. OutOfMemoryError) in core module

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31278: -- Affects Version/s: 1.19.0 > exit code 137 (i.e. OutOfMemoryError) in core module > ---

[jira] [Commented] (FLINK-31278) exit code 137 (i.e. OutOfMemoryError) in core module

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772152#comment-17772152 ] Matthias Pohl commented on FLINK-31278: --- https://dev.azure.com/apache-flink/apache

[jira] [Commented] (FLINK-33175) Nightly builds from S3 are not available for download, breaking all connector tests

2023-10-05 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772150#comment-17772150 ] Matthias Pohl commented on FLINK-33175: --- I looked into the issue with [~Sergey Nuy

[jira] [Created] (FLINK-33195) ElasticSearch Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-10-05 Thread Jing Ge (Jira)
Jing Ge created FLINK-33195: --- Summary: ElasticSearch Connector should directly depend on 3rd-party libs instead of flink-shaded repo Key: FLINK-33195 URL: https://issues.apache.org/jira/browse/FLINK-33195 P

[jira] [Comment Edited] (FLINK-33178) Highly parallel apps suffer from bottleneck in NativePRNG

2023-10-05 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771788#comment-17771788 ] Emre Kartoglu edited comment on FLINK-33178 at 10/5/23 9:06 AM: --

[jira] [Commented] (FLINK-33178) Highly parallel apps suffer from bottleneck in NativePRNG

2023-10-05 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772120#comment-17772120 ] Emre Kartoglu commented on FLINK-33178: --- Adding 1.17.1 to affected versions based

[jira] [Updated] (FLINK-33178) Highly parallel apps suffer from bottleneck in NativePRNG

2023-10-05 Thread Emre Kartoglu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emre Kartoglu updated FLINK-33178: -- Affects Version/s: 1.17.1 > Highly parallel apps suffer from bottleneck in NativePRNG > -

Re: [PR] [FLINK-33095] Job jar issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR. [flink]

2023-10-05 Thread via GitHub
surendralilhore commented on code in PR #23428: URL: https://github.com/apache/flink/pull/23428#discussion_r1346953716 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java: ## @@ -242,8 +242,14 @@ private CompletableFuture handleException(

Re: [PR] [FLINK-33095] Job jar issue should be reported as BAD_REQUEST instead of INTERNAL_SERVER_ERROR. [flink]

2023-10-05 Thread via GitHub
surendralilhore commented on code in PR #23428: URL: https://github.com/apache/flink/pull/23428#discussion_r1346953716 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/AbstractHandler.java: ## @@ -242,8 +242,14 @@ private CompletableFuture handleException(

Re: [PR] [FLINK-33046][FLIP-333] Redesign Apache Flink website [flink-web]

2023-10-05 Thread via GitHub
rmetzger commented on PR #676: URL: https://github.com/apache/flink-web/pull/676#issuecomment-1748220121 I am ready to soft-approve this pull request, but would feel more comfortable if another committer would take a look as well, given that this PR is changing the "face" of Flink pretty si

Re: [PR] [FLINK-33046][FLIP-333] Redesign Apache Flink website [flink-web]

2023-10-05 Thread via GitHub
rmetzger commented on PR #676: URL: https://github.com/apache/flink-web/pull/676#issuecomment-1748210083 Thank you for addressing my feedback. > Would you prefer it in both locations, or just under About? This is a very subjective question, there's no right or wrong here. But I