Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
fengjiajie commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1759036712 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-10-12 Thread via GitHub
AlexYinHan opened a new pull request, #23514: URL: https://github.com/apache/flink/pull/23514 ## What is the purpose of the change As one part of FLIP-306, this PR enables file merging in snapshot by implementing the corresponding output&input streams for ```FileMergingSnapsh

[jira] [Updated] (FLINK-32073) Implement file merging in snapshot

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32073: --- Labels: pull-request-available (was: ) > Implement file merging in snapshot > -

[PR] [FLINK-33116][tests] Fix CliClientTest.testCancelExecutionInteractiveMode fails with NPE [flink]

2023-10-12 Thread via GitHub
Jiabao-Sun opened a new pull request, #23515: URL: https://github.com/apache/flink/pull/23515 ## What is the purpose of the change [FLINK-33116][tests] Fix CliClientTest.testCancelExecutionInteractiveMode fails with NPE ```shell Sep 18 02:26:15 02:26:15.743 [ERROR]

[jira] [Updated] (FLINK-33116) CliClientTest.testCancelExecutionInteractiveMode fails with NPE on AZP

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33116: --- Labels: pull-request-available stale-critical test-stability (was: stale-critical test-stab

Re: [PR] [FLINK-33116][tests] Fix CliClientTest.testCancelExecutionInteractiveMode fails with NPE [flink]

2023-10-12 Thread via GitHub
Jiabao-Sun commented on PR #23515: URL: https://github.com/apache/flink/pull/23515#issuecomment-1759051781 Hi @XComp, could you please help review this? Thanks a lot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-32073][checkpoint] Implement file merging in snapshot [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23514: URL: https://github.com/apache/flink/pull/23514#issuecomment-1759052156 ## CI report: * 5e531dee90e96951b572c2e2dddaf7c371b29e5d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33116][tests] Fix CliClientTest.testCancelExecutionInteractiveMode fails with NPE [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23515: URL: https://github.com/apache/flink/pull/23515#issuecomment-1759059406 ## CI report: * acb4dfd1144735ee8d6602d363d71a086f2ac6f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33226][table] Forbid to drop current database [flink]

2023-10-12 Thread via GitHub
ferenc-csaky commented on PR #23501: URL: https://github.com/apache/flink/pull/23501#issuecomment-1759083959 Thank you for you suggestions @fsk119, I incorporated them, pls. take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1356383787 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -124,23 +157,74 @@ private void handleDeploymentFailure(ExecutionVer

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
lincoln-lil commented on code in PR #23478: URL: https://github.com/apache/flink/pull/23478#discussion_r1355984417 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/utils/ScalarOperatorsTestBase.scala: ## @@ -51,6 +53,7 @@ abstract clas

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
lincoln-lil commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1759102773 > @lincoln-lil Thank you for your review. Are the 5 datatypes you mentioned referring to DATE, TIME_WITHOUT_TIME_ZONE, TIMESTAMP_WITHOUT_TIME_ZONE, TIMESTAMP_WITH_TIME_ZONE, and TIMES

[jira] [Created] (FLINK-33250) HBase Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-10-12 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-33250: -- Summary: HBase Connector should directly depend on 3rd-party libs instead of flink-shaded repo Key: FLINK-33250 URL: https://issues.apache.org/jira/browse/FLINK-33250

[jira] [Commented] (FLINK-32896) Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774363#comment-17774363 ] Matthias Pohl commented on FLINK-32896: --- Sure, go ahead. Thanks for picking this u

[jira] [Assigned] (FLINK-32896) Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-32896: - Assignee: ZY tang > Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinter

[jira] [Assigned] (FLINK-33241) Align config option generation documentation for Flink's config documentation

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33241: - Assignee: Junrui Li > Align config option generation documentation for Flink's config d

[PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser opened a new pull request, #27: URL: https://github.com/apache/flink-connector-hbase/pull/27 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[jira] [Updated] (FLINK-33250) HBase Connector should directly depend on 3rd-party libs instead of flink-shaded repo

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33250: --- Labels: pull-request-available (was: ) > HBase Connector should directly depend on 3rd-part

[jira] [Commented] (FLINK-33241) Align config option generation documentation for Flink's config documentation

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774365#comment-17774365 ] Matthias Pohl commented on FLINK-33241: --- I assigned the issue to you. Thanks for y

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1321300535 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -488,6 +488,23 @@ public enum SchedulerType {

Re: [PR] [FLINK-33030][python]Add python 3.11 support [flink]

2023-10-12 Thread via GitHub
HuangXingBo commented on PR #23417: URL: https://github.com/apache/flink/pull/23417#issuecomment-1759117083 Sorry for the late reply. It's been a holiday in China for the past few days. I'll solve the problem of pemja asap. -- This is an automated message from the Apache Git Service. To r

[jira] [Commented] (FLINK-32193) AWS connector removes the dependency on flink-shaded

2023-10-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774368#comment-17774368 ] Yuxin Tan commented on FLINK-32193: --- Duplicated with https://issues.apache.org/jira/br

[jira] [Closed] (FLINK-32193) AWS connector removes the dependency on flink-shaded

2023-10-12 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-32193. - Resolution: Duplicate > AWS connector removes the dependency on flink-shaded > -

[jira] [Closed] (FLINK-21211) Looking for reviews on a framework based on flink-statefun

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-21211. -- Resolution: Invalid > Looking for reviews on a framework based on flink-statefun > --

[jira] [Commented] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774374#comment-17774374 ] Martijn Visser commented on FLINK-33249: [~zhoujira86] This should only be fixed

[jira] [Commented] (FLINK-33235) Quickstart guide for Flink OLAP should support building from master branch

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774375#comment-17774375 ] Martijn Visser commented on FLINK-33235: [~xiangyu0xf] I don't think we should d

[jira] [Commented] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774376#comment-17774376 ] Martijn Visser commented on FLINK-33229: [~lincoln.86xy] Should this ticket not

[jira] [Commented] (FLINK-33224) Flink Batch Job does not complete when using Kafka topics with empty partitions

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774378#comment-17774378 ] Martijn Visser commented on FLINK-33224: [~ekanthi] Can you verify this in a sup

[jira] [Commented] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774379#comment-17774379 ] Martijn Visser commented on FLINK-33213: [~snuyanzin] Any thoughts on this one?

[jira] [Assigned] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33213: -- Assignee: Sergey Paryshev > Flink SQL MinMax aggregations without retract messages wh

[jira] [Updated] (FLINK-33198) Add timestamp with local time zone support in Avro converters

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-33198: --- Fix Version/s: 1.19.0 (was: 1.18.1) > Add timestamp with local time z

[jira] [Commented] (FLINK-33198) Add timestamp with local time zone support in Avro converters

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774380#comment-17774380 ] Martijn Visser commented on FLINK-33198: Changed the fixVersion to 1.19.0 since

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-12 Thread via GitHub
XComp commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1356512684 ## flink-autoscaler/pom.xml: ## @@ -45,6 +45,32 @@ under the License. provided + +org.projectlombok +

[jira] [Commented] (FLINK-33200) ItemAt Expression validation fail in Table API due to type mismatch

2023-10-12 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774387#comment-17774387 ] Timo Walther commented on FLINK-33200: -- We should not use `PlannerTypeInferenceUtil

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
fengjiajie commented on code in PR #23478: URL: https://github.com/apache/flink/pull/23478#discussion_r1356549020 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -488,6 +488,18 @@ object ScalarOperato

[jira] [Updated] (FLINK-33227) Flink SQL cep support 'notFollowedBy' semantics

2023-10-12 Thread xiaoran (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaoran updated FLINK-33227: Summary: Flink SQL cep support 'notFollowedBy' semantics (was: Flink sql cep support 'notFollowedBy' sema

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-12 Thread via GitHub
fengjiajie commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1759267500 @lincoln-lil Hi, I changed back to the previous approach. Please see if this is workable: Keep the 'if' statement to indicate the case of handling TimePoint and TimeString, and cal

[jira] [Commented] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774390#comment-17774390 ] lincoln lee commented on FLINK-33229: - fixed in master: 521e742bfc034d66168e151e15e6

[jira] [Updated] (FLINK-33227) Flink SQL CEP support 'notFollowedBy' semantics

2023-10-12 Thread xiaoran (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiaoran updated FLINK-33227: Summary: Flink SQL CEP support 'notFollowedBy' semantics (was: Flink SQL cep support 'notFollowedBy' sema

[jira] [Closed] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-33229. --- > Moving Java FlinkRecomputeStatisticsProgram from scala package to java package > -

[jira] [Resolved] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-33229. - Assignee: dalongliu Resolution: Fixed > Moving Java FlinkRecomputeStatisticsProgram from s

[jira] [Commented] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774389#comment-17774389 ] lincoln lee commented on FLINK-33229: - [~martijnvisser] thanks for the reminder :) W

[jira] [Commented] (FLINK-33181) Table using `kinesis` connector can not be used for both read & write operations if it's defined with unsupported sink property

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774391#comment-17774391 ] Martijn Visser commented on FLINK-33181: [~danny.cranmer] [~Hong Teoh] Is this o

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356560575 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356563142 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -469,11 +470,13 @@ private void verifyHBaseLo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356560575 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356564633 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

[jira] [Commented] (FLINK-32958) Support VIEW as a source table in CREATE TABLE ... Like statement

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774393#comment-17774393 ] Martijn Visser commented on FLINK-32958: [~fornaix] I can't find the "CREATE TAB

[jira] [Closed] (FLINK-32944) Caused by: org.apache.flink.api.common.InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-32944. -- Resolution: Invalid Closing this ticket due to lack of input for a reproducer > Caused by: or

[jira] [Commented] (FLINK-32943) run batch tasks concurrently, the tasks still in the initialization status

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774396#comment-17774396 ] Martijn Visser commented on FLINK-32943: [~zhuyinjun] Can this ticket be closed?

Re: [PR] [FLINK-33030][python]Add python 3.11 support [flink]

2023-10-12 Thread via GitHub
gaborgsomogyi commented on PR #23417: URL: https://github.com/apache/flink/pull/23417#issuecomment-1759282897 Thanks for the help! Rebased to the latest master + bumped the version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-32871][SQL] Support BuiltInMethod TO_TIMESTAMP with timezone options [flink]

2023-10-12 Thread via GitHub
MartijnVisser commented on PR #23220: URL: https://github.com/apache/flink/pull/23220#issuecomment-1759285878 There is no consensus on this Jira ticket, so closing this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [FLINK-32871][SQL] Support BuiltInMethod TO_TIMESTAMP with timezone options [flink]

2023-10-12 Thread via GitHub
MartijnVisser closed pull request #23220: [FLINK-32871][SQL] Support BuiltInMethod TO_TIMESTAMP with timezone options URL: https://github.com/apache/flink/pull/23220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-32871) Support BuiltInMethod TO_TIMESTAMP with timezone options

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774397#comment-17774397 ] Martijn Visser commented on FLINK-32871: I'm +1 for [~libenchao] his comment: I

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356575876 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/source/HBaseRowDataAsyncLookupFunctionTest.java: ## @@ -74,8 +72,8 @@ publi

[jira] [Commented] (FLINK-33229) Moving Java FlinkRecomputeStatisticsProgram from scala package to java package

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774399#comment-17774399 ] Martijn Visser commented on FLINK-33229: Awesome, thanks :) > Moving Java Flink

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356574049 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

[jira] [Created] (FLINK-33251) SQL Client query execution aborts after a few seconds: ConnectTimeoutException

2023-10-12 Thread Robin Moffatt (Jira)
Robin Moffatt created FLINK-33251: - Summary: SQL Client query execution aborts after a few seconds: ConnectTimeoutException Key: FLINK-33251 URL: https://issues.apache.org/jira/browse/FLINK-33251 Proj

[jira] [Resolved] (FLINK-33247) IllegalArgumentException in NoticeFileChecker

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33247. --- Resolution: Fixed > IllegalArgumentException in NoticeFileChecker >

[jira] [Updated] (FLINK-33251) SQL Client query execution aborts after a few seconds: ConnectTimeoutException

2023-10-12 Thread Robin Moffatt (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Moffatt updated FLINK-33251: -- Environment: Macbook Pro Apple M1 Max {code:java} $ uname -a Darwin asgard08 23.0.0 Darwin

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356589772 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356589772 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSourc

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
echauchot commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1356590600 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -488,6 +488,23 @@ public enum SchedulerType {

[jira] [Assigned] (FLINK-33252) LicenseChecker fails in GHA but succeeds in Azure

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-33252: - Assignee: Matthias Pohl > LicenseChecker fails in GHA but succeeds in Azure > -

[jira] [Created] (FLINK-33252) LicenseChecker fails in GHA but succeeds in Azure

2023-10-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33252: - Summary: LicenseChecker fails in GHA but succeeds in Azure Key: FLINK-33252 URL: https://issues.apache.org/jira/browse/FLINK-33252 Project: Flink Issue Typ

[PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]

2023-10-12 Thread via GitHub
ParyshevSergey opened a new pull request, #23516: URL: https://github.com/apache/flink/pull/23516 ## What is the purpose of the change Flink SqlMonotonicity doesn't calculated for Calc/FlinkLogicalCalc/StreamPhysicalCalc that leads of absent correct monotonicity for projects. GroupAg

[jira] [Updated] (FLINK-33213) Flink SQL MinMax aggregations without retract messages when `where` condition exist

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33213: --- Labels: pull-request-available (was: ) > Flink SQL MinMax aggregations without retract mess

Re: [PR] [FLINK-33213][table] Flink SQL calculate SqlMonotonicity for Calc. [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23516: URL: https://github.com/apache/flink/pull/23516#issuecomment-1759324534 ## CI report: * 4f5e9add87fdec27397a9415040ead85902d6f3d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356603415 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
ferenc-csaky commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356603415 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -384,11 +383,13 @@ public void testTableSo

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-12 Thread via GitHub
mxm commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1356605280 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-12 Thread via GitHub
mxm commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1356604652 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356612136 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink.typ

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
snuyanzin commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356612136 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink.typ

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-12 Thread via GitHub
1996fanrui commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1356620090 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-32650][protobuf]Added the ability to split flink-protobuf code… [flink]

2023-10-12 Thread via GitHub
maosuhan commented on code in PR #23162: URL: https://github.com/apache/flink/pull/23162#discussion_r1356624269 ## flink-formats/flink-protobuf/src/test/java/org/apache/flink/formats/protobuf/BigProtoBufCodeSpiltterTest.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache So

[PR] [FLINK-33249][table-planner] comment should be parsed by StringLitera… [flink]

2023-10-12 Thread via GitHub
zhougit86 opened a new pull request, #23517: URL: https://github.com/apache/flink/pull/23517 …l() instead of SqlCharStringLiteral to avoid parsing failure ## What is the purpose of the change make flink parser able to parse calcite unparsed ASCII comment ## Brief chan

[jira] [Updated] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33249: --- Labels: pull-request-available (was: ) > comment should be parsed by StringLiteral() instea

[jira] [Commented] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774426#comment-17774426 ] xiaogang zhou commented on FLINK-33249: --- [~martijnvisser]  Hi Martin, I am not sur

Re: [PR] [FLINK-33248] [table] Fix error message for CURRENT_WATERMARK without arguments [flink]

2023-10-12 Thread via GitHub
dawidwys merged PR #23512: URL: https://github.com/apache/flink/pull/23512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Closed] (FLINK-33248) Calling CURRENT_WATERMARK without parameters gives IndexOutOfBoundsException

2023-10-12 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33248. Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master: 35a2257af5d0cf9e671460b977

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-12 Thread via GitHub
1996fanrui commented on code in PR #22985: URL: https://github.com/apache/flink/pull/22985#discussion_r1356642732 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -488,6 +488,23 @@ public enum SchedulerType {

[jira] [Updated] (FLINK-27075) Migrate CI from Azure to Github Actions

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-27075: -- Description: Some rules for working on the GHA migration collaboratively: * We should create

Re: [PR] [FLINK-33249][table-planner] comment should be parsed by StringLitera… [flink]

2023-10-12 Thread via GitHub
flinkbot commented on PR #23517: URL: https://github.com/apache/flink/pull/23517#issuecomment-1759381531 ## CI report: * 08cb809219d1734d3c12c55a5d9421c558c48ba7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27075) Migrate CI from Azure to Github Actions

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-27075: -- Description: Some rules for working on the GHA migration collaboratively: * We should create

[jira] [Commented] (FLINK-33251) SQL Client query execution aborts after a few seconds: ConnectTimeoutException

2023-10-12 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774431#comment-17774431 ] Sergey Nuyanzin commented on FLINK-33251: - I followed the steps on linux (Fedora

[jira] [Created] (FLINK-33253) test_pyflink.sh fails: zip is missing in Docker image

2023-10-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33253: - Summary: test_pyflink.sh fails: zip is missing in Docker image Key: FLINK-33253 URL: https://issues.apache.org/jira/browse/FLINK-33253 Project: Flink Issue

[jira] [Created] (FLINK-33254) Improve speed of compile step

2023-10-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33254: - Summary: Improve speed of compile step Key: FLINK-33254 URL: https://issues.apache.org/jira/browse/FLINK-33254 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-33255) Validate argument count during type inference

2023-10-12 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-33255: Summary: Validate argument count during type inference Key: FLINK-33255 URL: https://issues.apache.org/jira/browse/FLINK-33255 Project: Flink Issue T

[jira] [Created] (FLINK-33256) Fatal error due to dubious ownership in docs-404-check

2023-10-12 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-33256: - Summary: Fatal error due to dubious ownership in docs-404-check Key: FLINK-33256 URL: https://issues.apache.org/jira/browse/FLINK-33256 Project: Flink Issu

[jira] [Commented] (FLINK-33256) Fatal error due to dubious ownership in docs-404-check

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774438#comment-17774438 ] Matthias Pohl commented on FLINK-33256: --- There's a issue for that in GitHub action

[jira] [Closed] (FLINK-32746) Using ZGC in JDK17 to solve long time class unloading STW

2023-10-12 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng closed FLINK-32746. Resolution: Done JDK17 is already supported in https://issues.apache.org/jira/browse/FLINK-15736,

[jira] [Commented] (FLINK-33257) Support filter pushdown in MongoDB connector

2023-10-12 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774440#comment-17774440 ] Jiabao Sun commented on FLINK-33257: Hi [~Leonard], could you help assign this ticke

[jira] [Created] (FLINK-33257) Support filter pushdown in MongoDB connector

2023-10-12 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33257: -- Summary: Support filter pushdown in MongoDB connector Key: FLINK-33257 URL: https://issues.apache.org/jira/browse/FLINK-33257 Project: Flink Issue Type: Improvem

[jira] [Updated] (FLINK-33257) Support filter pushdown in MongoDB connector

2023-10-12 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33257: --- Fix Version/s: mongodb-1.1.0 > Support filter pushdown in MongoDB connector > --

[jira] [Commented] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1777#comment-1777 ] Martijn Visser commented on FLINK-33249: I would wait until the Calcite communit

Re: [PR] [FLINK-33249][table-planner] comment should be parsed by StringLitera… [flink]

2023-10-12 Thread via GitHub
MartijnVisser commented on PR #23517: URL: https://github.com/apache/flink/pull/23517#issuecomment-1759416685 Let's wait with merging / reviewing until the related Calcite ticket has a resolution -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (FLINK-33249) comment should be parsed by StringLiteral() instead of SqlCharStringLiteral to avoid parsing failure

2023-10-12 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17774447#comment-17774447 ] Martijn Visser commented on FLINK-33249: [~zhoujira86] The PR wouldn't get merge

[jira] [Resolved] (FLINK-33253) test_pyflink.sh fails: zip is missing in Docker image

2023-10-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-33253. --- Resolution: Fixed Previously, it failed to install the {{.conda}} directory from the {{${TE

Re: [PR] [FLINK-33250][Connector/HBase] Remove dependency on `flink-shaded` [flink-connector-hbase]

2023-10-12 Thread via GitHub
MartijnVisser commented on code in PR #27: URL: https://github.com/apache/flink-connector-hbase/pull/27#discussion_r1356673406 ## flink-connector-hbase-2.2/src/test/java/org/apache/flink/connector/hbase2/HBaseConnectorITCase.java: ## @@ -40,18 +40,15 @@ import org.apache.flink

  1   2   3   >