Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-22 Thread via GitHub
MartijnVisser commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368202283 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.ap

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368195931 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,71 @@

[jira] [Commented] (FLINK-27020) use hive dialect in SqlClient would thrown an error based on 1.15 version

2023-10-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778537#comment-17778537 ] Martijn Visser commented on FLINK-27020: [~xinchen147] It's because in 1.15 we'v

[jira] [Commented] (FLINK-33154) flink on k8s,An error occurred during consuming rocketmq

2023-10-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778536#comment-17778536 ] Martijn Visser commented on FLINK-33154: [~monody] But that connector isn't owne

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368187442 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -117,53 +119,53 @@ public static boolean cr

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
1996fanrui commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368185629 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,7

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368183966 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/EventUtils.java: ## @@ -117,53 +119,53 @@ public static boolean cr

[jira] [Comment Edited] (FLINK-33238) Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410

2023-10-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1704#comment-1704 ] Martijn Visser edited comment on FLINK-33238 at 10/23/23 6:29 AM:

[jira] [Closed] (FLINK-33238) Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410

2023-10-22 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-33238. -- Resolution: Fixed > Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410 > --

Re: [PR] [BP 1.18][FLINK-33238][Formats/Avro] Upgrade used AVRO version to 1.11.3 [flink]

2023-10-22 Thread via GitHub
MartijnVisser merged PR #23559: URL: https://github.com/apache/flink/pull/23559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-32896][Runtime/Coordination] Incorrect `Map.computeIfAbsent(..., ...::new)` usage which misinterprets key as initial capacity [flink]

2023-10-22 Thread via GitHub
XComp commented on PR #23518: URL: https://github.com/apache/flink/pull/23518#issuecomment-1774505796 Could squash the commits and rebase the branch to most-recent `master`? We don't want have merge commits cluttering the git history. The Flink CI bot is known to have issues with forc

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368147631 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,71 @@

Re: [PR] [FLINK-33090][checkpointing] CheckpointsCleaner clean individual chec… [flink]

2023-10-22 Thread via GitHub
yigress commented on PR #23425: URL: https://github.com/apache/flink/pull/23425#issuecomment-1774447810 @pnowojski could you review again? appreciate every constructive review you gave! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis [flink]

2023-10-22 Thread via GitHub
flinkbot commented on PR #23564: URL: https://github.com/apache/flink/pull/23564#issuecomment-1774393422 ## CI report: * bff9234113ad13e9d535bef3761b0a61a168f956 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis [flink]

2023-10-22 Thread via GitHub
Jiabao-Sun commented on PR #23564: URL: https://github.com/apache/flink/pull/23564#issuecomment-1774391325 Hi @WencongLiu, @fsk119. Could you help review it when you have time? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (FLINK-32661) OperationRelatedITCase.testOperationRelatedApis fails on AZP

2023-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32661: --- Labels: auto-deprioritized-critical pull-request-available test-stability (was: auto-deprio

[PR] [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis [flink]

2023-10-22 Thread via GitHub
Jiabao-Sun opened a new pull request, #23564: URL: https://github.com/apache/flink/pull/23564 ## What is the purpose of the change [FLINK-32661][sql-gateway] Fix unstable OperationRelatedITCase.testOperationRelatedApis ## Brief change log The operation execution

[jira] [Commented] (FLINK-33112) Support placement constraint

2023-10-22 Thread Junfan Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778513#comment-17778513 ] Junfan Zhang commented on FLINK-33112: -- [https://hadoop.apache.org/docs/stable/hado

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-22 Thread via GitHub
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368093090 ## docs/content.zh/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) Review Comment: Since flink-tab

[jira] [Commented] (FLINK-33154) flink on k8s,An error occurred during consuming rocketmq

2023-10-22 Thread Monody (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778512#comment-17778512 ] Monody commented on FLINK-33154: [~martijnvisser]  hi~ Thank you for paying attention to

[jira] [Updated] (FLINK-33316) Avoid unnecessary heavy getStreamOperatorFactory

2023-10-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33316: Fix Version/s: 1.17.2 1.18.1 > Avoid unnecessary heavy getStreamOperatorFactory > -

[jira] [Commented] (FLINK-33316) Avoid unnecessary heavy getStreamOperatorFactory

2023-10-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778510#comment-17778510 ] Rui Fan commented on FLINK-33316: - The change is subtle, so I push this commit directly.

[jira] [Commented] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-10-22 Thread Dan Zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778505#comment-17778505 ] Dan Zou commented on FLINK-33313: - [~libenchao] OK, I will do it. > RexNodeExtractor fa

Re: [PR] [FLINK-31180] [Test Infrastructure] Fail early when installing minikube and check whether we can retry [flink]

2023-10-22 Thread via GitHub
victor9309 commented on PR #23497: URL: https://github.com/apache/flink/pull/23497#issuecomment-1774339850 Thanks @XComp for the review. Thank you very much for your suggestion, The current PR code has been submitted on PR #23528, merged together. -- This is an automated message from the

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-22 Thread via GitHub
1996fanrui commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368068093 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,7

Re: [PR] [FLINK-32107] [Tests] Kubernetes test failed because ofunable to establish ssl connection to github on AZP [flink]

2023-10-22 Thread via GitHub
victor9309 commented on PR #23528: URL: https://github.com/apache/flink/pull/23528#issuecomment-1774335390 Test crictl ![image](https://github.com/apache/flink/assets/18453843/f00b8709-a679-4a75-99ae-038b5c7321c7) -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [FLINK-32107] [Tests] Kubernetes test failed because ofunable to establish ssl connection to github on AZP [flink]

2023-10-22 Thread via GitHub
victor9309 commented on PR #23528: URL: https://github.com/apache/flink/pull/23528#issuecomment-1774332772 Thanks @XComp for the review. Current PR and PR https://github.com/apache/flink/pull/23497 combine submission codes;Use RETRY_COUNT and RETRY_BACKOFF_TIME variables -- This is an a

Re: [PR] [FLINK-32309][sql-gateway] Use independent resource manager for table environment [flink]

2023-10-22 Thread via GitHub
FangYongs commented on PR #22768: URL: https://github.com/apache/flink/pull/22768#issuecomment-1774329086 Thanks @KarmaGYZ , I will rebase master and work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Commented] (FLINK-32716) Give 'Default'(or maybe 'None') option for 'scheduler-mode'

2023-10-22 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778491#comment-17778491 ] Yao Zhang commented on FLINK-32716: --- Hi [~kination], The title of your PR now is [FLI

Re: [PR] [FLINK-23598] [core] Fix a bug that caused position to be updated twice when writing a string to a byte array [flink]

2023-10-22 Thread via GitHub
injae-kim commented on code in PR #23563: URL: https://github.com/apache/flink/pull/23563#discussion_r1367994297 ## flink-core/src/main/java/org/apache/flink/core/memory/DataOutputSerializer.java: ## @@ -160,7 +160,6 @@ public void writeBytes(String s) throws IOException {

[jira] [Commented] (FLINK-32940) Support projection pushdown to table source for column projections through UDTF

2023-10-22 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778478#comment-17778478 ] Jeyhun Karimov commented on FLINK-32940: Hi [~vsowrirajan] [~337361...@qq.com] [

Re: [PR] Draft: FLINK-28229 (CI) [flink]

2023-10-22 Thread via GitHub
afedulov commented on PR #23558: URL: https://github.com/apache/flink/pull/23558#issuecomment-1774210195 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (FLINK-33310) Scala before 2.12.18 doesn't compile on Java 21

2023-10-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33310. - Fix Version/s: 1.19.0 Resolution: Fixed > Scala before 2.12.18 doesn't compile on

[jira] [Closed] (FLINK-33310) Scala before 2.12.18 doesn't compile on Java 21

2023-10-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33310. --- > Scala before 2.12.18 doesn't compile on Java 21 >

[jira] [Commented] (FLINK-33310) Scala before 2.12.18 doesn't compile on Java 21

2023-10-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778464#comment-17778464 ] Sergey Nuyanzin commented on FLINK-33310: - Merged as [6cdfca2a6aba1a387b866d935

[jira] [Assigned] (FLINK-33310) Scala before 2.12.18 doesn't compile on Java 21

2023-10-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33310: --- Assignee: Sergey Nuyanzin > Scala before 2.12.18 doesn't compile on Java 21 > -

Re: [PR] [FLINK-33310] Scala before 2.12.18 doesn't compile on Java 21 [flink]

2023-10-22 Thread via GitHub
snuyanzin merged PR #23548: URL: https://github.com/apache/flink/pull/23548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-33310] Scala before 2.12.18 doesn't compile on Java 21 [flink]

2023-10-22 Thread via GitHub
snuyanzin commented on PR #23548: URL: https://github.com/apache/flink/pull/23548#issuecomment-1774179490 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Closed] (FLINK-33318) Create TimeMsPerSec metrics for each collector and add metrics across all collectors

2023-10-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-33318. -- Resolution: Fixed merged to master 76dda5d3cf7c4ecf255370679b27e11dd974a293 > Create TimeMsPerSec met

Re: [PR] [FLINK-33318] Expose aggregated collector metrics and measure timeMsPerSecond [flink]

2023-10-22 Thread via GitHub
gyfora merged PR #23554: URL: https://github.com/apache/flink/pull/23554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-33335) Remove unused e2e tests

2023-10-22 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-5: -- Description: FLINK-17375 removed _run-pre-commit-tests.sh_ in Flink 1.12 [1]. Since th

[jira] [Comment Edited] (FLINK-33335) Remove unused e2e tests

2023-10-22 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778126#comment-17778126 ] Alexander Fedulov edited comment on FLINK-5 at 10/22/23 10:07 AM:

[jira] [Updated] (FLINK-33138) Prometheus Connector Sink - DataStream API implementation

2023-10-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33138: --- Labels: pull-request-available (was: ) > Prometheus Connector Sink - DataStream API impleme

[PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2023-10-22 Thread via GitHub
nicusX opened a new pull request, #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1 ## Purpose of the change DataStream API implementation Also includes: * AMP Request Signed implementation ([FLINK-33141](https://issues.apache.org/jira/browse/FLINK-33141))