Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-10-23 Thread via GitHub
gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1774548983 @XComp I tried to address all of your comments, please take a look when you have some time -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-23 Thread via GitHub
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368207827 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.o

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368208203 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -32,20 +40,69 @@ */ @Experimental public inte

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368208991 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,71 @@

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368208203 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -32,20 +40,69 @@ */ @Experimental public inte

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368209456 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,71 @@

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
1996fanrui commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368211844 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesAutoScalerEventHandler.java: ## @@ -43,26 +52,7

Re: [PR] [FLINK-33187] using hashcode for parallelism map comparison [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
clarax commented on code in PR #685: URL: https://github.com/apache/flink-kubernetes-operator/pull/685#discussion_r1368211917 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/event/AutoScalerEventHandler.java: ## @@ -32,20 +40,69 @@ */ @Experimental public inte

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-10-23 Thread via GitHub
gyfora commented on PR #23490: URL: https://github.com/apache/flink/pull/23490#issuecomment-1774559892 A problem with the current PR/test-setup is that we don't actually run the CI using Java 17 (or java17-target profile) this means that the new tests are not executed on azure. This may act

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-23 Thread via GitHub
Myasuka commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368207827 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.apache.o

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-23 Thread via GitHub
MartijnVisser commented on code in PR #665: URL: https://github.com/apache/flink-web/pull/665#discussion_r1368214182 ## docs/content/documentation/flink-table-store-0.3.md: ## @@ -1,7 +1,7 @@ --- -weight: 10 -title: Table Store Master (snapshot) -bookHref: "https://nightlies.ap

[PR] [WIP][FLINK-25055][network] Support listen and notify mechanism for partit… [flink]

2023-10-23 Thread via GitHub
KarmaGYZ opened a new pull request, #23565: URL: https://github.com/apache/flink/pull/23565 …ion request ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re

Re: [PR] [WIP][FLINK-25055][network] Support listen and notify mechanism for partit… [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23565: URL: https://github.com/apache/flink/pull/23565#issuecomment-1774569815 ## CI report: * 998847411de3cee26b4cc0186913e92a71a4b930 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33313][table] Fix RexNodeExtractor#extractConjunctiveCondition… [flink]

2023-10-23 Thread via GitHub
zoudan opened a new pull request, #23566: URL: https://github.com/apache/flink/pull/23566 ## What is the purpose of the change Fix a bug that RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal ## Brief change log cast

[PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-10-23 Thread via GitHub
zoudan opened a new pull request, #23567: URL: https://github.com/apache/flink/pull/23567 ## What is the purpose of the change Fix a bug that RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal ## Brief change log cast

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23566: URL: https://github.com/apache/flink/pull/23566#issuecomment-1774584723 ## CI report: * ed0aa2ffeb59d877ec8b20a45619a335cd00d020 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33278) RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIsNotAvailable fails on AZP

2023-10-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33278: --- Attachment: screenshot-1.png > RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIs

[jira] [Commented] (FLINK-27020) use hive dialect in SqlClient would thrown an error based on 1.15 version

2023-10-23 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778546#comment-17778546 ] Xin Chen commented on FLINK-27020: -- Hi, [~martijnvisser] Thank you very much. Is there

[jira] [Commented] (FLINK-33154) flink on k8s,An error occurred during consuming rocketmq

2023-10-23 Thread Monody (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778545#comment-17778545 ] Monody commented on FLINK-33154: [~martijnvisser] That issue was also initiated by me:(

[jira] [Updated] (FLINK-33278) RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIsNotAvailable fails on AZP

2023-10-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33278: --- Attachment: screenshot-2.png > RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIs

[jira] [Updated] (FLINK-33278) RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIsNotAvailable fails on AZP

2023-10-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-33278: --- Attachment: screenshot-3.png > RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIs

Re: [PR] [FLINK-25055][runtime] Support listen and notify mechanism for partition request [flink]

2023-10-23 Thread via GitHub
KarmaGYZ commented on PR #19380: URL: https://github.com/apache/flink/pull/19380#issuecomment-1774588179 JFYI, I've refactor this PR, addressed all the exisiting comments and rebase on the lastest master in #23565 -- This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (FLINK-33278) RemotePekkoRpcActorTest.failsRpcResultImmediatelyIfRemoteRpcServiceIsNotAvailable fails on AZP

2023-10-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778548#comment-17778548 ] Jiabao Sun commented on FLINK-33278: Hold the thread at ClassLoadingUtils.guardCompl

Re: [PR] [FLINK-30768] [Project Website] flink-web version cleanup [flink-web]

2023-10-23 Thread via GitHub
victor9309 commented on PR #683: URL: https://github.com/apache/flink-web/pull/683#issuecomment-1774591947 Thanks @XComp for the review. I validate the return value, but I don't know if I need to exit the shell script or print if there is no valid value. Test no valid value: ![im

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23567: URL: https://github.com/apache/flink/pull/23567#issuecomment-1774592446 ## CI report: * 9fa61368af37cec5a50c937133b4cb946b6216a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33154) flink on k8s,An error occurred during consuming rocketmq

2023-10-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778551#comment-17778551 ] Martijn Visser commented on FLINK-33154: Ah. It could be a dependency issue on N

[jira] [Commented] (FLINK-33154) flink on k8s,An error occurred during consuming rocketmq

2023-10-23 Thread Monody (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778554#comment-17778554 ] Monody commented on FLINK-33154: [~martijnvisser] OK. thank you~  > flink on k8s,An err

[jira] [Commented] (FLINK-27020) use hive dialect in SqlClient would thrown an error based on 1.15 version

2023-10-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778556#comment-17778556 ] Martijn Visser commented on FLINK-27020: [~xinchen147] See FLINK-26603 > use hi

[jira] [Assigned] (FLINK-33331) Upgrade netty to 4.1.93+

2023-10-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-1: -- Assignee: Martijn Visser > Upgrade netty to 4.1.93+ > > >

[jira] [Updated] (FLINK-33331) Upgrade netty to 4.1.93+

2023-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-1: --- Labels: pull-request-available (was: ) > Upgrade netty to 4.1.93+ > ---

[jira] [Created] (FLINK-33336) Upgrade ASM to 9.6

2023-10-23 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-6: -- Summary: Upgrade ASM to 9.6 Key: FLINK-6 URL: https://issues.apache.org/jira/browse/FLINK-6 Project: Flink Issue Type: Technical Debt C

[jira] [Updated] (FLINK-33336) Upgrade ASM to 9.6

2023-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-6: --- Labels: pull-request-available (was: ) > Upgrade ASM to 9.6 > -- > >

[jira] [Commented] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-10-23 Thread Tony Garrard (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778559#comment-17778559 ] Tony Garrard commented on FLINK-31966: -- [~gyfora] Can you assign me to this issue.

[jira] [Commented] (FLINK-27020) use hive dialect in SqlClient would thrown an error based on 1.15 version

2023-10-23 Thread Xin Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778560#comment-17778560 ] Xin Chen commented on FLINK-27020: -- [~martijnvisser] Thanks a lot. > use hive dialect

Re: [PR] [FLINK-30768] [Project Website] flink-web version cleanup [flink-web]

2023-10-23 Thread via GitHub
XComp commented on code in PR #683: URL: https://github.com/apache/flink-web/pull/683#discussion_r1368272121 ## _include/q/_utils.sh: ## @@ -0,0 +1,34 @@ +#!/usr/bin/env bash + +# Licensed to the Ap

[jira] [Assigned] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-10-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31966: -- Assignee: Tony Garrard > Flink Kubernetes operator lacks TLS support > -

[jira] [Assigned] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-10-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31966: -- Assignee: (was: Anthony Collen) > Flink Kubernetes operator lacks TLS support >

[jira] [Assigned] (FLINK-31966) Flink Kubernetes operator lacks TLS support

2023-10-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31966: -- Assignee: Anthony Collen > Flink Kubernetes operator lacks TLS support > ---

Re: [PR] [FLINK-32611] Redirect to Apache Paimon's link instead of legacy flink table store [flink-web]

2023-10-23 Thread via GitHub
Myasuka commented on PR #665: URL: https://github.com/apache/flink-web/pull/665#issuecomment-1774663958 Already updated this PR, please take a review again @JingsongLi @MartijnVisser . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-10-23 Thread via GitHub
LadyForest commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1774684679 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime [flink]

2023-10-23 Thread via GitHub
Jiabao-Sun commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1774685829 Hi @JingGe, could you help review this PR when you have time? This PR is more difficult to review, and I can also split it into multiple. WDYT? -- This is an automated message fro

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-10-23 Thread via GitHub
zoudan commented on PR #23566: URL: https://github.com/apache/flink/pull/23566#issuecomment-1774687910 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-33313][table] fix RexNodeExtractor#extractConjunctiveConditions throws an Exception when handle binary literal [flink]

2023-10-23 Thread via GitHub
zoudan commented on PR #23567: URL: https://github.com/apache/flink/pull/23567#issuecomment-1774690073 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-31180] [Test Infrastructure] Fail early when installing minikube and check whether we can retry [flink]

2023-10-23 Thread via GitHub
XComp commented on PR #23497: URL: https://github.com/apache/flink/pull/23497#issuecomment-1774714262 Ok, sounds good to me. I'm gonna close this PR in favor of FLINK-32107 and PR #23528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-31180] [Test Infrastructure] Fail early when installing minikube and check whether we can retry [flink]

2023-10-23 Thread via GitHub
XComp closed pull request #23497: [FLINK-31180] [Test Infrastructure] Fail early when installing minikube and check whether we can retry URL: https://github.com/apache/flink/pull/23497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-32107] [Tests] Kubernetes test failed because ofunable to establish ssl connection to github on AZP [flink]

2023-10-23 Thread via GitHub
XComp commented on code in PR #23528: URL: https://github.com/apache/flink/pull/23528#discussion_r1368316329 ## flink-end-to-end-tests/test-scripts/common_kubernetes.sh: ## @@ -87,6 +101,17 @@ function setup_kubernetes_for_linux { sudo sysctl fs.protected_regular=0 } +fu

[PR] [FLINK-33267] Support PreparedStatement in JDBC Driver [flink]

2023-10-23 Thread via GitHub
zoudan opened a new pull request, #23568: URL: https://github.com/apache/flink/pull/23568 ## What is the purpose of the change Support PreparedStatement in JDBC Driver ## Brief change log - Add FlinkPreparedStatement which implements PreparedStatement. ##

[jira] [Closed] (FLINK-31180) Fail early when installing minikube and check whether we can retry

2023-10-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-31180. - Resolution: Duplicate I'm going to close this issue in favor of FLINK-32107 which covers similar

[jira] [Updated] (FLINK-33267) Support PreparedStatement in JDBC Driver

2023-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33267: --- Labels: pull-request-available (was: ) > Support PreparedStatement in JDBC Driver > ---

[jira] [Commented] (FLINK-33267) Support PreparedStatement in JDBC Driver

2023-10-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778580#comment-17778580 ] Benchao Li commented on FLINK-33267: [~FrankZou] Thanks for your contribution, since

Re: [PR] [FLINK-33267] Support PreparedStatement in JDBC Driver [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23568: URL: https://github.com/apache/flink/pull/23568#issuecomment-1774728364 ## CI report: * 9f6b055bb5683629839510ec8075c409a89208e4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33314][table] Fix the named parameter example in window tvf [flink]

2023-10-23 Thread via GitHub
lincoln-lil merged PR #23549: URL: https://github.com/apache/flink/pull/23549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-33314][table] Fix the named parameter example in window tvf [flink]

2023-10-23 Thread via GitHub
lincoln-lil commented on PR #23549: URL: https://github.com/apache/flink/pull/23549#issuecomment-1774729462 @xuyangzhong thanks for reviewing this! merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368341787 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -97,32 +99,30 @@ public CollectedMetricHistory updateMe

[jira] [Closed] (FLINK-33314) Fix the named parameter example in window tvf

2023-10-23 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-33314. --- Resolution: Fixed Fixed in master: 3596a94fe415fdc834cec346cc3910dd775f5239 > Fix the named paramet

Re: [PR] [FLINK-33330] Update zookeeper to 3.7.2, 3.8.3 to address CVE-2023-44981 [flink-shaded]

2023-10-23 Thread via GitHub
snuyanzin commented on PR #122: URL: https://github.com/apache/flink-shaded/pull/122#issuecomment-1774734112 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368342398 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ## @@ -97,32 +99,30 @@ public CollectedMetricHistory updateMe

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368344860 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

Re: [PR] [FLINK-33330] Update zookeeper to 3.7.2, 3.8.3 to address CVE-2023-44981 [flink-shaded]

2023-10-23 Thread via GitHub
snuyanzin merged PR #122: URL: https://github.com/apache/flink-shaded/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[PR] Bump com.google.guava:guava from 31.1-jre to 32.0.0-jre in /flink-shaded-guava-31 [flink-shaded]

2023-10-23 Thread via GitHub
dependabot[bot] opened a new pull request, #125: URL: https://github.com/apache/flink-shaded/pull/125 Bumps [com.google.guava:guava](https://github.com/google/guava) from 31.1-jre to 32.0.0-jre. Release notes Sourced from https://github.com/google/guava/releases";>com.google.guava:

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368345973 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -151,6 +151,31 @@ private static ConfigOptions.Option

[jira] [Assigned] (FLINK-33330) Bump zookeeper to address CVE-2023-44981

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-0: --- Assignee: Sergey Nuyanzin > Bump zookeeper to address CVE-2023-44981 > ---

[jira] [Resolved] (FLINK-33330) Bump zookeeper to address CVE-2023-44981

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-0?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-0. - Fix Version/s: shaded-18.0 Resolution: Fixed > Bump zookeeper to address CVE-202

[jira] [Commented] (FLINK-33330) Bump zookeeper to address CVE-2023-44981

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778584#comment-17778584 ] Sergey Nuyanzin commented on FLINK-0: - Merged as [18e315a25bb699263861146fd

Re: [PR] [FLINK-33306] Use observed source throughput as true processing rate [flink-kubernetes-operator]

2023-10-23 Thread via GitHub
gyfora commented on code in PR #686: URL: https://github.com/apache/flink-kubernetes-operator/pull/686#discussion_r1368347405 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricEvaluator.java: ## @@ -154,6 +153,56 @@ private Map evaluateMetrics(

[jira] [Created] (FLINK-33337) Expose IngestDB and ClipDB in the official RocksDB API

2023-10-23 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-7: -- Summary: Expose IngestDB and ClipDB in the official RocksDB API Key: FLINK-7 URL: https://issues.apache.org/jira/browse/FLINK-7 Project: Flink Is

[jira] [Created] (FLINK-33338) Bump up RocksDB version to 7.x

2023-10-23 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-8: -- Summary: Bump up RocksDB version to 7.x Key: FLINK-8 URL: https://issues.apache.org/jira/browse/FLINK-8 Project: Flink Issue Type: Sub-task

Re: [PR] [FLINK-33329] Upgrade commons-compress to 1.24.0 [flink]

2023-10-23 Thread via GitHub
snuyanzin merged PR #23561: URL: https://github.com/apache/flink/pull/23561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-33338) Bump RocksDB version to 7.x

2023-10-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8: --- Summary: Bump RocksDB version to 7.x (was: Bump up RocksDB version to 7.x) > Bump RocksDB v

[jira] [Commented] (FLINK-25217) FLIP-190: Support Version Upgrades for Table API & SQL Programs

2023-10-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778588#comment-17778588 ] Timo Walther commented on FLINK-25217: -- Update: A more sophisticated testing infra

[jira] [Resolved] (FLINK-33329) Bump commons-compress to address CVEs

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33329. - Fix Version/s: 1.19.0 Resolution: Fixed > Bump commons-compress to address CVEs >

[jira] [Assigned] (FLINK-25809) Introduce test infra for building FLIP-190 tests

2023-10-23 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-25809: Assignee: Timo Walther > Introduce test infra for building FLIP-190 tests >

[jira] [Assigned] (FLINK-33329) Bump commons-compress to address CVEs

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33329: --- Assignee: Sergey Nuyanzin > Bump commons-compress to address CVEs > ---

[jira] [Commented] (FLINK-33329) Bump commons-compress to address CVEs

2023-10-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778589#comment-17778589 ] Sergey Nuyanzin commented on FLINK-33329: - Merged as [d59196cc23e58ca7d86d7ce29

[jira] [Commented] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778591#comment-17778591 ] Jing Ge commented on FLINK-33301: - There are some pre-built jars. Let me copy the reply

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778591#comment-17778591 ] Jing Ge edited comment on FLINK-33301 at 10/23/23 9:13 AM: --- Th

[jira] [Comment Edited] (FLINK-33301) Add Java and Maven version checks in the bash script of Flink release process

2023-10-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17778591#comment-17778591 ] Jing Ge edited comment on FLINK-33301 at 10/23/23 9:14 AM: --- Th

Re: [PR] [FLINK-33331] Upgrade Netty to 4.1.100.Final [flink-shaded]

2023-10-23 Thread via GitHub
MartijnVisser merged PR #123: URL: https://github.com/apache/flink-shaded/pull/123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[jira] [Created] (FLINK-33339) Update Guava to 32.1.3

2023-10-23 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-9: -- Summary: Update Guava to 32.1.3 Key: FLINK-9 URL: https://issues.apache.org/jira/browse/FLINK-9 Project: Flink Issue Type: Technical Debt

[jira] [Updated] (FLINK-33338) Bump FRocksDB version to 7.x

2023-10-23 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-8: --- Summary: Bump FRocksDB version to 7.x (was: Bump RocksDB version to 7.x) > Bump FRocksDB ve

Re: [PR] [FLINK-33336][Build/Shaded] Update ASM to 9.5 [flink-shaded]

2023-10-23 Thread via GitHub
MartijnVisser commented on PR #124: URL: https://github.com/apache/flink-shaded/pull/124#issuecomment-1774781816 Yes, let me fix that. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [FLINK-33336][Build/Shaded] Update ASM to 9.6 [flink-shaded]

2023-10-23 Thread via GitHub
MartijnVisser merged PR #124: URL: https://github.com/apache/flink-shaded/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

Re: [PR] fix zh logo redirect to wrong url [flink-web]

2023-10-23 Thread via GitHub
Matrix42 closed pull request #656: fix zh logo redirect to wrong url URL: https://github.com/apache/flink-web/pull/656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[jira] [Closed] (FLINK-33336) Upgrade ASM to 9.6

2023-10-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-6. -- Fix Version/s: shaded-18.0 Resolution: Fixed Fixed in apache/flink-shaded:master 4b62d5

[jira] [Closed] (FLINK-33331) Upgrade netty to 4.1.93+

2023-10-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-1. -- Fix Version/s: shaded-18.0 Resolution: Fixed Fixed in apache/flink-shaded:master c2e27e

Re: [PR] [hotfix][docs] Adds clean to Maven command in README file [flink-shaded]

2023-10-23 Thread via GitHub
MartijnVisser merged PR #121: URL: https://github.com/apache/flink-shaded/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@fl

[PR] [FLINK-33323] Fix the unexpected exception in DiskIOScheduler when the BatchShuffleReadBufferPool is destroyed [flink]

2023-10-23 Thread via GitHub
WencongLiu opened a new pull request, #23569: URL: https://github.com/apache/flink/pull/23569 ## What is the purpose of the change *Fix the unexpected exception in DiskIOScheduler when the BatchShuffleReadBufferPool is destroyed.* ## Brief change log - *Fix the une

[jira] [Updated] (FLINK-33323) HybridShuffleITCase fails with produced an uncaught exception in FatalExitExceptionHandler

2023-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33323: --- Labels: pull-request-available test-stability (was: test-stability) > HybridShuffleITCase f

Re: [PR] [FLINK-33323] Fix the unexpected exception in DiskIOScheduler when the BatchShuffleReadBufferPool is destroyed [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23569: URL: https://github.com/apache/flink/pull/23569#issuecomment-1774838302 ## CI report: * 4ae9ca044e318ac5564e0fd150efd0da816753fe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-32671) Document Externalized Declarative Resource Management

2023-10-23 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-32671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-32671: - Assignee: David Morávek > Document Externalized Declarative Resource Management > -

[PR] [FLINK-32671] Document Externalized Declararative Resource Management… [flink]

2023-10-23 Thread via GitHub
dmvk opened a new pull request, #23570: URL: https://github.com/apache/flink/pull/23570 https://issues.apache.org/jira/browse/FLINK-32671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-32671] Document Externalized Declararative Resource Management… [flink]

2023-10-23 Thread via GitHub
flinkbot commented on PR #23570: URL: https://github.com/apache/flink/pull/23570#issuecomment-1774892085 ## CI report: * df4e8991925cb0791689bc4489bb434729aabdae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-33340) Bump Jackson to 2.15.3

2023-10-23 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-33340: --- Summary: Bump Jackson to 2.15.3 Key: FLINK-33340 URL: https://issues.apache.org/jira/browse/FLINK-33340 Project: Flink Issue Type: Technical Debt

Re: [PR] [FLINK-33340] Upgrade jackson to 2.15.3 [flink-shaded]

2023-10-23 Thread via GitHub
snuyanzin commented on code in PR #126: URL: https://github.com/apache/flink-shaded/pull/126#discussion_r1368471343 ## flink-shaded-jackson-parent/flink-shaded-jackson-2/src/main/resources/META-INF/NOTICE: ## @@ -6,11 +6,11 @@ The Apache Software Foundation (http://www.apache.or

[jira] [Updated] (FLINK-33340) Bump Jackson to 2.15.3

2023-10-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33340: --- Labels: pull-request-available (was: ) > Bump Jackson to 2.15.3 > -- >

Re: [PR] [FLINK-32671] Document Externalized Declararative Resource Management… [flink]

2023-10-23 Thread via GitHub
zentol commented on code in PR #23570: URL: https://github.com/apache/flink/pull/23570#discussion_r1368477395 ## docs/content/docs/deployment/elastic_scaling.md: ## @@ -25,22 +25,100 @@ under the License. # Elastic Scaling -Apache Flink allows you to rescale your jobs. You

Re: [PR] [FLINK-33171][table planner] Consistent implicit type coercion support for equal and non-equal comparisons for codegen [flink]

2023-10-23 Thread via GitHub
fengjiajie commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1774955380 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-32380] Support Java Records with PojoTypeInfo/Serializer [flink]

2023-10-23 Thread via GitHub
XComp commented on code in PR #23490: URL: https://github.com/apache/flink/pull/23490#discussion_r1368358256 ## flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/JavaRecordHelper.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [FLINK-33090][checkpointing] CheckpointsCleaner clean individual chec… [flink]

2023-10-23 Thread via GitHub
pnowojski commented on PR #23425: URL: https://github.com/apache/flink/pull/23425#issuecomment-1774965429 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-27076) Setup runners

2023-10-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-27076: -- Description: Below is a collection of links around the topic of self-hosted runners and the c

  1   2   3   >