PatrickRen merged PR #16:
URL: https://github.com/apache/flink-connector-mongodb/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
victor9309 commented on PR #683:
URL: https://github.com/apache/flink-web/pull/683#issuecomment-1783658488
Thanks @XComp for the review. I changed the variable; If
_includes/q/quickstart-scala.sh and _includes/q/quickstart-scala-SNAPSHOT.sh
are removed, and if 1.7+ is not supported; Do
[
https://issues.apache.org/jira/browse/FLINK-32931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780562#comment-17780562
]
Jing Ge commented on FLINK-32931:
-
[https://hub.docker.com/r/apache/flink] is online
> Publish the
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374920762
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374878989
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Samrat002 commented on PR #23531:
URL: https://github.com/apache/flink/pull/23531#issuecomment-1783316403
> I should have mentioned it in
[FLINK-32806](https://issues.apache.org/jira/browse/FLINK-32806) already: We
might want to start a ML discussion on adding another parameter. If we
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374875133
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374884825
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedJobResultStore.java:
##
@@ -67,7 +79,7 @@ public boolean
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374878989
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374875133
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Samrat002 commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374875133
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780489#comment-17780489
]
Oleksandr Nitavskyi commented on FLINK-33376:
-
It would be really good to be able to support
echauchot commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1374827779
##
.github/workflows/ci.yml:
##
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
echauchot commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1374820946
##
.github/workflows/ci.yml:
##
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780456#comment-17780456
]
macdoor615 edited comment on FLINK-33365 at 10/27/23 4:38 PM:
--
[~davidradl]
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780456#comment-17780456
]
macdoor615 edited comment on FLINK-33365 at 10/27/23 4:36 PM:
--
[~davidradl]
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780456#comment-17780456
]
macdoor615 commented on FLINK-33365:
[~davidradl] I create another case
1. create a paimon table
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: flink-connector-jdbc-3.1.1-1.17.png
> Missing filter condition in execution plan
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: (was: flink-connector-jdbc-3.1.1-1.17.png)
> Missing filter condition in execution
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: flink-connector-jdbc-3.0.0-1.16.png
> Missing filter condition in execution plan
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: (was: image-2023-10-28-00-26-52-681.png)
> Missing filter condition in execution
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: flink-connector-jdbc-3.1.1-1.17.png
> Missing filter condition in execution plan
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated FLINK-33365:
---
Attachment: image-2023-10-28-00-26-52-681.png
> Missing filter condition in execution plan
[
https://issues.apache.org/jira/browse/FLINK-33324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780439#comment-17780439
]
dongwoo.kim edited comment on FLINK-33324 at 10/27/23 3:48 PM:
---
Thanks for
[
https://issues.apache.org/jira/browse/FLINK-33324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780439#comment-17780439
]
dongwoo.kim commented on FLINK-33324:
-
Thanks for the opnion [~roman] , and sorry for the late
mbalassi merged PR #687:
URL: https://github.com/apache/flink-kubernetes-operator/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780427#comment-17780427
]
macdoor615 commented on FLINK-33365:
[~davidradl] I'm not sure if your test case represents my
dawidwys commented on PR #23603:
URL: https://github.com/apache/flink/pull/23603#issuecomment-1783097478
I'll squash all commits that do not start with `[xxx]` once the CI is green
and the PR is approved.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/FLINK-33341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Richter closed FLINK-33341.
--
Resolution: Fixed
merged in a4ad86f
> Use available local keyed state for rescaling
>
StefanRRichter merged PR #23591:
URL: https://github.com/apache/flink/pull/23591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780411#comment-17780411
]
Matthias Pohl commented on FLINK-33376:
---
Sounds like a good idea. We could think about utilizing
[
https://issues.apache.org/jira/browse/FLINK-33367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780409#comment-17780409
]
Matthias Pohl edited comment on FLINK-33367 at 10/27/23 2:39 PM:
-
Makes
[
https://issues.apache.org/jira/browse/FLINK-33367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780409#comment-17780409
]
Matthias Pohl commented on FLINK-33367:
---
But to answer the questions:
{quote}
1) Can a file name
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780403#comment-17780403
]
david radley commented on FLINK-33365:
--
[~macdoor615] I notice that I can run
[
https://issues.apache.org/jira/browse/FLINK-33371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Wysakowicz closed FLINK-33371.
Resolution: Fixed
Implemented in e914eb7fc3f31286ed7e33cc93e7ffbca785b731
> Make
dawidwys merged PR #23601:
URL: https://github.com/apache/flink/pull/23601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374631884
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/CalcTestProgram.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374632320
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -0,0 +1,229 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780391#comment-17780391
]
Clay Johnson commented on FLINK-33373:
--
I have reached out to Infra to get the proper account
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780387#comment-17780387
]
Oleksandr Nitavskyi commented on FLINK-33376:
-
Thanks for the link. If we really require a
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780387#comment-17780387
]
Oleksandr Nitavskyi edited comment on FLINK-33376 at 10/27/23 1:56 PM:
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780377#comment-17780377
]
Matthias Pohl commented on FLINK-33376:
---
No worries. Thanks. I assigned the issue to you. There is
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl reassigned FLINK-33376:
-
Assignee: Oleksandr Nitavskyi
> Add AuthInfo config option for Zookeeper configuration
[
https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780374#comment-17780374
]
Matthias Pohl commented on FLINK-33373:
---
[~chesnay] could you have a look at this? I think it
[
https://issues.apache.org/jira/browse/FLINK-33376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780373#comment-17780373
]
Oleksandr Nitavskyi commented on FLINK-33376:
-
[~mapohl] sure, would be glad to drive this!
flinkbot commented on PR #23610:
URL: https://github.com/apache/flink/pull/23610#issuecomment-1782935726
## CI report:
* 4c2cc92a9246f79e0edd28abeba74cfc61f339b5 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
XComp commented on code in PR #23531:
URL: https://github.com/apache/flink/pull/23531#discussion_r1374561765
##
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/JobResultStoreOptions.java:
##
@@ -65,4 +65,11 @@ public class JobResultStoreOptions {
Wosin opened a new pull request, #23610:
URL: https://github.com/apache/flink/pull/23610
## What is the purpose of the change
This change removes the `dataCenter` configuration for DataDog reporter and
replaces it with `dataCenterUrl` that allows users to configure whole address
of
[
https://issues.apache.org/jira/browse/FLINK-30284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-30284:
---
Labels: pull-request-available (was: )
> Make datadog reporter url configurable
>
[
https://issues.apache.org/jira/browse/FLINK-33373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780369#comment-17780369
]
Clay Johnson commented on FLINK-33373:
--
Good questions [~mapohl]!
{quote}I'm not that familiar with
david radley created FLINK-33384:
Summary: MySQL JDBC driver is deprecated
Key: FLINK-33384
URL: https://issues.apache.org/jira/browse/FLINK-33384
Project: Flink
Issue Type: Improvement
eskabetxe commented on code in PR #76:
URL:
https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1374484452
##
pom.xml:
##
@@ -47,7 +47,7 @@ under the License.
-1.17.0
+1.18.0
Review Comment:
as comment ofline downgrade to 1.16.2
[
https://issues.apache.org/jira/browse/FLINK-14819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl resolved FLINK-14819.
---
Resolution: Fixed
I'm closing this one in favor of FLINK-14068 which is used as a Jira
[
https://issues.apache.org/jira/browse/FLINK-27432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl reassigned FLINK-27432:
-
Assignee: Jiabao Sun (was: Chesnay Schepler)
> Replace Time with Duration in
[
https://issues.apache.org/jira/browse/FLINK-33369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-33369:
-
Issue Type: Technical Debt (was: Bug)
> Wordcount is failing on AZP with jdk17
>
[
https://issues.apache.org/jira/browse/FLINK-27432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl resolved FLINK-27432.
---
Resolution: Fixed
master:
[
https://issues.apache.org/jira/browse/FLINK-33369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-33369.
Fix Version/s: 1.19.0
1.18.1
Resolution: Fixed
master:
zentol merged PR #23608:
URL: https://github.com/apache/flink/pull/23608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
XComp merged PR #23574:
URL: https://github.com/apache/flink/pull/23574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
XComp commented on PR #23574:
URL: https://github.com/apache/flink/pull/23574#issuecomment-1782883587
Additionally, it's considered a good habit to not ping people right away
within days. Mentions are noticed and if a contributor finds time to review it,
he/she will get to it. Our mailbox
twalthr commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374547838
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -0,0 +1,229 @@
+/*
+ * Licensed
twalthr commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374546134
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/CalcTestProgram.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
XComp commented on code in PR #23528:
URL: https://github.com/apache/flink/pull/23528#discussion_r1374531279
##
flink-end-to-end-tests/test-scripts/common_kubernetes.sh:
##
@@ -87,6 +94,35 @@ function setup_kubernetes_for_linux {
sudo sysctl fs.protected_regular=0
}
snuyanzin commented on PR #23608:
URL: https://github.com/apache/flink/pull/23608#issuecomment-1782857193
I see, thanks for the trick
yes i see that it is running with `Java version: 17.0.8.`
--
This is an automated message from the Apache Git Service.
To respond to the message,
XComp commented on code in PR #78:
URL: https://github.com/apache/flink-benchmarks/pull/78#discussion_r1374521671
##
src/main/java/org/apache/flink/olap/benchmark/HighAvailabilityServiceBenchmark.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation
XComp commented on code in PR #78:
URL: https://github.com/apache/flink-benchmarks/pull/78#discussion_r1374521671
##
src/main/java/org/apache/flink/olap/benchmark/HighAvailabilityServiceBenchmark.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation
XComp commented on code in PR #683:
URL: https://github.com/apache/flink-web/pull/683#discussion_r1374515494
##
_include/q/quickstart-scala.sh:
##
@@ -18,13 +18,16 @@
# limitations under the License.
[
https://issues.apache.org/jira/browse/FLINK-33383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-33383:
--
Description:
The {{_includes/q/quickstart-scala.sh}} script does work for Flink 1.17
JingGe opened a new pull request, #163:
URL: https://github.com/apache/flink-docker/pull/163
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/FLINK-33383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-33383:
--
Description:
The {{_includes/q/quickstart-scala.sh}} script does work for Flink 1.17
[
https://issues.apache.org/jira/browse/FLINK-33383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-33383:
--
Summary: flink-quickstart-scala.sh is not supported anymore since 1.17 but
is used in
[
https://issues.apache.org/jira/browse/FLINK-33383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780344#comment-17780344
]
Matthias Pohl commented on FLINK-33383:
---
[~martijnvisser] do you agree that deleting these scripts
Matthias Pohl created FLINK-33383:
-
Summary: flink-quickstart-scala is not supported anymore since 1.17
Key: FLINK-33383
URL: https://issues.apache.org/jira/browse/FLINK-33383
Project: Flink
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374496162
##
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSourceITCase.java:
##
@@ -319,12 +361,13 @@ private
Jiabao-Sun commented on PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#issuecomment-1782818570
> Thanks for your contribution. Overall LGTM. I left some minor comments
here.
>
> BTW, I think it's better to add more tests for plan to verify these
filters can
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374485571
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesRuntimeFunctions.java:
##
@@ -613,8 +610,13 @@ public void
eskabetxe commented on code in PR #76:
URL:
https://github.com/apache/flink-connector-jdbc/pull/76#discussion_r1374484452
##
pom.xml:
##
@@ -47,7 +47,7 @@ under the License.
-1.17.0
+1.18.0
Review Comment:
reverted
--
This is an automated
xuyangzhong commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374480777
##
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSourceITCase.java:
##
@@ -319,12 +361,13 @@ private
xuyangzhong commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374480051
##
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java:
##
@@ -76,7 +76,7 @@
/** IT cases for
[
https://issues.apache.org/jira/browse/FLINK-32931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780337#comment-17780337
]
Jing Ge edited comment on FLINK-32931 at 10/27/23 12:08 PM:
Opened a PR with
[
https://issues.apache.org/jira/browse/FLINK-32931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17780337#comment-17780337
]
Jing Ge commented on FLINK-32931:
-
Opened a PR with the official docker library:
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374478320
##
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java:
##
@@ -178,6 +196,41 @@ public void
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374475234
##
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoFilterPushDownVisitor.java:
##
@@ -0,0 +1,251 @@
+/*
+ *
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374465459
##
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoFilterPushDownVisitor.java:
##
@@ -0,0 +1,251 @@
+/*
+ *
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374466579
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -0,0 +1,229 @@
+/*
+ * Licensed
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374460482
##
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSourceITCase.java:
##
@@ -319,12 +361,13 @@ private
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374455479
##
flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/MongoSourceITCase.java:
##
@@ -76,7 +76,7 @@
/** IT cases for
eskabetxe commented on code in PR #73:
URL:
https://github.com/apache/flink-connector-jdbc/pull/73#discussion_r1374455266
##
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/internal/JdbcOutputSerializerTest.java:
##
@@ -0,0 +1,36 @@
+package
[
https://issues.apache.org/jira/browse/FLINK-32931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-32931:
--
Description:
Note: the official Dockerfiles fetch the binary distribution of the target
[
https://issues.apache.org/jira/browse/FLINK-31566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Pohl updated FLINK-31566:
--
Description:
Note: the official Dockerfiles fetch the binary distribution of the target
Jiabao-Sun commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374448348
##
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java:
##
@@ -148,13 +163,16 @@ public
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374442591
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/CalcTestProgram.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed
xuyangzhong commented on code in PR #17:
URL:
https://github.com/apache/flink-connector-mongodb/pull/17#discussion_r1374396462
##
flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java:
##
@@ -178,6 +196,41 @@ public void
gaborgsomogyi commented on PR #23555:
URL: https://github.com/apache/flink/pull/23555#issuecomment-1782755925
+1 on `WriterInitContext`. The reasons behind is simple, we have
`CommitterInitContext` which is properly naming what kind of context is
expected. We should add the same clarity on
[
https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martijn Visser reassigned FLINK-33365:
--
Assignee: david radley
> Missing filter condition in execution plan containing
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374420759
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##
@@ -879,6 +890,7 @@ private
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374420333
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java:
##
@@ -981,16 +998,25 @@ public boolean
Jiabao-Sun commented on PR #16:
URL:
https://github.com/apache/flink-connector-mongodb/pull/16#issuecomment-1782724487
Thanks @PatrickRen, the CI passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dawidwys commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374384507
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/RestoreTestBase.java:
##
@@ -0,0 +1,229 @@
+/*
+ * Licensed
twalthr commented on code in PR #23603:
URL: https://github.com/apache/flink/pull/23603#discussion_r1374365391
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/CalcTestProgram.java:
##
@@ -0,0 +1,42 @@
+/*
+ * Licensed to
1 - 100 of 207 matches
Mail list logo
