[jira] [Commented] (FLINK-33971) Specifies whether to use HBase table that supports dynamic columns.

2024-01-02 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802045#comment-17802045 ] MOBIN commented on FLINK-33971: --- https://github.com/apache/flink-connector-hbase/pull/36 > Specifies

[jira] (FLINK-33971) Specifies whether to use HBase table that supports dynamic columns.

2024-01-02 Thread MOBIN (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33971 ] MOBIN deleted comment on FLINK-33971: --- was (Author: mobin): https://github.com/apache/flink-connector-hbase/pull/36 > Specifies whether to use HBase table that supports dynamic columns. >

[jira] [Created] (FLINK-33971) Specifies whether to use HBase table that supports dynamic columns.

2024-01-02 Thread MOBIN (Jira)
MOBIN created FLINK-33971: - Summary: Specifies whether to use HBase table that supports dynamic columns. Key: FLINK-33971 URL: https://issues.apache.org/jira/browse/FLINK-33971 Project: Flink Issue

[jira] [Resolved] (FLINK-26694) LookupFunction doesn't support multilevel inheritance

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-26694. Resolution: Fixed Fixed in master(1.19): 6e78eb18524ead3abd60da0ca41751b45e0e2482 >

[jira] [Assigned] (FLINK-26694) LookupFunction doesn't support multilevel inheritance

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-26694: -- Assignee: Xianxun Ye > LookupFunction doesn't support multilevel inheritance >

[jira] [Updated] (FLINK-26694) LookupFunction doesn't support multilevel inheritance

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-26694: --- Fix Version/s: 1.19.0 > LookupFunction doesn't support multilevel inheritance >

Re: [PR] [FLINK-26694][table] Support lookup join via a multi-level inheritance of TableFunction [flink]

2024-01-02 Thread via GitHub
leonardBang merged PR #23684: URL: https://github.com/apache/flink/pull/23684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-20899][table-planner-blink] Fix ClassCastException when calculating cost in HepPlanner [flink]

2024-01-02 Thread via GitHub
leonardBang commented on PR #14588: URL: https://github.com/apache/flink/pull/14588#issuecomment-1874950162 Hey @godfreyhe would you like to rebase this PR to fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[PR] Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-02 Thread via GitHub
MOBIN-F opened a new pull request, #36: URL: https://github.com/apache/flink-connector-hbase/pull/36 Specifies whether to use an HBase table that supports dynamic columns. Refer to the dynamic.table parameter in this document:

Re: [PR] Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-02 Thread via GitHub
boring-cyborg[bot] commented on PR #36: URL: https://github.com/apache/flink-connector-hbase/pull/36#issuecomment-1874935171 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Commented] (FLINK-32958) Support VIEW as a source table in CREATE TABLE ... Like statement

2024-01-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802032#comment-17802032 ] Martijn Visser commented on FLINK-32958: Thanks [~fornaix] ! > Support VIEW as a source table

[jira] [Commented] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802031#comment-17802031 ] Martijn Visser commented on FLINK-33964: Thanks [~leonard] [~Tison]! > Flink documentation

[jira] [Assigned] (FLINK-33970) Add necessary checks for connector document

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-33970: -- Assignee: Zhongqiang Gong > Add necessary checks for connector document >

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-02 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802025#comment-17802025 ] Zhongqiang Gong commented on FLINK-33970: - [~leonard]  I am willing to take this issue, Please

[jira] [Updated] (FLINK-33970) Add necessary checks for connector document

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33970: --- Description: In FLINK-33964, we found the documentation files in independent connector repos lacks

[jira] [Created] (FLINK-33970) Add necessary checks for connector document

2024-01-02 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-33970: -- Summary: Add necessary checks for connector document Key: FLINK-33970 URL: https://issues.apache.org/jira/browse/FLINK-33970 Project: Flink Issue Type:

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107366 ## flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReaderContext.java: ## @@ -39,7 +41,16 @@ public interface SourceReaderContext { */

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106348 ## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ## @@ -63,14 +67,27 @@ public interface RuntimeContext { /** * The

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440105816 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -166,7 +169,10 @@ public class Task /** ID which identifies the slot in

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107273 ## flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java: ## @@ -119,7 +120,14 @@ public interface Environment { Configuration

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440108370 ## flink-core/src/main/java/org/apache/flink/core/failure/FailureEnricher.java: ## @@ -84,14 +88,26 @@ enum FailureType { * Get the ID of the job.

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440108479 ## flink-core/src/main/java/org/apache/flink/core/failure/FailureEnricher.java: ## @@ -124,5 +140,16 @@ enum FailureType { * @return the Executor pool

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440108007 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/InitContext.java: ## @@ -35,16 +40,37 @@ public interface InitContext { */ long

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107496 ## flink-core/src/main/java/org/apache/flink/api/connector/sink2/InitContext.java: ## @@ -57,6 +83,34 @@ public interface InitContext { /** * The ID of

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107425 ## flink-core/src/main/java/org/apache/flink/api/connector/source/SourceReaderContext.java: ## @@ -68,8 +79,24 @@ public interface SourceReaderContext { * Get

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107273 ## flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java: ## @@ -119,7 +120,14 @@ public interface Environment { Configuration

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440107033 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/batch/compact/BatchPartitionCommitterSinkTest.java: ## @@ -127,7

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106774 ## flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/operator/CepRuntimeContextTest.java: ## @@ -110,38 +111,41 @@ public void testCepRuntimeContext() {

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106348 ## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ## @@ -63,14 +67,27 @@ public interface RuntimeContext { /** * The

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106462 ## flink-core/src/test/java/org/apache/flink/api/common/operators/base/FlatMapOperatorCollectionTest.java: ## @@ -42,6 +43,7 @@ import java.util.List; import

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440106155 ## flink-core/src/main/java/org/apache/flink/api/common/functions/RuntimeContext.java: ## @@ -473,4 +520,26 @@ AggregatingState getAggregatingState( */

Re: [PR] [FLINK-33941][table-planner] use field index instead of field name about window time column [flink]

2024-01-02 Thread via GitHub
LadyForest commented on code in PR #23991: URL: https://github.com/apache/flink/pull/23991#discussion_r1440106137 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkAggregateProjectMergeRule.java: ## @@ -18,6 +18,8 @@

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440105816 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java: ## @@ -166,7 +169,10 @@ public class Task /** ID which identifies the slot in

Re: [PR] [FLINK-33905][core] Unify the Provision of Diverse Metadata for Context-like APIs [flink]

2024-01-02 Thread via GitHub
WencongLiu commented on code in PR #23905: URL: https://github.com/apache/flink/pull/23905#discussion_r1440105629 ## flink-core/src/main/java/org/apache/flink/api/common/JobInfoImpl.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
1996fanrui commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440105061 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -221,7 +221,7 @@ private static double

Re: [PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
1996fanrui commented on code in PR #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743#discussion_r1440104568 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/metrics/ScalingMetrics.java: ## @@ -221,7 +221,7 @@ private static double

[jira] [Resolved] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-33964. Resolution: Fixed > Flink documentation can't be build due to error in Pulsar docs >

[jira] [Commented] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802021#comment-17802021 ] Leonard Xu commented on FLINK-33964: Fixed in flink-connector-pulsar via  main:

Re: [PR] [FLINK-33941][table-planner] use field index instead of field name about window time column [flink]

2024-01-02 Thread via GitHub
LadyForest commented on code in PR #23991: URL: https://github.com/apache/flink/pull/23991#discussion_r1437490488 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala: ## @@ -1117,6 +1117,7 @@ object AggregateUtil

[jira] [Updated] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33964: --- Fix Version/s: pulsar-4.1.1 > Flink documentation can't be build due to error in Pulsar docs >

[jira] [Updated] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33964: --- Affects Version/s: pulsar-4.1.0 (was: 1.18.0) > Flink documentation

[jira] [Updated] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33964: --- Affects Version/s: 1.18.0 > Flink documentation can't be build due to error in Pulsar docs >

[jira] [Commented] (FLINK-33964) Flink documentation can't be build due to error in Pulsar docs

2024-01-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802019#comment-17802019 ] Leonard Xu commented on FLINK-33964: Document action has been fixed

Re: [PR] [FLINK-33632] Adding custom flink mutator [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
AncyRominus commented on code in PR #733: URL: https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1440100481 ## flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java: ## @@ -17,43 +17,88 @@

Re: [PR] [FLINK-33632] Adding custom flink mutator [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
AncyRominus commented on code in PR #733: URL: https://github.com/apache/flink-kubernetes-operator/pull/733#discussion_r1440100481 ## flink-kubernetes-webhook/src/main/java/org/apache/flink/kubernetes/operator/admission/mutator/FlinkMutator.java: ## @@ -17,43 +17,88 @@

Re: [PR] [FLINK-33884] Update Pulsar dependency to 3.0.2 in Pulsar Connector [flink-connector-pulsar]

2024-01-02 Thread via GitHub
dchristle commented on PR #72: URL: https://github.com/apache/flink-connector-pulsar/pull/72#issuecomment-1874876697 > @dchristle I've triggered the CI, but I'm expecting that upgrading the version will also have impact on the license checks (the listed versions in the NOTICE files)

Re: [PR] [hotfix] Update copyright NOTICE year to 2024 [flink]

2024-01-02 Thread via GitHub
1996fanrui merged PR #24018: URL: https://github.com/apache/flink/pull/24018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-02 Thread via GitHub
flinkbot commented on PR #24020: URL: https://github.com/apache/flink/pull/24020#issuecomment-1874824806 ## CI report: * 32e25c7d0a6c58dc23ae28437f7159bf449bdce1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33969) Implement restore tests for TableSourceScan node

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33969: --- Labels: pull-request-available (was: ) > Implement restore tests for TableSourceScan node

[PR] [FLINK-33969] Implement restore tests for TableSourceScan node [flink]

2024-01-02 Thread via GitHub
bvarghese1 opened a new pull request, #24020: URL: https://github.com/apache/flink/pull/24020 ## What is the purpose of the change *Add restore tests for TableSourceScan node* ## Verifying this change This change added tests and can be verified as follows:

[jira] [Created] (FLINK-33969) Implement restore tests for TableSourceScan node

2024-01-02 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33969: --- Summary: Implement restore tests for TableSourceScan node Key: FLINK-33969 URL: https://issues.apache.org/jira/browse/FLINK-33969 Project: Flink Issue

[jira] [Updated] (FLINK-33814) Autoscaler Standalone control loop supports multiple thread

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33814: --- Labels: pull-request-available (was: ) > Autoscaler Standalone control loop supports

[PR] [FLINK-33814][autoscaler] Autoscaler Standalone control loop supports multiple threads [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
1996fanrui opened a new pull request, #744: URL: https://github.com/apache/flink-kubernetes-operator/pull/744 ## What is the purpose of the change When the job list has a lot of jobs, single thread isn't enough. So Autoscaler Standalone control loop supports multiple thread is very

[jira] [Resolved] (FLINK-33965) Refactor the configuration for autoscaler standalone

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33965. - Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed > Refactor the configuration for

Re: [PR] [FLINK-30535] Introduce TTL state based benchmarks [flink-benchmarks]

2024-01-02 Thread via GitHub
Zakelly commented on PR #83: URL: https://github.com/apache/flink-benchmarks/pull/83#issuecomment-1874802825 @Myasuka Kindly remind~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-33965) Refactor the configuration for autoscaler standalone

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801998#comment-17801998 ] Rui Fan commented on FLINK-33965: - Merged to main(1.8.0) via : fa938439ad8a7601462a3be268077aa4078881bc

Re: [PR] [FLINK-33965][autoscaler] Introducing the AutoscalerStandaloneOptions to simplify options for autoscaler standalone [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
1996fanrui merged PR #742: URL: https://github.com/apache/flink-kubernetes-operator/pull/742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33968][runtime] Advance the calculation of num of subpartitions to the time of initializing execution job vertex [flink]

2024-01-02 Thread via GitHub
flinkbot commented on PR #24019: URL: https://github.com/apache/flink/pull/24019#issuecomment-1874793432 ## CI report: * 433585f7f7fb48fe903a8beafce86e0bfec5d776 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33968][runtime] Advance the calculation of num of subpartitions to the time of initializing execution job vertex [flink]

2024-01-02 Thread via GitHub
wanglijie95 commented on PR #24019: URL: https://github.com/apache/flink/pull/24019#issuecomment-1874792567 @JunRuiLee @zhuzhurk Could you help to review this PR ? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-33968) Compute the number of subpartitions when initializing executon job vertices

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33968: --- Labels: pull-request-available (was: ) > Compute the number of subpartitions when

[jira] [Commented] (FLINK-32958) Support VIEW as a source table in CREATE TABLE ... Like statement

2024-01-02 Thread Han (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801993#comment-17801993 ] Han commented on FLINK-32958: - [~martijnvisser]  sure. spark doc:

[PR] [FLINK-33968][runtime] Advance the calculation of num of subpartitions to the time of initializing execution job vertex [flink]

2024-01-02 Thread via GitHub
wanglijie95 opened a new pull request, #24019: URL: https://github.com/apache/flink/pull/24019 ## What is the purpose of the change Solve FLINK-33968 ## Verifying this change This change is already covered by existing tests. ## Does this pull request potentially

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801992#comment-17801992 ] Rui Fan commented on FLINK-33940: - Hi [~Zhanghao Chen] , IIUC flink-benchmarks[1] is checking the

[jira] [Updated] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33940: Attachment: image-2024-01-03-10-52-05-861.png > Update the auto-derivation rule of max parallelism for

[jira] [Updated] (FLINK-33968) Compute the number of subpartitions when initializing executon job vertices

2024-01-02 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang updated FLINK-33968: --- Description: Currently, when using dynamic graphs, the subpartition-num of a task is lazily

[jira] [Created] (FLINK-33968) Compute the number of subpartitions when initializing executon job vertices

2024-01-02 Thread Lijie Wang (Jira)
Lijie Wang created FLINK-33968: -- Summary: Compute the number of subpartitions when initializing executon job vertices Key: FLINK-33968 URL: https://issues.apache.org/jira/browse/FLINK-33968 Project:

[jira] [Closed] (FLINK-33949) METHOD_ABSTRACT_NOW_DEFAULT should be both source compatible and binary compatible

2024-01-02 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wencong Liu closed FLINK-33949. --- Resolution: Not A Problem > METHOD_ABSTRACT_NOW_DEFAULT should be both source compatible and binary

[jira] [Assigned] (FLINK-33892) FLIP-383: Support Job Recovery for Batch Jobs

2024-01-02 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-33892: -- Assignee: Junrui Li (was: Lijie Wang) > FLIP-383: Support Job Recovery for Batch Jobs >

Re: [PR] [FLINK-33935][checkpoint] Improve the default value logic related to `execution.checkpointing.tolerable-failed-checkpoints` and `state.backend.type` [flink]

2024-01-02 Thread via GitHub
Zakelly commented on code in PR #23987: URL: https://github.com/apache/flink/pull/23987#discussion_r1440016826 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -1040,8 +1041,9 @@ public void

[jira] [Commented] (FLINK-33949) METHOD_ABSTRACT_NOW_DEFAULT should be both source compatible and binary compatible

2024-01-02 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801988#comment-17801988 ] Wencong Liu commented on FLINK-33949: - Thanks for the explanation from [~chesnay] . Given that all

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801987#comment-17801987 ] Zhanghao Chen commented on FLINK-33940: --- [~mxm] thanks for the quick response, I'll update with

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-02 Thread via GitHub
zoudan commented on code in PR #23984: URL: https://github.com/apache/flink/pull/23984#discussion_r1440008761 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CodeGenUtils.scala: ## @@ -124,14 +124,27 @@ object CodeGenUtils { private

[jira] [Assigned] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33966: --- Assignee: Yang LI (was: Li Yang) > Fix the getNumRecordsInPerSecond Utility Function >

[jira] [Assigned] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33966: --- Assignee: Li Yang > Fix the getNumRecordsInPerSecond Utility Function >

Re: [PR] [FLINK-33792] Generate the same code for the same logic [flink]

2024-01-02 Thread via GitHub
zoudan commented on PR #23984: URL: https://github.com/apache/flink/pull/23984#issuecomment-1874770437 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33962) Chaining-agnostic OperatorID generation for improved state compatibility on parallelism change

2024-01-02 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801984#comment-17801984 ] Zhanghao Chen commented on FLINK-33962: --- Thanks for the quick response, I'll draft a FLIP and

Re: [PR] [BP][FLINK-33964][pulsar][docs] Drop admin docs reference [flink-connector-pulsar]

2024-01-02 Thread via GitHub
leonardBang merged PR #76: URL: https://github.com/apache/flink-connector-pulsar/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-33962) Chaining-agnostic OperatorID generation for improved state compatibility on parallelism change

2024-01-02 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801976#comment-17801976 ] Xintong Song commented on FLINK-33962: -- Thanks for reaching out, [~Zhanghao Chen]. Just some quick

[jira] [Created] (FLINK-33967) Remove/Rename log4j2-test.properties in flink-streaming-java's test bundle

2024-01-02 Thread Koala Lam (Jira)
Koala Lam created FLINK-33967: - Summary: Remove/Rename log4j2-test.properties in flink-streaming-java's test bundle Key: FLINK-33967 URL: https://issues.apache.org/jira/browse/FLINK-33967 Project: Flink

[jira] [Updated] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33966: --- Labels: pull-request-available (was: ) > Fix the getNumRecordsInPerSecond Utility Function

[PR] [FLINK-33966] Fix the getNumRecordsInPerSecond Utility Function [flink-kubernetes-operator]

2024-01-02 Thread via GitHub
Yang-LI-CS opened a new pull request, #743: URL: https://github.com/apache/flink-kubernetes-operator/pull/743 ## What is the purpose of the change Fix the getNumRecordsInPerSecond Utility Function to addresses the redundant check and ensures correct metric fetching for

[jira] [Updated] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Yang LI (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang LI updated FLINK-33966: Description: We have following code in the codebase {code:java} if (isSource &&

[jira] [Updated] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Yang LI (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang LI updated FLINK-33966: Description: We have 2 times the same condition check in the function getNumRecordsInPerSecond

[jira] [Updated] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Yang LI (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang LI updated FLINK-33966: Description: We have 2 times the same condition check in the function getNumRecordsInPerSecond

[jira] [Created] (FLINK-33966) Fix the getNumRecordsInPerSecond Utility Function

2024-01-02 Thread Yang LI (Jira)
Yang LI created FLINK-33966: --- Summary: Fix the getNumRecordsInPerSecond Utility Function Key: FLINK-33966 URL: https://issues.apache.org/jira/browse/FLINK-33966 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-02 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1438684576 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801843#comment-17801843 ] Maximilian Michels commented on FLINK-33940: [~Zhanghao Chen] Even though the factor only

Re: [PR] [FLINK-20454][format][debezium] Allow to read metadata for debezium-avro-confluent format [flink]

2024-01-02 Thread via GitHub
creativedutchmen commented on PR #18744: URL: https://github.com/apache/flink/pull/18744#issuecomment-1874226714 This would be super helpful to have merged. Are there any plans on pushing this forward? -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-02 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1438684576 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-02 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1438684576 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

Re: [PR] [FLINK-33694][gs-fs-hadoop] Support overriding GCS root URL [flink]

2024-01-02 Thread via GitHub
patricklucas commented on PR #23836: URL: https://github.com/apache/flink/pull/23836#issuecomment-1874157629 I do not think there is much room for unexpected behavior here. The surface area of the change is quite small and follows the existing model for translating a Hadoop config option

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801815#comment-17801815 ] Zhanghao Chen commented on FLINK-33940: --- [~mxm] There's no concrete rationale for selecting the

Re: [PR] [hotfix] Update copyright NOTICE year to 2024 [flink]

2024-01-02 Thread via GitHub
flinkbot commented on PR #24018: URL: https://github.com/apache/flink/pull/24018#issuecomment-1874115436 ## CI report: * 42c6079b521c50cc7e0e8017c29ce70f634688d3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] Update copyright NOTICE year to 2024 [flink]

2024-01-02 Thread via GitHub
caicancai commented on PR #24018: URL: https://github.com/apache/flink/pull/24018#issuecomment-1874107814 cc @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [hotfix] Update copyright NOTICE year to 2024 [flink]

2024-01-02 Thread via GitHub
caicancai opened a new pull request, #24018: URL: https://github.com/apache/flink/pull/24018 ## What is the purpose of the change Update copyright NOTICE year to 2024 ## Brief change log Update copyright NOTICE year to 2024 ## Verifying this change Update copyright

[jira] [Resolved] (FLINK-33433) Support invoke async-profiler on Jobmanager through REST API

2024-01-02 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-33433. -- Fix Version/s: 1.19.0 Resolution: Fixed merged in master:

[jira] [Commented] (FLINK-33940) Update the auto-derivation rule of max parallelism for enlarged upscaling space

2024-01-02 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801790#comment-17801790 ] Maximilian Michels commented on FLINK-33940: [~Zhanghao Chen] Thank you for the proposal. I

Re: [PR] [FLINK-33433][rest] Introduce async-profiler to support profiling Job… [flink]

2024-01-02 Thread via GitHub
Myasuka closed pull request #23820: [FLINK-33433][rest] Introduce async-profiler to support profiling Job… URL: https://github.com/apache/flink/pull/23820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2024-01-02 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1438684576 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +97,115 @@ public

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-02 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17801783#comment-17801783 ] Benchao Li commented on FLINK-33611: {quote}the main proposal here is to now reuse the variable

  1   2   >