Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-05 Thread via GitHub
1996fanrui commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1878373155 > I'm curious whether the [ArchUnit test still

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-05 Thread via GitHub
JunRuiLee commented on code in PR #24025: URL: https://github.com/apache/flink/pull/24025#discussion_r1442659438 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -385,7 +335,9 @@ private void configureStreamGraph(final

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-05 Thread via GitHub
JunRuiLee commented on code in PR #24025: URL: https://github.com/apache/flink/pull/24025#discussion_r1442658972 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java: ## @@ -614,7 +563,9 @@ private Collection

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-05 Thread via GitHub
JunRuiLee commented on code in PR #24025: URL: https://github.com/apache/flink/pull/24025#discussion_r1442656319 ## flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java: ## @@ -1201,6 +1212,9 @@ public void configure(ReadableConfig configuration,

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-05 Thread via GitHub
XComp commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1878363137 I'm curious whether the [ArchUnit test still

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-05 Thread via GitHub
JunRuiLee commented on code in PR #24025: URL: https://github.com/apache/flink/pull/24025#discussion_r1442654302 ## flink-core/src/main/java/org/apache/flink/api/common/cache/DistributedCache.java: ## @@ -228,6 +229,21 @@ public static List> parseCachedFilesFromSt

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-05 Thread via GitHub
1996fanrui commented on PR #22984: URL: https://github.com/apache/flink/pull/22984#issuecomment-1878358857 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-05 Thread via GitHub
1996fanrui commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1442632110 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration

Re: [PR] [FLINK-32570][runtime][stream] Deprecates @Public/@PublicEvolving API that uses Flink's Time classes [flink]

2024-01-05 Thread via GitHub
XComp commented on code in PR #22984: URL: https://github.com/apache/flink/pull/22984#discussion_r1442629925 ## flink-core/src/main/java/org/apache/flink/api/common/restartstrategy/RestartStrategies.java: ## @@ -72,9 +72,23 @@ public static RestartStrategyConfiguration

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-05 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803459#comment-17803459 ] Jufang He edited comment on FLINK-33856 at 1/5/24 8:39 AM: --- [~pnowojski] 

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-05 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803459#comment-17803459 ] Jufang He commented on FLINK-33856: --- [~pnowojski] Thanks for your advice. It seems that we need

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-05 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803450#comment-17803450 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 8:10 AM: - I had

[jira] [Comment Edited] (FLINK-33970) Add necessary checks for connector document

2024-01-05 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803450#comment-17803450 ] Zhongqiang Gong edited comment on FLINK-33970 at 1/5/24 8:07 AM: - I had

[jira] [Commented] (FLINK-33970) Add necessary checks for connector document

2024-01-05 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17803450#comment-17803450 ] Zhongqiang Gong commented on FLINK-33970: - jdbc action for test :

<    1   2