MartijnVisser commented on PR #87:
URL:
https://github.com/apache/flink-connector-jdbc/pull/87#issuecomment-1886531861
@zhilinli123 I still don't understand the Jira ticket, so I can't really
review it. Perhaps @snuyanzin or @eskabetxe understand the goal of this PR.
--
This is an
[
https://issues.apache.org/jira/browse/FLINK-34040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805414#comment-17805414
]
Matthias Pohl commented on FLINK-34040:
---
Yeah no. [~snuyanzin] also already gave the hint that it
[
https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805411#comment-17805411
]
Matthias Pohl edited comment on FLINK-34007 at 1/11/24 7:36 AM:
I still
[
https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805411#comment-17805411
]
Matthias Pohl commented on FLINK-34007:
---
I still don't fully understand the error you shared:
reswqa commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1448417073
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemoryManagerImpl.java:
##
@@ -385,7 +395,7 @@ private
xiangforever2014 commented on code in PR #24058:
URL: https://github.com/apache/flink/pull/24058#discussion_r1448416625
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -163,14 +163,16 @@ public static
zhilinli123 commented on PR #87:
URL:
https://github.com/apache/flink-connector-jdbc/pull/87#issuecomment-1886457713
PTAL: @MartijnVisser thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jiangxin369 commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1448384184
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartition.java:
##
@@ -187,6 +187,7 @@ public void
jiangxin369 commented on PR #23957:
URL: https://github.com/apache/flink/pull/23957#issuecomment-1886429024
@reswqa Thanks for the review, I've updated the PR, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LadyForest commented on code in PR #24030:
URL: https://github.com/apache/flink/pull/24030#discussion_r1448344823
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/TestData.scala:
##
@@ -756,6 +756,147 @@ object TestData {
LadyForest commented on code in PR #24030:
URL: https://github.com/apache/flink/pull/24030#discussion_r1448379812
##
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/utils/TestData.scala:
##
@@ -756,6 +756,147 @@ object TestData {
[
https://issues.apache.org/jira/browse/FLINK-33932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805398#comment-17805398
]
xiangyu feng commented on FLINK-33932:
--
[~masteryhx] Thx for ur reply, I've talked to [~dianer17]
LadyForest commented on code in PR #24030:
URL: https://github.com/apache/flink/pull/24030#discussion_r1446810962
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala:
##
@@ -279,19 +279,19 @@ object AggregateUtil
[
https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805392#comment-17805392
]
Yue Ma commented on FLINK-34050:
Hi [~lijinzhong]
Thanks for reporting this issue. We have also
flinkbot commented on PR #24069:
URL: https://github.com/apache/flink/pull/24069#issuecomment-1886378530
## CI report:
* 556acc2a010b25284766bb9eeed2e18f2a8c2eef UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-33946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-33946:
---
Labels: pull-request-available (was: )
> RocksDb sets setAvoidFlushDuringShutdown to true
mayuehappy opened a new pull request, #24069:
URL: https://github.com/apache/flink/pull/24069
set setAvoidFlushDuringShutdown to true for avoiding Flush when Cancel Task
## What is the purpose of the change
set setAvoidFlushDuringShutdown to true for avoiding Flush when
masteryhx commented on code in PR #24066:
URL: https://github.com/apache/flink/pull/24066#discussion_r1448341514
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -105,12 +105,14 @@ public boolean equals(Object o) {
[
https://issues.apache.org/jira/browse/FLINK-33881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu resolved FLINK-33881.
--
Resolution: Fixed
Thanks [~lijinzhong] for the great work!
merged 907d0f32 into master
>
masteryhx closed pull request #24057: [FLINK-33881]Avoid copy and update value
in TtlListState#getUnexpiredOrNull
URL: https://github.com/apache/flink/pull/24057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
masteryhx commented on PR #24057:
URL: https://github.com/apache/flink/pull/24057#issuecomment-1886347612
merged.
Just a reminder, remeber to write commit message with component tag next
time.
--
This is an automated message from the Apache Git Service.
To respond to the message,
flinkbot commented on PR #24068:
URL: https://github.com/apache/flink/pull/24068#issuecomment-1886331556
## CI report:
* fd074024357c148202e3ff3e218309480ba12569 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804983#comment-17804983
]
Renxiang Zhou edited comment on FLINK-34015 at 1/11/24 5:48 AM:
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805378#comment-17805378
]
Renxiang Zhou commented on FLINK-34015:
---
[~masteryhx] Many thanks to you, I will check it~(y)
>
[
https://issues.apache.org/jira/browse/FLINK-34049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-34049:
---
Labels: pull-request-available (was: )
> Refactor classes related to window TVF
xuyangzhong opened a new pull request, #24068:
URL: https://github.com/apache/flink/pull/24068
## What is the purpose of the change
Currently, the implementation of the window aggregate op with new WINDOW TVF
syntax is strongly bound to slicing windows such as TUMBLE, HOP and
[
https://issues.apache.org/jira/browse/FLINK-33325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805374#comment-17805374
]
Yu Chen commented on FLINK-33325:
-
Hi [~Zhanghao Chen] , thanks for your attention, the feature will be
[
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yue Ma updated FLINK-7:
---
Attachment: image-2024-01-11-12-03-14-308.png
> Expose IngestDB and ClipDB in the official RocksDB API
>
[
https://issues.apache.org/jira/browse/FLINK-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805364#comment-17805364
]
Yue Ma commented on FLINK-7:
Update: https://github.com/facebook/rocksdb/pull/12219
This PR fixes a
[
https://issues.apache.org/jira/browse/FLINK-34021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805363#comment-17805363
]
Rui Fan commented on FLINK-34021:
-
Merged to main(1.8.0) via : f67cba9c8269ddd4e27fcdc40cfd8a293ae665de
[
https://issues.apache.org/jira/browse/FLINK-34021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan resolved FLINK-34021.
-
Resolution: Fixed
> Print jobKey in the Autoscaler standalone log
>
1996fanrui merged PR #750:
URL: https://github.com/apache/flink-kubernetes-operator/pull/750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #750:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/750#issuecomment-1886189083
Thanks @mxm for the review, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Jane Chan created FLINK-34059:
-
Summary: Add documentation on how to use state TTL hint
Key: FLINK-34059
URL: https://issues.apache.org/jira/browse/FLINK-34059
Project: Flink
Issue Type:
1996fanrui commented on code in PR #24003:
URL: https://github.com/apache/flink/pull/24003#discussion_r1448255898
##
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java:
##
@@ -367,17 +367,13 @@ private void restartTasksWithDelay(final
[
https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu reassigned FLINK-33819:
Assignee: Yue Ma
> Support setting CompressType in RocksDBStateBackend
>
[
https://issues.apache.org/jira/browse/FLINK-33946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu reassigned FLINK-33946:
Assignee: Yue Ma (was: Hangxiang Yu)
> RocksDb sets setAvoidFlushDuringShutdown to true
[
https://issues.apache.org/jira/browse/FLINK-33946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu reassigned FLINK-33946:
Assignee: Hangxiang Yu
> RocksDb sets setAvoidFlushDuringShutdown to true to speed up
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805359#comment-17805359
]
Hangxiang Yu commented on FLINK-34015:
--
[~zhourenxiang] Fine, it's vaild.
I have assigned it to
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu reassigned FLINK-34015:
Assignee: Hangxiang Yu
> Setting `execution.savepoint.ignore-unclaimed-state` does not
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu reassigned FLINK-34015:
Assignee: Renxiang Zhou (was: Hangxiang Yu)
> Setting
masteryhx commented on code in PR #24058:
URL: https://github.com/apache/flink/pull/24058#discussion_r1448208494
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -163,14 +163,16 @@ public static SavepointRestoreSettings
[
https://issues.apache.org/jira/browse/FLINK-33946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805355#comment-17805355
]
Yue Ma commented on FLINK-33946:
[~masteryhx] thanks , I would like to take this and I'll draft the pr
WencongLiu closed pull request #23978: Test
URL: https://github.com/apache/flink/pull/23978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805354#comment-17805354
]
Yue Ma commented on FLINK-33819:
[~masteryhx] thanks , I would like to take this and I'll draft the pr
ljz2051 commented on code in PR #24066:
URL: https://github.com/apache/flink/pull/24066#discussion_r1448240936
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -105,12 +105,14 @@ public boolean equals(Object o) {
ljz2051 commented on code in PR #24066:
URL: https://github.com/apache/flink/pull/24066#discussion_r1448240936
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -105,12 +105,14 @@ public boolean equals(Object o) {
ljz2051 commented on code in PR #24066:
URL: https://github.com/apache/flink/pull/24066#discussion_r1448240936
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/SavepointRestoreSettings.java:
##
@@ -105,12 +105,14 @@ public boolean equals(Object o) {
[
https://issues.apache.org/jira/browse/FLINK-33009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805352#comment-17805352
]
Wencong Liu commented on FLINK-33009:
-
I've opened a pull request and CI has passed.
>
[
https://issues.apache.org/jira/browse/FLINK-33905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xintong Song closed FLINK-33905.
Resolution: Done
master (1.19): 06b46a9cbf0d8fa987bbde570510f75a7558f54d
> FLIP-382: Unify the
xintongsong closed pull request #23905: [FLINK-33905][core] Unify the Provision
of Diverse Metadata for Context-like APIs
URL: https://github.com/apache/flink/pull/23905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805349#comment-17805349
]
Renxiang Zhou edited comment on FLINK-34015 at 1/11/24 2:36 AM:
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805349#comment-17805349
]
Renxiang Zhou commented on FLINK-34015:
---
[~masteryhx] Yes, if we use the dynamic parameters to
[
https://issues.apache.org/jira/browse/FLINK-34015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805349#comment-17805349
]
Renxiang Zhou edited comment on FLINK-34015 at 1/11/24 2:35 AM:
Feng Jin created FLINK-34058:
Summary: Support optional parameters for named parameters
Key: FLINK-34058
URL: https://issues.apache.org/jira/browse/FLINK-34058
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-34055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Jin updated FLINK-34055:
-
Summary: Introduce a new annotation for named parameters (was: Introduce a
new annotation for named
Feng Jin created FLINK-34057:
Summary: Support named parameters for functions
Key: FLINK-34057
URL: https://issues.apache.org/jira/browse/FLINK-34057
Project: Flink
Issue Type: Sub-task
Feng Jin created FLINK-34056:
Summary: Support named parameters for procedures
Key: FLINK-34056
URL: https://issues.apache.org/jira/browse/FLINK-34056
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-32852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rui Fan updated FLINK-32852:
Fix Version/s: 1.19.0
> [JUnit5 Migration] The scheduler package of flink-runtime module
>
[
https://issues.apache.org/jira/browse/FLINK-32852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805348#comment-17805348
]
Rui Fan commented on FLINK-32852:
-
Merged to master(1.19) via a6412b8497d1fdb3c0137a1651767db33836d966
[
https://issues.apache.org/jira/browse/FLINK-34054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Jin updated FLINK-34054:
-
Summary: FLIP-387: Support named parameters for functions and procedures
(was: FLIP-387: Support named
1996fanrui merged PR #24062:
URL: https://github.com/apache/flink/pull/24062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
1996fanrui commented on PR #24062:
URL: https://github.com/apache/flink/pull/24062#issuecomment-1886099946
Thanks @RocMarshal for the review! Ci is green, merging~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Feng Jin created FLINK-34055:
Summary: Introduce a new annotation for named parameters.
Key: FLINK-34055
URL: https://issues.apache.org/jira/browse/FLINK-34055
Project: Flink
Issue Type:
lsyldliu commented on code in PR #23984:
URL: https://github.com/apache/flink/pull/23984#discussion_r1448202301
##
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/LongHashJoinGenerator.scala:
##
@@ -87,10 +90,11 @@ object
Feng Jin created FLINK-34054:
Summary: FLIP-387: Support named parameters for functions and call
procedures
Key: FLINK-34054
URL: https://issues.apache.org/jira/browse/FLINK-34054
Project: Flink
flinkbot commented on PR #24067:
URL: https://github.com/apache/flink/pull/24067#issuecomment-1886092566
## CI report:
* 5d2c318f914b6cc790dabdf318b1788d0e0128a6 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-34053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jane Chan reassigned FLINK-34053:
-
Assignee: xuyang
> Support state TTL hint for group aggregate
>
[
https://issues.apache.org/jira/browse/FLINK-30088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu updated FLINK-30088:
-
Component/s: Runtime / State Backends
> Excessive state updates for TtlMapState and
WencongLiu opened a new pull request, #24067:
URL: https://github.com/apache/flink/pull/24067
## What is the purpose of the change
*Revert the breaking change to the public implementations of RichFunction.
The original breaking change is applied by
[
https://issues.apache.org/jira/browse/FLINK-34053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805346#comment-17805346
]
xuyang commented on FLINK-34053:
Hi, [~qingyue] Can I take this jira?
> Support state TTL hint for
[
https://issues.apache.org/jira/browse/FLINK-34052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junrui Li updated FLINK-34052:
--
Component/s: Examples
> Missing TopSpeedWindowing and SessionWindowing JARs in Flink Maven Repository
Jane Chan created FLINK-34053:
-
Summary: Support state TTL hint for group aggregate
Key: FLINK-34053
URL: https://issues.apache.org/jira/browse/FLINK-34053
Project: Flink
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/FLINK-33583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jane Chan resolved FLINK-33583.
---
Fix Version/s: 1.19.0
Resolution: Fixed
> Support state TTL hint for regular join
>
[
https://issues.apache.org/jira/browse/FLINK-33583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jane Chan closed FLINK-33583.
-
> Support state TTL hint for regular join
> ---
>
>
[
https://issues.apache.org/jira/browse/FLINK-33583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805345#comment-17805345
]
Jane Chan commented on FLINK-33583:
---
Fixed in master 21403e31f4761bdddf5e4e802e0e5eb9b4533202
>
LadyForest merged PR #23752:
URL: https://github.com/apache/flink/pull/23752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reswqa commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1448184760
##
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/shuffle/TieredResultPartition.java:
##
@@ -187,6 +187,7 @@ public void
flinkbot commented on PR #24066:
URL: https://github.com/apache/flink/pull/24066#issuecomment-1886063614
## CI report:
* 96b1dc66449cb7782351ac379f78fdd0a29cb8ac UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-34051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-34051:
---
Labels: pull-request-available (was: )
> Fix equals/hashCode/toString for
masteryhx opened a new pull request, #24066:
URL: https://github.com/apache/flink/pull/24066
## What is the purpose of the change
SavepointRestoreSettings#equals/hashCode/toString missed restoreMode property
## Brief change log
- Add restoreMode property for
mas-chen commented on code in PR #44:
URL:
https://github.com/apache/flink-connector-kafka/pull/44#discussion_r1448066046
##
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/DynamicKafkaSource.java:
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache
snuyanzin opened a new pull request, #709:
URL: https://github.com/apache/flink-web/pull/709
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
sharath1709 commented on PR #23937:
URL: https://github.com/apache/flink/pull/23937#issuecomment-1885748350
@libenchao Could you review this PR again, it is updated as per our
discussion on the JIRA ticket and I also added a test case that fails without
the changes in this PR.
--
This
[
https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805294#comment-17805294
]
Zhenqiu Huang commented on FLINK-34007:
---
[~mapohl]
Yes, I mistakenly looked into the flink 1.17
[
https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805279#comment-17805279
]
Brad Atcheson commented on FLINK-34023:
---
Yes. I'll look into it, post a proposed solution approach
[
https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhenqiu Huang updated FLINK-34007:
--
Attachment: Debug.log
> Flink Job stuck in suspend state after losing leadership in HA Mode
>
davidradl commented on PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1885629516
> I haven't gone through all the code and comments yet, there are some
inline comments below, however, two questions came into my mind while reviewing
the PR:
>
> *
davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1447891687
##
flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java:
##
@@ -78,6 +79,8 @@ public class
mas-chen commented on code in PR #44:
URL:
https://github.com/apache/flink-connector-kafka/pull/44#discussion_r1447804230
##
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/DynamicKafkaSource.java:
##
@@ -0,0 +1,199 @@
+/*
+ * Licensed to the Apache
ferenc-csaky commented on PR #36:
URL:
https://github.com/apache/flink-connector-hbase/pull/36#issuecomment-1885437651
> @ferenc-csaky Want to take a look?
I'll review it in the next 2 days. Thanks for your contribution @MOBIN-F!
--
This is an automated message from the Apache Git
flinkbot commented on PR #24065:
URL: https://github.com/apache/flink/pull/24065#issuecomment-1885431512
## CI report:
* b779d13403028c290b803501a66f8c212a92ad8b UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
ferenc-csaky opened a new pull request, #24065:
URL: https://github.com/apache/flink/pull/24065
## What is the purpose of the change
Support fetching remote job JAR and additional artifacts (UDFs, formats,
dependencies, etc.) in nativa Kubernetes and standalone application mode. The
jeyhunkarimov commented on code in PR #23612:
URL: https://github.com/apache/flink/pull/23612#discussion_r1447763299
##
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlShowDatabasesConverter.java:
##
@@ -0,0 +1,51 @@
+/*
+ *
bvarghese1 commented on code in PR #24020:
URL: https://github.com/apache/flink/pull/24020#discussion_r1447722550
##
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/TableSourceScanTestPrograms.java:
##
@@ -0,0 +1,259 @@
+/*
+
bvarghese1 commented on code in PR #24020:
URL: https://github.com/apache/flink/pull/24020#discussion_r1447721761
##
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TableTestProgram.java:
##
@@ -198,6 +198,18 @@ public SqlTestStep
hlteoh37 commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1447650514
##
prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/PrometheusSinkWriter.java:
##
@@ -0,0 +1,267 @@
+/*
+ * Licensed to
XComp commented on PR #23970:
URL: https://github.com/apache/flink/pull/23970#issuecomment-1885215058
I triggered another workflow with lower timeouts:
https://github.com/XComp/flink/actions/runs/7478072394 ...to double-check that
running into time outs works as expected.
--
This is an
hlteoh37 commented on code in PR #1:
URL:
https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1447607637
##
amp-request-signer/pom.xml:
##
@@ -0,0 +1,63 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
[
https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805217#comment-17805217
]
Matthias Pohl commented on FLINK-34007:
---
The fix you shared ended up in 6.0.0. That would mean
1 - 100 of 174 matches
Mail list logo
