Re: [PR] [FLINK-34312][table] Improve the handling of default node types for named parameters [flink]

2024-02-01 Thread via GitHub
snuyanzin commented on code in PR #24235: URL: https://github.com/apache/flink/pull/24235#discussion_r1475692973 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -158,16 +160,17 @@ * Default implementation of {@link

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-01 Thread via GitHub
1996fanrui commented on code in PR #24246: URL: https://github.com/apache/flink/pull/24246#discussion_r1475680928 ## flink-tests/src/test/java/org/apache/flink/test/checkpointing/AutoRescalingITCase.java: ## @@ -328,7 +330,7 @@ public void testCheckpointRescalingNonPartitionedS

[jira] [Comment Edited] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813215#comment-17813215 ] Matthias Pohl edited comment on FLINK-34333 at 2/2/24 7:46 AM: ---

[jira] [Commented] (FLINK-34202) python tests take suspiciously long in some of the cases

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813537#comment-17813537 ] Matthias Pohl commented on FLINK-34202: --- https://dev.azure.com/apache-flink/apache

[jira] [Reopened] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-34007: --- I'm reopening the issue because we're seeing test instabilities now: * [https://dev.azure.com/

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-01 Thread via GitHub
1996fanrui commented on code in PR #24246: URL: https://github.com/apache/flink/pull/24246#discussion_r1475645896 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java: ## @@ -367,9 +367,11 @@ public static void waitForCheckpoint(JobID jobID, Mi

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-01 Thread via GitHub
1996fanrui commented on code in PR #24246: URL: https://github.com/apache/flink/pull/24246#discussion_r1475645896 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java: ## @@ -367,9 +367,11 @@ public static void waitForCheckpoint(JobID jobID, Mi

Re: [PR] [FLINK-34323][table-planner] Fix param name in session window tvf when using named params [flink]

2024-02-01 Thread via GitHub
xuyangzhong commented on code in PR #24243: URL: https://github.com/apache/flink/pull/24243#discussion_r1475601398 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala: ## @@ -257,4 +257,48 @@ class Window

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes [flink]

2024-02-01 Thread via GitHub
1996fanrui commented on PR #24248: URL: https://github.com/apache/flink/pull/24248#issuecomment-1923016887 org.apache.flink.test.checkpointing.AutoRescalingITCase#testCheckpointRescalingNonPartitionedStateCausesException hangs as well. I checked, all test jobs of AutoRescalingITCase

Re: [PR] [FLINK-34323][table-planner] Fix param name in session window tvf when using named params [flink]

2024-02-01 Thread via GitHub
hackergin commented on code in PR #24243: URL: https://github.com/apache/flink/pull/24243#discussion_r1475597199 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala: ## @@ -257,4 +257,48 @@ class WindowTa

Re: [PR] [FLINK-34323][table-planner] Fix param name in session window tvf when using named params [flink]

2024-02-01 Thread via GitHub
xuyangzhong commented on code in PR #24243: URL: https://github.com/apache/flink/pull/24243#discussion_r1475596548 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala: ## @@ -257,4 +257,48 @@ class Window

[jira] [Created] (FLINK-34338) An exception is thrown when some named params change order when using window tvf

2024-02-01 Thread xuyang (Jira)
xuyang created FLINK-34338: -- Summary: An exception is thrown when some named params change order when using window tvf Key: FLINK-34338 URL: https://issues.apache.org/jira/browse/FLINK-34338 Project: Flink

Re: [PR] [FLINK-26369][doc-zh] Translate the part zh-page mixed with not be translated. [flink]

2024-02-01 Thread via GitHub
Jiabao-Sun commented on code in PR #20340: URL: https://github.com/apache/flink/pull/20340#discussion_r1475595276 ## docs/content.zh/docs/deployment/ha/overview.md: ## @@ -74,18 +74,9 @@ Flink 提供了两种高可用服务实现: {{< top >}} -## JobResultStore - -The JobResultStore is used to arc

Re: [PR] [FLINK-34323][table-planner] Fix param name in session window tvf when using named params [flink]

2024-02-01 Thread via GitHub
xuyangzhong commented on code in PR #24243: URL: https://github.com/apache/flink/pull/24243#discussion_r1475591118 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/stream/sql/WindowTableFunctionTest.scala: ## @@ -257,4 +257,48 @@ class Window

Re: [PR] [FLINK-33396][table-planner] Fix table alias not be cleared in subquery [flink]

2024-02-01 Thread via GitHub
xuyangzhong commented on code in PR #24239: URL: https://github.com/apache/flink/pull/24239#discussion_r1475586086 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/hints/batch/NestLoopJoinHintTest.xml: ## @@ -679,8 +680,8 @@ HashJoin(join

Re: [PR] [FLINK-34337][core] Sink.InitContextWrapper should implement metadataConsumer method [flink]

2024-02-01 Thread via GitHub
flinkbot commented on PR #24249: URL: https://github.com/apache/flink/pull/24249#issuecomment-1922891781 ## CI report: * a57b0e7e04a2f3f3b61a7a5c2ed5f3e8cbae9f47 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34337][core] Sink.InitContextWrapper should implement metadataConsumer method [flink]

2024-02-01 Thread via GitHub
Jiabao-Sun commented on PR #24249: URL: https://github.com/apache/flink/pull/24249#issuecomment-1922891276 Hi @pvary, could you help review it when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-34192) Update flink-connector-kafka to be compatible with updated SinkV2 interfaces

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34192: --- Labels: pull-request-available (was: ) > Update flink-connector-kafka to be compatible with

[jira] [Resolved] (FLINK-34178) The ScalingTracking of autoscaler is wrong

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34178. - Fix Version/s: kubernetes-operator-1.8.0 Resolution: Fixed > The ScalingTracking of autoscaler is

[jira] [Commented] (FLINK-34178) The ScalingTracking of autoscaler is wrong

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813488#comment-17813488 ] Rui Fan commented on FLINK-34178: - Merged to main(1.8.0) via: * 2bd6b1b38171ce821509d46

[jira] [Comment Edited] (FLINK-34329) ScalingReport format tests fail locally on decimal format

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813487#comment-17813487 ] Rui Fan edited comment on FLINK-34329 at 2/2/24 5:54 AM: - Merged

[jira] [Resolved] (FLINK-34329) ScalingReport format tests fail locally on decimal format

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-34329. - Resolution: Fixed > ScalingReport format tests fail locally on decimal format >

[jira] [Commented] (FLINK-34329) ScalingReport format tests fail locally on decimal format

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813487#comment-17813487 ] Rui Fan commented on FLINK-34329: - Merged to main(1.9.0) via : 398a87c9012ddc79bfe4b2378

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
1996fanrui merged PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-34178][autoscaler] Fix the bug that observed scaling restart time is always great than `stabilization.interval` [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
1996fanrui commented on PR #759: URL: https://github.com/apache/flink-kubernetes-operator/pull/759#issuecomment-1922886105 Thanks for the review. I tested locally, it works fine, the tracking time is correct now. Merging~ -- This is an automated message from the Apache Git Service. To re

[jira] [Updated] (FLINK-34337) Sink.InitContextWrapper should implement metadataConsumer method

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34337: --- Labels: pull-request-available (was: ) > Sink.InitContextWrapper should implement metadataC

[PR] [FLINK-34337][core] Sink.InitContextWrapper should implement metadataConsumer method [flink]

2024-02-01 Thread via GitHub
Jiabao-Sun opened a new pull request, #24249: URL: https://github.com/apache/flink/pull/24249 ## What is the purpose of the change [FLINK-34337][core] Sink.InitContextWrapper should implement metadataConsumer method ## Brief change log Sink.InitContextWrapper sho

[jira] [Created] (FLINK-34337) Sink.InitContextWrapper should implement metadataConsumer method

2024-02-01 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-34337: -- Summary: Sink.InitContextWrapper should implement metadataConsumer method Key: FLINK-34337 URL: https://issues.apache.org/jira/browse/FLINK-34337 Project: Flink

Re: [PR] [FLINK-34329][autoscaler] Fix the bug that scaling report parser doesn't support Locale [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
1996fanrui merged PR #769: URL: https://github.com/apache/flink-kubernetes-operator/pull/769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34336: Description: AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang in  wait

Re: [PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes [flink]

2024-02-01 Thread via GitHub
flinkbot commented on PR #24248: URL: https://github.com/apache/flink/pull/24248#issuecomment-1922845516 ## CI report: * 9732c01c33a38cb989d9fb73a5838329f35d8f7e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34336: --- Labels: pull-request-available (was: ) > AutoRescalingITCase#testCheckpointRescalingWithKey

[PR] [FLINK-34336][test] Fix the bug that AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes [flink]

2024-02-01 Thread via GitHub
1996fanrui opened a new pull request, #24248: URL: https://github.com/apache/flink/pull/24248 ## Purpose AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang in waitForRunningTasks(restClusterClient, jobID, parallelism2); ## Reason: The job

[jira] [Updated] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34336: Description: AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang in  wait

[jira] [Created] (FLINK-34336) AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes

2024-02-01 Thread Rui Fan (Jira)
Rui Fan created FLINK-34336: --- Summary: AutoRescalingITCase#testCheckpointRescalingWithKeyedAndNonPartitionedState may hang sometimes Key: FLINK-34336 URL: https://issues.apache.org/jira/browse/FLINK-34336

Re: [PR] [FLINK-32075][FLIP-306][Checkpoint] Delete merged files on checkpoint abort or subsumption [flink]

2024-02-01 Thread via GitHub
fredia commented on code in PR #24181: URL: https://github.com/apache/flink/pull/24181#discussion_r1475523078 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/WithinCheckpointFileMergingSnapshotManager.java: ## @@ -50,6 +50,43 @@ public WithinCheckp

[jira] [Created] (FLINK-34335) Query hints in RexSubQuery could not be printed

2024-02-01 Thread xuyang (Jira)
xuyang created FLINK-34335: -- Summary: Query hints in RexSubQuery could not be printed Key: FLINK-34335 URL: https://issues.apache.org/jira/browse/FLINK-34335 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-34335) Query hints in RexSubQuery could not be printed

2024-02-01 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813470#comment-17813470 ] xuyang commented on FLINK-34335: I'll try to fix it. > Query hints in RexSubQuery could

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core package api-common [flink]

2024-02-01 Thread via GitHub
Jiabao-Sun commented on code in PR #23960: URL: https://github.com/apache/flink/pull/23960#discussion_r1475422173 ## flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java: ## @@ -603,55 +587,52 @@ public void testGetStatisticsMultipleOneFileWithCached

[jira] [Commented] (FLINK-34169) [benchmark] CI fails during test running

2024-02-01 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813469#comment-17813469 ] Yunfeng Zhou commented on FLINK-34169: -- Fixed in 8dd28a2e8bf10ec278ff90c99563468e29

[jira] [Commented] (FLINK-34295) Release Testing Instructions: Verify FLINK-33712 Deprecate RuntimeContext#getExecutionConfig

2024-02-01 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813465#comment-17813465 ] Junrui Li commented on FLINK-34295: --- [~lincoln.86xy] This change doesn't need cross te

[jira] [Commented] (FLINK-34296) Release Testing Instructions: Verify FLINK-33581 Deprecate configuration getters/setters that return/set complex Java objects

2024-02-01 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813466#comment-17813466 ] Junrui Li commented on FLINK-34296: --- [~lincoln.86xy] This change doesn't need cross te

[jira] [Updated] (FLINK-32514) FLIP-309: Support using larger checkpointing interval when source is processing backlog

2024-02-01 Thread Yunfeng Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunfeng Zhou updated FLINK-32514: - Release Note: ProcessingBacklog is introduced to demonstrate whether a record should be processe

[jira] [Commented] (FLINK-34299) Release Testing Instructions: Verify FLINK-33203 Adding a separate configuration for specifying Java Options of the SQL Gateway

2024-02-01 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813464#comment-17813464 ] Yangze Guo commented on FLINK-34299: This change doesn't need crossteam testing. >

[jira] [Closed] (FLINK-34299) Release Testing Instructions: Verify FLINK-33203 Adding a separate configuration for specifying Java Options of the SQL Gateway

2024-02-01 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo closed FLINK-34299. -- Resolution: Fixed > Release Testing Instructions: Verify FLINK-33203 Adding a separate > configuratio

[jira] [Closed] (FLINK-34258) Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction

2024-02-01 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-34258. - > Incorrect example of accumulator usage within emitUpdateWithRetract for > TableAggregateFunction > --

[jira] [Resolved] (FLINK-34258) Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction

2024-02-01 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-34258. --- Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master 0779c91e581dc16c4aef61d6cc27774f11495

[jira] [Assigned] (FLINK-34258) Incorrect example of accumulator usage within emitUpdateWithRetract for TableAggregateFunction

2024-02-01 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34258: - Assignee: Jane Chan > Incorrect example of accumulator usage within emitUpdateWithRetract for

Re: [PR] [FLINK-34258][docs][table] Fix incorrect retract example for TableAggregateFunction [flink]

2024-02-01 Thread via GitHub
LadyForest merged PR #24215: URL: https://github.com/apache/flink/pull/24215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [DRAFT][FLINK-33734] Merge unaligned checkpoint state handle [flink]

2024-02-01 Thread via GitHub
flinkbot commented on PR #24247: URL: https://github.com/apache/flink/pull/24247#issuecomment-1922655270 ## CI report: * 5d0a461e79a4b6446e73c171bac69482f9d3251f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33734) Merge unaligned checkpoint state handle

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33734: --- Labels: pull-request-available (was: ) > Merge unaligned checkpoint state handle >

[PR] [FLINK-33734] Merge unaligned checkpoint state handle [flink]

2024-02-01 Thread via GitHub
zoltar9264 opened a new pull request, #24247: URL: https://github.com/apache/flink/pull/24247 ## What is the purpose of the change Merge and serialize the state handles of unaligned checkpoint on TaskManager to potentially reduce checkpoint production time. Details in [FLINK-33734](h

[jira] [Commented] (FLINK-27054) Elasticsearch SQL connector SSL issue

2024-02-01 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813391#comment-17813391 ] Mingliang Liu commented on FLINK-27054: --- Any updates on this? My understanding is

Re: [PR] [FLINK-34111][table] Add JSON_QUOTE and JSON_UNQUOTE function [flink]

2024-02-01 Thread via GitHub
JingGe commented on PR #24156: URL: https://github.com/apache/flink/pull/24156#issuecomment-1922027269 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-01 Thread via GitHub
XComp commented on code in PR #24246: URL: https://github.com/apache/flink/pull/24246#discussion_r1474488421 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/CommonTestUtils.java: ## @@ -367,9 +367,11 @@ public static void waitForCheckpoint(JobID jobID, MiniClu

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
gyfora commented on PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#issuecomment-1921722522 @lajith2006 do you already have a Jira account? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Commented] (FLINK-34148) Potential regression (Jan. 13): stringWrite with Java8

2024-02-01 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813319#comment-17813319 ] Sergey Nuyanzin commented on FLINK-34148: - As it was decided in release meeting

[jira] [Commented] (FLINK-34132) Batch WordCount job fails when run with AdaptiveBatch scheduler

2024-02-01 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813316#comment-17813316 ] Wencong Liu commented on FLINK-34132: - Thanks for the reminding. [~zhuzh] I will add

Re: [PR] [FLINK-33089] Clean up 1.13 and 1.14 references from docs and code [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
mxm merged PR #768: URL: https://github.com/apache/flink-kubernetes-operator/pull/768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Updated] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34333: -- Description: FLINK-34007 revealed a bug in the k8s client v6.6.2 which we're using since Flin

[jira] [Closed] (FLINK-34319) Bump okhttp version to 4.12.0

2024-02-01 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-34319. -- Fix Version/s: kubernetes-operator-1.8.0 (was: 1.8.0) Assignee: ConradJ

Re: [PR] [FLINK-34319] Bump okhttp version to 4.12.0 [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
gyfora merged PR #766: URL: https://github.com/apache/flink-kubernetes-operator/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33557] Externalize Cassandra Python connector code [flink-connector-cassandra]

2024-02-01 Thread via GitHub
ferenc-csaky commented on PR #26: URL: https://github.com/apache/flink-connector-cassandra/pull/26#issuecomment-1921525300 @pvary @gaborgsomogyi JAR included, CI run passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-31220) Replace Pod with PodTemplateSpec for the pod template properties

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31220: --- Labels: pull-request-available (was: ) > Replace Pod with PodTemplateSpec for the pod templ

Re: [PR] [FLINK-31220] Replace Pod with PodTemplateSpec for the pod template properties [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
gyfora commented on PR #770: URL: https://github.com/apache/flink-kubernetes-operator/pull/770#issuecomment-1921435716 cc @afedulov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [FLINK-31220] Replace Pod with PodTemplateSpec for the pod template properties [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
gyfora opened a new pull request, #770: URL: https://github.com/apache/flink-kubernetes-operator/pull/770 ## What is the purpose of the change The PodTemplate fields in the CRD currently incorrectly use the Pod time, when they should be PodTemplateSpec type. This leads to unnecessary

Re: [PR] [hotfix] Remove unnecessary fields from podTemplate examples [flink-kubernetes-operator]

2024-02-01 Thread via GitHub
gyfora closed pull request #767: [hotfix] Remove unnecessary fields from podTemplate examples URL: https://github.com/apache/flink-kubernetes-operator/pull/767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-31472] Disable Intermittently failing throttling test [flink]

2024-02-01 Thread via GitHub
vahmed-hamdy commented on PR #24175: URL: https://github.com/apache/flink/pull/24175#issuecomment-1921379510 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Commented] (FLINK-34325) Inconsistent state with data loss after OutOfMemoryError

2024-02-01 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813238#comment-17813238 ] Alexis Sarda-Espinosa commented on FLINK-34325: --- I will say that, while I

[jira] [Comment Edited] (FLINK-34325) Inconsistent state with data loss after OutOfMemoryError

2024-02-01 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813238#comment-17813238 ] Alexis Sarda-Espinosa edited comment on FLINK-34325 at 2/1/24 1:49 PM: ---

[jira] [Updated] (FLINK-34325) Inconsistent state with data loss after OutOfMemoryError

2024-02-01 Thread Alexis Sarda-Espinosa (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexis Sarda-Espinosa updated FLINK-34325: -- Description: I have a job that uses broadcast state to maintain a cache of req

[jira] [Commented] (FLINK-34328) Release Testing Instructions: Verify FLINK-34037 Improve Serialization Configuration And Usage In Flink

2024-02-01 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813234#comment-17813234 ] lincoln lee commented on FLINK-34328: - [~Zhanghao Chen] Assigned to you :) > Releas

[jira] [Assigned] (FLINK-34328) Release Testing Instructions: Verify FLINK-34037 Improve Serialization Configuration And Usage In Flink

2024-02-01 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34328: --- Assignee: Zhanghao Chen > Release Testing Instructions: Verify FLINK-34037 Improve Serializ

[jira] [Commented] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813215#comment-17813215 ] Matthias Pohl commented on FLINK-34333: --- I think it's fine to do the upgrade from

Re: [PR] [FLINK-34200][test] Fix the bug that AutoRescalingITCase.testCheckpointRescalingInKeyedState fails occasionally [flink]

2024-02-01 Thread via GitHub
flinkbot commented on PR #24246: URL: https://github.com/apache/flink/pull/24246#issuecomment-1921304022 ## CI report: * 9eec91beb3f2ac2344454b9402ba2505201f0e49 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813205#comment-17813205 ] Rui Fan commented on FLINK-34200: - I have attached the detailed log in this JIRA. > Aut

[jira] [Updated] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34200: --- Labels: pull-request-available test-stability (was: test-stability) > AutoRescalingITCase#t

[jira] [Assigned] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-34200: --- Assignee: Rui Fan > AutoRescalingITCase#testCheckpointRescalingInKeyedState fails > ---

Re: [PR] Revert "[FLINK-33705] Upgrade to flink-shaded 18.0" [flink]

2024-02-01 Thread via GitHub
snuyanzin merged PR #24227: URL: https://github.com/apache/flink/pull/24227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] Revert "[FLINK-33705] Upgrade to flink-shaded 18.0" [flink]

2024-02-01 Thread via GitHub
snuyanzin commented on PR #24227: URL: https://github.com/apache/flink/pull/24227#issuecomment-1921276645 thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-01 Thread via GitHub
flinkbot commented on PR #24245: URL: https://github.com/apache/flink/pull/24245#issuecomment-1921277811 ## CI report: * 087ef9d4311dcacaa6d7e7caf15d9abce0e8fb95 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813201#comment-17813201 ] Rui Fan edited comment on FLINK-34200 at 2/1/24 12:59 PM: -- Afte

[jira] [Commented] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813201#comment-17813201 ] Rui Fan commented on FLINK-34200: - After re-run hundreds of times and adding a series of

[jira] [Comment Edited] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813199#comment-17813199 ] Matthias Pohl edited comment on FLINK-34333 at 2/1/24 12:55 PM: --

[jira] [Updated] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34333: --- Labels: pull-request-available (was: ) > Fix FLINK-34007 LeaderElector bug in 1.18 > --

[PR] [FLINK-34333][k8s] 1.18 backport of FLINK-34007 [flink]

2024-02-01 Thread via GitHub
XComp opened a new pull request, #24245: URL: https://github.com/apache/flink/pull/24245 ## What is the purpose of the change This is the fix of FLINK-34007 applied to Flink 1.18. In the end, it's a straight-forward backport including the upgrade to fabric8io:kubernetes-client v6.9.0

[jira] [Updated] (FLINK-34200) AutoRescalingITCase#testCheckpointRescalingInKeyedState fails

2024-02-01 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34200: Attachment: debug-34200.log > AutoRescalingITCase#testCheckpointRescalingInKeyedState fails >

[jira] [Comment Edited] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813199#comment-17813199 ] Matthias Pohl edited comment on FLINK-34333 at 2/1/24 12:48 PM: --

[jira] [Commented] (FLINK-34333) Fix FLINK-34007 LeaderElector bug in 1.18

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813199#comment-17813199 ] Matthias Pohl commented on FLINK-34333: --- Breaking changes between v6.6.2 and v6.9.

[jira] [Created] (FLINK-34334) Add sub-task level RocksDB file count metric

2024-02-01 Thread Jufang He (Jira)
Jufang He created FLINK-34334: - Summary: Add sub-task level RocksDB file count metric Key: FLINK-34334 URL: https://issues.apache.org/jira/browse/FLINK-34334 Project: Flink Issue Type: Improvemen

Re: [PR] [FLINK-33960][Scheduler] Fix the bug that Adaptive Scheduler doesn't respect the lowerBound when one flink job has more than 1 tasks [flink]

2024-02-01 Thread via GitHub
zentol commented on code in PR #24012: URL: https://github.com/apache/flink/pull/24012#discussion_r1474310073 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/SlotSharingSlotAllocator.java: ## @@ -301,27 +301,24 @@ public Collection getContai

Re: [PR] [FLINK-34312][table] Improve the handling of default node types for named parameters [flink]

2024-02-01 Thread via GitHub
hackergin commented on code in PR #24235: URL: https://github.com/apache/flink/pull/24235#discussion_r1474310557 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkSqlCallBinding.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-34312][table] Improve the handling of default node types for named parameters [flink]

2024-02-01 Thread via GitHub
hackergin commented on code in PR #24235: URL: https://github.com/apache/flink/pull/24235#discussion_r1474303521 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/FlinkSqlCallBinding.java: ## @@ -77,20 +76,15 @@ public List operands() {

Re: [PR] [FLINK-34312][table] Improve the handling of default node types for named parameters [flink]

2024-02-01 Thread via GitHub
hackergin commented on code in PR #24235: URL: https://github.com/apache/flink/pull/24235#discussion_r1474302721 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/inference/OperatorBindingCallContext.java: ## @@ -59,7 +59,7 @@ public Opera

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34007: -- Release Note: Fixes a bug where the leader election wasn't able to pick up leadership again af

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-02-01 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34007: -- Release Note: Fixes a bug where the leader election wasn't able to pick up leadership again af

[jira] [Commented] (FLINK-34229) Duplicate entry in InnerClasses attribute in class file FusionStreamOperator

2024-02-01 Thread Dan Zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813169#comment-17813169 ] Dan Zou commented on FLINK-34229: - [~xiasun] Could you please check if this [PR|https:/

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

2024-02-01 Thread via GitHub
zentol commented on code in PR #24244: URL: https://github.com/apache/flink/pull/24244#discussion_r1474268805 ## flink-end-to-end-tests/test-scripts/test_file_sink.sh: ## @@ -96,13 +51,54 @@ function get_complete_result { # line number in part files #

Re: [PR] [FLINK-34260][Connectors/AWS] Update flink-connector-aws to be compatible with updated SinkV2 interfaces [flink-connector-aws]

2024-02-01 Thread via GitHub
z3d1k commented on code in PR #127: URL: https://github.com/apache/flink-connector-aws/pull/127#discussion_r1474264702 ## flink-connector-aws/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java: ## @@ -284,7 +284,7 @

Re: [PR] [FLINK-34324][test] Makes all s3 related operations being declared and called in a single location [flink]

2024-02-01 Thread via GitHub
zentol commented on code in PR #24244: URL: https://github.com/apache/flink/pull/24244#discussion_r1474261856 ## flink-end-to-end-tests/test-scripts/test_file_sink.sh: ## @@ -96,13 +51,54 @@ function get_complete_result { # line number in part files #

  1   2   >