Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-03 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1477028925 ## prometheus-connector/src/main/java/org/apache/flink/connector/prometheus/sink/errorhandling/SinkWriterErrorHandlingBehaviorConfiguration.java: ## @@ -0,

Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-02-03 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1477031366 ## amp-request-signer/pom.xml: ## @@ -0,0 +1,60 @@ + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

[jira] [Assigned] (FLINK-34343) ResourceManager registration is not completed when registering the JobMaster

2024-02-03 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-34343: Assignee: Chesnay Schepler > ResourceManager registration is not completed when r

[jira] [Commented] (FLINK-34343) ResourceManager registration is not completed when registering the JobMaster

2024-02-03 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813902#comment-17813902 ] Chesnay Schepler commented on FLINK-34343: -- [~mapohl] and I looked at this toge

[jira] [Updated] (FLINK-34343) ResourceManager registration is not completed when registering the JobMaster

2024-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34343: --- Labels: pull-request-available test-stability (was: test-stability) > ResourceManager regis

Re: [PR] [FLINK-34343][rpc] Use actor path when rejecting early messages [flink]

2024-02-03 Thread via GitHub
flinkbot commented on PR #24258: URL: https://github.com/apache/flink/pull/24258#issuecomment-1925260957 ## CI report: * b511bb4434de6f182ebe9fefbd19eec1abb30793 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2024-02-03 Thread via GitHub
snuyanzin commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1925293405 I have a question about license it looks like we don't have any info about Elastic 8.x in NOTICE, should we add it or what is the best approach here? -- This is

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925300907 > After I check, I think there are other classes can be removed as well, such as: > > * TaskManagerRegistration > > * Note: It's `org.apache.flink.runtime.

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
1996fanrui commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925301702 > org.apache.flink.runtime.resourcemanager.slotmanager.SlotManagerConfigurationBuilder I saw that some classes are used, are you sure to delete them? It seems my IDEA doesn't

Re: [PR] [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support [flink-connector-elasticsearch]

2024-02-03 Thread via GitHub
reta commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1925311387 > Based on the info [1] it is no longer produced under Apache 2.0 license after 7.10 The ES Java Client license is still Apache [1] (it is an exemption) [1] h

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-03 Thread via GitHub
mateczagany commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1477106598 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/JobAutoScalerImpl.java: ## @@ -106,7 +107,13 @@ public void scale(Context ctx) throws

[jira] [Commented] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-02-03 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17813995#comment-17813995 ] Jeyhun Karimov commented on FLINK-33989: Hi [~flaviu.cicio], with the latest ver

Re: [PR] [FLINK-33396][table-planner] Fix table alias not be cleared in subquery [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24239: URL: https://github.com/apache/flink/pull/24239#discussion_r1477160533 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RelTreeWriterImpl.scala: ## @@ -286,4 +297,45 @@ class RelTreeWriterImpl

Re: [PR] [FLINK-33396][table-planner] Fix table alias not be cleared in subquery [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24239: URL: https://github.com/apache/flink/pull/24239#discussion_r1477160714 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RelTreeWriterImpl.scala: ## @@ -189,7 +191,16 @@ class RelTreeWriterImpl

[jira] [Updated] (FLINK-34345) Remove TaskExecutorManager related logic

2024-02-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-34345: Description: FLINK-31449 removed DeclarativeSlotManager related logic. Some related classes should be rem

Re: [PR] [FLINK-34345][runtime] Remove TaskExecutorManager related logic [flink]

2024-02-03 Thread via GitHub
caicancai commented on PR #24257: URL: https://github.com/apache/flink/pull/24257#issuecomment-1925552439 Thank you for your review and patient reply -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-33963) There is only one UDF instance after serializing the same task

2024-02-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814014#comment-17814014 ] xuyang commented on FLINK-33963: I agree that we should be more rigorous in our consider

[jira] [Comment Edited] (FLINK-33963) There is only one UDF instance after serializing the same task

2024-02-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814014#comment-17814014 ] xuyang edited comment on FLINK-33963 at 2/4/24 2:34 AM: I agree

[jira] [Commented] (FLINK-34304) Release Testing Instructions: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814015#comment-17814015 ] Shuai Xu commented on FLINK-34304: -- Minibatch join is ready. Users could improve perfor

Re: [PR] [FLINK-34217][docs] Update user doc for type serialization with FLIP-398 [flink]

2024-02-03 Thread via GitHub
reswqa commented on PR #24230: URL: https://github.com/apache/flink/pull/24230#issuecomment-1925557566 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (FLINK-34300) Release Testing Instructions: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814016#comment-17814016 ] Shuai Xu commented on FLINK-34300: -- Hi, [~xuyangzhong]. I'd like to take this verificat

[PR] [FLINK-33549][streaming-api] Enable AbstractStreamOperatorFactory to support YieldingOperatorFactory interface [flink]

2024-02-03 Thread via GitHub
xishuaidelin opened a new pull request, #24259: URL: https://github.com/apache/flink/pull/24259 …support YieldingOperatorFactory interface ## What is the purpose of the change This pull request makes AbstractStreamOperatorFactory to support YieldingOperatorFactory inter

[jira] [Updated] (FLINK-33549) Exception "Factory does not implement interface YieldingOperatorFactory" thrown in batch mode

2024-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33549: --- Labels: pull-request-available (was: ) > Exception "Factory does not implement interface Yi

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
LadyForest commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477163654 ## docs/content.zh/docs/dev/table/sql/queries/window-agg.md: ## @@ -124,12 +142,12 @@ Flink SQL> SELECT window_start, window_end, SUM(price) `GROUPING SETS` 窗口聚合中 `

Re: [PR] [FLINK-33549][streaming-api] Enable AbstractStreamOperatorFactory to support YieldingOperatorFactory interface [flink]

2024-02-03 Thread via GitHub
flinkbot commented on PR #24259: URL: https://github.com/apache/flink/pull/24259#issuecomment-1925561972 ## CI report: * a63ca588dd2f369d96308a7e00cbfd58475b2504 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Description: This is an umbrella ticket for the Flink 1.19 testing efforts. !screenshot-1.png!

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Attachment: screenshot-1.png > [Umbrella] Test Flink Release 1.19 > --

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Description: This is an umbrella ticket for the Flink 1.19 testing efforts. Please follow the st

[jira] [Assigned] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34298: - Assignee: (was: Jane Chan) > Release Testing Instructions: Verify FLINK-33397 Support Confi

[jira] [Created] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread xuyang (Jira)
xuyang created FLINK-34346: -- Summary: Release Testing: Verify FLINK-24024 Support session Window TVF Key: FLINK-34346 URL: https://issues.apache.org/jira/browse/FLINK-34346 Project: Flink Issue Typ

[jira] [Created] (FLINK-34347) Kubernetes native resource manager request wrong spec.

2024-02-03 Thread Ruibin Xing (Jira)
Ruibin Xing created FLINK-34347: --- Summary: Kubernetes native resource manager request wrong spec. Key: FLINK-34347 URL: https://issues.apache.org/jira/browse/FLINK-34347 Project: Flink Issue Ty

[jira] [Created] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-03 Thread xuyang (Jira)
xuyang created FLINK-34348: -- Summary: Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input Key: FLINK-34348 URL: https://issues.apache.org/jira/browse/FLINK-34348 Project: F

[jira] [Assigned] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34346: --- Assignee: (was: xuyang) > Release Testing: Verify FLINK-24024 Support session Window TV

[jira] [Updated] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34346: --- Description: Session window TVF is ready. Users can use Session window TVF aggregation instead of using leg

[jira] [Updated] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34348: --- Description: Window TVF aggregation supports changelog stream  is ready for testing. User can add a window

[jira] [Created] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
Shuai Xu created FLINK-34349: Summary: Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch Key: FLINK-34349 URL: https://issues.apache.org/jira/browse/FLINK-34349 Projec

[jira] [Updated] (FLINK-34350) Hugo cannot rebuild site for zh doc

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-34350: -- Component/s: Documentation > Hugo cannot rebuild site for zh doc > ---

[jira] [Created] (FLINK-34350) Hugo cannot rebuild site for zh doc

2024-02-03 Thread Jane Chan (Jira)
Jane Chan created FLINK-34350: - Summary: Hugo cannot rebuild site for zh doc Key: FLINK-34350 URL: https://issues.apache.org/jira/browse/FLINK-34350 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Xu updated FLINK-34349: - Description: Minibatch join is ready. Users could improve performance in regular stream join scenarios.

Re: [PR] [FLINK-34247][doc] Document FLIP-366: Support standard YAML for FLINK configuration [flink]

2024-02-03 Thread via GitHub
zhuzhurk commented on code in PR #24251: URL: https://github.com/apache/flink/pull/24251#discussion_r1477168412 ## docs/content/docs/deployment/config.md: ## @@ -27,16 +27,100 @@ under the License. # Configuration -All configuration is done in `conf/flink-conf.yaml`, which

Re: [PR] [FLINK-34217][docs] Update user doc for type serialization with FLIP-398 [flink]

2024-02-03 Thread via GitHub
X-czh commented on PR #24230: URL: https://github.com/apache/flink/pull/24230#issuecomment-1925568094 The UT failed due to an issue unrelated to this PR, rebased latest master and squashed commits to wait for CI -- This is an automated message from the Apache Git Service. To respond to th

[jira] (FLINK-34304) Release Testing Instructions: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread Shuai Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34304 ] Shuai Xu deleted comment on FLINK-34304: -- was (Author: JIRAUSER300096): Minibatch join is ready. Users could improve performance in regular stream join scenarios.  Someone can verify this feat

[jira] [Assigned] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34349: --- Assignee: (was: Shuai Xu) > Release Testing: Verify FLINK-34219 Introduce a new join op

[jira] [Assigned] (FLINK-34348) Release Testing: Verify FLINK-20281 Window aggregation supports changelog stream input

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34348: --- Assignee: (was: xuyang) > Release Testing: Verify FLINK-20281 Window aggregation suppor

[jira] [Commented] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Yubin Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814022#comment-17814022 ] Yubin Li commented on FLINK-34298: -- [~qingyue] I would like to take this, please assign

[jira] [Commented] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814024#comment-17814024 ] lincoln lee commented on FLINK-34346: - [~xu_shuai_] Assigned to you since you commen

[jira] [Assigned] (FLINK-34346) Release Testing: Verify FLINK-24024 Support session Window TVF

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-34346: --- Assignee: Shuai Xu > Release Testing: Verify FLINK-24024 Support session Window TVF > -

[jira] [Commented] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814027#comment-17814027 ] Jane Chan commented on FLINK-34298: --- Hi,  [~liyubin117], Thanks for volunteering. Assi

[jira] [Assigned] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34298: - Assignee: Yubin Li > Release Testing Instructions: Verify FLINK-33397 Support Configuring > Di

Re: [PR] [FLINK-34229][table] Set CodeGeneratorContext of outer class as ancestor context when generate inner classes to avoid naming conflicts [flink]

2024-02-03 Thread via GitHub
zoudan commented on PR #24228: URL: https://github.com/apache/flink/pull/24228#issuecomment-1925571822 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[PR] [FLINK-34265][doc] Add the doc of named parameters [flink]

2024-02-03 Thread via GitHub
hackergin opened a new pull request, #24260: URL: https://github.com/apache/flink/pull/24260 ## What is the purpose of the change *Add doc of named parameters* ## Brief change log - *Add doc of named parameters* ## Verifying this change Add doc

[jira] [Updated] (FLINK-34265) Add the doc of named parameters

2024-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34265: --- Labels: pull-request-available (was: ) > Add the doc of named parameters >

Re: [PR] [FLINK-34265][doc] Add the doc of named parameters [flink]

2024-02-03 Thread via GitHub
flinkbot commented on PR #24260: URL: https://github.com/apache/flink/pull/24260#issuecomment-1925572915 ## CI report: * 9ee08840d9ec17ba1dc03da272fa37669de01aff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477174266 ## docs/content/docs/dev/table/sql/queries/window-tvf.md: ## @@ -289,6 +289,100 @@ Here is an example invocation on the Bid table: +--+

Re: [PR] [FLINK-34247][doc] Document FLIP-366: Support standard YAML for FLINK configuration [flink]

2024-02-03 Thread via GitHub
JunRuiLee commented on PR #24251: URL: https://github.com/apache/flink/pull/24251#issuecomment-1925576425 Thanks @zhuzhurk , I've updated this pr, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-34247][doc] Document FLIP-366: Support standard YAML for FLINK configuration [flink]

2024-02-03 Thread via GitHub
zhuzhurk commented on code in PR #24251: URL: https://github.com/apache/flink/pull/24251#discussion_r1477179904 ## docs/content.zh/docs/deployment/cli.md: ## @@ -30,7 +30,7 @@ under the License. Flink provides a Command-Line Interface (CLI) `bin/flink` to run programs that ar

Re: [PR] [FLINK-34152] Tune heap memory of autoscaled jobs [flink-kubernetes-operator]

2024-02-03 Thread via GitHub
1996fanrui commented on code in PR #762: URL: https://github.com/apache/flink-kubernetes-operator/pull/762#discussion_r1477167226 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/state/AutoScalerStateStore.java: ## @@ -69,6 +70,13 @@ void storeParallelismOverrides(

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477182383 ## docs/content/docs/dev/table/sql/queries/window-tvf.md: ## @@ -289,6 +289,100 @@ Here is an example invocation on the Bid table: +--+

[jira] [Created] (FLINK-34351) Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
Jane Chan created FLINK-34351: - Summary: Release Testing: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint Key: FLINK-34351 URL: https://issues.apache.org/jira/browse/FLINK-34351

[jira] [Assigned] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan reassigned FLINK-34298: - Assignee: Jane Chan (was: Yubin Li) > Release Testing Instructions: Verify FLINK-33397 Support

[jira] [Updated] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-34298: -- Description: This ticket describes how to verify FLINK-33397: Support Configuring Different State TTL

[jira] [Resolved] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan resolved FLINK-34298. --- Resolution: Fixed I've added the instructions on how to verify the feature. > Release Testing Instr

[jira] [Commented] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814043#comment-17814043 ] Jane Chan commented on FLINK-34298: --- Hi, [~liyubin117]; according to the new workflow,

[jira] [Closed] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan closed FLINK-34298. - > Release Testing Instructions: Verify FLINK-33397 Support Configuring > Different State TTLs using SQL Hin

[jira] [Comment Edited] (FLINK-34298) Release Testing Instructions: Verify FLINK-33397 Support Configuring Different State TTLs using SQL Hint

2024-02-03 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814043#comment-17814043 ] Jane Chan edited comment on FLINK-34298 at 2/4/24 5:48 AM: --- Hi

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-02-03 Thread via GitHub
swuferhong closed pull request #24077: [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint URL: https://github.com/apache/flink/pull/24077 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477182383 ## docs/content/docs/dev/table/sql/queries/window-tvf.md: ## @@ -289,6 +289,100 @@ Here is an example invocation on the Bid table: +--+

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Attachment: screenshot-2.png > [Umbrella] Test Flink Release 1.19 > --

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Description: This is an umbrella ticket for the Flink 1.19 testing efforts. Please follow the st

[jira] [Updated] (FLINK-34285) [Umbrella] Test Flink Release 1.19

2024-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-34285: Description: This is an umbrella ticket for the Flink 1.19 testing efforts. Please follow the st

Re: [PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-02-03 Thread via GitHub
fengjiajie commented on PR #24212: URL: https://github.com/apache/flink/pull/24212#issuecomment-1925600132 Hi @1996fanrui , please take a look at this fix when you have a moment to see if it can be merged, or if I need to reach out to someone else? thanks. -- This is an automated message

[PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-02-03 Thread via GitHub
swuferhong opened a new pull request, #24077: URL: https://github.com/apache/flink/pull/24077 ## What is the purpose of the change This pr is aims to update the query hint docs to clarify the resolution of conflicts in kv hint and list hint. ## Brief change log

Re: [PR] [FLINK-34256][doc] Add a documentation section for minibatch join [flink]

2024-02-03 Thread via GitHub
lsyldliu commented on code in PR #24240: URL: https://github.com/apache/flink/pull/24240#discussion_r1477184327 ## docs/content/docs/dev/table/tuning.md: ## @@ -266,5 +266,23 @@ GROUP BY day Flink SQL optimizer can recognize the different filter arguments on the same distinct

[jira] [Updated] (FLINK-34256) Add a documentation section for minibatch join

2024-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34256: --- Labels: pull-request-available (was: ) > Add a documentation section for minibatch join > -

[jira] [Assigned] (FLINK-33981) File Descriptor References Not Released After Job Execution in MiniCluster Mode

2024-02-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-33981: --- Assignee: Feng Jiajie > File Descriptor References Not Released After Job Execution in MiniCluster

Re: [PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-02-03 Thread via GitHub
1996fanrui merged PR #24212: URL: https://github.com/apache/flink/pull/24212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477191963 ## docs/content.zh/docs/dev/table/sql/queries/window-tvf.md: ## @@ -30,10 +30,10 @@ under the License. Apache Flink 提供了如下 `窗口表值函数`(table-valued function, 缩写TVF)把

[jira] [Commented] (FLINK-33981) File Descriptor References Not Released After Job Execution in MiniCluster Mode

2024-02-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814046#comment-17814046 ] Rui Fan commented on FLINK-33981: - Hi [~fengjiajie] , would you mind backporting it to 1

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477192718 ## docs/content.zh/docs/dev/table/sql/queries/window-agg.md: ## @@ -124,12 +142,12 @@ Flink SQL> SELECT window_start, window_end, SUM(price) `GROUPING SETS` 窗口聚合中

Re: [PR] [FLINK-34313][doc] Update doc about session window tvf [flink]

2024-02-03 Thread via GitHub
xuyangzhong commented on code in PR #24250: URL: https://github.com/apache/flink/pull/24250#discussion_r1477192738 ## docs/content.zh/docs/dev/table/sql/queries/window-agg.md: ## @@ -113,6 +117,20 @@ Flink SQL> SELECT window_start, window_end, SUM(price) | 2020-04-15 08:10 | 20

Re: [PR] [FLINK-34034][docs] Update the query hint docs to clarify the resolution of conflicts in kv hint and list hint [flink]

2024-02-03 Thread via GitHub
LadyForest commented on code in PR #24077: URL: https://github.com/apache/flink/pull/24077#discussion_r1475434026 ## docs/content/docs/dev/table/sql/queries/hints.md: ## @@ -114,6 +114,42 @@ hintOption: | stringLiteral ``` +### Conflict Cases In Query Hints Review Com

[PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-02-03 Thread via GitHub
fengjiajie opened a new pull request, #24261: URL: https://github.com/apache/flink/pull/24261 This closes https://github.com/apache/flink/pull/24212 ## What is the purpose of the change When using MiniCluster mode, file descriptors like /tmp/minicluster_6e62ab17ab058e0d

[PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing … [flink]

2024-02-03 Thread via GitHub
fengjiajie opened a new pull request, #24262: URL: https://github.com/apache/flink/pull/24262 This closes https://github.com/apache/flink/pull/24212 ## What is the purpose of the change When using MiniCluster mode, file descriptors like /tmp/minicluster_6e62ab17ab058e0d

Re: [PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-02-03 Thread via GitHub
flinkbot commented on PR #24261: URL: https://github.com/apache/flink/pull/24261#issuecomment-1925610512 ## CI report: * a51edbb7b93d958103a4b783fc5402f7ab1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34229][table] Set CodeGeneratorContext of outer class as ancestor context when generate inner classes to avoid naming conflicts [flink]

2024-02-03 Thread via GitHub
lsyldliu commented on code in PR #24228: URL: https://github.com/apache/flink/pull/24228#discussion_r1477192926 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/sort/SortCodeGenerator.scala: ## @@ -41,12 +41,22 @@ import scala.collection.m

Re: [PR] [FLINK-33981][runtime] Fix not closing DirectoryStream after listing local state files [flink]

2024-02-03 Thread via GitHub
flinkbot commented on PR #24262: URL: https://github.com/apache/flink/pull/24262#issuecomment-1925611990 ## CI report: * b2dd522ec1fa4600ce536b3f78ce74ca5d12fbd0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34349) Release Testing: Verify FLINK-34219 Introduce a new join operator to support minibatch

2024-02-03 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814047#comment-17814047 ] xuyang commented on FLINK-34349: Hi, I'd like to take this verification. > Release Test