Re: [PR] [FLINK-34481][table] Migrate SetOpRewriteUtil to java [flink]

2024-02-22 Thread via GitHub
liuyongvs commented on PR #24358: URL: https://github.com/apache/flink/pull/24358#issuecomment-1958898435 hi @JingGe will you review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-34455] Move RestoreMode from flink-runtime to flink-core [flink]

2024-02-22 Thread via GitHub
fredia merged PR #24320: URL: https://github.com/apache/flink/pull/24320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Commented] (FLINK-34455) Move RestoreMode from flink-runtime to flink-core

2024-02-22 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819527#comment-17819527 ] Yanfei Lei commented on FLINK-34455: merged 80090c7 into master. > Move RestoreMode

[jira] [Resolved] (FLINK-34455) Move RestoreMode from flink-runtime to flink-core

2024-02-22 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-34455. Resolution: Resolved > Move RestoreMode from flink-runtime to flink-core > ---

Re: [PR] [FLINK-34455] Move RestoreMode from flink-runtime to flink-core [flink]

2024-02-22 Thread via GitHub
Zakelly commented on PR #24320: URL: https://github.com/apache/flink/pull/24320#issuecomment-1958974445 @fredia Thanks for your review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add JDBC 3.1.2 connector [flink-web]

2024-02-22 Thread via GitHub
snuyanzin commented on PR #707: URL: https://github.com/apache/flink-web/pull/707#issuecomment-1958974611 rebased to resolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-34485] Add URI/Configuration constructor to DynamicTemporaryAWSCredentialsProvider [flink]

2024-02-22 Thread via GitHub
gaborgsomogyi commented on PR #24360: URL: https://github.com/apache/flink/pull/24360#issuecomment-1958985279 The test failure is unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-34485] Add URI/Configuration constructor to DynamicTemporaryAWSCredentialsProvider [flink]

2024-02-22 Thread via GitHub
gaborgsomogyi commented on PR #24360: URL: https://github.com/apache/flink/pull/24360#issuecomment-1958985526 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure

2024-02-22 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819546#comment-17819546 ] Zakelly Lan commented on FLINK-34495: - Thanks for reporting this! But I'm afraid it

[jira] [Updated] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34050: --- Labels: pull-request-available (was: ) > Rocksdb state has space amplification after rescal

[PR] [FLINK-34050][state] Clean up useless files in deleted ranges during rescaling for RocksdbStateBackend [flink]

2024-02-22 Thread via GitHub
ljz2051 opened a new pull request, #24367: URL: https://github.com/apache/flink/pull/24367 ## What is the purpose of the change This pull request cleans up useless sst files within rocksdb during rescaling, which reclaims local disk space, reducing the space amplification problem cau

[jira] [Commented] (FLINK-34488) Integrate snapshot deployment into GHA nightly workflow

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819550#comment-17819550 ] Matthias Pohl commented on FLINK-34488: --- We should use the Apache Infra nightly sn

[jira] [Created] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-34496: Summary: Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil Key: FLINK-34496 URL: https://issues.apache.org/jira/browse/FLINK-34496 Project:

Re: [PR] [FLINK-33517] Implement restore tests for Values node [flink]

2024-02-22 Thread via GitHub
dawidwys merged PR #24114: URL: https://github.com/apache/flink/pull/24114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-34050][state] Clean up useless files in deleted ranges during rescaling for RocksdbStateBackend [flink]

2024-02-22 Thread via GitHub
flinkbot commented on PR #24367: URL: https://github.com/apache/flink/pull/24367#issuecomment-1959065683 ## CI report: * e5e4c71c5902c3ce3e1dc43b17c4336483356904 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-34496: - Description: This is a fun one! ExecNodeMetadataUtil and JsonSerdeUtil have a circular

[jira] [Closed] (FLINK-33517) Implement restore tests for Value node

2024-02-22 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-33517. Fix Version/s: 1.20.0 (was: 1.19.0) Resolution: Implemented

Re: [PR] [FLINK-34050][state] Clean up useless files in deleted ranges during rescaling for RocksdbStateBackend [flink]

2024-02-22 Thread via GitHub
StefanRRichter commented on code in PR #24367: URL: https://github.com/apache/flink/pull/24367#discussion_r1498971141 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBIncrementalCheckpointUtils.java: ## @@ -153,13 +

Re: [PR] [FLINK-34476][table-planner] Consider assignment operator during TVF column expansion [flink]

2024-02-22 Thread via GitHub
twalthr merged PR #24361: URL: https://github.com/apache/flink/pull/24361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

[jira] [Commented] (FLINK-34451) [Kubernetes Operator] Job with restarting TaskManagers uses wrong/misleading fallback approach

2024-02-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819563#comment-17819563 ] Gyula Fora commented on FLINK-34451: [~alexdchoffer] so, just to confirm: This issu

[jira] (FLINK-34451) [Kubernetes Operator] Job with restarting TaskManagers uses wrong/misleading fallback approach

2024-02-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34451 ] Gyula Fora deleted comment on FLINK-34451: was (Author: gyfora): [~alexdchoffer] so, just to confirm: This issue doesn't occur with Flink 1.18? (even with the adaptive scheduler) > [Kuberne

[jira] [Commented] (FLINK-34451) [Kubernetes Operator] Job with restarting TaskManagers uses wrong/misleading fallback approach

2024-02-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819564#comment-17819564 ] Gyula Fora commented on FLINK-34451: Which 1.18 version are you using? I have only t

[jira] [Commented] (FLINK-34451) [Kubernetes Operator] Job with restarting TaskManagers uses wrong/misleading fallback approach

2024-02-22 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819567#comment-17819567 ] Gyula Fora commented on FLINK-34451: I am only asking because there have been fixes

[jira] [Commented] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819568#comment-17819568 ] Chesnay Schepler commented on FLINK-34496: -- A quick fix would be moving JsonSer

Re: [PR] [FLINK-34485] Add URI/Configuration constructor to DynamicTemporaryAWSCredentialsProvider [flink]

2024-02-22 Thread via GitHub
zentol merged PR #24360: URL: https://github.com/apache/flink/pull/24360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Closed] (FLINK-34485) Token delegation doesn't work with Presto S3 filesystem

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-34485. Assignee: Chesnay Schepler Resolution: Fixed master: cf5bb80b5fd965928ff75d415dd93e0

[jira] [Commented] (FLINK-34471) Tune network memory as part of Autoscaler Memory Tuning

2024-02-22 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819578#comment-17819578 ] Maximilian Michels commented on FLINK-34471: Thanks! That would be very help

[jira] [Comment Edited] (FLINK-34471) Tune network memory as part of Autoscaler Memory Tuning

2024-02-22 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819578#comment-17819578 ] Maximilian Michels edited comment on FLINK-34471 at 2/22/24 10:18 AM:

[jira] [Commented] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li commented on FLINK-34050: - Here are the benchmark results before and aft

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:24 AM: ---

[jira] [Updated] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-34496: - Description: This is a fun one! ExecNodeMetadataUtil and JsonSerdeUtil have a circular

[jira] [Updated] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-34496: - Description: This is a fun one! ExecNodeMetadataUtil and JsonSerdeUtil have a circular

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:28 AM: ---

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:29 AM: ---

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:30 AM: ---

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:31 AM: ---

[jira] [Commented] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819583#comment-17819583 ] Matthias Pohl commented on FLINK-34495: --- Ah, thanks for pointing it out. I was alr

[jira] [Updated] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34495: -- Description: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57760&view

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:33 AM: ---

[jira] [Created] (FLINK-34497) Avoid using system classloader in SerializedThrowableDeserializer

2024-02-22 Thread jrthe42 (Jira)
jrthe42 created FLINK-34497: --- Summary: Avoid using system classloader in SerializedThrowableDeserializer Key: FLINK-34497 URL: https://issues.apache.org/jira/browse/FLINK-34497 Project: Flink Is

[jira] [Comment Edited] (FLINK-34050) Rocksdb state has space amplification after rescaling with DeleteRange

2024-02-22 Thread Jinzhong Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819579#comment-17819579 ] Jinzhong Li edited comment on FLINK-34050 at 2/22/24 10:36 AM: ---

[jira] [Updated] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34495: -- Summary: Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to File

[jira] [Updated] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34495: -- Description: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=57760&view

[jira] [Comment Edited] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819583#comment-17819583 ] Matthias Pohl edited comment on FLINK-34495 at 2/22/24 10:39 AM: -

[PR] [FLINK-34454] Introduce StateRecoveryOptions in flink-core and Rename options [flink]

2024-02-22 Thread via GitHub
Zakelly opened a new pull request, #24368: URL: https://github.com/apache/flink/pull/24368 ## What is the purpose of the change As one part of FLIP-406, This PR introduce the `StateRecoveryOptions` in flink-core, and move & rename all state-recovery-related options into. ## Bri

[jira] [Updated] (FLINK-34454) Introduce RecoveryOptions in flink-core

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34454: --- Labels: pull-request-available (was: ) > Introduce RecoveryOptions in flink-core >

[jira] [Updated] (FLINK-34454) Introduce StateRecoveryOptions in flink-core

2024-02-22 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-34454: Summary: Introduce StateRecoveryOptions in flink-core (was: Introduce RecoveryOptions in flink-co

[PR] [FLINK-34497][REST] Avoid using system classloader in SerializedThrowableDeserializer [flink]

2024-02-22 Thread via GitHub
jrthe42 opened a new pull request, #24369: URL: https://github.com/apache/flink/pull/24369 ## What is the purpose of the change When using Flink rest client in systems like spring boot, which are using [Executable Jar Format](https://docs.spring.io/spring-boot/docs/current/refere

[jira] [Updated] (FLINK-34497) Avoid using system classloader in SerializedThrowableDeserializer

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34497: --- Labels: pull-request-available (was: ) > Avoid using system classloader in SerializedThrowa

Re: [PR] [FLINK-34454] Introduce StateRecoveryOptions in flink-core and Rename options [flink]

2024-02-22 Thread via GitHub
flinkbot commented on PR #24368: URL: https://github.com/apache/flink/pull/24368#issuecomment-1959183526 ## CI report: * 643754c9698b758dbb145f14d222981fa53d5bc4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34497][REST] Avoid using system classloader in SerializedThrowableDeserializer [flink]

2024-02-22 Thread via GitHub
flinkbot commented on PR #24369: URL: https://github.com/apache/flink/pull/24369#issuecomment-1959183798 ## CI report: * 26bbaefa39593297e4316cc8ebef7b7d01d76cbe UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-34498) GSFileSystemFactory logs full Flink config

2024-02-22 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-34498: Summary: GSFileSystemFactory logs full Flink config Key: FLINK-34498 URL: https://issues.apache.org/jira/browse/FLINK-34498 Project: Flink Issue Type

[jira] [Commented] (FLINK-34471) Tune network memory as part of Autoscaler Memory Tuning

2024-02-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819590#comment-17819590 ] Rui Fan commented on FLINK-34471: - {quote}I realized point to point connections might be

[jira] [Commented] (FLINK-34471) Tune network memory as part of Autoscaler Memory Tuning

2024-02-22 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819591#comment-17819591 ] Maximilian Michels commented on FLINK-34471: Yes, that is exactly what I mea

[jira] [Created] (FLINK-34499) Configuration#toString should hide sensitive values

2024-02-22 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-34499: Summary: Configuration#toString should hide sensitive values Key: FLINK-34499 URL: https://issues.apache.org/jira/browse/FLINK-34499 Project: Flink I

Re: [PR] [FLINK-31192][connectors/dataGen] Fix dataGen takes too long to initi… [flink]

2024-02-22 Thread via GitHub
xuzhiwen1255 commented on PR #22010: URL: https://github.com/apache/flink/pull/22010#issuecomment-1959219838 I think so. I will modify it as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (FLINK-34476) Window TVFs with named parameters don't support column expansion

2024-02-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-34476. Resolution: Fixed Fixed in master: e622205d0b74c6cbaf6fef6d8c11a397cdc30284 Fixed in release-1.19:

[jira] [Closed] (FLINK-33028) FLIP-348: Make expanding behavior of virtual metadata columns configurable

2024-02-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-33028. Resolution: Fixed > FLIP-348: Make expanding behavior of virtual metadata columns configurable > -

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-22 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1499093498 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -890,13 +900,32 @@ public long getTaskManagerIdleS

[jira] [Commented] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-22 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819600#comment-17819600 ] Zakelly Lan commented on FLINK-34495: - [~mapohl] I would like to, but I have no idea

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-22 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1499111780 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManagerTest.java: ## @@ -594,6 +601,68 @@ private void testNotificati

Re: [PR] [FLINK-33859] Support OpenSearch v2 [flink-connector-opensearch]

2024-02-22 Thread via GitHub
snuyanzin commented on PR #38: URL: https://github.com/apache/flink-connector-opensearch/pull/38#issuecomment-1959277002 thanks for the feedback @reswqa >I just have one question: Since the legacy sink implementation (based on the sink function) is deprecated, why did we need to inc

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-22 Thread via GitHub
zentol commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1499111780 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManagerTest.java: ## @@ -594,6 +601,68 @@ private void testNotificati

Re: [PR] [Draft][bugfix] Move the deserialization of shuffleDescriptor to a separate … [flink]

2024-02-22 Thread via GitHub
caodizhou commented on PR #24115: URL: https://github.com/apache/flink/pull/24115#issuecomment-1959282007 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-22 Thread via GitHub
snuyanzin commented on code in PR #24035: URL: https://github.com/apache/flink/pull/24035#discussion_r1499119629 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/ProtoToRowConverter.java: ## @@ -68,17 +68,14 @@ public ProtoToRowConverte

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-22 Thread via GitHub
snuyanzin commented on code in PR #24035: URL: https://github.com/apache/flink/pull/24035#discussion_r1499119629 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/ProtoToRowConverter.java: ## @@ -68,17 +68,14 @@ public ProtoToRowConverte

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-22 Thread via GitHub
snuyanzin commented on code in PR #24035: URL: https://github.com/apache/flink/pull/24035#discussion_r1499120508 ## flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/serialize/RowToProtoConverter.java: ## @@ -59,7 +59,7 @@ public RowToProtoConverter(Ro

[jira] [Commented] (FLINK-34495) Resuming Savepoint (rocks, scale up, heap timers) end-to-end test failure due to FileNotFoundException

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819635#comment-17819635 ] Matthias Pohl commented on FLINK-34495: --- # The failed step {{Run e2e tests}} can b

Re: [PR] [FLINK-34152] Tune all directly observable memory types [flink-kubernetes-operator]

2024-02-22 Thread via GitHub
mxm merged PR #778: URL: https://github.com/apache/flink-kubernetes-operator/pull/778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[PR] [FLINK-34471] Tune network memory with memory tuning [flink-kubernetes-operator]

2024-02-22 Thread via GitHub
mxm opened a new pull request, #781: URL: https://github.com/apache/flink-kubernetes-operator/pull/781 This PR is a follow-up to #778 where we skipped tuning network memory based on the actual usage and kept it constant instead. In this PR, we calculate the maximum amount of memory required

[jira] [Updated] (FLINK-34471) Tune network memory as part of Autoscaler Memory Tuning

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34471: --- Labels: pull-request-available (was: ) > Tune network memory as part of Autoscaler Memory T

Re: [PR] [FLINK-34497][REST] Avoid using system classloader in SerializedThrowableDeserializer [flink]

2024-02-22 Thread via GitHub
zentol commented on code in PR #24369: URL: https://github.com/apache/flink/pull/24369#discussion_r1499199919 ## flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/SerializedThrowableDeserializer.java: ## @@ -47,7 +47,7 @@ public SerializedThrowable deserial

[jira] [Commented] (FLINK-34490) flink-connector-kinesis not correctly supporting credential chaining

2024-02-22 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819641#comment-17819641 ] Danny Cranmer commented on FLINK-34490: --- Assigning to [~a.pilipenko] to take a loo

[jira] [Assigned] (FLINK-34490) flink-connector-kinesis not correctly supporting credential chaining

2024-02-22 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer reassigned FLINK-34490: - Assignee: Aleksandr Pilipenko > flink-connector-kinesis not correctly supporting creden

[jira] [Updated] (FLINK-34449) Flink build took too long

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-34449: -- Affects Version/s: 1.17.2 > Flink build took too long > - > >

[jira] [Commented] (FLINK-34449) Flink build took too long

2024-02-22 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819649#comment-17819649 ] Matthias Pohl commented on FLINK-34449: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-33859] Support OpenSearch v2 [flink-connector-opensearch]

2024-02-22 Thread via GitHub
reta commented on PR #38: URL: https://github.com/apache/flink-connector-opensearch/pull/38#issuecomment-1959456788 > I would suggest to create a dedicated follow up task for that, WDYT? @snuyanzin fyi, we have https://github.com/apache/flink-connector-opensearch/pull/5 open -- T

Re: [PR] Add JDBC 3.1.2 connector [flink-web]

2024-02-22 Thread via GitHub
snuyanzin commented on PR #707: URL: https://github.com/apache/flink-web/pull/707#issuecomment-1959554100 content changes is a result of website rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add JDBC 3.1.2 connector [flink-web]

2024-02-22 Thread via GitHub
snuyanzin merged PR #707: URL: https://github.com/apache/flink-web/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

2024-02-22 Thread via GitHub
ferenc-csaky opened a new pull request, #42: URL: https://github.com/apache/flink-connector-hbase/pull/42 Took the as minimum change as possible approach. Some pinned/excluded dependencies probably can be cleaned up, but I'd rather do that separately to not involve too many changes. -- T

[jira] [Updated] (FLINK-34413) Drop support for HBase v1

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34413: --- Labels: pull-request-available (was: ) > Drop support for HBase v1 > --

Re: [PR] [FLINK-34413] Remove HBase 1.x connector files and deps [flink-connector-hbase]

2024-02-22 Thread via GitHub
ferenc-csaky commented on PR #42: URL: https://github.com/apache/flink-connector-hbase/pull/42#issuecomment-1959622208 cc @MartijnVisser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-22 Thread via GitHub
maosuhan commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-1959622425 @sharath1709 Thanks for the contribution. I'll also help to look into this PR also and I expect to finish it this week. cc @libenchao -- This is an automated message from the Apache

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-22 Thread via GitHub
echauchot commented on code in PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1499408610 ## _utils.sh: ## @@ -68,4 +68,15 @@ function set_pom_version { new_version=$1 ${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set -Dne

Re: [PR] [FLINK-34401][docs-zh] Translate "Flame Graphs" page into Chinese [flink]

2024-02-22 Thread via GitHub
lxliyou001 commented on PR #24279: URL: https://github.com/apache/flink/pull/24279#issuecomment-1959663357 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34363] Set artifact version to $project_version if $FLINK_VERSION is not set [flink-connector-shared-utils]

2024-02-22 Thread via GitHub
echauchot commented on code in PR #38: URL: https://github.com/apache/flink-connector-shared-utils/pull/38#discussion_r1499410517 ## _utils.sh: ## @@ -68,4 +68,15 @@ function set_pom_version { new_version=$1 ${MVN} org.codehaus.mojo:versions-maven-plugin:2.8.1:set -Dne

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2024-02-22 Thread via GitHub
maosuhan commented on code in PR #24035: URL: https://github.com/apache/flink/pull/24035#discussion_r1499433950 ## docs/content/docs/connectors/table/formats/protobuf.md: ## @@ -149,9 +149,12 @@ Format Options false Boolean - This option only works

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-22 Thread via GitHub
XComp commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1499457151 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -243,7 +253,7 @@ private void registerSlotManagerMe

Re: [PR] [FLINK-34427][runtime] Adds state check to requirementsCheck logic [flink]

2024-02-22 Thread via GitHub
XComp commented on code in PR #24309: URL: https://github.com/apache/flink/pull/24309#discussion_r1499457482 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -890,13 +900,32 @@ public long getTaskManagerIdleSi

Re: [PR] Update sql_functions.yml [flink]

2024-02-22 Thread via GitHub
hanyuzheng7 closed pull request #24297: Update sql_functions.yml URL: https://github.com/apache/flink/pull/24297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [FLINK-32261][table] Add built-in MAP_UNION function. [flink]

2024-02-22 Thread via GitHub
hanyuzheng7 commented on PR #22842: URL: https://github.com/apache/flink/pull/22842#issuecomment-1959740514 @snuyanzin can you help me do a code review again, Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Created] (FLINK-34500) Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread SuDewei (Jira)
SuDewei created FLINK-34500: --- Summary: Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources Key: FLINK-34500 URL: https://issues.apache.org/jira/browse/FLINK-34500 Project:

[jira] [Updated] (FLINK-34500) Release Testing: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread SuDewei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] SuDewei updated FLINK-34500: Description: This issue aims to verify [FLIP-367|https://cwiki.apache.org/confluence/pages/viewpage.actio

[jira] [Commented] (FLINK-34305) Release Testing Instructions: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread SuDewei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819715#comment-17819715 ] SuDewei commented on FLINK-34305: - [~lincoln.86xy] [~Zhanghao Chen] Hi, the docs is read

[jira] [Comment Edited] (FLINK-34305) Release Testing Instructions: Verify FLINK-33261 Support Setting Parallelism for Table/SQL Sources

2024-02-22 Thread SuDewei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819715#comment-17819715 ] SuDewei edited comment on FLINK-34305 at 2/22/24 4:30 PM: -- [~li

[jira] [Assigned] (FLINK-34499) Configuration#toString should hide sensitive values

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-34499: Assignee: Chesnay Schepler > Configuration#toString should hide sensitive values

[jira] [Assigned] (FLINK-34496) Classloading deadlock between ExecNodeMetadataUtil and JsonSerdeUtil

2024-02-22 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-34496: Assignee: Chesnay Schepler > Classloading deadlock between ExecNodeMetadataUtil a

[jira] [Updated] (FLINK-34499) Configuration#toString should hide sensitive values

2024-02-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34499: --- Labels: pull-request-available (was: ) > Configuration#toString should hide sensitive value

Re: [PR] [FLINK-34499] Configuration#toString hides sensitive values [flink]

2024-02-22 Thread via GitHub
flinkbot commented on PR #24370: URL: https://github.com/apache/flink/pull/24370#issuecomment-1959897297 ## CI report: * 4bcf3b36ec474e9c49760d2225c8e1bb87324541 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34496] Break circular dependency in static initializatio [flink]

2024-02-22 Thread via GitHub
zentol opened a new pull request, #24371: URL: https://github.com/apache/flink/pull/24371 `ExecNodeMetadataUtil` and `JsonSerdeUtil` have a circular dependency in their static initialization, which can cause a classloading lockup when 2 threads are running the class initialization of each c

  1   2   >