[jira] [Updated] (FLINK-34648) Avoid RPC time when apply SchemaChangeEvent to external system

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34648: --- Labels: pull-request-available (was: ) > Avoid RPC time when apply SchemaChangeEvent to ext

[jira] [Updated] (FLINK-34648) Avoid RPC time when apply SchemaChangeEvent to external system

2024-03-12 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LvYanquan updated FLINK-34648: -- Attachment: 截屏2024-03-12 14.55.09.png > Avoid RPC time when apply SchemaChangeEvent to external system

[jira] [Comment Edited] (FLINK-34648) Avoid RPC time when apply SchemaChangeEvent to external system

2024-03-12 Thread LvYanquan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825538#comment-17825538 ] LvYanquan edited comment on FLINK-34648 at 3/12/24 7:07 AM:

Re: [PR] [FLINK-34533][release] Add release note for version 1.19 [flink]

2024-03-12 Thread via GitHub
lincoln-lil commented on PR #24394: URL: https://github.com/apache/flink/pull/24394#issuecomment-1990932477 @snuyanzin Thanks for reviewing this! I've fixed these incorrect spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520965160 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/PartitionAggregateOperator.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache So

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520966653 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/PartitionAggregateOperatorTest.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apac

[jira] [Created] (FLINK-34653) Support table merging with route in Flink CDC

2024-03-12 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-34653: - Summary: Support table merging with route in Flink CDC Key: FLINK-34653 URL: https://issues.apache.org/jira/browse/FLINK-34653 Project: Flink Issue Type: N

[jira] [Updated] (FLINK-34653) Support table merging with route in Flink CDC

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34653: --- Labels: pull-request-available (was: ) > Support table merging with route in Flink CDC > --

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520970150 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/KeyedPartitionWindowedStreamITCase.java: ## @@ -0,0 +1,521 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-34533][release] Add release note for version 1.19 [flink]

2024-03-12 Thread via GitHub
snuyanzin commented on PR #24394: URL: https://github.com/apache/flink/pull/24394#issuecomment-1990943352 @lincoln-lil thanks a question: since tests are now executed against jdk 8, 11, 17, 21 should we add a note about jdk21 Beta support ? -- This is an automated message from the

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520972048 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/MapPartitionIteratorTest.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520972873 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MapPartitionOperator.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520973260 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MapPartitionOperator.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520975025 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MapPartitionIterator.java: ## @@ -0,0 +1,215 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520976445 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sortpartition/FixedLengthByteKeyAndValueComparator.java: ## @@ -0,0 +1,176 @@ +/* + *

Re: [PR] [DRAFT][FLINK-34440][formats][protobuf-confluent] add support for protobuf-confluent [flink]

2024-03-12 Thread via GitHub
anupamaggarwal commented on code in PR #24482: URL: https://github.com/apache/flink/pull/24482#discussion_r1520977487 ## flink-formats/flink-protobuf-confluent-registry/pom.xml: ## @@ -0,0 +1,171 @@ + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.

Re: [PR] [FLINK-34484][state] Split 'state.backend.local-recovery' into two options for checkpointing and recovery [flink]

2024-03-12 Thread via GitHub
ljz2051 commented on PR #24402: URL: https://github.com/apache/flink/pull/24402#issuecomment-1990952035 The pr has been rebased on master branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825551#comment-17825551 ] Matthias Pohl commented on FLINK-34227: --- https://github.com/apache/flink/actions/r

[jira] [Commented] (FLINK-29114) TableSourceITCase#testTableHintWithLogicalTableScanReuse sometimes fails with result mismatch

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825553#comment-17825553 ] Matthias Pohl commented on FLINK-29114: --- * https://dev.azure.com/apache-flink/apa

[jira] [Commented] (FLINK-34643) JobIDLoggingITCase failed

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825552#comment-17825552 ] Matthias Pohl commented on FLINK-34643: --- * https://dev.azure.com/apache-flink/apa

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1520985642 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sortpartition/FixedLengthByteKeyAndValueComparator.java: ## @@ -0,0 +1,176 @@ +/* + *

Re: [PR] [FLINK-34533][release] Add release note for version 1.19 [flink]

2024-03-12 Thread via GitHub
lincoln-lil commented on PR #24394: URL: https://github.com/apache/flink/pull/24394#issuecomment-1990984725 @snuyanzin This should be added, I'll add https://issues.apache.org/jira/browse/FLINK-33163. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
rmetzger commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1521014951 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,470 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-0

[jira] [Updated] (FLINK-34543) Support Full Partition Processing On Non-keyed DataStream

2024-03-12 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wencong Liu updated FLINK-34543: Description: Introduce the PartitionWindowedStream and provide multiple full window operations in

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1507274806 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -104,15 +113,101 @@ void testNonParti

[jira] [Commented] (FLINK-31472) AsyncSinkWriterThrottlingTest failed with Illegal mailbox thread

2024-03-12 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825567#comment-17825567 ] Ahmed Hamdy commented on FLINK-31472: - [~lincoln.86xy] [~mapohl] Hello, could you p

Re: [PR] [FLINK-25544][streaming][JUnit5 Migration] The runtime package of module flink-stream-java [flink]

2024-03-12 Thread via GitHub
JingGe commented on PR #24483: URL: https://github.com/apache/flink/pull/24483#issuecomment-1991049712 @Jiabao-Sun thanks driving this. Since this PR is huge and contains 117 changed files. Would you like to summarise all changes in the "Brief change log" section to help reviewers do their

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521036729 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -83,157 +110,193 @@ void after() {

[jira] [Created] (FLINK-34654) Add "Special Thanks" Page on the Flink Website

2024-03-12 Thread Jark Wu (Jira)
Jark Wu created FLINK-34654: --- Summary: Add "Special Thanks" Page on the Flink Website Key: FLINK-34654 URL: https://issues.apache.org/jira/browse/FLINK-34654 Project: Flink Issue Type: New Feature

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
reswqa commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1521091212 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/sortpartition/FixedLengthByteKeyAndValueComparator.java: ## @@ -0,0 +1,176 @@ +/* + * Lice

[jira] [Closed] (FLINK-34528) Disconnect TM in JM when TM was killed to further reduce the job restart time

2024-03-12 Thread junzhong qin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] junzhong qin closed FLINK-34528. Resolution: Won't Do > Disconnect TM in JM when TM was killed to further reduce the job restart ti

Re: [PR] feat: autoscaling decision parallelism improvement [FLINK-34563] [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
Yang-LI-CS commented on PR #787: URL: https://github.com/apache/flink-kubernetes-operator/pull/787#issuecomment-1991128610 > I have some concerns about this change: > > 1. It doesn't work with custom slot sharing configuration which is very common > 2. It provides almost no benefi

Re: [PR] feat: autoscaling decision parallelism improvement [FLINK-34563] [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
Yang-LI-CS closed pull request #787: feat: autoscaling decision parallelism improvement [FLINK-34563] URL: https://github.com/apache/flink-kubernetes-operator/pull/787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521110459 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1991138575 @masteryhx Thanks for the PR, I took a quick look and had some questions, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
fredia commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521110459 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521128496 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -70,6 +85,11 @@ private static M

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on code in PR #24418: URL: https://github.com/apache/flink/pull/24418#discussion_r1521151391 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/filemerging/BlockingPhysicalFilePool.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521155291 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -96,6 +99,22 @@ private FileSystemOu

[jira] [Updated] (FLINK-34654) Add "Special Thanks" Page on the Flink Website

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34654: --- Labels: pull-request-available (was: ) > Add "Special Thanks" Page on the Flink Website > -

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521155291 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemOutputFormat.java: ## @@ -96,6 +99,22 @@ private FileSystemOu

[PR] [FLINK-34618][table] Migrate SplitPythonConditionFromJoinRule to java. [flink]

2024-03-12 Thread via GitHub
damumu0625 opened a new pull request, #24486: URL: https://github.com/apache/flink/pull/24486 ## What is the purpose of the change The PR migrates SplitPythonConditionFromJoinRule to java it doesn't touch SplitPythonConditionFromJoinRuleTest to be sure that java version con

[jira] [Updated] (FLINK-34618) Migrate SplitPythonConditionFromJoinRule

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34618: --- Labels: pull-request-available (was: ) > Migrate SplitPythonConditionFromJoinRule > ---

Re: [PR] [FLINK-34618][table] Migrate SplitPythonConditionFromJoinRule to java. [flink]

2024-03-12 Thread via GitHub
flinkbot commented on PR #24486: URL: https://github.com/apache/flink/pull/24486#issuecomment-1991230364 ## CI report: * 83e67a1d6988fe08173cdbcf161f6097dde2fecb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-34654] Add Special Thanks Page on the Flink Website [flink-web]

2024-03-12 Thread via GitHub
rmetzger commented on code in PR #725: URL: https://github.com/apache/flink-web/pull/725#discussion_r1521186823 ## docs/content/what-is-flink/special-thanks.md: ## @@ -0,0 +1,48 @@ +--- +title: Special Thanks +bookCollapseSection: false +weight: 9 +--- + + +# Special Thanks + +#

Re: [PR] [FLINK-34654] Add Special Thanks Page on the Flink Website [flink-web]

2024-03-12 Thread via GitHub
Zakelly commented on code in PR #725: URL: https://github.com/apache/flink-web/pull/725#discussion_r1521191193 ## docs/content/what-is-flink/special-thanks.md: ## @@ -0,0 +1,48 @@ +--- +title: Special Thanks +bookCollapseSection: false +weight: 9 +--- + + +# Special Thanks + +##

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521195360 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -37,24 +39,44 @@ import java.io

Re: [PR] [FLINK-34654] Add Special Thanks Page on the Flink Website [flink-web]

2024-03-12 Thread via GitHub
wuchong commented on code in PR #725: URL: https://github.com/apache/flink-web/pull/725#discussion_r1521200340 ## docs/content/what-is-flink/special-thanks.md: ## @@ -0,0 +1,48 @@ +--- +title: Special Thanks +bookCollapseSection: false +weight: 9 +--- + + +# Special Thanks + +##

Re: [PR] [FLINK-34654] Add Special Thanks Page on the Flink Website [flink-web]

2024-03-12 Thread via GitHub
wuchong commented on PR #725: URL: https://github.com/apache/flink-web/pull/725#issuecomment-1991281258 @dannycranmer @hlteoh37 could you help to review the AWS part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-32076][checkpoint] Introduce file pool to reuse files [flink]

2024-03-12 Thread via GitHub
masteryhx commented on PR #24418: URL: https://github.com/apache/flink/pull/24418#issuecomment-1991306532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1521248255 ## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ## @@ -282,7 +278,7 @@ private FileSystemOu

[jira] [Created] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Rui Fan (Jira)
Rui Fan created FLINK-34655: --- Summary: Autoscaler doesn't work for flink 1.15 Key: FLINK-34655 URL: https://issues.apache.org/jira/browse/FLINK-34655 Project: Flink Issue Type: Bug Compon

Re: [PR] [FLINK-34615]Split `ExternalizedCheckpointCleanup` out of `Checkpoint… [flink]

2024-03-12 Thread via GitHub
Zakelly commented on code in PR #24461: URL: https://github.com/apache/flink/pull/24461#discussion_r1521260155 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/CheckpointConfig.java: ## @@ -520,12 +521,40 @@ public void setTolerableCheckpointFailu

[PR] [FLINK-34655] Autoscaler doesn't work for flink 1.15 [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
1996fanrui opened a new pull request, #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797 flink-ubernetes-operator is committed to supporting the latest 4 flink minor versions, and autoscaler is a part of flink-ubernetes-operator. Currently, the latest 4 flink minor vers

[jira] [Updated] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34655: --- Labels: pull-request-available (was: ) > Autoscaler doesn't work for flink 1.15 > -

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-03-12 Thread via GitHub
wckdman commented on PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#issuecomment-1991405676 Any news here? :) I'm really looking forward to see this feature 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825639#comment-17825639 ] Matthias Pohl commented on FLINK-34227: --- My suspicion is that there's a bug in the

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825639#comment-17825639 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 11:24 AM: -

Re: [PR] [FLINK-33925][connectors/opensearch] Allow customising bulk failure handling [flink-connector-opensearch]

2024-03-12 Thread via GitHub
hajimeni commented on PR #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1991441614 Hey @schulzp. Thank you for creating this PR. It would be very helpful if this PR gets merged. The CI error seems to be caused by differences in files under the `a

Re: [PR] [FLINK-29114][connector][filesystem] Fix issue of file overwriting caused by multiple writes to the same sink table and shared staging directory [flink]

2024-03-12 Thread via GitHub
LadyForest commented on PR #24390: URL: https://github.com/apache/flink/pull/24390#issuecomment-1991461563 Hi [XComp](https://github.com/XComp), thanks so much for the time and effort you've put into the review and discussion :) -- This is an automated message from the Apache Git Service.

Re: [PR] [FLINK-34543][datastream]Support Full Partition Processing On Non-keyed DataStream [flink]

2024-03-12 Thread via GitHub
WencongLiu commented on code in PR #24398: URL: https://github.com/apache/flink/pull/24398#discussion_r1521322872 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/MapPartitionOperator.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-34152][autoscaler] Refactor the MemoryTuning to avoid the huge method [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
mxm commented on code in PR #795: URL: https://github.com/apache/flink-kubernetes-operator/pull/795#discussion_r1521324931 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java: ## @@ -92,24 +99,51 @@ public static ConfigChanges tuneTaskManagerM

Re: [PR] feat: autoscaling decision parallelism improvement [FLINK-34563] [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
mxm commented on PR #787: URL: https://github.com/apache/flink-kubernetes-operator/pull/787#issuecomment-1991480345 I think there are some really good ideas in this PR which we might consider in the future, but for the sake of simplicity it might be better to leave things as-is for now. Th

[jira] [Commented] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825655#comment-17825655 ] Gyula Fora commented on FLINK-34655: The bigger issue is that aggregated busy time m

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825654#comment-17825654 ] Matthias Pohl commented on FLINK-34227: --- The [findings of my initial analysis|htt

[jira] [Commented] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825656#comment-17825656 ] Gyula Fora commented on FLINK-34655: But the vertex parallelism overrides feature wa

[jira] [Updated] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-34655: --- Priority: Major (was: Blocker) > Autoscaler doesn't work for flink 1.15 > -

[jira] [Commented] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825657#comment-17825657 ] Gyula Fora commented on FLINK-34655: Also this issue is fixed in the Kubernetes-oper

[jira] [Comment Edited] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825657#comment-17825657 ] Gyula Fora edited comment on FLINK-34655 at 3/12/24 12:12 PM:

Re: [PR] [FLINK-34655] Autoscaler doesn't work for flink 1.15 [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
gyfora commented on PR #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797#issuecomment-1991512469 Instead of a new rest client you could also do what is done in the Kubernetes-operator module, see: https://github.com/apache/flink-kubernetes-operator/blob/main/flink-

Re: [PR] [FLINK-34655] Autoscaler doesn't work for flink 1.15 [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
gyfora commented on PR #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797#issuecomment-1991513679 But still it will not make it work fully for 1.15 as the aggregated metrics need to be back ported on the Flink side (similar to other features required for the autoscaler

Re: [PR] [FLINK-34655] Autoscaler doesn't work for flink 1.15 [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
1996fanrui commented on PR #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797#issuecomment-1991537856 Thanks @gyfora for the valuable feedback! > Instead of a new rest client you could also do what is done in the Kubernetes-operator module, see: https://github.

Re: [PR] [FLINK-34655] Autoscaler doesn't work for flink 1.15 [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
gyfora commented on PR #797: URL: https://github.com/apache/flink-kubernetes-operator/pull/797#issuecomment-1991544918 > Thanks @gyfora for the valuable feedback! > > > Instead of a new rest client you could also do what is done in the Kubernetes-operator module, see: https://github

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825654#comment-17825654 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 1:00 PM: --

[jira] [Commented] (FLINK-34655) Autoscaler doesn't work for flink 1.15

2024-03-12 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825669#comment-17825669 ] Rui Fan commented on FLINK-34655: - {quote}But the vertex parallelism overrides feature w

Re: [PR] [FLINK-34152][autoscaler] Refactor the MemoryTuning to avoid the huge method [flink-kubernetes-operator]

2024-03-12 Thread via GitHub
1996fanrui commented on code in PR #795: URL: https://github.com/apache/flink-kubernetes-operator/pull/795#discussion_r1521431571 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/tuning/MemoryTuning.java: ## @@ -92,24 +99,51 @@ public static ConfigChanges tuneTaskM

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825654#comment-17825654 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 1:09 PM: --

Re: [PR] [FLINK-34334][state] Add sub-task level RocksDB file count metrics [flink]

2024-03-12 Thread via GitHub
hejufang commented on code in PR #24322: URL: https://github.com/apache/flink/pull/24322#discussion_r1521505824 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBProperty.java: ## @@ -31,55 +31,92 @@ */ @Internal

[jira] [Created] (FLINK-34656) Generated code for `ITEM` operator should return null when getting element of a null map/array/row

2024-03-12 Thread yisha zhou (Jira)
yisha zhou created FLINK-34656: -- Summary: Generated code for `ITEM` operator should return null when getting element of a null map/array/row Key: FLINK-34656 URL: https://issues.apache.org/jira/browse/FLINK-34656

[jira] [Commented] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825698#comment-17825698 ] Matthias Pohl commented on FLINK-34227: --- [~chesnay] supported the investigation. H

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
lincoln-lil commented on PR #721: URL: https://github.com/apache/flink-web/pull/721#issuecomment-1991840142 @xintongsong @rmoff As per the conclusion of our discussion, I've tweaked these examples and tried to keep them to just describing what the functionality looks like (and avoiding over

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
lincoln-lil commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1521623410 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,456 @@ +--- Review Comment: @MartijnVisser As we discussed at the sync meeting, I've added the

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825698#comment-17825698 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 3:12 PM: --

[jira] [Commented] (FLINK-23542) Upgrade Checkstyle to at least 8.29

2024-03-12 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825712#comment-17825712 ] Ryan Skraba commented on FLINK-23542: - This has become slightly more important : the

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825698#comment-17825698 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 3:20 PM: --

Re: [PR] [FLINK-34533][release] Add release note for version 1.19 [flink]

2024-03-12 Thread via GitHub
lincoln-lil commented on code in PR #24394: URL: https://github.com/apache/flink/pull/24394#discussion_r1521683726 ## docs/content.zh/release-notes/flink-1.19.md: ## @@ -0,0 +1,362 @@ +--- +title: "Release Notes - Flink 1.19" +--- + + +# Release notes - Flink 1.19 + +These relea

[jira] [Comment Edited] (FLINK-34227) Job doesn't disconnect from ResourceManager

2024-03-12 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825698#comment-17825698 ] Matthias Pohl edited comment on FLINK-34227 at 3/12/24 3:45 PM: --

[PR] [hotfix] In case of unexpected errors do not loose the primary failur [flink]

2024-03-12 Thread via GitHub
pnowojski opened a new pull request, #24487: URL: https://github.com/apache/flink/pull/24487 Unexpected error can be for example NPE ## Verifying this change This ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add

Re: [PR] [hotfix] In case of unexpected errors do not loose the primary failur [flink]

2024-03-12 Thread via GitHub
flinkbot commented on PR #24487: URL: https://github.com/apache/flink/pull/24487#issuecomment-1992068365 ## CI report: * d07a37b06fc847c1f2c6ce148a918c2490f2490c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix] In case of unexpected errors do not loose the primary failur [flink]

2024-03-12 Thread via GitHub
rkhachatryan commented on code in PR #24487: URL: https://github.com/apache/flink/pull/24487#discussion_r1521803705 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -1046,27 +1046,32 @@ private void onTriggerFailure(

Re: [PR] [hotfix] In case of unexpected errors do not loose the primary failur [flink]

2024-03-12 Thread via GitHub
rkhachatryan commented on code in PR #24487: URL: https://github.com/apache/flink/pull/24487#discussion_r1521803705 ## flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java: ## @@ -1046,27 +1046,32 @@ private void onTriggerFailure(

Re: [PR] Modify BarrierAlignmentUtilTest comments [flink]

2024-03-12 Thread via GitHub
HCTommy commented on PR #24476: URL: https://github.com/apache/flink/pull/24476#issuecomment-1992162943 @zhuzhurk Hi, I fixed a grammar error in the comments when testing the barrier. Could you please review in your available time. -- This is an automated message from the Apache Git Servi

Re: [PR] [FLINK-33925][connectors/opensearch] Allow customising bulk failure handling [flink-connector-opensearch]

2024-03-12 Thread via GitHub
schulzp commented on PR #39: URL: https://github.com/apache/flink-connector-opensearch/pull/39#issuecomment-1992274982 Hey @hajimeni! > The CI error seems to be caused by differences in files under the archunit-violations path. > It was resolved in the following PR. https://githu

[jira] [Created] (FLINK-34657) Implement Lineage Graph for streaming API use cases

2024-03-12 Thread Zhenqiu Huang (Jira)
Zhenqiu Huang created FLINK-34657: - Summary: Implement Lineage Graph for streaming API use cases Key: FLINK-34657 URL: https://issues.apache.org/jira/browse/FLINK-34657 Project: Flink Issue T

[jira] [Created] (FLINK-34658) Scala API unusable on Flink 1.18.1/Java 17 Docker image

2024-03-12 Thread Matthew Ernst (Jira)
Matthew Ernst created FLINK-34658: - Summary: Scala API unusable on Flink 1.18.1/Java 17 Docker image Key: FLINK-34658 URL: https://issues.apache.org/jira/browse/FLINK-34658 Project: Flink Iss

[jira] [Assigned] (FLINK-25352) Update stability annotations to include the since and missedGraduations fields

2024-03-12 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-25352: --- Assignee: Jing Ge > Update stability annotations to include the since and missedGraduations fields

Re: [PR] [FLINK-34647][core] Optimize Path normalization [flink]

2024-03-12 Thread via GitHub
schlosna commented on PR #24473: URL: https://github.com/apache/flink/pull/24473#issuecomment-1992844641 Thanks for taking a look at this PR. > 1. What's your setup for the path ? We have checkpoints writing to a variety of file systems depending on the infrastructure, so it mi

[jira] [Updated] (FLINK-34647) Path normalization is allocation intensive

2024-03-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34647: --- Labels: pull-request-available (was: ) > Path normalization is allocation intensive > -

Re: [PR] [FLINK-33759] [flink-parquet] Add support for nested array with row type [flink]

2024-03-12 Thread via GitHub
ukby1234 commented on PR #24029: URL: https://github.com/apache/flink/pull/24029#issuecomment-1992944538 @MartijnVisser can you help review this PR? and possibly https://github.com/apache/flink/pull/23881 as well? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Add announcement blog post for Flink 1.19 [flink-web]

2024-03-12 Thread via GitHub
Myasuka commented on code in PR #721: URL: https://github.com/apache/flink-web/pull/721#discussion_r1522360842 ## docs/content/posts/2024-03-xx-release-1.19.0.md: ## @@ -0,0 +1,501 @@ +--- +authors: +- LincolnLee: + name: "Lincoln Lee" + twitter: lincoln_86xy + +date: "2024-03

  1   2   >