jeyhunkarimov commented on PR #23470:
URL: https://github.com/apache/flink/pull/23470#issuecomment-2078737997
Hi @xuyangzhong thanks for the comment. I addressed your comments. Please,
let me know if you agree.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/FLINK-35239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi resolved FLINK-35239.
-
Resolution: Fixed
> 1.19 docs show outdated warning
> ---
>
>
yeezychao commented on PR #24689:
URL: https://github.com/apache/flink/pull/24689#issuecomment-2078737494
@Myasuka PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
[
https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841063#comment-17841063
]
Zhongqiang Gong commented on FLINK-35240:
-
Welcome [~robyoung] to join this diss
[
https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhongqiang Gong updated FLINK-35240:
Attachment: screenshot-1.png
> Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record
>
PatrickRen merged PR #3240:
URL: https://github.com/apache/flink-cdc/pull/3240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
mas-chen commented on code in PR #97:
URL:
https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1580512725
##
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##
@@ -288,36 +288,39 @
yuxiqian commented on code in PR #1907:
URL: https://github.com/apache/flink-cdc/pull/1907#discussion_r1580510172
##
flink-connector-mysql-cdc/src/main/java/com/ververica/cdc/connectors/mysql/table/MySqlTableSourceFactory.java:
##
Review Comment:
Is this file content modifi
yuxiqian commented on PR #2944:
URL: https://github.com/apache/flink-cdc/pull/2944#issuecomment-2078672448
Hi @lvyanquan could you please rebase this with `master` again? Also cc
@Jiabao-Sun
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
yuxiqian commented on PR #2921:
URL: https://github.com/apache/flink-cdc/pull/2921#issuecomment-2078671706
Hi @WholeWorld-Timothy, could you please rebase this PR with master branch
to see if the CI passes?
cc @lvyanquan
--
This is an automated message from the Apache Git Service.
yuxiqian commented on PR #2908:
URL: https://github.com/apache/flink-cdc/pull/2908#issuecomment-2078670718
Hi @WholeWorld-Timothy, could you please rebase this PR with latest `master`
branch and address the comments above?
cc @whhe
--
This is an automated message from the Apache Gi
yeezychao commented on PR #1907:
URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2078670546
Hi @yuxiqian, thanks for your reply, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
yuxiqian commented on PR #2896:
URL: https://github.com/apache/flink-cdc/pull/2896#issuecomment-2078669536
Thanks for @Cqz666's contribution, could you please rebase this PR with
latest `master` branch before it could be merged?
--
This is an automated message from the Apache Git Service.
yuxiqian commented on PR #2880:
URL: https://github.com/apache/flink-cdc/pull/2880#issuecomment-2078667944
Hi @baxinyu, could you please rebase this PR with latest `master` branch
before it could be merged? Thank you!
--
This is an automated message from the Apache Git Service.
To respond
yuxiqian commented on PR #2848:
URL: https://github.com/apache/flink-cdc/pull/2848#issuecomment-2078665245
Thanks @JNSimba for the great work, could you please rebase this PR with
latest `master` branch before it could be merged?
--
This is an automated message from the Apache Git Service
yuxiqian commented on PR #2808:
URL: https://github.com/apache/flink-cdc/pull/2808#issuecomment-2078661660
Hi @EchoLee5, could you please rebase this PR with latest `master` branch
before it could be merged?
cc @ruanhang1993
--
This is an automated message from the Apache Git Serv
yuxiqian commented on PR #2787:
URL: https://github.com/apache/flink-cdc/pull/2787#issuecomment-2078660878
Hi @lizhongze1 Could you please rebase this PR with latest `master` branch?
cc @loserwang1024
--
This is an automated message from the Apache Git Service.
To respond to the mes
yuxiqian commented on PR #2755:
URL: https://github.com/apache/flink-cdc/pull/2755#issuecomment-2078659089
Hi @parthcri1997, could you please rebase this PR with latest `master`
branch and run `mvn spotless:apply` to fix checkstyle violations?
--
This is an automated message from the Apac
yuxiqian commented on PR #2754:
URL: https://github.com/apache/flink-cdc/pull/2754#issuecomment-2078657737
Hi @HappyHacker123, could you please rebase this PR with latest `master`
branch and trigger the CI? Thanks for your contribution!
--
This is an automated message from the Apache Git
yuxiqian commented on PR #2705:
URL: https://github.com/apache/flink-cdc/pull/2705#issuecomment-2078655679
Hi @edmond-kk, could you please rebase this PR with latest `master` branch
before it could be merged? Thanks for your contribution!
--
This is an automated message from the Apache Gi
SML0127 commented on code in PR #3148:
URL: https://github.com/apache/flink-cdc/pull/3148#discussion_r1560428551
##
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/MySqlValidator.java:
##
@@ -50,6 +50,7
hanyuzheng7 commented on code in PR #24365:
URL: https://github.com/apache/flink/pull/24365#discussion_r1580488725
##
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##
@@ -409,6 +409,18 @@ ANY, and(logical(LogicalTy
hanyuzheng7 commented on code in PR #24365:
URL: https://github.com/apache/flink/pull/24365#discussion_r1580488012
##
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/scalar/SplitFunction.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apa
yuxiqian commented on PR #2588:
URL: https://github.com/apache/flink-cdc/pull/2588#issuecomment-2078640229
Hi @comien, could you please rebase this PR with latest `master` branch
before it could be merged?
--
This is an automated message from the Apache Git Service.
To respond to the mess
yuxiqian commented on PR #2571:
URL: https://github.com/apache/flink-cdc/pull/2571#issuecomment-2078639402
Hi @lzshlzsh, could you please rebase this PR with latest `master` branch
before it could be merged?
Also cc @loserwang1024
--
This is an automated message from the Apache Git
fredia commented on PR #24667:
URL: https://github.com/apache/flink/pull/24667#issuecomment-2078637067
@Zakelly Thanks for the review, I addressed the comments and rebased to
master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
yuxiqian commented on PR #2512:
URL: https://github.com/apache/flink-cdc/pull/2512#issuecomment-2078635982
Could you please rebase this PR with `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
yuxiqian commented on PR #2523:
URL: https://github.com/apache/flink-cdc/pull/2523#issuecomment-2078636920
Is there any progress on this PR? cc @lvyanquan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yuxiqian commented on PR #2495:
URL: https://github.com/apache/flink-cdc/pull/2495#issuecomment-2078634937
Hi @hzjhjjyy, thanks for your contribution! Could you please rebase your PR
with latest `master` branch before it could be merged? You may need to rename
packages like from `com.verver
yuxiqian commented on PR #3084:
URL: https://github.com/apache/flink-cdc/pull/3084#issuecomment-2078632869
Closing this PR since it's been resolved in #3217 & #3253.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yuxiqian commented on PR #2479:
URL: https://github.com/apache/flink-cdc/pull/2479#issuecomment-2078631669
Hi @lvyanquan, could you please rebase this PR with `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
yuxiqian commented on PR #2461:
URL: https://github.com/apache/flink-cdc/pull/2461#issuecomment-2078629764
Hi @zhaomin1423, thanks for your contribution! Could you please rebase it
with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the
Zakelly commented on code in PR #24667:
URL: https://github.com/apache/flink/pull/24667#discussion_r1580464018
##
flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/AsyncExecutionController.java:
##
@@ -94,26 +97,38 @@ public class AsyncExecutionController {
yuxiqian commented on PR #2581:
URL: https://github.com/apache/flink-cdc/pull/2581#issuecomment-2078596504
Thanks @wuzhenhua01 for the contribution, would you mind open a new PR based
on latest `master` branch, as the code base has changed greatly since then?
cc @loserwang1024
--
yuxiqian commented on PR #2493:
URL: https://github.com/apache/flink-cdc/pull/2493#issuecomment-2078593562
Closing this PR as resolved in Flink CDC 3.0. Pleaes open a [Jira
Ticket](https://issues.apache.org/jira/projects/FLINK/summary) if this problem
occurs again.
--
This is an automate
yuxiqian closed pull request #2493: hotfix: exclude debezium jackson dependency
& add: assorted e2e case
URL: https://github.com/apache/flink-cdc/pull/2493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
yuxiqian commented on PR #2494:
URL: https://github.com/apache/flink-cdc/pull/2494#issuecomment-2078592893
Hi @ThisisWilli, thanks for your great contribution! Could you please rebase
this PR with latest `master` branch? You may need to rename some packages like
from `com.ververica.cdc` to
yuxiqian commented on PR #2686:
URL: https://github.com/apache/flink-cdc/pull/2686#issuecomment-2078591185
Hi @vanliu-tx, thanks for your contribution! Could you please rebase this PR
with latest `master` branch? You may need to rename some packages from
`com.ververica.cdc` to `org.apache.f
yuxiqian commented on PR #2597:
URL: https://github.com/apache/flink-cdc/pull/2597#issuecomment-2078589995
Closing this PR since it has been outdated. Please reopen a PR for this
patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
yuxiqian commented on PR #2501:
URL: https://github.com/apache/flink-cdc/pull/2501#issuecomment-2078589126
Thanks for @ariesy's contribution! Could you please rebase this PR with
latest `master` branch? You may want to patch the `pom.xml` file in
`flink-cdc-connect/flink-cdc-source-connecto
yuxiqian commented on PR #2392:
URL: https://github.com/apache/flink-cdc/pull/2392#issuecomment-2078584190
Thanks @wuzhenhua01 for the great work! Before this PR could be merged,
could you please rebase it with latest `master` branch?
cc @loserwang1024
--
This is an automated mess
wenbingshen commented on PR #91:
URL:
https://github.com/apache/flink-connector-pulsar/pull/91#issuecomment-2078583839
> The pulsar-client-all should be upgrade to the 3.0.4 in the mean time.
@syhily
--
This is an automated message from the Apache Git Service.
To respond to the me
yuxiqian commented on PR #2389:
URL: https://github.com/apache/flink-cdc/pull/2389#issuecomment-2078583656
Thanks @linzhicong1996 for the great work! Before this PR could be merged,
could you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git
yuxiqian commented on PR #2385:
URL: https://github.com/apache/flink-cdc/pull/2385#issuecomment-2078583039
Closing this PR as it has been resolved in #3024.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yuxiqian commented on PR #2361:
URL: https://github.com/apache/flink-cdc/pull/2361#issuecomment-2078580496
Hi @liugddx, seems Debezium 2.x requires JDK 11+, however currently Flink
CDC needs to support Java 8. As Flink 1.20 still keeps Java 8 compatibility, we
can't drop support for legacy
yuxiqian commented on PR #2358:
URL: https://github.com/apache/flink-cdc/pull/2358#issuecomment-2078577626
Hi @liugddx, there's been a lot of changes since your original commit. Could
you please rebase this PR with latest `master` branch before it could be
merged? Thanks!
--
This is an a
yuxiqian commented on PR #2339:
URL: https://github.com/apache/flink-cdc/pull/2339#issuecomment-2078573012
Hi @zhaomin1423, could you please rebase with latest `master` branch before
further actions? Thanks for your contribution!
--
This is an automated message from the Apache Git Service
[
https://issues.apache.org/jira/browse/FLINK-34639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qingsheng Ren resolved FLINK-34639.
---
Resolution: Fixed
> Flink CDC: Support DebeziumDeserializationSchema in OceanBase source con
[
https://issues.apache.org/jira/browse/FLINK-34639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840683#comment-17840683
]
Qingsheng Ren edited comment on FLINK-34639 at 4/26/24 3:32 AM:
--
PatrickRen merged PR #3259:
URL: https://github.com/apache/flink-cdc/pull/3259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
[
https://issues.apache.org/jira/browse/FLINK-35128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840657#comment-17840657
]
Qingsheng Ren edited comment on FLINK-35128 at 4/26/24 3:30 AM:
--
[
https://issues.apache.org/jira/browse/FLINK-35128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qingsheng Ren resolved FLINK-35128.
---
Fix Version/s: cdc-3.1.0
(was: 3.1.0)
Resolution: Fixed
> Re-c
PatrickRen merged PR #3257:
URL: https://github.com/apache/flink-cdc/pull/3257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.
yuxiqian commented on PR #2338:
URL: https://github.com/apache/flink-cdc/pull/2338#issuecomment-2078569056
Thanks for your contribution! Closing this since it has been addressed in
#2901.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yuxiqian commented on PR #2329:
URL: https://github.com/apache/flink-cdc/pull/2329#issuecomment-2078568254
Thanks @zhaomin1423 for the fix, could you please rebase this PR with latest
`master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841035#comment-17841035
]
Rob Young commented on FLINK-35240:
---
Hi, I've been looking into this.
1.
[FLUSH_AFTE
[ https://issues.apache.org/jira/browse/FLINK-35236 ]
hongxu han deleted comment on FLINK-35236:
was (Author: maomao):
[~Weijie Guo] I would like to filing a PR to fix this.
This is my first PR,If there are any non-standard formats, I am willin
yuxiqian commented on PR #2327:
URL: https://github.com/apache/flink-cdc/pull/2327#issuecomment-2078563743
Thanks @zhaomin1423 for the great work! Before this PR could be merged,
could you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Se
yuxiqian commented on PR #2298:
URL: https://github.com/apache/flink-cdc/pull/2298#issuecomment-2078562138
Hi @nidonglin, thanks for your contribution! Could you please rebase this PR
with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to t
yuxiqian commented on PR #2304:
URL: https://github.com/apache/flink-cdc/pull/2304#issuecomment-2078563215
Could you please also rebase this? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
yuxiqian commented on PR #2271:
URL: https://github.com/apache/flink-cdc/pull/2271#issuecomment-2078559293
Thanks for your contribution! Closing this PR as resolved in #3186. Feel
free to reopen this if you have any concerns.
--
This is an automated message from the Apache Git Service.
To
rovboyko commented on PR #24703:
URL: https://github.com/apache/flink/pull/24703#issuecomment-2078558651
Hi @xishuaidelin !
I've fixed all places you noticed about. Could you please review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/FLINK-35236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841031#comment-17841031
]
hongxu han commented on FLINK-35236:
#24726
I filing a PR to fix this,again.
Thank
flinkbot commented on PR #24726:
URL: https://github.com/apache/flink/pull/24726#issuecomment-2078558449
## CI report:
* dd67144505817b8dab1b337b2284427812542324 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
yuxiqian commented on PR #2266:
URL: https://github.com/apache/flink-cdc/pull/2266#issuecomment-2078557650
Hi @code-dm, thanks for your contribution! Could you please rebase this PR
with latest `master` branch before it could be merged?
--
This is an automated message from the Apache Git
yuxiqian commented on PR #2257:
URL: https://github.com/apache/flink-cdc/pull/2257#issuecomment-2078556727
Hi @dua01, thanks for you contribution! Could you please rebase this PR with
latest `master` branch before it could be merged? Also please describe this as
a temporary workaround in co
yuxiqian commented on PR #2244:
URL: https://github.com/apache/flink-cdc/pull/2244#issuecomment-2078554829
Hi @zhaomin1423, thanks for your contribution! Could you please rebase this
PR with latest `master` branch before it could be merged?
--
This is an automated message from the Apache
maomao931228 opened a new pull request, #24726:
URL: https://github.com/apache/flink/pull/24726
I'm glad to be here for the first time to open a pull request 'Modify
Translation error on the execution_mode/order-of-processing'.
https://github.com/apache/flink/assets/152967266/6c40992d
yuxiqian commented on PR #2188:
URL: https://github.com/apache/flink-cdc/pull/2188#issuecomment-2078554200
Hi @y0908105023, could you please rebase this PR with latest `master` branch
before it could be merged? Thanks!
--
This is an automated message from the Apache Git Service.
To respon
yuxiqian commented on PR #2145:
URL: https://github.com/apache/flink-cdc/pull/2145#issuecomment-2078552080
Hi @LiPL2017, thanks for your great work! We're planning a general
rate-limit framework in the following Flink 3.x releases, so closing this PR
for now.
--
This is an automated mess
yuxiqian commented on PR #2134:
URL: https://github.com/apache/flink-cdc/pull/2134#issuecomment-2078549985
Thanks @debjeetsarkar for the great work! Could you please rebase it with
latest `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the messa
yuxiqian commented on PR #2086:
URL: https://github.com/apache/flink-cdc/pull/2086#issuecomment-2078547913
Hi @TyrantLucifer, could you please rebase this PR with latest `master`
branch? Thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond
yuxiqian commented on PR #2069:
URL: https://github.com/apache/flink-cdc/pull/2069#issuecomment-2078547449
Thanks @fuyun2024 for the great work! Before this PR could be merged, could
you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Serv
yuxiqian commented on PR #2038:
URL: https://github.com/apache/flink-cdc/pull/2038#issuecomment-2078546586
Thanks @ArainChen for the great work! Before this PR could be merged, could
you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Serv
maomao931228 commented on PR #24720:
URL: https://github.com/apache/flink/pull/24720#issuecomment-2078544001
> > Thanks for the fix. I just left a minor comment, please take a look.
> > BTW, could you please squash all commits to one: `[FLINK-35236][docs]
Fix incorrect translation on exec
maomao931228 closed pull request #24720: [FLINK-35236] [chinese-translation]
Modify Translation error on the execution_mode/order-of-processing
URL: https://github.com/apache/flink/pull/24720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yuxiqian commented on PR #2061:
URL: https://github.com/apache/flink-cdc/pull/2061#issuecomment-2078544616
Thanks @snuyanzin for the great work, could you please rebase it with latest
`master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message,
yuxiqian commented on PR #2009:
URL: https://github.com/apache/flink-cdc/pull/2009#issuecomment-2078543458
Thanks @weAreFriendYo for the great work! Before this PR could be merged,
could you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git
yuxiqian commented on PR #1974:
URL: https://github.com/apache/flink-cdc/pull/1974#issuecomment-2078542556
Thanks @xieyi888 for the great work! Before this PR could be merged, could
you please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Servi
maomao931228 commented on PR #24720:
URL: https://github.com/apache/flink/pull/24720#issuecomment-2078537546
> Thanks for the fix. I just left a minor comment, please take a look.
>
> BTW, could you please squash all commits to one: `[FLINK-35236][docs] Fix
incorrect translation on ex
yuxiqian commented on PR #1945:
URL: https://github.com/apache/flink-cdc/pull/1945#issuecomment-2078536816
@ruanhang1993 Could you please rebase this PR with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
yuxiqian commented on PR #1941:
URL: https://github.com/apache/flink-cdc/pull/1941#issuecomment-2078535892
Thanks @green1893 for the great work! Before this PR could be merged, could
you please rebase it with latest `master` branch?
cc @ruanhang1993
--
This is an automated message
yuxiqian commented on PR #1918:
URL: https://github.com/apache/flink-cdc/pull/1918#issuecomment-2078535495
Thanks @e-mhui for the great work! Before this PR could be merged, could you
please rebase it with latest `master` branch?
cc @ruanhang1993
--
This is an automated message fro
yuxiqian commented on PR #1915:
URL: https://github.com/apache/flink-cdc/pull/1915#issuecomment-2078533983
Hi @lzshlzsh, thanks for your contribution! Before this PR could be merged,
could you please rebase it with latest `master` branch?
cc @leonardBang @PatrickRen
--
This is an
yuxiqian commented on PR #1907:
URL: https://github.com/apache/flink-cdc/pull/1907#issuecomment-2078533192
Hi @yeezychao, thanks for your great contribution! Before this PR could be
merged, could you please rebase it with latest `master` branch?
--
This is an automated message from the Ap
[
https://issues.apache.org/jira/browse/FLINK-35178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841029#comment-17841029
]
Yanfei Lei commented on FLINK-35178:
[~elon]
> the result was the same?
Does i
yuxiqian commented on PR #1895:
URL: https://github.com/apache/flink-cdc/pull/1895#issuecomment-2078529182
Thanks for your contribution! Before this PR could be merged, could you
please rebase it with latest `master` branch?
cc @leonardBang
--
This is an automated message from the
mas-chen commented on PR #97:
URL:
https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2078522854
Thanks for explaining, I missed that! Rerunning CI, the PR LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
yuxiqian commented on PR #1882:
URL: https://github.com/apache/flink-cdc/pull/1882#issuecomment-2078522702
Thanks for your contribution! Before this PR could be merged, could you
please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To
yuxiqian commented on PR #1877:
URL: https://github.com/apache/flink-cdc/pull/1877#issuecomment-2078520313
Closing this PR since this feature has been implemented by #3024.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dalongliu updated FLINK-35189:
--
Component/s: Connectors / FileSystem
> Introduce test-filesystem Catalog based on FileSystem Connector
yuxiqian commented on PR #1876:
URL: https://github.com/apache/flink-cdc/pull/1876#issuecomment-2078518760
Thanks for your contribution! Could you please rebase this PR with latest
`master` branch, and update maven wrapper properties to align with [Flink
repository](https://github.com/apach
yuxiqian commented on PR #1863:
URL: https://github.com/apache/flink-cdc/pull/1863#issuecomment-2078515594
Thanks @LXin96 for the great work! Before this PR could be merged, could you
please rebase it with latest `master` branch? `com.ververica.cdc.connectors`
have been renamed to `org.apac
yuxiqian commented on PR #1838:
URL: https://github.com/apache/flink-cdc/pull/1838#issuecomment-2078510778
Closing this PR since this feature has been implemented in #3024.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
[
https://issues.apache.org/jira/browse/FLINK-34127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-34127:
---
Labels: pull-request-available (was: )
> Kafka connector repo runs a duplicate of `Integrat
mas-chen commented on PR #98:
URL:
https://github.com/apache/flink-connector-kafka/pull/98#issuecomment-2078508305
This shaves 1-2 minutes from CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
yuxiqian commented on PR #1836:
URL: https://github.com/apache/flink-cdc/pull/1836#issuecomment-2078507662
Thanks for your contribution! Before this PR could be merged, could you
please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To
lsyldliu commented on PR #24707:
URL: https://github.com/apache/flink/pull/24707#issuecomment-2078505570
Sorry for forget to approve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lsyldliu commented on code in PR #24712:
URL: https://github.com/apache/flink/pull/24712#discussion_r1580355919
##
flink-test-utils-parent/flink-table-filesystem-test-utils/src/main/java/org/apache/flink/table/file/testutils/catalog/TestFileSystemCatalog.java:
##
@@ -0,0 +1,687
yuxiqian commented on PR #1821:
URL: https://github.com/apache/flink-cdc/pull/1821#issuecomment-2078503312
Thanks for your contribution! Before this PR could be merged, could you
please rebase it with latest `master` branch?
--
This is an automated message from the Apache Git Service.
To
1 - 100 of 261 matches
Mail list logo
