Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
zhongqishang commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1581741205 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent de

Re: [PR] Fix during the snapshot phase, projection is not being performed according to the user defined schema. [flink-cdc]

2024-04-26 Thread via GitHub
hzjhjjyy commented on PR #2495: URL: https://github.com/apache/flink-cdc/pull/2495#issuecomment-2080353903 > Hi @hzjhjjyy, thanks for your contribution! Could you please rebase your PR with latest `master` branch before it could be merged? You may need to rename packages like from `com.verv

[jira] [Created] (FLINK-35248) Support table/column comment to modify DDL

2024-04-26 Thread melin (Jira)
melin created FLINK-35248: - Summary: Support table/column comment to modify DDL Key: FLINK-35248 URL: https://issues.apache.org/jira/browse/FLINK-35248 Project: Flink Issue Type: New Feature

Re: [PR] support op_type metadata columns [flink-cdc]

2024-04-26 Thread via GitHub
wangqinghuan closed pull request #1071: support op_type metadata columns URL: https://github.com/apache/flink-cdc/pull/1071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581716086 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java: ## @@ -133,6 +139,21 @@ prot

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581321727 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/PhysicalTransformation.java: ## @@ -34,6 +35,7 @@ public abstract class Physi

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581715242 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java: ## @@ -123,6 +124,7 @@ public class StreamGraph implements Pipeline {

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
mas-chen commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581372979 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java: ## @@ -464,6 +466,8

[jira] [Updated] (FLINK-35247) Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21

2024-04-26 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-35247: --- Description: Spotless apply version from flink-connector-parent does not work with Java 21 Issue fo

[jira] [Created] (FLINK-35247) Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21

2024-04-26 Thread Mason Chen (Jira)
Mason Chen created FLINK-35247: -- Summary: Upgrade spotless apply to `2.41.1` in flink-connector-parent to work with Java 21 Key: FLINK-35247 URL: https://issues.apache.org/jira/browse/FLINK-35247 Project

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581326630 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/stream/StreamExecLegacyTableSourceScan.java: ## @@ -90,6 +90,7 @@ p

Re: [PR] [FLINK-33211][table] support flink table lineage [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu commented on code in PR #24618: URL: https://github.com/apache/flink/pull/24618#discussion_r1581321727 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/transformations/PhysicalTransformation.java: ## @@ -34,6 +35,7 @@ public abstract class Physi

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841301#comment-17841301 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 5:11 PM:

Re: [PR] [FLINK-33210] Cleanup the lineage interface comments [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24731: URL: https://github.com/apache/flink/pull/24731#issuecomment-2079751600 ## CI report: * 93207bb3788bdcd5f6cf3657c2feb5d92ddb5871 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841301#comment-17841301 ] Zhongqiang Gong commented on FLINK-35240: - [~afedulov] I opened a pr to patch th

[PR] [FLINK-33210] Cleanup the lineage interface comments [flink]

2024-04-26 Thread via GitHub
HuangZhenQiu opened a new pull request, #24731: URL: https://github.com/apache/flink/pull/24731 ## What is the purpose of the change Format the class comments of lineage interface classes ## Brief change log - Remove the unneeded empty line of class comments ## Veri

Re: [PR] [FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24730: URL: https://github.com/apache/flink/pull/24730#issuecomment-2079743542 ## CI report: * 418a88849ef1c9f850cc80b5f691cfe033ac7c09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]

2024-04-26 Thread via GitHub
GOODBOY008 commented on code in PR #90: URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581286005 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java: ## @@ -49,7 +49,7 @@ public Foo() {} @Ove

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35240: --- Labels: pull-request-available (was: ) > Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per

[PR] [FLINK-35240][Connectors][format]Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record for csv format [flink]

2024-04-26 Thread via GitHub
GOODBOY008 opened a new pull request, #24730: URL: https://github.com/apache/flink/pull/24730 Changes: - Disable `FLUSH_AFTER_WRITE_VALUE` - Use `ObjectWriter#writeValue(org.apache.flink.shaded.jackson2.com.fasterxml.jackson.core.JsonGenerator, java.lang.Object)` instead of `ObjectWr

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2079731646 > > @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. > > If you want, just go

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-26 Thread via GitHub
ferenc-csaky commented on code in PR #22789: URL: https://github.com/apache/flink/pull/22789#discussion_r1581270742 ## flink-filesystems/flink-gs-fs-hadoop/src/test/java/org/apache/flink/fs/gs/writer/GSRecoverableFsDataOutputStreamTest.java: ## @@ -133,57 +131,57 @@ public void

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… [flink]

2024-04-26 Thread via GitHub
davidradl closed pull request #24729: [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… URL: https://github.com/apache/flink/pull/24729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223 ] david radley deleted comment on FLINK-31223: -- was (Author: JIRAUSER300523): [~Weijie Guo] I have created pr [https://github.com/apache/flink/pull/24729] for the 1.18 backport > sql-client.

Re: [PR] [FLINK-31223][sqlgateway] Introduce getFlinkConfigurationOptions to g… [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #24729: URL: https://github.com/apache/flink/pull/24729#issuecomment-2079655100 incomplete will redo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Comment Edited] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841279#comment-17841279 ] david radley edited comment on FLINK-31223 at 4/26/24 3:47 PM: ---

[jira] [Commented] (FLINK-31223) sql-client.sh fails to start with ssl enabled

2024-04-26 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841279#comment-17841279 ] david radley commented on FLINK-31223: -- [~Weijie Guo] I have created pr [https://gi

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841271#comment-17841271 ] Alexander Fedulov commented on FLINK-35240: --- [~gongzhongqiang] and [~robyoung]

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-20-647.png > Disable FLUSH_AFTER_WRITE_VALUE to avo

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-30-293.png > Disable FLUSH_AFTER_WRITE_VALUE to avo

[jira] [Updated] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-35240: -- Attachment: image-2024-04-26-17-16-07-925.png > Disable FLUSH_AFTER_WRITE_VALUE to avo

[jira] [Commented] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841267#comment-17841267 ] Oleksandr Nitavskyi commented on FLINK-35232: - [~galenwarren] thanks. We hav

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking ability

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking ability

[jira] [Updated] (FLINK-35232) Support for retry settings on GCS connector

2024-04-26 Thread Oleksandr Nitavskyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleksandr Nitavskyi updated FLINK-35232: Description: https://issues.apache.org/jira/browse/FLINK-32877 is tracking ability

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter [flink-connector-aws]

2024-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1581114799 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java: ## @@

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix: DynamicKafkaSource does not read re-added topic for the same cluster [flink-connector-kafka]

2024-04-26 Thread via GitHub
IgnasD commented on PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#issuecomment-2079488271 Changed the title as requested. Also, I've added filtering to `unassignedInitialPartitions` as suggested and covered it with a test case. -- This is an automated message from

Re: [PR] [FLINK-35228][Connectors/Kafka] Fix DynamicKafkaSourceEnumerator removed topics state cleanup [flink-connector-kafka]

2024-04-26 Thread via GitHub
IgnasD commented on code in PR #97: URL: https://github.com/apache/flink-connector-kafka/pull/97#discussion_r1581103075 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java: ## @@ -288,36 +288,39 @@

Re: [PR] [FLINK-35022][Connector/DynamoDB] Add TypeInformed DDB Element Converter [flink-connector-aws]

2024-04-26 Thread via GitHub
vahmed-hamdy commented on code in PR #136: URL: https://github.com/apache/flink-connector-aws/pull/136#discussion_r1581083313 ## flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/sink/DynamoDbTypeInformedElementConverter.java: ## @@

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841232#comment-17841232 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 1:34 PM:

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841238#comment-17841238 ] Zhongqiang Gong commented on FLINK-35240: - Base on the logic of _writer. close,W

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841232#comment-17841232 ] Zhongqiang Gong commented on FLINK-35240: - !截图-1.png! The close methed always

[jira] [Comment Edited] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841232#comment-17841232 ] Zhongqiang Gong edited comment on FLINK-35240 at 4/26/24 1:22 PM:

[jira] [Commented] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841227#comment-17841227 ] Weijie Guo commented on FLINK-35246: master via 4e6dbe2d1a225a0d0e48fd0997c1f1131740

[jira] [Closed] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35246. -- Resolution: Fixed > SqlClientSSLTest.testGatewayMode failed in AZP > -

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
reswqa merged PR #24727: URL: https://github.com/apache/flink/pull/24727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
reswqa commented on PR #24727: URL: https://github.com/apache/flink/pull/24727#issuecomment-2079379345 Thanks for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [FLINK-34629] Fix non-partition topic subscribe lost. [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on PR #84: URL: https://github.com/apache/flink-connector-pulsar/pull/84#issuecomment-2079360052 Plz close this PR for it has been fixed in #85. @tisonkun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on code in PR #90: URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581009843 ## flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java: ## @@ -49,7 +49,7 @@ public Foo() {} @Overrid

Re: [PR] [FLINK-35196] [Connector / Pulsar] Fix bouncycastle class not found [flink-connector-pulsar]

2024-04-26 Thread via GitHub
syhily commented on PR #91: URL: https://github.com/apache/flink-connector-pulsar/pull/91#issuecomment-2079354340 > > The pulsar-client-all should be upgrade to the 3.0.4 in the mean time. > > @syhily After `pulsar-client-all` was updated to 3.0.4, the unit test failed. I took a brie

Re: [PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24728: URL: https://github.com/apache/flink/pull/24728#issuecomment-2079305845 ## CI report: * 6511c8930cde9f8a3e3acef78fc3bcecb5e9cb51 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
davidradl commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2079304678 > @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. > > If you want, just g

[jira] [Updated] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35194: --- Labels: pull-request-available (was: ) > Support describe job syntax and execution > --

[PR] [FLINK-35194][table] Support describe job with job id [flink]

2024-04-26 Thread via GitHub
xuyangzhong opened a new pull request, #24728: URL: https://github.com/apache/flink/pull/24728 ## What is the purpose of the change Support syntax '{ DESCRIBE | DESC } JOB 'xxx'' ## Brief change log - *Support to parse syntax { DESCRIBE | DESC } JOB 'xxx'* - *Suppo

[jira] [Commented] (FLINK-35097) Table API Filesystem connector with 'raw' format repeats last line

2024-04-26 Thread David Perkins (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841197#comment-17841197 ] David Perkins commented on FLINK-35097: --- Can the fix get applied to 1.17 also? >

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

[jira] [Resolved] (FLINK-35026) Introduce async execution configurations

2024-04-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei resolved FLINK-35026. Resolution: Resolved > Introduce async execution configurations >

[jira] [Commented] (FLINK-35026) Introduce async execution configurations

2024-04-26 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841182#comment-17841182 ] Yanfei Lei commented on FLINK-35026: Merged into master via 713c30f..3ff2ba4  > Int

Re: [PR] [FLINK-35026][runtime][config] Introduce async execution configurations [flink]

2024-04-26 Thread via GitHub
fredia merged PR #24667: URL: https://github.com/apache/flink/pull/24667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-27146] [Filesystem] Migrate to Junit5 [flink]

2024-04-26 Thread via GitHub
kottmann commented on PR #22789: URL: https://github.com/apache/flink/pull/22789#issuecomment-2079230716 Sorry for the delay on my end, I added a new commit to address all your comments above. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Kafka part required for Flink Apicurio Avro support. Prototype for review [flink-connector-kafka]

2024-04-26 Thread via GitHub
boring-cyborg[bot] commented on PR #99: URL: https://github.com/apache/flink-connector-kafka/pull/99#issuecomment-2079138385 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is a

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on code in PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#discussion_r1580840112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/event/DataChangeEventSerializer.java: ## @@ -76,28 +72,18 @@ public DataChangeEvent deseri

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:04 AM: ---

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:05 AM: ---

[jira] [Comment Edited] (FLINK-34694) Delete num of associations for streaming outer join

2024-04-26 Thread Roman Boyko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837205#comment-17837205 ] Roman Boyko edited comment on FLINK-34694 at 4/26/24 10:01 AM: ---

[jira] [Commented] (FLINK-35192) operator oom

2024-04-26 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841129#comment-17841129 ] Biao Geng commented on FLINK-35192: --- !screenshot-3.png! According to the flink k8s o

[jira] [Updated] (FLINK-35192) operator oom

2024-04-26 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Geng updated FLINK-35192: -- Attachment: screenshot-3.png > operator oom > > > Key: FLINK-35192 >

[jira] [Assigned] (FLINK-35195) Support the execution of create materialized table in continuous refresh mode

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35195: - Assignee: dalongliu > Support the execution of create materialized table in continuous refresh

[jira] [Commented] (FLINK-35189) Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841128#comment-17841128 ] dalongliu commented on FLINK-35189: --- Merged in master: 714d1cb2e0bd0df03393492dc87cbd8

[jira] [Resolved] (FLINK-35189) Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35189. --- Resolution: Fixed > Introduce test-filesystem Catalog based on FileSystem Connector to support > ma

Re: [PR] [FLINK-35189][test-utils]Introduce test-filesystem Catalog based on FileSystem Connector to support materialized table [flink]

2024-04-26 Thread via GitHub
lsyldliu merged PR #24712: URL: https://github.com/apache/flink/pull/24712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Assigned] (FLINK-35197) Support the execution of suspend, resume materialized table in continuous refresh mode

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35197: - Assignee: Feng Jin > Support the execution of suspend, resume materialized table in continuous

[jira] [Commented] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841122#comment-17841122 ] dalongliu commented on FLINK-35194: --- Yeah, assigned to you. > Support describe job sy

[jira] [Assigned] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-35194: - Assignee: xuyang > Support describe job syntax and execution >

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
yuxiqian commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2079004056 @Jiabao-Sun Sure, I'll take it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [FLINK-35119][cdc-runtime] Change DataChangeEvent serialization and eserialization [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun commented on PR #3226: URL: https://github.com/apache/flink-cdc/pull/3226#issuecomment-2078993303 Thanks @zhongqishang for this fix. Hi @yuxiqian, do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (FLINK-35240) Disable FLUSH_AFTER_WRITE_VALUE to avoid flush per record

2024-04-26 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841117#comment-17841117 ] Alexander Fedulov commented on FLINK-35240: --- I don't think touching any of the

[jira] [Resolved] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer resolved FLINK-32877. --- Resolution: Done > Support for HTTP connect and timeout options while writes in GCS connecto

Re: [PR] [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-2078971443 Merged in https://github.com/apache/flink/pull/24673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer closed pull request #23226: [FLINK-32877][Filesystem]add HTTP options to gcs-cloud-storage client URL: https://github.com/apache/flink/pull/23226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-35246][test] Fix incorrect address construction in SqlClientSSLTest [flink]

2024-04-26 Thread via GitHub
flinkbot commented on PR #24727: URL: https://github.com/apache/flink/pull/24727#issuecomment-2078971258 ## CI report: * a327b1e5ee7948bfd7f5c699222be5575e72f6f6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-35244) Move package for flink-connector-tidb-cdc test

2024-04-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun reassigned FLINK-35244: -- Assignee: Xie Yi > Move package for flink-connector-tidb-cdc test > -

[jira] [Updated] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-32877: -- Affects Version/s: 1.18.1 1.19.0 > Support for HTTP connect and timeout

[jira] [Updated] (FLINK-32877) Support for HTTP connect and timeout options while writes in GCS connector

2024-04-26 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer updated FLINK-32877: -- Fix Version/s: 1.20.0 > Support for HTTP connect and timeout options while writes in GCS conne

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer merged PR #24673: URL: https://github.com/apache/flink/pull/24673 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #24673: URL: https://github.com/apache/flink/pull/24673#issuecomment-2078968511 Apologies I did not fix the commit message 🤦 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Updated] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35246: --- Labels: pull-request-available (was: ) > SqlClientSSLTest.testGatewayMode failed in AZP > -

Re: [PR] [FLINK-31223] sql-client.sh fails to start with ssl enabled [flink]

2024-04-26 Thread via GitHub
reswqa commented on PR #22026: URL: https://github.com/apache/flink/pull/22026#issuecomment-2078960338 @davidradl Make sense to back port this as we should treat this as a bugfix because sql client previously supported SSL, which is a kind of regresssion. -- This is an automated message f

[jira] [Resolved] (FLINK-35235) Fix missing dependencies in the uber jar

2024-04-26 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-35235. Assignee: LvYanquan Resolution: Fixed Resolved via * cdc master: ec643c9dd7365261f3cee620d4

Re: [PR] [FLINK-32877][Filesystem][Rebased] Add HTTP options to java-storage client [flink]

2024-04-26 Thread via GitHub
dannycranmer commented on PR #24673: URL: https://github.com/apache/flink/pull/24673#issuecomment-2078965258 LGTM, I will fix the commit message on merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (FLINK-35194) Support describe job syntax and execution

2024-04-26 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17841113#comment-17841113 ] xuyang commented on FLINK-35194: Hi, can I take this jira? > Support describe job synta

Re: [PR] [FLINK-35235][pipeline-connector][kafka] Fix missing dependencies in the uber jar of Kafka pipeline sink. [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3262: URL: https://github.com/apache/flink-cdc/pull/3262 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Assigned] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35246: -- Assignee: Weijie Guo > SqlClientSSLTest.testGatewayMode failed in AZP > -

[jira] [Created] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35246: -- Summary: SqlClientSSLTest.testGatewayMode failed in AZP Key: FLINK-35246 URL: https://issues.apache.org/jira/browse/FLINK-35246 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1784#comment-1784 ] Weijie Guo commented on FLINK-35246: {code:java} InetSocketAddress.createUnresolved

Re: [PR] [BP-3.1][FLINK-35235][pipeline-connector][kafka] Fix missing dependencies in the uber jar of Kafka pipeline sink. [flink-cdc]

2024-04-26 Thread via GitHub
Jiabao-Sun merged PR #3263: URL: https://github.com/apache/flink-cdc/pull/3263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Comment Edited] (FLINK-35246) SqlClientSSLTest.testGatewayMode failed in AZP

2024-04-26 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1784#comment-1784 ] Weijie Guo edited comment on FLINK-35246 at 4/26/24 8:59 AM: -

Re: [PR] [FLINK-32084][checkpoint] Migrate current file merging of channel state snapshot into the unify file merging framework [flink]

2024-04-26 Thread via GitHub
fredia commented on PR #24653: URL: https://github.com/apache/flink/pull/24653#issuecomment-2078953534 @Zakelly @1996fanrui would you please to take a look? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [tidb] Add metrics for tidb connector [flink-cdc]

2024-04-26 Thread via GitHub
xieyi888 commented on PR #1974: URL: https://github.com/apache/flink-cdc/pull/1974#issuecomment-2078942188 > add metrcis: currentFetchEventTimeLag, currentEmitEventTimeLag, sourceIdleTime for TiKVRichParallelSourceFunction > Thanks @xieyi888 for the great work! Before this PR

  1   2   >