[jira] [Commented] (FLINK-35485) JobMaster failed with "the job xx has not been finished"

2024-05-29 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850600#comment-17850600 ] Matthias Pohl commented on FLINK-35485: --- Hi [~xccui], thanks for reporting the iss

Re: [PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-29 Thread via GitHub
flinkbot commented on PR #24871: URL: https://github.com/apache/flink/pull/24871#issuecomment-2138808750 ## CI report: * 69835bf1c0ef659b078e303af046366952ce5691 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35461][config] Improve Runtime Configuration for Flink 2.0 [flink]

2024-05-29 Thread via GitHub
xintongsong closed pull request #24853: [FLINK-35461][config] Improve Runtime Configuration for Flink 2.0 URL: https://github.com/apache/flink/pull/24853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-34953][ci] Add github ci for flink-web to auto commit build files [flink-web]

2024-05-29 Thread via GitHub
GOODBOY008 commented on PR #732: URL: https://github.com/apache/flink-web/pull/732#issuecomment-2138805592 @MartijnVisser @XComp PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35483: --- Labels: pull-request-available (was: ) > BatchJobRecoveryTest related to JM failover produc

[jira] [Closed] (FLINK-33892) FLIP-383: Support Job Recovery from JobMaster Failures for Batch Jobs

2024-05-29 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33892. --- Fix Version/s: 1.20.0 Resolution: Done > FLIP-383: Support Job Recovery from JobMaster Failures for B

[PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-29 Thread via GitHub
JunRuiLee opened a new pull request, #24871: URL: https://github.com/apache/flink/pull/24871 ## What is the purpose of the change Fix unstable BatchJobRecoveryTest. ## Brief change log ## Verifying this change This change is already cove

Re: [PR] [FLINK-35461][config] Improve Runtime Configuration for Flink 2.0 [flink]

2024-05-29 Thread via GitHub
xintongsong commented on code in PR #24853: URL: https://github.com/apache/flink/pull/24853#discussion_r1620063207 ## flink-core/src/main/java/org/apache/flink/configuration/NettyShuffleEnvironmentOptions.java: ## @@ -428,6 +455,21 @@ public enum CompressionCodec {

[jira] [Commented] (FLINK-33892) FLIP-383: Support Job Recovery from JobMaster Failures for Batch Jobs

2024-05-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850599#comment-17850599 ] Rui Fan commented on FLINK-33892: - Thanks [~zhuzh] for the reminder, and [~JunRuiLi] for

[jira] [Updated] (FLINK-33892) FLIP-383: Support Job Recovery from JobMaster Failures for Batch Jobs

2024-05-29 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33892: Release Note: In 1.20, we introduced a batch job recovery mechanism to enable batch jobs to recover as mu

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
showuon commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620052845 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: Thanks @reswqa !

Re: [PR] [FLINK-35399][doc] Add documents for batch job recovery from jobMaster failover. [flink]

2024-05-29 Thread via GitHub
1996fanrui commented on code in PR #24855: URL: https://github.com/apache/flink/pull/24855#discussion_r1620051730 ## docs/content.zh/docs/ops/batch/recovery_from_job_master_failure.md: ## @@ -0,0 +1,96 @@ +--- +title: "Recovery job progress from job master failures" +weight: 4 +

Re: [PR] [FLINK-35399][doc] Add documents for batch job recovery from jobMaster failover. [flink]

2024-05-29 Thread via GitHub
1996fanrui commented on code in PR #24855: URL: https://github.com/apache/flink/pull/24855#discussion_r1620047917 ## docs/content.zh/docs/ops/batch/recovery_from_job_master_failure.md: ## @@ -0,0 +1,96 @@ +--- +title: "Recovery job progress from job master failures" +weight: 4 +

[jira] [Commented] (FLINK-33892) FLIP-383: Support Job Recovery from JobMaster Failures for Batch Jobs

2024-05-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850598#comment-17850598 ] Junrui Li commented on FLINK-33892: --- Thanks, [~zhuzh] , for the reminder. It seems tha

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
reswqa commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620040735 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: I'm not trying to

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
reswqa commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620040735 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: I'm not trying to

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850596#comment-17850596 ] Junrui Li commented on FLINK-35483: --- The issue arises from cases in BatchJobRecoveryTe

[PR] [minor][paimon] Remove duplicates implements. [flink-cdc]

2024-05-29 Thread via GitHub
joyCurry30 opened a new pull request, #3381: URL: https://github.com/apache/flink-cdc/pull/3381 Because WithPreCommitTopology has extended TwoPhaseCommittingSink, there is no need to implement the TwoPhaseCommittingSink interface separately. -- This is an automated message from the Apache

[jira] [Resolved] (FLINK-35379) File merging manager is not properly notified about checkpoint

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35379. - Fix Version/s: 1.20.0 Resolution: Fixed > File merging manager is not properly notified a

[jira] [Commented] (FLINK-35379) File merging manager is not properly notified about checkpoint

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850592#comment-17850592 ] Zakelly Lan commented on FLINK-35379: - Merged into master via 2bcc308d3600b429416b01

[jira] [Commented] (FLINK-35400) Rebuild FileMergingSnapshotManager in failover

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850590#comment-17850590 ] Zakelly Lan commented on FLINK-35400: - Merged into master via 54f037f9b2f08bd958d02e

[jira] [Resolved] (FLINK-35400) Rebuild FileMergingSnapshotManager in failover

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-35400. - Fix Version/s: 1.20.0 Resolution: Fixed > Rebuild FileMergingSnapshotManager in failover

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
showuon commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620010384 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: In English versio

[jira] [Commented] (FLINK-32088) Re-uploading in state file-merging for space amplification control

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850589#comment-17850589 ] Zakelly Lan commented on FLINK-32088: - Merged into master via 6ee30947a9184a0b877891

[jira] [Resolved] (FLINK-32088) Re-uploading in state file-merging for space amplification control

2024-05-29 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan resolved FLINK-32088. - Fix Version/s: 1.20.0 Resolution: Fixed > Re-uploading in state file-merging for space am

Re: [PR] [FLINK-32088][checkpoint] Space control in file merging [flink]

2024-05-29 Thread via GitHub
Zakelly merged PR #24807: URL: https://github.com/apache/flink/pull/24807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
reswqa commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1619978915 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: Is the english ver

[jira] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483 ] Junrui Li deleted comment on FLINK-35483: --- was (Author: JIRAUSER293716): The issue comes from cases in BatchJobRecoveryTest that require waiting for a batch job to finish recovering. Right now

[jira] [Commented] (FLINK-33892) FLIP-383: Support Job Recovery from JobMaster Failures for Batch Jobs

2024-05-29 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850582#comment-17850582 ] Zhu Zhu commented on FLINK-33892: - The feature development is done except for some follo

[jira] [Closed] (FLINK-35399) Add documents for batch job master failure recovery

2024-05-29 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-35399. --- Fix Version/s: 1.20.0 Resolution: Done aabfd6e2eaa37d554632129c959a309f85d528c5 > Add documents for

Re: [PR] [FLINK-35399][doc] Add documents for batch job recovery from jobMaster failover. [flink]

2024-05-29 Thread via GitHub
zhuzhurk merged PR #24855: URL: https://github.com/apache/flink/pull/24855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Created] (FLINK-35488) DataType Support Geometry Type

2024-05-29 Thread Leopold (Jira)
Leopold created FLINK-35488: --- Summary: DataType Support Geometry Type Key: FLINK-35488 URL: https://issues.apache.org/jira/browse/FLINK-35488 Project: Flink Issue Type: Improvement Compon

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850577#comment-17850577 ] Junrui Li commented on FLINK-35483: --- The issue comes from cases in BatchJobRecoveryTes

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850573#comment-17850573 ] Weijie Guo commented on FLINK-35483: [~JunRuiLi] Thanks for the quick reply, I have

[jira] [Assigned] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-35483: -- Assignee: Junrui Li > BatchJobRecoveryTest related to JM failover produced no output for 900

[jira] [Closed] (FLINK-35456) Many tests fails on AZP as NPE related to FileMerging

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-35456. -- Fix Version/s: 1.20.0 Resolution: Fixed This should be resolved by FLINK-35446. > Many tests f

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-05-29 Thread via GitHub
reswqa commented on PR #24544: URL: https://github.com/apache/flink/pull/24544#issuecomment-2138670012 @kumar-mallikarjuna Thanks for the rebase, could you squash these to some meaningful commits? I will merge this PR then. -- This is an automated message from the Apache Git Service. To r

[jira] [Updated] (FLINK-35487) ContinuousFileProcessingCheckpointITCase crashed as process exit with code 127

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35487: --- Description: {code:java} Process Exit Code: 127 May 29 16:46:04 16:46:04.495 [ERROR] Crashed tests:

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850567#comment-17850567 ] Junrui Li commented on FLINK-35483: --- Thanks [~Weijie Guo] , I will take a look. > Bat

[jira] [Created] (FLINK-35487) ContinuousFileProcessingCheckpointITCase crashed as process exit with code 127

2024-05-29 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35487: -- Summary: ContinuousFileProcessingCheckpointITCase crashed as process exit with code 127 Key: FLINK-35487 URL: https://issues.apache.org/jira/browse/FLINK-35487 Project: F

Re: [PR] Enable async profiler [flink-benchmarks]

2024-05-29 Thread via GitHub
SamBarker commented on PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138664126 @Zakelly I've pushed https://github.com/apache/flink-benchmarks/pull/90/commits/decdc8e2d161584a798461b4f381adba7cee731f which restores the JMH defaults from 1.19. Hopefully that a

Re: [PR] Enable async profiler [flink-benchmarks]

2024-05-29 Thread via GitHub
SamBarker commented on PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138632929 I've confirmed the runtime duration increase comes from upgrading JMH from 1.19 to 1.21. The minimum version for async profiler looks to be JMH 1.31. So if we want flame graphs 1.3

[jira] [Resolved] (FLINK-35409) Request more splits if all splits are filtered from addSplits method

2024-05-29 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35409. Resolution: Implemented master via: 19c382c0f2f2736baeb1c652130cb30dd98ca90c > Request more split

Re: [PR] [FLINK-35409][cdc][mysql] Request more splits if all splits are filtered from addSplits method [flink-cdc]

2024-05-29 Thread via GitHub
leonardBang merged PR #3342: URL: https://github.com/apache/flink-cdc/pull/3342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[jira] [Updated] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35484: --- Fix Version/s: 1.20.0 > Flink document file had removed but website can access > ---

[jira] [Updated] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35484: --- Affects Version/s: 1.19.0 > Flink document file had removed but website can access > ---

[jira] [Commented] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850558#comment-17850558 ] Leonard Xu commented on FLINK-35484: Thanks [~gongzhongqiang] for taking it, assigne

[jira] [Assigned] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35484: -- Assignee: Zhongqiang Gong > Flink document file had removed but website can access >

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-29 Thread via GitHub
showuon commented on PR #24863: URL: https://github.com/apache/flink/pull/24863#issuecomment-2138622168 @reswqa, please help take a look at the small doc update PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] [FLINK-35297][mysql] Add validation for option connect.timeout [flink-cdc]

2024-05-29 Thread via GitHub
ruanhang1993 commented on code in PR #3295: URL: https://github.com/apache/flink-cdc/pull/3295#discussion_r1619789988 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/table/MySqlTableSourceFactory.java: ##

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

2024-05-29 Thread via GitHub
yuxiqian closed pull request #24867: [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard URL: https://github.com/apache/flink/pull/24867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

2024-05-29 Thread via GitHub
yuxiqian commented on PR #24867: URL: https://github.com/apache/flink/pull/24867#issuecomment-2138565763 Ah I see. Thanks for your clarification! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-29 Thread via GitHub
flinkbot commented on PR #24870: URL: https://github.com/apache/flink/pull/24870#issuecomment-2138564099 ## CI report: * 0c70a19e64eea6cb7ba7699ce32c46a9bc85ab64 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-35486) Potential sql expression generation issues on SQL gateway

2024-05-29 Thread Xingcan Cui (Jira)
Xingcan Cui created FLINK-35486: --- Summary: Potential sql expression generation issues on SQL gateway Key: FLINK-35486 URL: https://issues.apache.org/jira/browse/FLINK-35486 Project: Flink Issue

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-29 Thread via GitHub
RocMarshal commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1619745280 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -93,16 +90,18 @@ spec: ``` {{< hint info >}} -When using the operator with Flink nat

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-29 Thread via GitHub
GOODBOY008 commented on PR #24870: URL: https://github.com/apache/flink/pull/24870#issuecomment-2138558371 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35484: --- Labels: pull-request-available (was: ) > Flink document file had removed but website can ac

[PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-29 Thread via GitHub
GOODBOY008 opened a new pull request, #24870: URL: https://github.com/apache/flink/pull/24870 Changes: - add `--delete` to delete file which source not exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Updated] (FLINK-35484) Flink document file had removed but website can access

2024-05-29 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-35484: Summary: Flink document file had removed but website can access (was: Flink Document docu

[jira] [Created] (FLINK-35485) JobMaster failed with "the job xx has not been finished"

2024-05-29 Thread Xingcan Cui (Jira)
Xingcan Cui created FLINK-35485: --- Summary: JobMaster failed with "the job xx has not been finished" Key: FLINK-35485 URL: https://issues.apache.org/jira/browse/FLINK-35485 Project: Flink Issue

[jira] [Commented] (FLINK-35484) Flink Document document file had removed but website can access

2024-05-29 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850548#comment-17850548 ] Zhongqiang Gong commented on FLINK-35484: - [~Leonard] This issue I had fixed in

[jira] [Created] (FLINK-35484) Flink Document document file had removed but website can access

2024-05-29 Thread Zhongqiang Gong (Jira)
Zhongqiang Gong created FLINK-35484: --- Summary: Flink Document document file had removed but website can access Key: FLINK-35484 URL: https://issues.apache.org/jira/browse/FLINK-35484 Project: Flink

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-29 Thread via GitHub
RocMarshal commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1619733319 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

2024-05-29 Thread via GitHub
X-czh commented on PR #24867: URL: https://github.com/apache/flink/pull/24867#issuecomment-2138542042 AFAIK, it is planned to remove the support for non-numeric gauge metric values in Flink 2.0, see [FLINK-6053](https://issues.apache.org/jira/browse/FLINK-6053). -- This is an automated m

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850543#comment-17850543 ] Weijie Guo commented on FLINK-35483: testRecoverFromJMFailover https://dev.azure.co

[jira] [Commented] (FLINK-35012) ChangelogNormalizeRestoreTest.testRestore failure

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850542#comment-17850542 ] Weijie Guo commented on FLINK-35012: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850541#comment-17850541 ] Weijie Guo commented on FLINK-35483: testRecoverDecidedParallelismFromTheSameJobGrap

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850540#comment-17850540 ] Weijie Guo commented on FLINK-35483: testRecoverDecidedParallelismFromTheSameJobGrap

[jira] [Updated] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35483: --- Summary: BatchJobRecoveryTest related to JM failover produced no output for 900 second (was: BatchJ

[jira] [Updated] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35483: --- Description: testRecoverFromJMFailover https://dev.azure.com/apache-flink/apache-flink/_build/resul

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850539#comment-17850539 ] Weijie Guo commented on FLINK-35483: testRecoverFromJMFailoverAndPartitionsUnavailab

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-29 Thread via GitHub
loserwang1024 commented on PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#issuecomment-2138531074 The finally advice, you can do same thing in org.apache.flink.cdc.debezium.DebeziumSourceFunction#notifyCheckpointComplete , or you mention in configuration document that this opt

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-05-29 Thread via GitHub
X-czh commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1619710677 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[jira] [Updated] (FLINK-35483) BatchJobRecoveryTest.testRecoverFromJMFailover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35483: --- Description: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=59919&view=logs&

[jira] [Created] (FLINK-35483) BatchJobRecoveryTest.testRecoverFromJMFailover produced no output for 900 second

2024-05-29 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-35483: -- Summary: BatchJobRecoveryTest.testRecoverFromJMFailover produced no output for 900 second Key: FLINK-35483 URL: https://issues.apache.org/jira/browse/FLINK-35483 Project:

Re: [PR] [FLINK-33462][Connector/JDBC] Sort out the document page about the new Jdbc source. [flink-connector-jdbc]

2024-05-29 Thread via GitHub
RocMarshal closed pull request #122: [FLINK-33462][Connector/JDBC] Sort out the document page about the new Jdbc source. URL: https://github.com/apache/flink-connector-jdbc/pull/122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [FLINK-35149][cdc-composer] Fix DataSinkTranslator#sinkTo ignoring pre-write topology if not TwoPhaseCommittingSink [flink-cdc]

2024-05-29 Thread via GitHub
loserwang1024 commented on PR #3233: URL: https://github.com/apache/flink-cdc/pull/3233#issuecomment-2138528049 > Hi @loserwang1024, could you please backport this patch to `release-3.1` branch so that it could be released with CDC 3.1.1? I'd like to, but it haven't been merged to mas

Re: [PR] [FLINK-35399][doc] Add documents for batch job recovery from jobMaster failover. [flink]

2024-05-29 Thread via GitHub
zhuzhurk commented on code in PR #24855: URL: https://github.com/apache/flink/pull/24855#discussion_r1619700579 ## docs/content/docs/ops/batch/recovery_from_job_master_failure.md: ## @@ -0,0 +1,113 @@ +--- +title: "Recovery job progress from job master failures" +weight: 4 +type

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-05-29 Thread via GitHub
X-czh commented on PR #24845: URL: https://github.com/apache/flink/pull/24845#issuecomment-2138522323 > Hi @X-czh thanks for the PR. I had a minor comment. In addition to that we might want to extend our tests to cover `TypeSerializerUpgradeTestBase`. WDYT? Hi @jeyhunkarimov, thanks f

Re: [PR] [FLINK-35461][config] Improve Runtime Configuration for Flink 2.0 [flink]

2024-05-29 Thread via GitHub
Sxnan commented on PR #24853: URL: https://github.com/apache/flink/pull/24853#issuecomment-2138517126 @xintongsong @TanYuxin-tyx Thanks for the review! I updated the PR accordingly. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Updated] (FLINK-35461) Improve Runtime Configuration for Flink 2.0

2024-05-29 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuannan Su updated FLINK-35461: --- Release Note: The following configurations have been deprecated as we are phasing out the hash-bas

Re: [PR] [FLINK-35461][config] Improve Runtime Configuration for Flink 2.0 [flink]

2024-05-29 Thread via GitHub
Sxnan commented on code in PR #24853: URL: https://github.com/apache/flink/pull/24853#discussion_r1619691173 ## flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/NettyShuffleEnvironmentConfiguration.java: ## @@ -373,11 +373,18 @@ public static NettyShuffleEnvironm

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-05-29 Thread via GitHub
1996fanrui commented on code in PR #24685: URL: https://github.com/apache/flink/pull/24685#discussion_r1597784913 ## flink-core/src/test/java/org/apache/flink/core/memory/CrossSegmentTypeTest.java: ## @@ -86,15 +84,15 @@ private void testCompare(MemorySegment seg1, MemorySegment

Re: [PR] [FLINK-33462][Connector/JDBC] Sort out the document page about the new Jdbc source. [flink-connector-jdbc]

2024-05-29 Thread via GitHub
RocMarshal commented on PR #122: URL: https://github.com/apache/flink-connector-jdbc/pull/122#issuecomment-2138508557 blocked by https://github.com/apache/flink-connector-jdbc/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] [hotfix][javadocs] Expand JavaDoc for PuncatedWatermarkGenerator [flink-kubernetes-operator]

2024-05-29 Thread via GitHub
soulmz opened a new pull request, #832: URL: https://github.com/apache/flink-kubernetes-operator/pull/832 ## What is the purpose of the change ## Brief change log - *`kubectl -f example/basic.yaml ` -> `kubectl apply -f example/basic.yaml `* ## Verifying this

[jira] [Updated] (FLINK-35482) ParquetInt64TimestampReaderTest unit tests fail due to system timezone

2024-05-29 Thread Rob Young (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Young updated FLINK-35482: -- Environment: on master commit 89c89d8522f779986f3f6f163d803e5d5f11ec62 (HEAD -> master, origin/master

[jira] [Created] (FLINK-35482) ParquetInt64TimestampReaderTest unit tests fail due to system timezone

2024-05-29 Thread Rob Young (Jira)
Rob Young created FLINK-35482: - Summary: ParquetInt64TimestampReaderTest unit tests fail due to system timezone Key: FLINK-35482 URL: https://issues.apache.org/jira/browse/FLINK-35482 Project: Flink

Re: [PR] Enable async profiler [flink-benchmarks]

2024-05-29 Thread via GitHub
SamBarker commented on PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2138478974 > It compiles & install flink before run benchmarks via /mnt/jenkins/tools/hudson.tasks.Maven_MavenInstallation/M3/bin/mvn -Dflink.version=1.20-SNAPSHOT clean install exec:exec -Pe

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-05-29 Thread via GitHub
jeyhunkarimov commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r161942 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-05-29 Thread via GitHub
rkhachatryan commented on code in PR #24869: URL: https://github.com/apache/flink/pull/24869#discussion_r1619465130 ## flink-core/src/main/java/org/apache/flink/configuration/AlgorithmOptions.java: ## @@ -60,4 +61,56 @@ public class AlgorithmOptions {

Re: [PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-05-29 Thread via GitHub
flinkbot commented on PR #24869: URL: https://github.com/apache/flink/pull/24869#issuecomment-2138245149 ## CI report: * 3b92e02418068b4ed7def5609dfc8b1fdf5d63e4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-34559) TVF Window Aggregations might get stuck

2024-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34559: --- Labels: pull-request-available (was: ) > TVF Window Aggregations might get stuck >

[PR] [FLINK-34559] Limit Global & Local Aggregation buffers [flink]

2024-05-29 Thread via GitHub
rkhachatryan opened a new pull request, #24869: URL: https://github.com/apache/flink/pull/24869 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring th

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-05-29 Thread via GitHub
sap1ens commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2138173997 > Would you recommend keeping it normal, String? Yes! And if someone needs base64 encoding they can encode it in the `SerializationSchema`. > I have a follow up qu

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-05-29 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2138092946 > @19priyadhingra 👋 I've had the opportunity to build and try this connector. Want to share some feedback: > > * Currently, it looks like all messages are encoded

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-05-29 Thread via GitHub
sap1ens commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2137994741 @19priyadhingra 👋 I've had the opportunity to build and try this connector. Want to share some feedback: - Currently, it looks like all messages are encoded with base64.

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-29 Thread via GitHub
liuml07 commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1619214815 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,14

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-29 Thread via GitHub
liuml07 commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1619214815 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,14

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-29 Thread via GitHub
liuml07 commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1619214117 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,14

[jira] [Updated] (FLINK-35363) FLIP-449: Reorganization of flink-connector-jdbc

2024-05-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35363: --- Labels: pull-request-available (was: ) > FLIP-449: Reorganization of flink-connector-jdbc >

  1   2   >