[jira] [Commented] (FLINK-33937) Translate "Stateful Stream Processing" page into Chinese

2024-05-30 Thread Pinrui Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850604#comment-17850604 ] Pinrui Dong commented on FLINK-33937: - It is still unsolved. Could you please assign

[jira] [Closed] (FLINK-35461) Improve Runtime Configuration for Flink 2.0

2024-05-30 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-35461. Fix Version/s: 1.20.0 Resolution: Done master (1.20): 132722e1b43607fe2236ecbbc3ba1faad1ad1

[jira] (FLINK-34953) Add github ci for flink-web to auto commit build files

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34953 ] Zhongqiang Gong deleted comment on FLINK-34953: - was (Author: JIRAUSER301076): Hi [~mapohl][~martijnvisser] , PR is ready, But the flink-web repo's ci is not enabled. Myabe open a ticket

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-30 Thread via GitHub
reswqa commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620086895 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: I means you should

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-30 Thread via GitHub
reswqa commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620086895 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: I mean you should

Re: [PR] [FLINK-35399][doc] Add documents for batch job recovery from jobMaster failover. [flink]

2024-05-30 Thread via GitHub
JunRuiLee commented on code in PR #24855: URL: https://github.com/apache/flink/pull/24855#discussion_r1620092964 ## docs/content.zh/docs/ops/batch/recovery_from_job_master_failure.md: ## @@ -0,0 +1,96 @@ +--- +title: "Recovery job progress from job master failures" +weight: 4 +t

Re: [PR] [BP-1.19][FLINK-34379][table] Fix adding catalogtable logic [flink]

2024-05-30 Thread via GitHub
JingGe merged PR #24860: URL: https://github.com/apache/flink/pull/24860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [BP-1.18][FLINK-34379][table] Fix adding catalogtable logic [flink]

2024-05-30 Thread via GitHub
JingGe merged PR #24861: URL: https://github.com/apache/flink/pull/24861 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [BP-1.17][FLINK-34379][table] Fix adding catalogtable logic [flink]

2024-05-30 Thread via GitHub
JingGe merged PR #24862: URL: https://github.com/apache/flink/pull/24862 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[PR] [FLINK-35399][doc] Update the batch job recovery documentation. [flink]

2024-05-30 Thread via GitHub
JunRuiLee opened a new pull request, #24872: URL: https://github.com/apache/flink/pull/24872 ## What is the purpose of the change Update the batch job recovery documentation. ## Brief change log Update the batch job recovery documentation. ## Verify

[jira] [Commented] (FLINK-34379) table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError

2024-05-30 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850610#comment-17850610 ] Jing Ge commented on FLINK-34379: - release-1.19: 663eeaf4092ed8c393b03ff6425f66559d97dc6

Re: [PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-30 Thread via GitHub
JunRuiLee commented on PR #24871: URL: https://github.com/apache/flink/pull/24871#issuecomment-2138842524 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35399][doc] Update the batch job recovery documentation. [flink]

2024-05-30 Thread via GitHub
flinkbot commented on PR #24872: URL: https://github.com/apache/flink/pull/24872#issuecomment-2138847340 ## CI report: * 58afe98f5c86b46cc7ee5e774b3d1cef256d5ff9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs-zh] maven should require v3.8.6, not higher [flink]

2024-05-30 Thread via GitHub
showuon commented on code in PR #24863: URL: https://github.com/apache/flink/pull/24863#discussion_r1620118257 ## docs/content.zh/docs/dev/configuration/maven.md: ## @@ -28,7 +28,7 @@ under the License. ## 要求 -- Maven 3.8.6 (推荐或者使用更高版本) Review Comment: My bad. Didn't ge

Re: [PR] [FLINK-34613][cdc] Support recover from a specific savepoint file [flink-cdc]

2024-05-30 Thread via GitHub
monologuist commented on PR #2959: URL: https://github.com/apache/flink-cdc/pull/2959#issuecomment-2138861809 @lvyanquan hi,请问您这个PR,所预期的从savepoint重启Flink CDC Pipeline作业的规范命令是这样吗? ``` 在${FLINK_CDC_HOME}目录下执行: $ ./bin/flink-cdc.sh mysql-to-doris.yaml -s /tmp/flink-savepoints/savep

[jira] [Updated] (FLINK-34613) allow specifing a savepoint file to restart using cli script.

2024-05-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34613: --- Labels: pull-request-available (was: ) > allow specifing a savepoint file to restart using

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-30 Thread via GitHub
XComp commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2138868656 I'm not gonna wait for another CI round. Looks like the CI bot didn't pick up the rerun command. Anyway, I verified that the test ran (see [logs](https://dev.azure.com/apache-flink/apache-f

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-30 Thread via GitHub
XComp commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2138886095 One final thing: I wasn't able to do it myself somehow. Can you change the commit message prefix from `[refactor]` to `[FLINK-20398]`? "refactor" isn't a prefix the Flink community usually

[jira] [Created] (FLINK-35489) Add capability to set min taskmanager.memory.managed.size when enabling autotuning

2024-05-30 Thread Nicolas Fraison (Jira)
Nicolas Fraison created FLINK-35489: --- Summary: Add capability to set min taskmanager.memory.managed.size when enabling autotuning Key: FLINK-35489 URL: https://issues.apache.org/jira/browse/FLINK-35489

Re: [PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-30 Thread via GitHub
JunRuiLee commented on PR #24871: URL: https://github.com/apache/flink/pull/24871#issuecomment-2138906588 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-35121) CDC pipeline connector should verify requiredOptions and optionalOptions

2024-05-30 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35121: --- Labels: pull-request-available (was: ) > CDC pipeline connector should verify requiredOptio

Re: [PR] [FLINK-35129][cdc][postgres] Add checkpoint cycle option for commit offsets [flink-cdc]

2024-05-30 Thread via GitHub
morazow commented on PR #3349: URL: https://github.com/apache/flink-cdc/pull/3349#issuecomment-2139025700 Hey @loserwang1024, Thanks for the suggestions! I was actually wondering about it. Since this is only feature for Postgres, initially I considered adding it in PostgresSQL

[jira] [Commented] (FLINK-35489) Add capability to set min taskmanager.memory.managed.size when enabling autotuning

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850635#comment-17850635 ] Rui Fan commented on FLINK-35489: - Hi [~nfraison.datadog] {quote}because we are relying

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-05-30 Thread via GitHub
affo commented on PR #24471: URL: https://github.com/apache/flink/pull/24471#issuecomment-2139041576 @XComp done! Don't worry in any case, I loved the review process. This is my first contribution and this is part of learning for next ones 🤝 -- This is an automated message from th

[jira] [Comment Edited] (FLINK-33937) Translate "Stateful Stream Processing" page into Chinese

2024-05-30 Thread Pinrui Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850604#comment-17850604 ] Pinrui Dong edited comment on FLINK-33937 at 5/30/24 8:40 AM:

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-05-30 Thread via GitHub
jeyhunkarimov commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1620282539 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35463]Fixed issue for route rule changed when restored from checkpoint. [flink-cdc]

2024-05-30 Thread via GitHub
yuxiqian commented on PR #3364: URL: https://github.com/apache/flink-cdc/pull/3364#issuecomment-2139108465 Hi @hk-lrzy, I've compiled Flink CDC on your branch and tried to verify this patch by doing the following steps: 1. Create a MySQL source with tables (`alice`, `bob`, and `chris`

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-30 Thread via GitHub
leonardBang commented on PR #24870: URL: https://github.com/apache/flink/pull/24870#issuecomment-2139125612 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Commented] (FLINK-34585) [JUnit5 Migration] Module: Flink CDC

2024-05-30 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850662#comment-17850662 ] Muhammet Orazov commented on FLINK-34585: - Hey all, Since this is lots of effor

[jira] [Created] (FLINK-35490) [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors

2024-05-30 Thread Muhammet Orazov (Jira)
Muhammet Orazov created FLINK-35490: --- Summary: [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors Key: FLINK-35490 URL: https://issues.apache.org/jira/browse/FLINK-35490

[jira] [Commented] (FLINK-35490) [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors

2024-05-30 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850663#comment-17850663 ] Muhammet Orazov commented on FLINK-35490: - I would be happy to work on this, ple

[jira] [Commented] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2024-05-30 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850664#comment-17850664 ] Kartikey Pant commented on FLINK-32384: --- Hello [~zhuzh], I am eager to start contr

[jira] [Created] (FLINK-35491) [JUnit5 Migration] Module: Flink CDC modules

2024-05-30 Thread Muhammet Orazov (Jira)
Muhammet Orazov created FLINK-35491: --- Summary: [JUnit5 Migration] Module: Flink CDC modules Key: FLINK-35491 URL: https://issues.apache.org/jira/browse/FLINK-35491 Project: Flink Issue Type

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
1996fanrui commented on code in PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119#discussion_r1620372109 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/ContinuousUnBoundingSettings.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to th

Re: [PR] [FLINK-35463]Fixed issue for route rule changed when restored from checkpoint. [flink-cdc]

2024-05-30 Thread via GitHub
hk-lrzy commented on PR #3364: URL: https://github.com/apache/flink-cdc/pull/3364#issuecomment-2139205095 > exception got it, let me do the double check and give you reply asap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620403861 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-30 Thread via GitHub
leonardBang merged PR #24870: URL: https://github.com/apache/flink/pull/24870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Resolved] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35484. Resolution: Fixed Fixed via master: b1841c0ff34b6e8d118139f6f87b7fdf06afacd3 > Flink document fil

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-05-30 Thread via GitHub
kumar-mallikarjuna commented on PR #24544: URL: https://github.com/apache/flink/pull/24544#issuecomment-2139268835 Done, @reswqa . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 10:40 AM: ---

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 10:41 AM: ---

[jira] [Commented] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek commented on FLINK-33001: - Just be able to try with the *flink-connector

Re: [PR] [docs] Improve the readme and issue template [flink-cdc]

2024-05-30 Thread via GitHub
caicancai commented on code in PR #3383: URL: https://github.com/apache/flink-cdc/pull/3383#discussion_r1620475491 ## .github/ISSUE_TEMPLATE/issue-notice.yml: ## @@ -47,6 +50,8 @@ body: 感谢您选择 Flink CDC! 由于 Apache Flink 的要求,请在 [Apache Jira](https://issues.apa

[jira] [Commented] (FLINK-35489) Add capability to set min taskmanager.memory.managed.size when enabling autotuning

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850694#comment-17850694 ] Nicolas Fraison commented on FLINK-35489: - Thks [~fanrui] for the feedback it he

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
twalthr commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1620578309 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Summary: Metaspace size can be too little after autotuning change memory setting (was: Ad

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Description: We have enable the autotuning feature on one of our flink job with below conf

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Description: We have enable the autotuning feature on one of our flink job with below conf

[jira] [Comment Edited] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850694#comment-17850694 ] Nicolas Fraison edited comment on FLINK-35489 at 5/30/24 12:07 PM: ---

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted nodejs dependency

2024-05-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850700#comment-17850700 ] Weijie Guo commented on FLINK-30719: {code:java} The archive file /__w/1/.m2/reposi

[jira] [Created] (FLINK-35492) Add metrics for FlinkStateSnapshot resources

2024-05-30 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-35492: Summary: Add metrics for FlinkStateSnapshot resources Key: FLINK-35492 URL: https://issues.apache.org/jira/browse/FLINK-35492 Project: Flink Issue Type: Sub-

[jira] [Created] (FLINK-35493) Make max history age and count configurable for FlinkStateSnapshot resources

2024-05-30 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-35493: Summary: Make max history age and count configurable for FlinkStateSnapshot resources Key: FLINK-35493 URL: https://issues.apache.org/jira/browse/FLINK-35493 Project:

Re: [PR] [FLINK-35199][table] Support the execution of create materialized table in full refresh mode [flink]

2024-05-30 Thread via GitHub
lsyldliu commented on code in PR #24866: URL: https://github.com/apache/flink/pull/24866#discussion_r1620385497 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -640,10 +750,15 @@ private

Re: [PR] Enable async profiler [flink-benchmarks]

2024-05-30 Thread via GitHub
Zakelly commented on PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2139458543 > @Zakelly I've pushed [decdc8e](https://github.com/apache/flink-benchmarks/commit/decdc8e2d161584a798461b4f381adba7cee731f) which restores the JMH defaults from 1.19. Hopefully that

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 1:07 PM:

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
RocMarshal commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2139538600 Hi, @1996fanrui . Kafka introduced KafkaSource API in the Flink 1.12 branch https://issues.apache.org/jira/browse/FLINK-18323 Afterwards, in Flink version 1.14, Kafk

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-30 Thread via GitHub
RocMarshal commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1620723423 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-26808][1.19] Limit FileUploadHandler to multipart routes [flink]

2024-05-30 Thread via GitHub
uce merged PR #24859: URL: https://github.com/apache/flink/pull/24859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.or

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2139649509 Backport for Flink 1.19: https://github.com/apache/flink-docker/pull/191 Backport for Flink 1.18: https://github.com/apache/flink-docker/pull/192 Backport for Flink 1.17: https://

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2139650422 Appreciate if I could get your review please! @MartijnVisser or @lincoln-lil :) -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [BP-1.19][FLINK-35358][clients] Reintroduce recursive JAR listing in classpath load from "usrlib" [flink]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #24792: URL: https://github.com/apache/flink/pull/24792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35358][clients] Reintroduce recursive JAR listing in classpath load from "usrlib" [flink]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #24791: URL: https://github.com/apache/flink/pull/24791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850727#comment-17850727 ] Hong Liang Teoh commented on FLINK-35358: -  merged commit [{{853989b}}|https://

[jira] [Commented] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850729#comment-17850729 ] Hong Liang Teoh commented on FLINK-35358: - merged commit [{{90a71a1}}|https://g

[jira] [Updated] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-35358: Fix Version/s: 1.20.0 > Breaking change when loading artifacts > -

[jira] [Updated] (FLINK-35367) Reorganize sinks

2024-05-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Boto updated FLINK-35367: -- Summary: Reorganize sinks (was: Reorganize datastream sink and source) > Reorganize sinks > -

[jira] [Closed] (FLINK-34379) table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh closed FLINK-34379. --- Resolution: Fixed > table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError > ---

[jira] [Resolved] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-35358. - Resolution: Fixed > Breaking change when loading artifacts > ---

[jira] [Commented] (FLINK-34379) table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850730#comment-17850730 ] Hong Liang Teoh commented on FLINK-34379: - Closing Jira as patch has been comple

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #191: URL: https://github.com/apache/flink-docker/pull/191#issuecomment-2139676975 Thanks @MartijnVisser. Merging the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #191: URL: https://github.com/apache/flink-docker/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #192: URL: https://github.com/apache/flink-docker/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #193: URL: https://github.com/apache/flink-docker/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Commented] (FLINK-34746) Switching to the Apache CDN for Dockerfile

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850732#comment-17850732 ] Hong Liang Teoh commented on FLINK-34746: -  merged commit [{{7f63237}}|https://

[jira] [Commented] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2024-05-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850734#comment-17850734 ] Zhu Zhu commented on FLINK-32384: - Thanks for volunteering to contribute to Flink. [~kar

Re: [PR] [FLINK-35399][doc] Update the batch job recovery documentation. [flink]

2024-05-30 Thread via GitHub
zhuzhurk merged PR #24872: URL: https://github.com/apache/flink/pull/24872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-35399) Add documents for batch job master failure recovery

2024-05-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850739#comment-17850739 ] Zhu Zhu commented on FLINK-35399: - 56cd9607713d0da874dcc54c4cf6d5b3b52b1050 refined the

Re: [PR] [hotfix][docs] Fix typo in alter.md [flink]

2024-05-30 Thread via GitHub
potterxu commented on PR #24858: URL: https://github.com/apache/flink/pull/24858#issuecomment-2139841619 Hi @swuferhong @luoyuxia , would you mind take a look at the above changes in doc? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-30 Thread via GitHub
zhuzhurk commented on code in PR #24871: URL: https://github.com/apache/flink/pull/24871#discussion_r1620899559 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/BatchJobRecoveryTest.java: ## @@ -257,6 +260,11 @@ void testRecoverFromJMFailover() thr

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621010106 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621010106 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

[jira] [Created] (FLINK-35494) Reorganize sources

2024-05-30 Thread Jira
João Boto created FLINK-35494: - Summary: Reorganize sources Key: FLINK-35494 URL: https://issues.apache.org/jira/browse/FLINK-35494 Project: Flink Issue Type: Sub-task Reporter: João

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
liuml07 commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621057382 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,14

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621068383 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson commented on FLINK-34023: --- [Here's](https://github.com/brada/flink-c

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:26 PM: --

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:28 PM: --

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:28 PM: --

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-05-30 Thread via GitHub
GOODBOY008 commented on PR #24685: URL: https://github.com/apache/flink/pull/24685#issuecomment-2140991378 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-05-30 Thread via GitHub
GOODBOY008 commented on PR #24685: URL: https://github.com/apache/flink/pull/24685#issuecomment-2141075315 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-34613][cdc] Support recover from a specific savepoint file [flink-cdc]

2024-05-30 Thread via GitHub
monologuist commented on PR #2959: URL: https://github.com/apache/flink-cdc/pull/2959#issuecomment-2141075378 > @lvyanquan hi,请问您这个PR,所预期的从savepoint重启Flink CDC Pipeline作业的规范命令是这样吗? > > ``` > 在${FLINK_CDC_HOME}目录下执行: > $ ./bin/flink-cdc.sh mysql-to-doris.yaml -s /tmp/flink-savepo

[jira] [Commented] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong commented on FLINK-35484: - After build document ci scheduled,I c

[jira] [Comment Edited] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong edited comment on FLINK-35484 at 5/31/24 1:31 AM:

[jira] [Comment Edited] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong edited comment on FLINK-35484 at 5/31/24 1:31 AM:

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
1996fanrui commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2141086375 > Maybe we should revert this commit and re-commit it in the next second or third version Sounds make sense to me. The JdbcSource is introduced in the current versio

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850892#comment-17850892 ] Rui Fan commented on FLINK-33463: - After discuss with [~RocMarshal] , it's better to sup

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850894#comment-17850894 ] Weijie Guo commented on FLINK-35483: https://dev.azure.com/apache-flink/apache-flink

  1   2   >