Re: [PR] [FLINK-33138] DataStream API implementation [flink-connector-prometheus]

2024-06-08 Thread via GitHub
nicusX commented on code in PR #1: URL: https://github.com/apache/flink-connector-prometheus/pull/1#discussion_r1632187848 ## README.md: ## @@ -8,6 +8,14 @@ Apache Flink is an open source stream processing framework with powerful stream- Learn more about Flink at [https://

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-08 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2156354857 > It'd also be great to mention what permissions are needed for this connector to work. E.g., is `sqs:SendMessage` sufficient? Good point!, Yes, `sqs:SendMessage`

Re: [PR] [FLINK-35453][core] StreamReader Charset fix with UTF8 in core files [flink]

2024-06-08 Thread via GitHub
xuzifu666 commented on PR #24842: URL: https://github.com/apache/flink/pull/24842#issuecomment-2156347384 > Hi @xuzifu666 thanks for driving this PR. Could you please update the intro section of this PR and add tests for your changes? Thanks @jeyhunkarimov Hi,it is not fitable for add

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1632183182 ## flink-connector-aws-e2e-tests/flink-connector-aws-sqs-e2e-tests/pom.xml: ## @@ -0,0 +1,122 @@ + + + +http://maven.apache.org/POM/4.0.0"; +

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1632182646 ## flink-connector-aws-e2e-tests/flink-connector-aws-sqs-e2e-tests/pom.xml: ## @@ -0,0 +1,122 @@ + + + +http://maven.apache.org/POM/4.0.0"; +

[jira] [Commented] (FLINK-34633) Support unnesting array constants

2024-06-08 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853436#comment-17853436 ] Jeyhun Karimov commented on FLINK-34633: Hi [~fanrui]  Yes, considering that pa

[jira] [Comment Edited] (FLINK-34633) Support unnesting array constants

2024-06-08 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853436#comment-17853436 ] Jeyhun Karimov edited comment on FLINK-34633 at 6/8/24 9:35 PM: --

Re: [PR] [FLINK-35548] Add E2E tests for PubSubSinkV2 [flink-connector-gcp-pubsub]

2024-06-08 Thread via GitHub
jeyhunkarimov commented on code in PR #28: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/28#discussion_r1632110151 ## flink-connector-gcp-pubsub-e2e-tests/src/test/java/org/apache/flink/connector/gcp/pubsub/sink/util/PubsubHelper.java: ## @@ -36,27 +40,50 @@ i

Re: [PR] [FLINK-34924][table] Support partition pushdown for join queries [flink]

2024-06-08 Thread via GitHub
jeyhunkarimov commented on PR #24559: URL: https://github.com/apache/flink/pull/24559#issuecomment-2156176949 Hi @libenchao kindly reminder for review in your available time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Description: Incorrect shading configuration causes ClassCastException during exce

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Description: Incorrect shading configuration causes ClassCastException during exce

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Description: Incorrect shading configuration causes ClassCastException during exce

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Attachment: Screenshot 2024-06-08 at 18.19.30.png > Shading issue cause class conf

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Description: Incorrect shading configuration causes ClassCastException during exce

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35559: --- Labels: pull-request-available (was: ) > Shading issue cause class conflict > -

[PR] [FLINK-35559][Connector/Kinesis] fix shading configuration to avoid class conflicts when using flink-connector-kinesis alongside Firehose sink [flink-connector-aws]

2024-06-08 Thread via GitHub
z3d1k opened a new pull request, #142: URL: https://github.com/apache/flink-connector-aws/pull/142 ## Purpose of the change Add `org.apache.flink.connector.aws.sink` to relocation list in order to prevent class conflicts while including `flink-connector-kinesis` alongside wit

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Description: Incorrect shading configuration causes ClassCastException during exce

[jira] [Updated] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko updated FLINK-35559: Component/s: Connectors / Firehose Connectors / Kinesis > Shading

[jira] [Created] (FLINK-35559) Shading issue cause class conflict

2024-06-08 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-35559: --- Summary: Shading issue cause class conflict Key: FLINK-35559 URL: https://issues.apache.org/jira/browse/FLINK-35559 Project: Flink Issue Type:

[jira] [Commented] (FLINK-35548) Add E2E tests for PubSubSinkV2

2024-06-08 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853409#comment-17853409 ] Ahmed Hamdy commented on FLINK-35548: - [~snuyanzin] Could you please help review thi

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-08 Thread via GitHub
lincoln-lil commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r1632045102 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/RelNodeBlock.scala: ## @@ -352,7 +353,14 @@ class RelNodeBlockPlanBui

Re: [PR] [FLINK-34482][checkpoint] Rename checkpointing options [flink]

2024-06-08 Thread via GitHub
masteryhx commented on code in PR #24878: URL: https://github.com/apache/flink/pull/24878#discussion_r1632041988 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -97,11 +97,11 @@ public class CheckpointingOptions { * to {@link

Re: [PR] [FLINK-34482][checkpoint] Rename checkpointing options [flink]

2024-06-08 Thread via GitHub
masteryhx commented on code in PR #24878: URL: https://github.com/apache/flink/pull/24878#discussion_r1632041854 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -210,11 +209,11 @@ public class CheckpointingOptions { * Local recov

[jira] [Commented] (FLINK-35138) Release flink-connector-kafka v3.2.0 for Flink 1.19

2024-06-08 Thread yazgoo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853367#comment-17853367 ] yazgoo commented on FLINK-35138: Awesome ! Thanks for your work ! > Release flink-conne

Re: [PR] [Flink-35473][table] Improve Table/SQL Configuration for Flink 2.0 [flink]

2024-06-08 Thread via GitHub
LadyForest commented on code in PR #24889: URL: https://github.com/apache/flink/pull/24889#discussion_r1631874007 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/optimize/RelNodeBlock.scala: ## @@ -352,7 +353,14 @@ class RelNodeBlockPlanBuil

[jira] [Commented] (FLINK-31533) CREATE TABLE AS SELECT should support to define partition

2024-06-08 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853357#comment-17853357 ] luoyuxia commented on FLINK-31533: -- [~spena] Greate! Feel free to take it! > CREATE TA

[jira] [Commented] (FLINK-33192) State memory leak in the Window Operator due to unregistered cleanup timer

2024-06-08 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17853344#comment-17853344 ] Kartikey Pant commented on FLINK-33192: --- Hello [~Yanfei Lei], I've submitted a Pu

Re: [PR] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-06-08 Thread via GitHub
flinkbot commented on PR #24917: URL: https://github.com/apache/flink/pull/24917#issuecomment-2155861840 ## CI report: * 7d3bbbd9e083bca422d8ea0f1d8928f2fb9ffe53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33192] Fix Memory Leak in WindowOperator due to Improper Timer Cleanup [flink]

2024-06-08 Thread via GitHub
kartikeypant opened a new pull request, #24917: URL: https://github.com/apache/flink/pull/24917 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring th