Re: [PR] [FLINK-36049] Add CompiledPlan annotations to BatchExecSortLimit [flink]

2024-08-16 Thread via GitHub
twalthr commented on code in PR #25207: URL: https://github.com/apache/flink/pull/25207#discussion_r1719432608 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecSortLimit.java: ## @@ -38,21 +40,47 @@ import org.apache

Re: [PR] [FLINK-36049] Add CompiledPlan annotations to BatchExecSortLimit [flink]

2024-08-16 Thread via GitHub
twalthr commented on PR #25207: URL: https://github.com/apache/flink/pull/25207#issuecomment-2292953228 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36048] Add CompiledPlan annotations to BatchExecRank [flink]

2024-08-16 Thread via GitHub
twalthr commented on code in PR #25206: URL: https://github.com/apache/flink/pull/25206#discussion_r1719447587 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/RankBatchRestoreTest.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to

[PR] Update hive_read_write.md [flink]

2024-08-16 Thread via GitHub
FSLiber opened a new pull request, #25210: URL: https://github.com/apache/flink/pull/25210 Fix ambiguous word -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Update hive_read_write.md [flink]

2024-08-16 Thread via GitHub
flinkbot commented on PR #25210: URL: https://github.com/apache/flink/pull/25210#issuecomment-2293039206 ## CI report: * 3e92557f44ba59c83df9f05fd56e2ed6d652ceba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36053][connectors/mongodb] Support multi-version integration test in mongodb connector [flink-connector-mongodb]

2024-08-16 Thread via GitHub
GOODBOY008 commented on code in PR #41: URL: https://github.com/apache/flink-connector-mongodb/pull/41#discussion_r1719513579 ## .github/workflows/push_pr.yml: ## @@ -28,14 +28,25 @@ jobs: compile_and_test: strategy: matrix: -flink: [ 1.18-SNAPSHOT ] -

Re: [PR] [FLINK-36053][connectors/mongodb] Support multi-version integration test in mongodb connector [flink-connector-mongodb]

2024-08-16 Thread via GitHub
GOODBOY008 commented on code in PR #41: URL: https://github.com/apache/flink-connector-mongodb/pull/41#discussion_r1719513579 ## .github/workflows/push_pr.yml: ## @@ -28,14 +28,25 @@ jobs: compile_and_test: strategy: matrix: -flink: [ 1.18-SNAPSHOT ] -

Re: [PR] [FLINK-36053][connectors/mongodb] Support multi-version integration test in mongodb connector [flink-connector-mongodb]

2024-08-16 Thread via GitHub
Jiabao-Sun merged PR #41: URL: https://github.com/apache/flink-connector-mongodb/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-33039) Avro Specific Record Logical timestamp is not serialized in Parquet

2024-08-16 Thread Nicolas Ferrario (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874152#comment-17874152 ] Nicolas Ferrario commented on FLINK-33039: -- Same here. It also happens when rea

[jira] [Resolved] (FLINK-36053) Support multi-version integration test in mongodb connector

2024-08-16 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun resolved FLINK-36053. Resolution: Implemented implemented by main: 97ec9b4314cdae92d050c112cef2112aed421e4e 4b8f5f93c2c1

Re: [PR] [hotfix] Update weekly builds against the latest released v1.2 branch [flink-connector-mongodb]

2024-08-16 Thread via GitHub
Jiabao-Sun merged PR #40: URL: https://github.com/apache/flink-connector-mongodb/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-16 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1719542058 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java: ## @@ -0,0 +1,1115 @@ +/* + * Licensed to the

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-16 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1719542058 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/GlueCatalog.java: ## @@ -0,0 +1,1115 @@ +/* + * Licensed to the

Re: [PR] [FLINK-30481][FLIP-277] GlueCatalog Implementation [flink-connector-aws]

2024-08-16 Thread via GitHub
Samrat002 commented on code in PR #47: URL: https://github.com/apache/flink-connector-aws/pull/47#discussion_r1719546294 ## flink-catalog-aws/flink-catalog-aws-glue/src/main/java/org/apache/flink/table/catalog/glue/util/GlueUtils.java: ## @@ -0,0 +1,384 @@ +/* + * Licensed to t

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-16 Thread via GitHub
rkhachatryan commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1719565014 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/util/PausableRelativeClock.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-16 Thread via GitHub
pnowojski commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1719583700 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/util/PausableRelativeClock.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-16 Thread via GitHub
pnowojski commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1719583700 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/util/PausableRelativeClock.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-36049] Add CompiledPlan annotations to BatchExecSortLimit [flink]

2024-08-16 Thread via GitHub
twalthr commented on PR #25207: URL: https://github.com/apache/flink/pull/25207#issuecomment-2293165758 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe.

2024-08-16 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-36076: - Summary: Hotfix: Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe. Key: FLINK-36076 URL: https://issues.apache.org/jira/browse/FLINK-36076 Proje

[jira] [Commented] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as isSchemaChangeApplying for thread safe.

2024-08-16 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874174#comment-17874174 ] Hongshun Wang commented on FLINK-36076: --- I'd like to do it. > Hotfix: Set isSchem

[jira] [Updated] (FLINK-36076) Hotfix: Set isSchemaChangeApplying as volatile for thread safe.

2024-08-16 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongshun Wang updated FLINK-36076: -- Summary: Hotfix: Set isSchemaChangeApplying as volatile for thread safe. (was: Hotfix: Set is

Re: [PR] [FLINK-35243] Extends schema change event types support [flink-cdc]

2024-08-16 Thread via GitHub
yuxiqian commented on PR #3521: URL: https://github.com/apache/flink-cdc/pull/3521#issuecomment-2293183939 Rebased & improved test coverage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Created] (FLINK-36077) Implement Table API support for PubSubSink V2

2024-08-16 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36077: --- Summary: Implement Table API support for PubSubSink V2 Key: FLINK-36077 URL: https://issues.apache.org/jira/browse/FLINK-36077 Project: Flink Issue Type: Sub-t

[jira] [Updated] (FLINK-36077) Implement Table API support for PubSubSink V2

2024-08-16 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-36077: Description: Duplicate of https://issues.apache.org/jira/browse/FLINK-24299 specific to Sink imple

[PR] [FLINK-36077][Connectors/Google PubSub] Implement table api support for SinkV2 [flink-connector-gcp-pubsub]

2024-08-16 Thread via GitHub
vahmed-hamdy opened a new pull request, #30: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/30 ## Description - Add Table Api support for PubSubSinkV2 [FLINK-36077] - Added credential providers options for Json Credentials and Access token credentials ## Testing -

[jira] [Updated] (FLINK-36077) Implement Table API support for PubSubSink V2

2024-08-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36077: --- Labels: pull-request-available (was: ) > Implement Table API support for PubSubSink V2 > --

Re: [PR] [FLINK-36077][Connectors/Google PubSub] Implement table api support for SinkV2 [flink-connector-gcp-pubsub]

2024-08-16 Thread via GitHub
vahmed-hamdy commented on PR #30: URL: https://github.com/apache/flink-connector-gcp-pubsub/pull/30#issuecomment-2293294073 @snuyanzin Could you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-16 Thread via GitHub
rkhachatryan commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1719692957 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/util/PausableRelativeClock.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-36077) Implement Table API support for PubSubSink V2

2024-08-16 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874190#comment-17874190 ] Ahmed Hamdy commented on FLINK-36077: - [~snuyanzin] Could you plz take a look when p

Re: [PR] [hotfix] Remove redundant maven properties with upgrade of flink-connector-parent to 1.1.0 [flink-connector-mongodb]

2024-08-16 Thread via GitHub
GOODBOY008 merged PR #42: URL: https://github.com/apache/flink-connector-mongodb/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-35997][table] Complete the Table API and Python API for LTRIM and RTRIM [flink]

2024-08-16 Thread via GitHub
lincoln-lil merged PR #25182: URL: https://github.com/apache/flink/pull/25182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[jira] [Closed] (FLINK-35997) Incomplete Table API & Python API of built-in function LTRIM & RTRIM

2024-08-16 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-35997. --- Assignee: Dylan He Resolution: Fixed Fixed in master: 500d274265d100e4fe091e27fa1d96cebd812c2d

[jira] [Assigned] (FLINK-34928) FLIP-439: Externalize Kudu Connector from Bahir

2024-08-16 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Csaky reassigned FLINK-34928: Assignee: Ferenc Csaky > FLIP-439: Externalize Kudu Connector from Bahir > --

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-16 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874301#comment-17874301 ] Hong Liang Teoh commented on FLINK-34023: - Hey [~atchesonaws] , your solution se

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-16 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874302#comment-17874302 ] Hong Liang Teoh commented on FLINK-34023: - Re: the testing fails, can you check

Re: [PR] [FLINK-36004] Deep copy the BinaryArrayData in ArrayDataSerializer#copy while using custom ArrayData [flink]

2024-08-16 Thread via GitHub
xccui merged PR #25208: URL: https://github.com/apache/flink/pull/25208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

Re: [PR] [FLINK-36004] Deep copy the BinaryArrayData in ArrayDataSerializer#copy while using custom ArrayData [flink]

2024-08-16 Thread via GitHub
xccui merged PR #25209: URL: https://github.com/apache/flink/pull/25209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Comment Edited] (FLINK-36004) Flink SQL returns wrong results for Paimon tables with complex schemas

2024-08-16 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874102#comment-17874102 ] Xingcan Cui edited comment on FLINK-36004 at 8/16/24 4:30 PM:

Re: [PR] [FLINK-36049] Add CompiledPlan annotations to BatchExecSortLimit [flink]

2024-08-16 Thread via GitHub
snuyanzin commented on PR #25207: URL: https://github.com/apache/flink/pull/25207#issuecomment-2293883982 Thanks for your contribution @jnh5y -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-36049] Add CompiledPlan annotations to BatchExecSortLimit [flink]

2024-08-16 Thread via GitHub
snuyanzin merged PR #25207: URL: https://github.com/apache/flink/pull/25207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-36049) Add CompiledPlan annotations to BatchExecSortLimit

2024-08-16 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36049: Component/s: Table SQL / Planner > Add CompiledPlan annotations to BatchExecSortLimit > --

[jira] [Commented] (FLINK-36049) Add CompiledPlan annotations to BatchExecSortLimit

2024-08-16 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874332#comment-17874332 ] Sergey Nuyanzin commented on FLINK-36049: - Merged as [99bf496b41cc30c5b633927a2

[jira] [Resolved] (FLINK-36049) Add CompiledPlan annotations to BatchExecSortLimit

2024-08-16 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36049. - Resolution: Fixed > Add CompiledPlan annotations to BatchExecSortLimit > ---

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-16 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874371#comment-17874371 ] Brad Atcheson edited comment on FLINK-34023 at 8/16/24 7:09 PM: --

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-08-16 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874371#comment-17874371 ] Brad Atcheson commented on FLINK-34023: --- Ah, thank you! Unit tests pass under Java

[jira] [Created] (FLINK-36078) Add Documentation for PubSubSink Table API connector

2024-08-16 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-36078: --- Summary: Add Documentation for PubSubSink Table API connector Key: FLINK-36078 URL: https://issues.apache.org/jira/browse/FLINK-36078 Project: Flink Issue Type

[PR] [FLINK-35016] catalog changes for model resource (#8) [flink]

2024-08-16 Thread via GitHub
lihaosky opened a new pull request, #25211: URL: https://github.com/apache/flink/pull/25211 [## What is the purpose of the change Catalog changes to support model resource ## Brief change log * Add `CatalogModel` related resource * Add model CRUD operations in `Cat

Re: [PR] [FLINK-35016] catalog changes for model resource [flink]

2024-08-16 Thread via GitHub
flinkbot commented on PR #25211: URL: https://github.com/apache/flink/pull/25211#issuecomment-2294376013 ## CI report: * 7d28f8478ea6823a7d176315ae7207791f95b96c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-34369) Elasticsearch connector supports SSL context

2024-08-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874427#comment-17874427 ] Mingliang Liu commented on FLINK-34369: --- Can we close this now? > Elasticsearch c

[jira] (FLINK-34369) Elasticsearch connector supports SSL context

2024-08-16 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34369 ] Mingliang Liu deleted comment on FLINK-34369: --- was (Author: liuml07): Can we close this now? > Elasticsearch connector supports SSL context > >

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-08-16 Thread via GitHub
liuml07 commented on PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#issuecomment-2294601880 Thank you @snuyanzin for taking another look. I see a lot of errors like this, and not sure if this is causing the compile & test to timeout > Warning: Coul