[jira] [Resolved] (FLINK-36397) Using the offset obtained after a query transaction as a high watermark cannot ensure exactly-once semantics.

2024-09-27 Thread Zhongmin Qiao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongmin Qiao resolved FLINK-36397. --- Resolution: Fixed > Using the offset obtained after a query transaction as a high watermark

[jira] [Updated] (FLINK-36397) Using the offset obtained after a query transaction as a high watermark cannot ensure exactly-once semantics.

2024-09-27 Thread Zhongmin Qiao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongmin Qiao updated FLINK-36397: -- Labels: pull-request-available (was: ) > Using the offset obtained after a query transaction

[jira] [Updated] (FLINK-36397) Using the offset obtained after a query transaction as a high watermark cannot ensure exactly-once semantics.

2024-09-27 Thread Zhongmin Qiao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongmin Qiao updated FLINK-36397: -- External issue URL: https://github.com/apache/flink-cdc/pull/3616 > Using the offset obtained

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
jectpro7 commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1779367317 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java: ## @@ -111,6 +111,6 @@ public enum StateRequestType { /** Get value

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
jectpro7 commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1779366932 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java: ## @@ -111,6 +111,6 @@ public enum StateRequestType { /** Get value

Re: [PR] [DRAFT][FLINK-36362][table] Remove dependency `flink-java` in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong commented on PR #25415: URL: https://github.com/apache/flink/pull/25415#issuecomment-2380411809 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
jectpro7 commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1779366932 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java: ## @@ -111,6 +111,6 @@ public enum StateRequestType { /** Get value

[jira] [Assigned] (FLINK-36397) Using the offset obtained after a query transaction as a high watermark cannot ensure exactly-once semantics.

2024-09-27 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36397: -- Assignee: Zhongmin Qiao > Using the offset obtained after a query transaction as a high water

Re: [PR] [FLINK-35888][cdc-connector][paimon] Add e2e test for PaimonDataSink. [flink-cdc]

2024-09-27 Thread via GitHub
github-actions[bot] commented on PR #3491: URL: https://github.com/apache/flink-cdc/pull/3491#issuecomment-2380300870 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [DRAFT][FLINK-36336] Remove deprecated dataset API dependency exclude table module [flink]

2024-09-27 Thread via GitHub
codenohup commented on PR #25365: URL: https://github.com/apache/flink/pull/25365#issuecomment-2379531348 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36362][table] Remove dependency `flink-java` in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong commented on PR #25415: URL: https://github.com/apache/flink/pull/25415#issuecomment-2379169236 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-28407] Added automation creation of Jenkins script parameters with default values [flink-benchmarks]

2024-09-27 Thread via GitHub
pnowojski merged PR #57: URL: https://github.com/apache/flink-benchmarks/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-34702][table] Do not deduplicate GroupAggregate and some joins for rank [flink]

2024-09-27 Thread via GitHub
snuyanzin closed pull request #25372: [FLINK-34702][table] Do not deduplicate GroupAggregate and some joins for rank URL: https://github.com/apache/flink/pull/25372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-34702][table] Do not deduplicate GroupAggregate and some joins for rank [flink]

2024-09-27 Thread via GitHub
snuyanzin commented on PR #25372: URL: https://github.com/apache/flink/pull/25372#issuecomment-2379995110 сдщыув шт афмщк ща https://github.com/apache/flink/pull/25380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-36362][table] Remove dependency `flink-java` in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong closed pull request #25415: [FLINK-36362][table] Remove dependency `flink-java` in table modules URL: https://github.com/apache/flink/pull/25415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-36389][security] Add check in DelegationTokenReceiverRepository for DT enabled flag [flink]

2024-09-27 Thread via GitHub
gaborgsomogyi commented on PR #25412: URL: https://github.com/apache/flink/pull/25412#issuecomment-2379926299 Intended to merge after green tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-36389][security] Add check in DelegationTokenReceiverRepository for DT enabled flag [flink]

2024-09-27 Thread via GitHub
gaborgsomogyi commented on PR #25412: URL: https://github.com/apache/flink/pull/25412#issuecomment-2379926759 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Resolved] (FLINK-36177) Deprecating KafkaShuffle

2024-09-27 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise resolved FLINK-36177. - Fix Version/s: kafka-3.3.0 Release Note: Deprecated KafkaShuffle and related API Reso

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-27 Thread via GitHub
JNSimba commented on PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2379575904 I changed this to compare timestamp in **BinlogOffset.compare** method, so there is no need to set serverid, PTAL, thanks @ruanhang1993 -- This is an automated message from the Apach

Re: [PR] [FLINK-36389][security] Add check in DelegationTokenReceiverRepository for DT enabled flag [flink]

2024-09-27 Thread via GitHub
argoyal2212 commented on PR #25412: URL: https://github.com/apache/flink/pull/25412#issuecomment-2379903359 @gaborgsomogyi updated the PR. Can I get a review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]

2024-09-27 Thread via GitHub
AHeise merged PR #121: URL: https://github.com/apache/flink-connector-kafka/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[PR] [FLINK-36362][table] Remove dependency flink-java in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong opened a new pull request, #25420: URL: https://github.com/apache/flink/pull/25420 ## What is the purpose of the change Remove all class dependencies from `flink-java` in table modules. Note: I have ensured that all table modules does not depend on the `flink-java`

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on PR #25331: URL: https://github.com/apache/flink/pull/25331#issuecomment-2379599167 > For the ArchTest of connectors, I'm not sure disabling all of them directly is the right solution. If I understand correctly, we need to add those connector classes that violates the

Re: [PR] [FLINK-36366][core] Remove deprecate API in flink-core exclude connector and state part [flink]

2024-09-27 Thread via GitHub
reswqa closed pull request #25396: [FLINK-36366][core] Remove deprecate API in flink-core exclude connector and state part URL: https://github.com/apache/flink/pull/25396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [FLINK-36378][table] Fix type extraction bug between java BigDecimal … [flink]

2024-09-27 Thread via GitHub
JingGe commented on code in PR #25404: URL: https://github.com/apache/flink/pull/25404#discussion_r1778975324 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java: ## @@ -126,6 +126,10 @@ private static DataType convertTo

Re: [PR] Debug Flink E2E by azure pipeline [flink]

2024-09-27 Thread via GitHub
xuyangzhong closed pull request #25386: Debug Flink E2E by azure pipeline URL: https://github.com/apache/flink/pull/25386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [FLINK-36378][table] Fix type extraction bug between java BigDecimal … [flink]

2024-09-27 Thread via GitHub
JingGe commented on code in PR #25404: URL: https://github.com/apache/flink/pull/25404#discussion_r1778975324 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java: ## @@ -126,6 +126,10 @@ private static DataType convertTo

[PR] [DRAFT][FLINK-36336] Remove deprecated dataset API exclude table module [flink]

2024-09-27 Thread via GitHub
codenohup opened a new pull request, #25419: URL: https://github.com/apache/flink/pull/25419 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[jira] [Commented] (FLINK-5601) Window operator does not checkpoint watermarks

2024-09-27 Thread juntaozhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885422#comment-17885422 ] juntaozhang commented on FLINK-5601: Hi all, has this issue been resolved? I tested i

Re: [PR] [FLINK-5601][Checkpointing] Watermark checkpointing [flink]

2024-09-27 Thread via GitHub
juntaozhang commented on PR #7013: URL: https://github.com/apache/flink/pull/7013#issuecomment-2379674878 Hi, I’m curious why this pull request hasn’t been merged yet. Could anyone provide context? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Updated] (FLINK-31986) Implement Integration test for FLIP-27 DataStreams API

2024-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31986: --- Labels: pull-request-available (was: ) > Implement Integration test for FLIP-27 DataStreams

[PR] [FLINK-31986][Connectors/Kinesis] Setup integration tests for source [flink-connector-aws]

2024-09-27 Thread via GitHub
elphastori opened a new pull request, #172: URL: https://github.com/apache/flink-connector-aws/pull/172 ## Purpose of the change Sets up Integrations tests for the FLIP-27 DataStreams API Kinesis source ## Verifying this change This change added tests and can be v

Re: [PR] [FLINK-36057][Connector/DynamoDB] Use Table ARN for DDB sink [flink-connector-aws]

2024-09-27 Thread via GitHub
elphastori closed pull request #157: [FLINK-36057][Connector/DynamoDB] Use Table ARN for DDB sink URL: https://github.com/apache/flink-connector-aws/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778851640 ## flink-walkthroughs/flink-walkthrough-common/pom.xml: ## @@ -43,4 +43,74 @@ under the License. provided + +

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778847740 ## flink-end-to-end-tests/flink-confluent-schema-registry/src/main/java/org/apache/flink/schema/registry/test/TestAvroConsumerConfluent.java: ## @@ -85,35 +81,39 @@ p

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778837890 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java: ## @@ -1014,8 +1014,8 @@ public DataStreamSink printToErr(String sinkIdenti

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778810353 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java: ## @@ -258,17 +198,7 @@ protected void submit

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
lvyanquan commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778809886 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/BatchSink.java: ## @@ -73,64 +51,4 @@ public static DataStreamSink

Re: [PR] [FLINK-36362][table] Remove dependency `flink-java` in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong commented on PR #25415: URL: https://github.com/apache/flink/pull/25415#issuecomment-2379549438 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]

2024-09-27 Thread via GitHub
AHeise commented on code in PR #121: URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778785067 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java: ## @@ -18,39 +18,15 @@ package o

Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]

2024-09-27 Thread via GitHub
AHeise commented on code in PR #121: URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778785067 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java: ## @@ -18,39 +18,15 @@ package o

Re: [PR] [hotfix] Bumps Flink snapshot version and related flink-shaded version [flink-benchmarks]

2024-09-27 Thread via GitHub
pnowojski closed pull request #87: [hotfix] Bumps Flink snapshot version and related flink-shaded version URL: https://github.com/apache/flink-benchmarks/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on PR #25261: URL: https://github.com/apache/flink/pull/25261#issuecomment-2379381101 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [hotfix] Bumps Flink snapshot version and related flink-shaded version [flink-benchmarks]

2024-09-27 Thread via GitHub
pnowojski commented on PR #87: URL: https://github.com/apache/flink-benchmarks/pull/87#issuecomment-2379487392 It looks like this got superseded by some other changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[jira] [Created] (FLINK-36399) cast result is incorrect

2024-09-27 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-36399: - Summary: cast result is incorrect Key: FLINK-36399 URL: https://issues.apache.org/jira/browse/FLINK-36399 Project: Flink Issue Type: Bug Components: Tabl

Re: [PR] Use chronological order timestamp for timers [flink-benchmarks]

2024-09-27 Thread via GitHub
pnowojski commented on PR #94: URL: https://github.com/apache/flink-benchmarks/pull/94#issuecomment-2379493463 Change looks good to me, but there seems to be a compilation failure? 🤔 I think it's unrelated, but could you take a look at it @zhiyisun ? -- This is an automated message from t

Re: [PR] [FLINK-23208] Add a benchmark for processing timers [flink-benchmarks]

2024-09-27 Thread via GitHub
pnowojski commented on PR #25: URL: https://github.com/apache/flink-benchmarks/pull/25#issuecomment-2379432672 Thanks for the explanation @zhiyisun . Option 2. sounds to me preferable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-36395][state/forst] Graceful quit for Forst StateBackend [flink]

2024-09-27 Thread via GitHub
Zakelly commented on PR #25416: URL: https://github.com/apache/flink/pull/25416#issuecomment-2379421566 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on code in PR #25261: URL: https://github.com/apache/flink/pull/25261#discussion_r1778695341 ## docs/content.zh/docs/dev/datastream/operators/overview.md: ## @@ -198,19 +198,19 @@ data_stream.key_by(lambda x: x[1]).reduce(lambda a, b: (a[0] + b[0], b[1])) ```ja

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on code in PR #25261: URL: https://github.com/apache/flink/pull/25261#discussion_r1778694960 ## README.md: ## @@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n') val windowCounts = text.flatMap { w => w.split("\\s") } .map { w => WordWithCount

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on PR #25261: URL: https://github.com/apache/flink/pull/25261#issuecomment-2379378432 > Bit irritated that we still got scala examples in the docs, but it's not a problem for this PR I suppose. Looks like there is a separate issue FLINK-36352 for that. -- This is an

Re: [PR] [FLINK-36378][table] Fix type extraction bug between java BigDecimal … [flink]

2024-09-27 Thread via GitHub
dylanhz commented on code in PR #25404: URL: https://github.com/apache/flink/pull/25404#discussion_r1778335511 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java: ## @@ -126,6 +126,10 @@ private static DataType convertT

Re: [PR] [Flink 36245] Remove legacy SourceFunction / SinkFunction / Sink V1 API in 2.0 [flink]

2024-09-27 Thread via GitHub
PatrickRen commented on code in PR #25331: URL: https://github.com/apache/flink/pull/25331#discussion_r1778440599 ## pom.xml: ## @@ -2420,6 +2420,10 @@ under the License. org.apache.flink.api.java.typeutils.Writabl

[jira] [Assigned] (FLINK-36348) Netty shuffle direct memory consumption end-to-end test failed due to direct memory OOM

2024-09-27 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xuannan Su reassigned FLINK-36348: -- Assignee: Xuannan Su > Netty shuffle direct memory consumption end-to-end test failed due to

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
zentol commented on code in PR #25261: URL: https://github.com/apache/flink/pull/25261#discussion_r1778601591 ## docs/content.zh/docs/dev/datastream/operators/overview.md: ## @@ -198,19 +198,19 @@ data_stream.key_by(lambda x: x[1]).reduce(lambda a, b: (a[0] + b[0], b[1])) ```j

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
zentol commented on code in PR #25261: URL: https://github.com/apache/flink/pull/25261#discussion_r1778600247 ## README.md: ## @@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n') val windowCounts = text.flatMap { w => w.split("\\s") } .map { w => WordWithCoun

Re: [PR] [FLINK-36181][build] Bump CI Java version to 11 [flink]

2024-09-27 Thread via GitHub
rmetzger commented on PR #25413: URL: https://github.com/apache/flink/pull/25413#issuecomment-2379225686 You also need to modify https://github.com/apache/flink/blob/master/tools/azure-pipelines/build-apache-repo.yml -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [DRAFT][FLINK-36336] Remove deprecated dataset API dependency exclude table module [flink]

2024-09-27 Thread via GitHub
codenohup commented on PR #25365: URL: https://github.com/apache/flink/pull/25365#issuecomment-2379233298 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-33634) Add Conditions to Flink CRD's Status field

2024-09-27 Thread lajith (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885358#comment-17885358 ] lajith commented on FLINK-33634: [~ryanvanhuuksloot]  In session mode, we will go with R

Re: [PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2024-09-27 Thread via GitHub
davidradl commented on code in PR #25418: URL: https://github.com/apache/flink/pull/25418#discussion_r1778559000 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala: ## @@ -679,13 +679,15 @@ class ExprCodeGenerator(ctx

Re: [PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2024-09-27 Thread via GitHub
davidradl commented on code in PR #25418: URL: https://github.com/apache/flink/pull/25418#discussion_r1778559000 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala: ## @@ -679,13 +679,15 @@ class ExprCodeGenerator(ctx

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
Zakelly commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1778555891 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java: ## @@ -111,6 +111,6 @@ public enum StateRequestType { /** Get value

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
Zakelly commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1778555116 ## flink-runtime/src/main/java/org/apache/flink/runtime/asyncprocessing/StateRequestType.java: ## @@ -111,6 +111,6 @@ public enum StateRequestType { /** Get value

[jira] [Commented] (FLINK-36399) cast result is incorrect

2024-09-27 Thread david radley (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885343#comment-17885343 ] david radley commented on FLINK-36399: -- [~jackylau] I see this flag is deprecated -

Re: [PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2024-09-27 Thread via GitHub
davidradl commented on code in PR #25418: URL: https://github.com/apache/flink/pull/25418#discussion_r1778517118 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/ExprCodeGenerator.scala: ## @@ -679,13 +679,15 @@ class ExprCodeGenerator(ctx

[jira] [Updated] (FLINK-36399) cast result is incorrect

2024-09-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36399: --- Labels: pull-request-available (was: ) > cast result is incorrect > ---

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on PR #25261: URL: https://github.com/apache/flink/pull/25261#issuecomment-237902 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [FLINK-36399][table] Fix incorrect cast behavior. [flink]

2024-09-27 Thread via GitHub
liuyongvs opened a new pull request, #25418: URL: https://github.com/apache/flink/pull/25418 ## What is the purpose of the change Fix incorrect cast behavior. ## Verifying this change This change is already covered by existing tests ## Does this pull request potent

[jira] [Commented] (FLINK-36356) HadoopRecoverableWriterTest.testRecoverWithState due to IOException

2024-09-27 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885337#comment-17885337 ] Matthias Pohl commented on FLINK-36356: --- https://dev.azure.com/apache-flink/apache

Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

2024-09-27 Thread via GitHub
XComp commented on PR #25261: URL: https://github.com/apache/flink/pull/25261#issuecomment-2379099107 Failure related to FLINK-36356. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-36398) Provide Schema conversion tools

2024-09-27 Thread JunboWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JunboWang updated FLINK-36398: -- Description: Sometimes users do not want to use Flink CDC to automatically create tables. Users want t

Re: [PR] [FLINK-36378][table] Fix type extraction bug between java BigDecimal … [flink]

2024-09-27 Thread via GitHub
liuyongvs commented on code in PR #25404: URL: https://github.com/apache/flink/pull/25404#discussion_r1778461405 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java: ## @@ -126,6 +126,10 @@ private static DataType conver

Re: [PR] [FLINK-36362][table] Remove dependency `flink-java` in table modules [flink]

2024-09-27 Thread via GitHub
xuyangzhong commented on PR #25415: URL: https://github.com/apache/flink/pull/25415#issuecomment-2379013436 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-36323][StateBackend] Remove deprecated MemoryStateBackend, FsStateBackend and RocksDBStateBackend [flink]

2024-09-27 Thread via GitHub
xing1mo commented on PR #25409: URL: https://github.com/apache/flink/pull/25409#issuecomment-2378990566 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-36355][runtime] Remove deprecated metrics [flink]

2024-09-27 Thread via GitHub
yunfengzhou-hub opened a new pull request, #25417: URL: https://github.com/apache/flink/pull/25417 ## What is the purpose of the change Remove deprecated metrics ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## D

Re: [PR] [FLINK-36177] Deprecate KafkaShuffle and more [flink-connector-kafka]

2024-09-27 Thread via GitHub
fapaul commented on code in PR #121: URL: https://github.com/apache/flink-connector-kafka/pull/121#discussion_r1778335632 ## flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/partitioner/FlinkKafkaPartitioner.java: ## @@ -18,39 +18,15 @@ package o

Re: [PR] [FLINK-36323][StateBackend] Remove deprecated MemoryStateBackend, FsStateBackend and RocksDBStateBackend [flink]

2024-09-27 Thread via GitHub
xing1mo commented on PR #25409: URL: https://github.com/apache/flink/pull/25409#issuecomment-2378916211 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36378][table] Fix type extraction bug between java BigDecimal … [flink]

2024-09-27 Thread via GitHub
dylanhz commented on code in PR #25404: URL: https://github.com/apache/flink/pull/25404#discussion_r1778335511 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/utils/ValueDataTypeConverter.java: ## @@ -126,6 +126,10 @@ private static DataType convertT

[jira] [Commented] (FLINK-36378) type extraction problem between java BigDecimal and sql decimal

2024-09-27 Thread Dylan He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885288#comment-17885288 ] Dylan He commented on FLINK-36378: -- There is already a PR about this issue: [https://g

[jira] [Comment Edited] (FLINK-36290) OutOfMemoryError in connect test run

2024-09-27 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885280#comment-17885280 ] Xuannan Su edited comment on FLINK-36290 at 9/27/24 9:19 AM: -

[jira] [Comment Edited] (FLINK-36290) OutOfMemoryError in connect test run

2024-09-27 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885280#comment-17885280 ] Xuannan Su edited comment on FLINK-36290 at 9/27/24 9:19 AM: -

Re: [PR] [FLINK-36323][StateBackend] Remove deprecated MemoryStateBackend, FsStateBackend and RocksDBStateBackend [flink]

2024-09-27 Thread via GitHub
xing1mo commented on PR #25409: URL: https://github.com/apache/flink/pull/25409#issuecomment-2378826238 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-27 Thread via GitHub
JNSimba commented on code in PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:

[jira] [Commented] (FLINK-33045) format avro-confluent - disable auto-registering schema in registry

2024-09-27 Thread nicolas paris (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885284#comment-17885284 ] nicolas paris commented on FLINK-33045: --- attempt to fix this one. Tested with the

[jira] [Updated] (FLINK-36306) Remove deprecated API for 2.0-preview

2024-09-27 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-36306: --- Description: ||Module||Contributor||Status|| |flink-sql-connector-hive-3.1.3_2.12|[~xuyangzhong]| |

[jira] [Updated] (FLINK-36306) Remove deprecated API for 2.0-preview

2024-09-27 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-36306: --- Description: ||Module||Contributor||Status|| |flink-sql-connector-hive-3.1.3_2.12|[~xuyangzhong]| |

[jira] [Resolved] (FLINK-36366) Remove deprecate API in flink-core exclude connector and state part

2024-09-27 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-36366. Resolution: Done master(2.0) via 6633719c. > Remove deprecate API in flink-core exclude connector

Re: [PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]

2024-09-27 Thread via GitHub
Zakelly commented on code in PR #25403: URL: https://github.com/apache/flink/pull/25403#discussion_r1778286768 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java: ## @@ -110,6 +112,8 @@ public StreamingRuntimeContext( th

[jira] [Updated] (FLINK-36398) Provide tools for users to schema conversion

2024-09-27 Thread JunboWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JunboWang updated FLINK-36398: -- Summary: Provide tools for users to schema conversion (was: Provide tools for users to obtain Schema

Re: [PR] [FLINK-36376] More friendly error or warn message for misconfigured statebackend with async state processing [flink]

2024-09-27 Thread via GitHub
fredia commented on code in PR #25403: URL: https://github.com/apache/flink/pull/25403#discussion_r1778284554 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamingRuntimeContext.java: ## @@ -110,6 +112,8 @@ public StreamingRuntimeContext( thi

[jira] [Updated] (FLINK-36398) Provide Schema conversion tools

2024-09-27 Thread JunboWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JunboWang updated FLINK-36398: -- Summary: Provide Schema conversion tools (was: Provide tools for users to schema conversion) > Provi

[jira] [Updated] (FLINK-36398) Provide tools for users to obtain Schema mapping

2024-09-27 Thread JunboWang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] JunboWang updated FLINK-36398: -- Description: Sometimes users do not want to use Flink CDC to automatically create tables. Users want t

[jira] [Commented] (FLINK-36290) OutOfMemoryError in connect test run

2024-09-27 Thread Xuannan Su (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17885280#comment-17885280 ] Xuannan Su commented on FLINK-36290: It is probably related to the [commit|http://

[jira] [Created] (FLINK-36398) Provide tools for users to obtain Schema mapping

2024-09-27 Thread JunboWang (Jira)
JunboWang created FLINK-36398: - Summary: Provide tools for users to obtain Schema mapping Key: FLINK-36398 URL: https://issues.apache.org/jira/browse/FLINK-36398 Project: Flink Issue Type: Improv

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-27 Thread via GitHub
JNSimba commented on code in PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
fredia commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1778269896 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStAggregatingState.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Apac

Re: [PR] [FLINK-36395][state/forst] Graceful quit for Forst StateBackend [flink]

2024-09-27 Thread via GitHub
Zakelly commented on PR #25416: URL: https://github.com/apache/flink/pull/25416#issuecomment-2378779993 @fredia Thanks for the review, updated accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2024-09-27 Thread via GitHub
JNSimba commented on code in PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#discussion_r1778269742 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/debezium/task/MySqlSnapshotSplitReadTask.java:

Re: [PR] [FLINK-34975][state/forst] Implement Aggregating Async State API for ForStStateBackend [flink]

2024-09-27 Thread via GitHub
jectpro7 commented on code in PR #25125: URL: https://github.com/apache/flink/pull/25125#discussion_r1778263507 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStAggregatingState.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to the Ap

Re: [PR] [DRAFT][FLINK-36336] Remove deprecated dataset API dependency exclude table module [flink]

2024-09-27 Thread via GitHub
reswqa commented on PR #25365: URL: https://github.com/apache/flink/pull/25365#issuecomment-2378767915 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

  1   2   >