[jira] [Commented] (FLINK-35652) FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join

2024-09-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882864#comment-17882864 ] Benchao Li commented on FLINK-35652: Thank you for the update, Weijie, that sounds g

[jira] [Commented] (FLINK-35652) FLIP-462: Support Custom Data Distribution for Input Stream of Lookup Join

2024-09-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882854#comment-17882854 ] Benchao Li commented on FLINK-35652: [~Weijie Guo] Hi Weijie, may I ask what's the s

[jira] [Commented] (FLINK-35341) Retraction stop working with Clock dependent function in Filter

2024-05-19 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17847771#comment-17847771 ] Benchao Li commented on FLINK-35341: I think it's a known issue, and has been resolv

[jira] [Updated] (FLINK-30586) Fix calcCodeGen failed if calc with like condition contains double quotation mark

2024-04-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-30586: --- Fix Version/s: 1.16.1 > Fix calcCodeGen failed if calc with like condition contains double quotation

[jira] [Assigned] (FLINK-35037) Optimize uniqueKeys and upsertKeys inference of windows with ROW_NUMBER

2024-04-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-35037: -- Assignee: yisha zhou > Optimize uniqueKeys and upsertKeys inference of windows with ROW_NUMBE

[jira] [Commented] (FLINK-35037) Optimize uniqueKeys and upsertKeys inference of windows with ROW_NUMBER

2024-04-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17835158#comment-17835158 ] Benchao Li commented on FLINK-35037: [~nilerzhou]  Assigned to you :) > Optimize un

[jira] [Commented] (FLINK-34656) Generated code for `ITEM` operator should return null when getting element of a null map/array/row

2024-03-27 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17831623#comment-17831623 ] Benchao Li commented on FLINK-34656: [~nilerzhou] Thank you for the test case, it he

[jira] [Commented] (FLINK-20578) Cannot create empty array using ARRAY[]

2024-03-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827958#comment-17827958 ] Benchao Li commented on FLINK-20578: [~nathantalewis] UDF is one of the workarounds

[jira] [Commented] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-03-13 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826918#comment-17826918 ] Benchao Li commented on FLINK-34529: [~nilerzhou] Thanks for the update. For #1, i

[jira] [Commented] (FLINK-34656) Generated code for `ITEM` operator should return null when getting element of a null map/array/row

2024-03-13 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826917#comment-17826917 ] Benchao Li commented on FLINK-34656: Although the {{resultTerm}} is a default value

[jira] [Commented] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-03-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823920#comment-17823920 ] Benchao Li commented on FLINK-34529: +1 for adding it to "PROJECT_RULES" so that we

[jira] [Resolved] (FLINK-16627) Support only generate non-null values when serializing into JSON

2024-03-05 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-16627. Fix Version/s: 1.20.0 Resolution: Fixed Fixed via 93555a7d55dc27571122cccb7c4d8af2c5db54cb

[jira] [Commented] (FLINK-16627) Support only generate non-null values when serializing into JSON

2024-03-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823408#comment-17823408 ] Benchao Li commented on FLINK-16627: [~nilerzhou] Thanks for the PR, I'll try to giv

[jira] [Comment Edited] (FLINK-34536) Support reading long value as Timestamp column in JSON format

2024-03-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17823407#comment-17823407 ] Benchao Li edited comment on FLINK-34536 at 3/5/24 3:56 AM:

[jira] [Closed] (FLINK-34536) Support reading long value as Timestamp column in JSON format

2024-03-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-34536. -- Resolution: Not A Problem I'm closing this due the discussions above, feel free to reopen it if anyone

[jira] [Commented] (FLINK-16627) Support only generate non-null values when serializing into JSON

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822358#comment-17822358 ] Benchao Li commented on FLINK-16627: [~nilerzhou] Thank you for the interest of cont

[jira] [Assigned] (FLINK-16627) Support only generate non-null values when serializing into JSON

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-16627: -- Assignee: yisha zhou > Support only generate non-null values when serializing into JSON > ---

[jira] [Commented] (FLINK-34536) Support reading long value as Timestamp column in JSON format

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822357#comment-17822357 ] Benchao Li commented on FLINK-34536: It sounds like a useful feature from the user p

[jira] [Comment Edited] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822118#comment-17822118 ] Benchao Li edited comment on FLINK-34529 at 2/29/24 1:08 PM: -

[jira] [Commented] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822118#comment-17822118 ] Benchao Li commented on FLINK-34529: [~xuyangzhong][~nilerzhou] Thank you for the ex

[jira] [Commented] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822119#comment-17822119 ] Benchao Li commented on FLINK-34529: [~nilerzhou] Assigned to you~ > Projection can

[jira] [Assigned] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-34529: -- Assignee: yisha zhou > Projection cannot be pushed down through rank operator. >

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-02-29 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822097#comment-17822097 ] Benchao Li commented on FLINK-33365: Yes, the related issue is FLINK-34170 > Missin

[jira] [Commented] (FLINK-34529) Projection cannot be pushed down through rank operator.

2024-02-28 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821949#comment-17821949 ] Benchao Li commented on FLINK-34529: [~nilerzhou] Thanks for reporting this, it soun

[jira] [Resolved] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33817. Fix Version/s: 1.20.0 Release Note: Protobuf format now supports set 'protobuf.read-default-v

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2024-02-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819075#comment-17819075 ] Benchao Li commented on FLINK-33817: According to what [~dsaisharath] provides, I te

[jira] [Commented] (FLINK-33989) Insert Statement With Filter Operation Generates Extra Tombstone using Upsert Kafka Connector

2024-02-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17819043#comment-17819043 ] Benchao Li commented on FLINK-33989: I think this is related to FLINK-9528, and it's

[jira] [Closed] (FLINK-34472) loading class of protobuf format descriptor by "Class.forName(className, true, Thread.currentThread().getContextClassLoader())" may can not find class because the current

2024-02-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-34472. -- Fix Version/s: (was: 1.20.0) Resolution: Duplicate [~jeremymu] Thanks for the confirmation,

[jira] [Commented] (FLINK-34472) loading class of protobuf format descriptor by "Class.forName(className, true, Thread.currentThread().getContextClassLoader())" may can not find class because the curr

2024-02-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17818806#comment-17818806 ] Benchao Li commented on FLINK-34472: Is this duplicated with FLINK-32418? > loading

[jira] [Updated] (FLINK-29370) Protobuf in flink-sql-protobuf is not shaded

2024-02-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-29370: --- Fix Version/s: (was: 1.19.0) > Protobuf in flink-sql-protobuf is not shaded > --

[jira] [Commented] (FLINK-34403) VeryBigPbProtoToRowTest#testSimple cannot pass due to OOM

2024-02-12 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816599#comment-17816599 ] Benchao Li commented on FLINK-34403: ITCase sounds good to me, +1 for it. > VeryBig

[jira] [Commented] (FLINK-34403) GHA misc test cannot pass due to OOM

2024-02-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17815124#comment-17815124 ] Benchao Li commented on FLINK-34403: CC [~mapohl], is it possible we can increase th

[jira] [Created] (FLINK-34403) GHA misc test cannot pass due to OOM

2024-02-06 Thread Benchao Li (Jira)
Benchao Li created FLINK-34403: -- Summary: GHA misc test cannot pass due to OOM Key: FLINK-34403 URL: https://issues.apache.org/jira/browse/FLINK-34403 Project: Flink Issue Type: Bug Co

[jira] [Resolved] (FLINK-33611) Support Large Protobuf Schemas

2024-02-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33611. Fix Version/s: 1.20 Resolution: Fixed Fixed via df03ada10e226053780cb2e5e9742add4536289c (m

[jira] [Commented] (FLINK-34378) Minibatch join disrupted the original order of input records

2024-02-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17814685#comment-17814685 ] Benchao Li commented on FLINK-34378: I'm wondering what kind of disorder it is, from

[jira] [Resolved] (FLINK-33261) FLIP-367: Support Setting Parallelism for Table/SQL Sources

2024-01-31 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33261. Resolution: Fixed Marking the umbrella issue "resolved" since all the subtasks has been finished.

[jira] [Resolved] (FLINK-34270) Update connector developer-facing doc for FLIP-367 & 146

2024-01-31 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-34270. Assignee: Zhanghao Chen Resolution: Fixed Fixed via 98e1d079f6e0689652b418b3ce2e271fc84bb55e

[jira] [Resolved] (FLINK-33264) Support source parallelism setting for DataGen connector

2024-01-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33264. Fix Version/s: 1.19.0 Resolution: Fixed Implemented via 862a7129d2730b4c70a21826a5b858fc541

[jira] [Commented] (FLINK-34238) In streaming mode, redundant exchange nodes can be optimally deleted in some cases

2024-01-26 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17811180#comment-17811180 ] Benchao Li commented on FLINK-34238: Make sense to me. Another general way is to let

[jira] [Resolved] (FLINK-33263) Implement ParallelismProvider for sources in the table planner

2024-01-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33263. Fix Version/s: 1.19.0 Resolution: Fixed Implemented via 42b7e74ab20785289b62f5dd68d566995ba

[jira] [Commented] (FLINK-31409) Hive dialect should use public interfaces in Hive connector

2024-01-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810185#comment-17810185 ] Benchao Li commented on FLINK-31409: [~luoyuxia] Could you fill the fixVersion of th

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809712#comment-17809712 ] Benchao Li edited comment on FLINK-33365 at 1/23/24 5:18 AM: -

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2024-01-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809712#comment-17809712 ] Benchao Li commented on FLINK-33365: [~martijnvisser]  The PR is very close to merge

[jira] [Assigned] (FLINK-23687) Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys

2024-01-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-23687: -- Assignee: yunfan (was: Jing Zhang) > Introduce partitioned lookup join to enforce input of L

[jira] [Commented] (FLINK-23687) Introduce partitioned lookup join to enforce input of LookupJoin to hash shuffle by lookup keys

2024-01-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808433#comment-17808433 ] Benchao Li commented on FLINK-23687: [~yunfanfight...@foxmail.com] Thanks for taking

[jira] [Resolved] (FLINK-33792) Generate the same code for the same logic

2024-01-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33792. Fix Version/s: 1.19.0 Resolution: Fixed Implemented via d26c1b668b7febc60aab1e4174f568958cd

[jira] [Commented] (FLINK-33263) Implement ParallelismProvider for sources in the table planner

2024-01-10 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17805165#comment-17805165 ] Benchao Li commented on FLINK-33263: [~sudewei.sdw] Welcome contribution, assigned t

[jira] [Assigned] (FLINK-33263) Implement ParallelismProvider for sources in the table planner

2024-01-10 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33263: -- Assignee: SuDewei > Implement ParallelismProvider for sources in the table planner >

[jira] [Commented] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804577#comment-17804577 ] Benchao Li commented on FLINK-33996: bq. In addition, what I would like to ask is wh

[jira] [Commented] (FLINK-33996) Support disabling project rewrite when multiple exprs in the project reference the same sub project field.

2024-01-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804093#comment-17804093 ] Benchao Li commented on FLINK-33996: Instead of solving this in optimization phase,

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-07 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17804080#comment-17804080 ] Benchao Li commented on FLINK-33611: [~dsaisharath] Thanks for the analysis and the

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17803156#comment-17803156 ] Benchao Li commented on FLINK-33611: [~dsaisharath] Thanks for the explanation, it h

[jira] [Assigned] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33990: -- Assignee: Dan Zou (was: Dan Zou) > Use default classloader in TaskManager when there are no

[jira] [Assigned] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33990: -- Assignee: Dan Zou > Use default classloader in TaskManager when there are no user jars for jo

[jira] [Updated] (FLINK-33990) Use default classloader in TaskManager when there are no user jars for job

2024-01-04 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33990: --- Description: TaskManager will create a new class loader for each flink job even when it has no user

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2024-01-02 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801783#comment-17801783 ] Benchao Li commented on FLINK-33611: {quote}the main proposal here is to now reuse t

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800304#comment-17800304 ] Benchao Li commented on FLINK-33817: [~maosuhan] What do you think of this? I have a

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-25 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800303#comment-17800303 ] Benchao Li commented on FLINK-33611: [~dsaisharath] Sure, I'll review the PR. I may

[jira] [Commented] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799752#comment-17799752 ] Benchao Li commented on FLINK-33817: [~dsaisharath]  Good catch, I read the release

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799751#comment-17799751 ] Benchao Li commented on FLINK-33611: 44,368 is sure a quite large one, I haven't met

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799688#comment-17799688 ] Benchao Li commented on FLINK-33490: [~xuyangzhong] No, I mean  {code:SQL} CREATE VI

[jira] [Commented] (FLINK-33611) Support Large Protobuf Schemas

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799400#comment-17799400 ] Benchao Li commented on FLINK-33611: I'm wondering how large will it be that can rea

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-12-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17799398#comment-17799398 ] Benchao Li commented on FLINK-33490: The standard states that: {quote}i) If any two

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-12-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798176#comment-17798176 ] Benchao Li commented on FLINK-33365: Yes, {{SELECT * FROM a left join mariadb_catalo

[jira] [Commented] (FLINK-32346) JdbcNumericBetweenParametersProvider Sharding key boundaries large storage long integer overflow, use BigDecimal instead Long

2023-12-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798139#comment-17798139 ] Benchao Li commented on FLINK-32346: [~sunnny] I agree the partition columns can/sho

[jira] [Comment Edited] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-12-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798131#comment-17798131 ] Benchao Li edited comment on FLINK-33365 at 12/18/23 11:09 AM: ---

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-12-18 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17798131#comment-17798131 ] Benchao Li commented on FLINK-33365: [~davidradl] I didn't see a problem in the exam

[jira] [Resolved] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-12-15 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33541. Fix Version/s: 1.19.0 1.18.1 1.17.3 Assignee: xuyang

[jira] [Commented] (FLINK-33754) Serialize QueryOperations into SQL

2023-12-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796688#comment-17796688 ] Benchao Li commented on FLINK-33754: [~dwysakowicz] Looking forward to it :) > Seri

[jira] [Commented] (FLINK-33754) Serialize QueryOperations into SQL

2023-12-13 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796517#comment-17796517 ] Benchao Li commented on FLINK-33754: [~dwysakowicz] Sorry to comment on a closed tic

[jira] [Commented] (FLINK-33751) use modules correctly when deserializing json plan

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795289#comment-17795289 ] Benchao Li commented on FLINK-33751: CC [~dwysakowicz] since I saw you have some act

[jira] [Commented] (FLINK-28691) Improve cache hit rate of generated class

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795237#comment-17795237 ] Benchao Li commented on FLINK-28691: [~FrankZou] Assigned to you. > Improve cache h

[jira] [Assigned] (FLINK-28691) Improve cache hit rate of generated class

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-28691: -- Assignee: Dan Zou > Improve cache hit rate of generated class > -

[jira] [Commented] (FLINK-33792) Generate the same code for the same logic

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17795235#comment-17795235 ] Benchao Li commented on FLINK-33792: [~FrankZou] Assigned to you. > Generate the sa

[jira] [Assigned] (FLINK-33792) Generate the same code for the same logic

2023-12-11 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li reassigned FLINK-33792: -- Assignee: Dan Zou > Generate the same code for the same logic > -

[jira] [Commented] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-12-09 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794968#comment-17794968 ] Benchao Li commented on FLINK-33313: 1.17.3: cfc7881ab5f1c27d7a9a7781b255fa94989201b

[jira] [Updated] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-12-09 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33313: --- Fix Version/s: 1.17.3 > RexNodeExtractor fails to extract conditions with binary literal > -

[jira] [Comment Edited] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-12-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794593#comment-17794593 ] Benchao Li edited comment on FLINK-33313 at 12/8/23 9:18 AM: -

[jira] [Updated] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-12-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-33313: --- Fix Version/s: 1.18.1 > RexNodeExtractor fails to extract conditions with binary literal > -

[jira] [Commented] (FLINK-33313) RexNodeExtractor fails to extract conditions with binary literal

2023-12-08 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17794593#comment-17794593 ] Benchao Li commented on FLINK-33313: 1.18: 265d81741654ff70836485e8e8d31ce33a87e960

[jira] [Resolved] (FLINK-33266) Support plan cache for DQL in SQL Gateway

2023-12-06 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-33266. Fix Version/s: 1.19.0 Resolution: Implemented Fixed via b6380d54f11ebb062397d775764f28f20fd

[jira] [Commented] (FLINK-33670) Public operators cannot be reused in multi sinks

2023-11-28 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17790898#comment-17790898 ] Benchao Li commented on FLINK-33670: I would take this as a CTE(common table express

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-24 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789405#comment-17789405 ] Benchao Li commented on FLINK-33541: It's clear now~ > RAND_INTEGER can't be exist

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789334#comment-17789334 ] Benchao Li commented on FLINK-33541: There is no such usage: "RAND(a, 10) and RAND(b

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789326#comment-17789326 ] Benchao Li commented on FLINK-33490: I agree mostly, I don't have a strong opinion w

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17789325#comment-17789325 ] Benchao Li commented on FLINK-33541: {quote}I notice currently the CAST rule is corr

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788980#comment-17788980 ] Benchao Li commented on FLINK-33490: Great, thanks [~xuyangzhong] for the investigat

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-22 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788974#comment-17788974 ] Benchao Li commented on FLINK-33606: +1 to have a FLIP since this would be in public

[jira] [Commented] (FLINK-33606) Support streaming mode in Flink JDBC driver

2023-11-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788604#comment-17788604 ] Benchao Li commented on FLINK-33606: Leaving out streaming/changelog out of Flink JD

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-21 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788340#comment-17788340 ] Benchao Li commented on FLINK-33541: I haven't looked into the details yet. One gene

[jira] [Comment Edited] (FLINK-33490) Validate the name conflicts when creating view

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788253#comment-17788253 ] Benchao Li edited comment on FLINK-33490 at 11/21/23 5:12 AM:

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788253#comment-17788253 ] Benchao Li commented on FLINK-33490: I'm wondering what the expected behavior for `

[jira] [Commented] (FLINK-33600) Print cost time for batch queries in SQL Client

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788252#comment-17788252 ] Benchao Li commented on FLINK-33600: +1 > Print cost time for batch queries in SQL

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17788250#comment-17788250 ] Benchao Li commented on FLINK-33365: [~davidradl] Is the PR ready to review now? Sin

[jira] [Commented] (FLINK-33594) Support BuiltInMethod TO_TIMESTAMP with timezone options

2023-11-20 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17787967#comment-17787967 ] Benchao Li commented on FLINK-33594: This is duplicated with FLINK-32871, exactly sa

[jira] [Resolved] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li resolved FLINK-27056. Fix Version/s: 1.19.0 Assignee: Zhanghao Chen Resolution: Fixed Fixed via 3856e41f

[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786179#comment-17786179 ] Benchao Li commented on FLINK-27056: [~Zhanghao Chen] Thanks for the clarification,

[jira] [Commented] (FLINK-27056) "pipeline.time-characteristic" should be deprecated and have EVENT_TIME as default value

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786172#comment-17786172 ] Benchao Li commented on FLINK-27056: [~Zhanghao Chen] I saw in FLINK-33240 you are p

[jira] [Commented] (FLINK-33365) Missing filter condition in execution plan containing lookup join with mysql jdbc connector

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17786165#comment-17786165 ] Benchao Li commented on FLINK-33365: [~davidradl] I take a quick glance at the PR, i

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-14 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17785940#comment-17785940 ] Benchao Li commented on FLINK-33541: [~martijnvisser] Could you point out the ticket

  1   2   3   4   5   6   7   >