Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5584
test failures due to
```
// logback + log4j, with/out krb5, different JVM opts
// IMPORTANT: Be aware that we are using side effects here to modify the
created YarnClusterDescriptor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5584#discussion_r170679952
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -186,7 +187,7 @@ public YarnClient getYarnClient
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5584
[FLINK-8787][flip6] WIP
WIP
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5573
@yanghua
I talked to @tillrohrmann offline, and we decided it is enough to add a
query parameter such as `includeSerializedValue` to the
`JobAccumulatorsHandler`. If `includeSerializedValue
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5573
I agree with @aljoscha. We should not add more `public` methods to
`ClusterClient`. Implementing `getAccumulators()` in `RestClusterClient` is
enough.
Regarding the `JobAccumulatorsHandler
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5577#discussion_r170537772
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderretrieval/SettableLeaderRetrievalServiceTest.java
---
@@ -0,0 +1,66
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5577#discussion_r170537784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/SettableLeaderRetrievalService.java
---
@@ -16,36 +16,34 @@
* limitations
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5573
@yanghua Take a look at `SerializedValueDeserializer` and
`SerializedValueSerializer`. You can use `@JsonSerialize(using= ... )`,
`@JsonSerialize(keyUsing= ... )`, and `@JsonDeserialize` to specify
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5577
[FLINK-8776][flip6] Use correct port for job submission from Web UI
## What is the purpose of the change
*Use correct port for job submission from Web UI when Flink is deployed in
YARN session
Github user GJL closed the pull request at:
https://github.com/apache/flink/pull/5545
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170279814
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -1156,6 +1213,26 @@ private void disposeSavepoint(String
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170296322
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170296168
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointTriggerException.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170300254
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -534,42 +536,94 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5560#discussion_r170281192
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskAsyncCallTest.java
---
@@ -289,7 +290,7 @@ public void invoke() throws Exception
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5566
[FLINK-8754][flip6] Make TaskManagerInfo implement Serializable
## What is the purpose of the change
*`TaskManagerInfo` can be returned from RPC calls, e.g.,
`ResourceManagerGateway
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r170179361
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r170179289
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RescaleParallelismQueryParameter.java
---
@@ -0,0 +1,41
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r170179272
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5487
I had these comments as well that were hidden:
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5557
I think you mean work-around
https://www.merriam-webster.com/dictionary/work-around
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5548#discussion_r169949268
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -412,6 +417,54 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5548#discussion_r169943180
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
---
@@ -377,14 +377,14 @@ public boolean scheduleForExecution
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169922284
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RescaleParallelismQueryParameter.java
---
@@ -0,0 +1,41
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169916387
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169634082
--- Diff:
flink-core/src/main/java/org/apache/flink/util/function/BiConsumerWithException.java
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169919835
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/RescaleParallelismQueryParameter.java
---
@@ -0,0 +1,41
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169918052
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169918959
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/async/AsynchronousOperationInfo.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169913228
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -963,6 +1120,36 @@ private Acknowledge suspendExecution(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169912256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169911850
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169920801
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/RescalingStatusMessageParameters.java
---
@@ -0,0 +1,39
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169632755
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/RescalingBehaviour.java
---
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169917224
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5487#discussion_r169917845
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -447,6 +453,165 @@ public void postStop() throws Exception
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5545
The test relies on being able to set setParallelism on a non-parallel
source:
`DataStream input1 = env.fromElements(1, 2, 3,
4).setMaxParallelism(128);`
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169687251
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -109,9 +97,7
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169676080
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -123,214 +109,112 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169694927
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
---
@@ -0,0 +1,350
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169682725
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/retriever/TestingGatewayRetriever.java
---
@@ -0,0 +1,46 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169696196
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlersTest.java
---
@@ -0,0 +1,350
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169675799
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/savepoints/SavepointHandlers.java
---
@@ -123,214 +109,112 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169687850
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/async/AsynchronousOperationResult.java
---
@@ -0,0 +1,74
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5545
I have test failures, e.g., `
StreamGraphGeneratorTest.testMaxParallelismWithConnectedKeyedStream` ð¢
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5546
[FLINK-8730][REST] JSON serialize entire SerializedThrowable
## What is the purpose of the change
*For the JSON representation, do not only serialize the serialized
exception but the entire
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5545
[FLINK-8718][DataStream] Set maxParallelism on non-parallel DataStreamSource
## What is the purpose of the change
*Set maxParallelism to 1
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5487
After rescaling `SocketWindowWordCount`, the parallelism exposed by the
REST API remains unchanged.
Steps to reproduce:
Start netcat.
```
nc -l 9001
```
Submit job
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169285404
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHeadersTest.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169285383
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarIdPathParameterTest.java
---
@@ -0,0 +1,53
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169285350
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5533
[FLINK-7714][flip6] Port JarPlanHandler to new REST endpoint
## What is the purpose of the change
*Enable showing job plan from the web job submission page.*
This PR is based on #5529
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169254360
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHeadersTest.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169254293
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandlerTest.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5529#discussion_r169254320
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarIdPathParameterTest.java
---
@@ -0,0 +1,53
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5529
[FLINK-7712][flip6] Port JarDeleteHandler to new REST endpoint
## What is the purpose of the change
*Enable deletion of jars from Web UI in flip6 mode.*
cc: @tillrohrmann
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5451#discussion_r169071363
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/async/AbstractAsynchronousOperationHandlers.java
---
@@ -0,0 +1,298
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5509#discussion_r168768261
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerTest.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5509#discussion_r168768024
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -1126,7 +1126,7 @@ public static void
setJobManagerAddressInConfig
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5509
[FLINK-7715][flip6] Port JarRunHandler to new REST endpoint
## What is the purpose of the change
*Port JarRunHandler to new REST endpoint.*
## Brief change log
- *Add
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5437#discussion_r168459950
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -402,6 +403,24 @@ public void start() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5437#discussion_r168461190
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
---
@@ -100,6 +101,18 @@ public MiniDispatcher
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5493
[FLINK-7857][flip6] Port JobVertexDetails to REST endpoint
## What is the purpose of the change
*Port JobVertexDetails to REST endpoint)*
This PR is based on #5035
cc
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4893
@zjureel Can you close this PR? Your changes were merged.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5430#discussion_r168420232
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -593,6 +617,8 @@ public void shutdown(Time timeout
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r168302562
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r168302491
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r168301191
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168200092
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -509,7 +536,7 @@ public void testListJobs() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168199770
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -493,7 +520,7 @@ public void testTriggerSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5466#discussion_r168199581
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
---
@@ -456,7 +483,7 @@ public void testTriggerSavepoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5436#discussion_r168185682
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -325,26 +325,43 @@ public void
onContainersCompleted(List list
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5436#discussion_r168184923
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
@@ -325,26 +325,43 @@ public void
onContainersCompleted(List list
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5432#discussion_r168173010
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -210,51 +225,72 @@ protected void run(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5430#discussion_r168166945
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/YarnCancelJobTerminationHeaders.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5430#discussion_r168148700
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/TestingRestfulGateway.java
---
@@ -169,22 +192,26 @@ public static Builder newBuilder
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5430#discussion_r168149188
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobTerminationHeaders.java
---
@@ -32,7 +32,7 @@
private static
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5430#discussion_r168165205
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
@@ -593,6 +617,8 @@ public void shutdown(Time timeout
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r168132269
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r168126480
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
---
@@ -163,29 +210,130 @@ protected void runCluster
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930454
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadResponseBody.java
---
@@ -0,0 +1,58
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930421
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930349
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java
---
@@ -100,6 +107,16 @@ public DispatcherRestEndpoint
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930317
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930401
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930373
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930279
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930470
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930174
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930099
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorUtils.java
---
@@ -207,6 +215,53 @@ public static WebMonitor
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167930021
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167929864
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarUploadHandler.java
---
@@ -0,0 +1,103 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167929949
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5442#discussion_r167929912
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/FileUploadHandler.java
---
@@ -0,0 +1,147 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r167610671
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
---
@@ -262,32 +430,151 @@ protected void shutDown(boolean
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r167608001
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
---
@@ -300,4 +587,12 @@ protected static ClusterConfiguration
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r167601541
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/MiniDispatcherTest.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r167606814
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
---
@@ -63,6 +89,10 @@
*/
public abstract class
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5431#discussion_r167593183
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -671,13 +674,68 @@ public void jobFinishedByOther
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5455#discussion_r167474541
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ng/JarListHandler.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed
201 - 300 of 690 matches
Mail list logo
