[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-01 Thread Makman2
Github user Makman2 commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90423889 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -1372,6 +1381,12 @@ /** The environment variable name

[GitHub] flink pull request #2915: [FLINK-5091] Formalize the Mesos AppMaster environ...

2016-12-01 Thread Makman2
Github user Makman2 commented on a diff in the pull request: https://github.com/apache/flink/pull/2915#discussion_r90423588 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/GlobalConfiguration.java --- @@ -39,12 +39,31 @@ public static final String

[GitHub] flink issue #2703: [FLINK-4900] flink-master: Allow to deploy TM with contai...

2016-11-12 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2703 Btw shall I use "fixup commits" or fix the commit directly? I prefer the second method, I'm not a real fan of non-atomic commits and commits like "Oops, fixing mistake from befor

[GitHub] flink issue #2737: [FLINK-4983] Web UI: Add favicon

2016-11-03 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2737 yeah I think also an outline image is better :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2737: [FLINK-4983] Web UI: Add favicon

2016-11-02 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2737 > Could we enhance the favicon itself? Maybe we can use the grayscale / black-white version of the flink logo, could fit more into the default dashboard design^^ > Not sure ho

[GitHub] flink issue #2737: [FLINK-4983] Web UI: Add favicon

2016-11-01 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2737 Not a web-dev, though doesn't need this some modifications in the according HTMLs to properly perenst the favicon? --- If your project is set up for it, you can reply to this email and have

[GitHub] flink issue #2703: [FLINK-4900] flink-master: Allow to deploy TM with contai...

2016-10-31 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2703 Hello :) Not sure what has gone wrong in the tests (it seems the CI is not really stable when looking at other PRs, especially on my typo fixing PR), though it would be good to merge it asap, as

[GitHub] flink issue #2704: [FLINK-4943] ConfigConstants: YYARN -> YARN

2016-10-27 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2704 Feel free to cherry-pick my commit into your branch and close this PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2704: [FLINK-4943] ConfigConstants: YYARN -> YARN

2016-10-27 Thread Makman2
Github user Makman2 commented on the issue: https://github.com/apache/flink/pull/2704 Though I wouldn't fix more than this one (except I stumble over some typos again) :3 Is there already a larger ticket? @greghogan --- If your project is set up for it, you can reply to

[GitHub] flink pull request #2704: [FLINK-4943] ConfigConstants: YYARN -> YARN

2016-10-27 Thread Makman2
GitHub user Makman2 opened a pull request: https://github.com/apache/flink/pull/2704 [FLINK-4943] ConfigConstants: YYARN -> YARN You can merge this pull request into a Git repository by running: $ git pull https://github.com/Makman2/flink Makman2/dcos4 Alternatively you

[GitHub] flink pull request #2703: [FLINK-4900] flink-master: Allow to deploy TM with...

2016-10-27 Thread Makman2
GitHub user Makman2 opened a pull request: https://github.com/apache/flink/pull/2703 [FLINK-4900] flink-master: Allow to deploy TM with container Allows via a setting to deploy a base image on that a task manager runs. You can merge this pull request into a Git repository by