Github user VenturaDelMonte closed the pull request at:
https://github.com/apache/flink/pull/2946
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/2946
I updated the PR accordingly to what developed in #328, please note that I
also kept into account
[FLINK-5741](https://issues.apache.org/jira/browse/FLINK-5741).
CC @aljoscha @manuzhang
Github user VenturaDelMonte closed the pull request at:
https://github.com/apache/flink/pull/2756
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/3285
Sure, I can take care of the all-window case!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/3285
I checked the code and it looks fine according to me. I see you are dealing
with RichFunction inheritance in wrapper classes. It is something that bothered
me too when I was working
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/2756
@aljoscha ok, then let me know, please, if I can help somehow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/2756
@manuzhang the other PR is ready since few days, you can find it here:
#2946 .
@aljoscha do you plan to add more tests also for AllWindowedStream?
---
If your project is set up
GitHub user VenturaDelMonte opened a pull request:
https://github.com/apache/flink/pull/2946
[FLINK-5157] [streaming] Extend AllWindow function metadata
This PR aims to extend AllWindow function metadata similarly to [FLINK-4997
](https://github.com/apache/flink/pull/2756
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/2756
@manuzhang thank you for your feedback and no problem!
@aljoscha ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user VenturaDelMonte commented on the issue:
https://github.com/apache/flink/pull/2756
Hi,
Thank you for both your review and your suggestions! It is good to learn
something new everyday!
Regarding InternalWindowFunction, that's alright, although we may need to
change
Github user VenturaDelMonte commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r88021488
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -800,4 +907,39 @@ public
Github user VenturaDelMonte commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r87975777
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -459,7 +545,28 @@ public
Github user VenturaDelMonte commented on a diff in the pull request:
https://github.com/apache/flink/pull/2756#discussion_r87974146
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
---
@@ -800,4 +907,39 @@ public
GitHub user VenturaDelMonte opened a pull request:
https://github.com/apache/flink/pull/2756
[FLINK-4997] Extending Window Function Metadata
This PR aims to introduce what discussed in
[FLIP-2](https://cwiki.apache.org/confluence/display/FLINK/FLIP-2+Extending+Window+Function
14 matches
Mail list logo
