[jira] [Created] (FLINK-35406) Use inner serializer when casting RAW type to BINARY or STRING in cast rules

2024-05-21 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-35406: Summary: Use inner serializer when casting RAW type to BINARY or STRING in cast rules Key: FLINK-35406 URL: https://issues.apache.org/jira/browse/FLINK-35406

[jira] [Commented] (FLINK-21542) Add documentation for supporting INSERT INTO specific columns

2021-03-02 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294341#comment-17294341 ] Zhenghua Gao commented on FLINK-21542: -- Is it enough to update the syntax of [insert

[jira] [Commented] (FLINK-18726) Support INSERT INTO specific columns

2021-01-24 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271091#comment-17271091 ] Zhenghua Gao commented on FLINK-18726: -- [~twalthr] [~Leonard Xu] [~jark] I have implemented this in

[jira] [Updated] (FLINK-21026) Align column list specification with Hive in INSERT statement

2021-01-19 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-21026: - Description: HIVE-9481 allows column list specification in INSERT statement. The syntax is:

[jira] [Updated] (FLINK-21026) Align column list specification with Hive in INSERT statement

2021-01-19 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-21026: - Description: HIVE-9481 allows column list specification in INSERT statement. The syntax is:

[jira] [Created] (FLINK-21026) Align column list specification with Hive in INSERT statement

2021-01-19 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-21026: Summary: Align column list specification with Hive in INSERT statement Key: FLINK-21026 URL: https://issues.apache.org/jira/browse/FLINK-21026 Project: Flink

[jira] [Commented] (FLINK-16827) StreamExecTemporalSort should require a distribution trait in StreamExecTemporalSortRule

2020-07-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159601#comment-17159601 ] Zhenghua Gao commented on FLINK-16827: -- [~jark] [~libenchao] I think this bugfix should port to

[jira] [Closed] (FLINK-16117) Avoid register source in TableTestBase#addTableSource

2020-05-15 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao closed FLINK-16117. Resolution: Won't Fix > Avoid register source in TableTestBase#addTableSource >

[jira] [Commented] (FLINK-15591) make up for feature parity by supporting CREATE TEMPORARY TABLE/VIEW in DDL

2020-04-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092691#comment-17092691 ] Zhenghua Gao commented on FLINK-15591: -- will open a PR soon for temporary table. > make up for

[jira] [Comment Edited] (FLINK-15591) make up for feature parity by supporting CREATE TEMPORARY TABLE/VIEW in DDL

2020-04-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092654#comment-17092654 ] Zhenghua Gao edited comment on FLINK-15591 at 4/26/20, 11:34 AM: -

[jira] [Commented] (FLINK-15591) make up for feature parity by supporting CREATE TEMPORARY TABLE/VIEW in DDL

2020-04-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092654#comment-17092654 ] Zhenghua Gao commented on FLINK-15591: -- Supported in 

[jira] [Updated] (FLINK-17112) Support DESCRIBE view_name in Flink SQL

2020-04-23 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17112: - Description: FLINK-14688 introduces DESCRIBE statement in sql parser, but doesn't implement it

[jira] [Updated] (FLINK-17112) Support DESCRIBE view_name in Flink SQL

2020-04-23 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17112: - Summary: Support DESCRIBE view_name in Flink SQL (was: Support DESCRIBE VIEW view_name in

[jira] [Comment Edited] (FLINK-16160) Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path

2020-04-21 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088275#comment-17088275 ] Zhenghua Gao edited comment on FLINK-16160 at 4/21/20, 6:04 AM: The root

[jira] [Commented] (FLINK-16160) Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path

2020-04-20 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088275#comment-17088275 ] Zhenghua Gao commented on FLINK-16160: -- The root causes are: * proctime()/rowtime() are used along

[jira] [Updated] (FLINK-17111) Support SHOW VIEWS in Flink SQL

2020-04-15 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17111: - Description: SHOW TABLES and SHOW VIEWS are not SQL standard-compliant commands.  MySQL

[jira] [Updated] (FLINK-17111) Support SHOW VIEWS in Flink SQL

2020-04-15 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17111: - Description: SHOW TABLES and SHOW VIEWS are not SQL standard-compliant commands.  MySQL

[jira] [Created] (FLINK-17113) Refactor view support in SQL Client

2020-04-13 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17113: Summary: Refactor view support in SQL Client Key: FLINK-17113 URL: https://issues.apache.org/jira/browse/FLINK-17113 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-17112) Support DESCRIBE VIEW view_name in Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17112: Summary: Support DESCRIBE VIEW view_name in Flink SQL Key: FLINK-17112 URL: https://issues.apache.org/jira/browse/FLINK-17112 Project: Flink Issue Type:

[jira] [Created] (FLINK-17111) Support SHOW VIEWS in Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17111: Summary: Support SHOW VIEWS in Flink SQL Key: FLINK-17111 URL: https://issues.apache.org/jira/browse/FLINK-17111 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-17106) Support create/drop view in Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17106: Summary: Support create/drop view in Flink SQL Key: FLINK-17106 URL: https://issues.apache.org/jira/browse/FLINK-17106 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-17105) FLIP-71: E2E view support for Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17105: - Component/s: Table SQL / Planner Table SQL / Legacy Planner

[jira] [Updated] (FLINK-17105) FLIP-71: E2E view support for Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17105: - Summary: FLIP-71: E2E view support for Flink SQL (was: FLIP-71: E2E viewsupport ) > FLIP-71:

[jira] [Updated] (FLINK-17105) FLIP-71: E2E view support for Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17105: - Affects Version/s: 1.10.0 > FLIP-71: E2E view support for Flink SQL >

[jira] [Created] (FLINK-17105) FLIP-71: E2E viewsupport

2020-04-13 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17105: Summary: FLIP-71: E2E viewsupport Key: FLINK-17105 URL: https://issues.apache.org/jira/browse/FLINK-17105 Project: Flink Issue Type: New Feature

[jira] [Updated] (FLINK-17105) FLIP-71: E2E view support for Flink SQL

2020-04-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17105: - Fix Version/s: 1.11.0 > FLIP-71: E2E view support for Flink SQL >

[jira] [Created] (FLINK-17098) CatalogManager#dropTemporaryTable and dropTemporaryView should use ObjectIdentifier as its argument

2020-04-12 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17098: Summary: CatalogManager#dropTemporaryTable and dropTemporaryView should use ObjectIdentifier as its argument Key: FLINK-17098 URL:

[jira] [Commented] (FLINK-17067) CatalogManager#createTable and createTemporaryTable should provide consistent semantics

2020-04-09 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079280#comment-17079280 ] Zhenghua Gao commented on FLINK-17067: -- Seems we didn't expose  [OR REPLACE] out yet.  Most 

[jira] [Updated] (FLINK-17067) CatalogManager#createTable and createTemporaryTable should provide consistent semantics

2020-04-09 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-17067: - Description: Currently CatalogManager#createTable provides  [IF NOT EXISTS] semantic and 

[jira] [Commented] (FLINK-17067) CatalogManager#createTable and createTemporaryTable should provide consistent semantics

2020-04-09 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079091#comment-17079091 ] Zhenghua Gao commented on FLINK-17067: -- Or the CREATE [TEMPORARY] TABLE|VIEW [IF NOT EXISTS] can't

[jira] [Created] (FLINK-17067) CatalogManager#createTable and createTemporaryTable should provide consistent semantics

2020-04-09 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-17067: Summary: CatalogManager#createTable and createTemporaryTable should provide consistent semantics Key: FLINK-17067 URL: https://issues.apache.org/jira/browse/FLINK-17067

[jira] [Commented] (FLINK-16632) SqlDateTimeUtils#toSqlTimestamp(String, String) may yield incorrect result

2020-04-07 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077035#comment-17077035 ] Zhenghua Gao commented on FLINK-16632: -- SqlDateTimeUtils#toSqlTimestamp(String, String) may yield

[jira] [Updated] (FLINK-16632) SqlDateTimeUtils#toSqlTimestamp(String, String) may yield incorrect result

2020-04-07 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-16632: - Summary: SqlDateTimeUtils#toSqlTimestamp(String, String) may yield  incorrect result (was: Cast

[jira] [Commented] (FLINK-16823) The functioin TIMESTAMPDIFF doesn't perform expected result

2020-03-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071511#comment-17071511 ] Zhenghua Gao commented on FLINK-16823: -- After talk with [~danny0405], we decide to introduce

[jira] [Commented] (FLINK-16379) Introduce fromValues in TableEnvironment

2020-03-29 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070659#comment-17070659 ] Zhenghua Gao commented on FLINK-16379: -- [~dwysakowicz] You could merge your branch first(better to

[jira] [Commented] (FLINK-16823) The functioin TIMESTAMPDIFF doesn't perform expected result

2020-03-27 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068618#comment-17068618 ] Zhenghua Gao commented on FLINK-16823: -- [~danny0405] What the plan of the upgrading of Calcite?

[jira] [Commented] (FLINK-16823) The functioin TIMESTAMPDIFF doesn't perform expected result

2020-03-27 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068610#comment-17068610 ] Zhenghua Gao commented on FLINK-16823: -- The root cause is CALCITE-3881, will fix on calcite side.

[jira] [Commented] (FLINK-16823) The functioin TIMESTAMPDIFF doesn't perform expected result

2020-03-27 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068426#comment-17068426 ] Zhenghua Gao commented on FLINK-16823: -- Flink use Calcite's SqlFunctions#subtractMonths to find the

[jira] [Commented] (FLINK-16823) The functioin TIMESTAMPDIFF doesn't perform expected result

2020-03-27 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068396#comment-17068396 ] Zhenghua Gao commented on FLINK-16823: -- OK, i will take a look at it. > The functioin

[jira] [Updated] (FLINK-16800) TypeMappingUtils#checkIfCompatible didn't deal with nested types

2020-03-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-16800: - Description: the planner uses TypeMappingUtils#checkIfCompatible to validate logical schema

[jira] [Updated] (FLINK-16800) TypeMappingUtils#checkIfCompatible didn't deal with nested types

2020-03-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-16800: - Summary: TypeMappingUtils#checkIfCompatible didn't deal with nested types (was:

[jira] [Updated] (FLINK-16800) TypeMappingUtils#checkIfCompatible didn't deal with nested types

2020-03-26 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-16800: - Description: the planner will use TypeMappingUtils#checkIfCompatible to validate logical

[jira] [Created] (FLINK-16800) TypeMappingUtils#checkPhysicalLogicalTypeCompatible didn't deal with nested types

2020-03-26 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-16800: Summary: TypeMappingUtils#checkPhysicalLogicalTypeCompatible didn't deal with nested types Key: FLINK-16800 URL: https://issues.apache.org/jira/browse/FLINK-16800

[jira] [Commented] (FLINK-16379) Introduce fromValues in TableEnvironment

2020-03-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17059150#comment-17059150 ] Zhenghua Gao commented on FLINK-16379: -- +1 to merge fromElements to fromValues.  Construction

[jira] [Commented] (FLINK-16379) Introduce fromValues in TableEnvironment

2020-03-11 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057536#comment-17057536 ] Zhenghua Gao commented on FLINK-16379: -- That's right that we can improve `fromValues(Object ...)`.

[jira] [Commented] (FLINK-16379) Introduce fromValues in TableEnvironment

2020-03-03 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050732#comment-17050732 ] Zhenghua Gao commented on FLINK-16379: -- >From the user perspective, constructing a Table from raw

[jira] [Updated] (FLINK-16029) Remove register source and sink in test cases of blink planner

2020-03-01 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-16029: - Summary: Remove register source and sink in test cases of blink planner (was: Remove register

[jira] [Commented] (FLINK-16327) Add TableEnvironment.fromElements interfaces for usability

2020-03-01 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048740#comment-17048740 ] Zhenghua Gao commented on FLINK-16327: -- CC [~twalthr] [~dwysakowicz] What do you think about this?

[jira] [Created] (FLINK-16327) Add TableEnvironment.fromElements interfaces for usability

2020-02-28 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-16327: Summary: Add TableEnvironment.fromElements interfaces for usability Key: FLINK-16327 URL: https://issues.apache.org/jira/browse/FLINK-16327 Project: Flink

[jira] [Commented] (FLINK-13302) DateTimeUtils.unixDateCeil returns the same value as unixDateFloor does

2020-02-20 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041568#comment-17041568 ] Zhenghua Gao commented on FLINK-13302: -- [~tison] The related issue is fixed in avatica-1.16.0, we

[jira] [Created] (FLINK-16160) Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path

2020-02-19 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-16160: Summary: Schema#proctime and Schema#rowtime don't work in TableEnvironment#connect code path Key: FLINK-16160 URL: https://issues.apache.org/jira/browse/FLINK-16160

[jira] [Commented] (FLINK-16143) Turn on more date time functions of blink planner

2020-02-19 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17039787#comment-17039787 ] Zhenghua Gao commented on FLINK-16143: -- [~jark] Actually the TIMESTAMPDIFF/TIMESTAMPADD with DATE

[jira] [Commented] (FLINK-16117) Avoid register source in TableTestBase#addTableSource

2020-02-17 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038729#comment-17038729 ] Zhenghua Gao commented on FLINK-16117: -- Most of these tests are plan tests and there is no input

[jira] [Created] (FLINK-16117) Avoid register source in TableTestBase#addTableSource

2020-02-17 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-16117: Summary: Avoid register source in TableTestBase#addTableSource Key: FLINK-16117 URL: https://issues.apache.org/jira/browse/FLINK-16117 Project: Flink Issue

[jira] [Created] (FLINK-16029) Remove register source and sink in test cases of planner

2020-02-12 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-16029: Summary: Remove register source and sink in test cases of planner Key: FLINK-16029 URL: https://issues.apache.org/jira/browse/FLINK-16029 Project: Flink

[jira] [Commented] (FLINK-15990) Remove register source and sink in ConnectTableDescriptor

2020-02-11 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034351#comment-17034351 ] Zhenghua Gao commented on FLINK-15990: -- the comment of *TableEnvironment.connect()* related code

[jira] [Updated] (FLINK-15968) LegacyTypeInfoDataTypeConverter should support conversion from BINARY/VARBINARY to BYTE_PRIMITIVE_ARRAY_TYPE_INFO

2020-02-10 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15968: - Description: Currently LegacyTypeInfoDataTypeConverter only support conversion between 

[jira] [Updated] (FLINK-15968) LegacyTypeInfoDataTypeConverter should support conversion from BINARY/VARBINARY to BYTE_PRIMITIVE_ARRAY_TYPE_INFO

2020-02-10 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15968: - Summary: LegacyTypeInfoDataTypeConverter should support conversion from BINARY/VARBINARY to

[jira] [Commented] (FLINK-15968) LegacyTypeInfoDataTypeConverter should support conversion between BINARY/VARBINARY and BYTE_PRIMITIVE_ARRAY_TYPE_INFO

2020-02-10 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033551#comment-17033551 ] Zhenghua Gao commented on FLINK-15968: -- [~jark] [~lzljs3620320] What do you think about this? >

[jira] [Updated] (FLINK-15968) LegacyTypeInfoDataTypeConverter should support conversion between BINARY/VARBINARY and BYTE_PRIMITIVE_ARRAY_TYPE_INFO

2020-02-10 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15968: - Description: Currently LegacyTypeInfoDataTypeConverter only support conversion between 

[jira] [Created] (FLINK-15968) LegacyTypeInfoDataTypeConverter should support conversion between BINARY/VARBINARY and BYTE_PRIMITIVE_ARRAY_TYPE_INFO

2020-02-10 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-15968: Summary: LegacyTypeInfoDataTypeConverter should support conversion between BINARY/VARBINARY and BYTE_PRIMITIVE_ARRAY_TYPE_INFO Key: FLINK-15968 URL:

[jira] [Commented] (FLINK-15881) Stop overriding TableSource::getReturnType in jdbc connector

2020-02-04 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030381#comment-17030381 ] Zhenghua Gao commented on FLINK-15881: -- This duplicates to FLINK-15445. The PR for FLINK-15445

[jira] [Commented] (FLINK-15574) DataType to LogicalType conversion issue

2020-01-17 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017874#comment-17017874 ] Zhenghua Gao commented on FLINK-15574: -- The root cause is mix use of conversion logic of blink

[jira] [Commented] (FLINK-15469) Update UpsertStreamTableSink and RetractStreamTableSink and related interface to new type system

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017755#comment-17017755 ] Zhenghua Gao commented on FLINK-15469: -- After an initial POC, the getTypeClass is not needed

[jira] [Comment Edited] (FLINK-15469) Update UpsertStreamTableSink and RetractStreamTableSink and related interface to new type system

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014828#comment-17014828 ] Zhenghua Gao edited comment on FLINK-15469 at 1/17/20 7:12 AM: --- Hi

[jira] [Updated] (FLINK-15469) Update UpsertStreamTableSink and RetractStreamTableSink and related interface to new type system

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15469: - Summary: Update UpsertStreamTableSink and RetractStreamTableSink and related interface to new

[jira] [Commented] (FLINK-15602) Blink planner does not respect the precision when casting timestamp to varchar

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17017666#comment-17017666 ] Zhenghua Gao commented on FLINK-15602: -- [~twalthr] AFAIK we have padded DECIMAL type and intervals

[jira] [Commented] (FLINK-15602) Blink planner does not respect the precision when casting timestamp to varchar

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016745#comment-17016745 ] Zhenghua Gao commented on FLINK-15602: -- [~dwysakowicz] [~twalthr] [~jark] Let's padding the

[jira] [Commented] (FLINK-15546) Obscure error message from ScalarOperatorGens::generateCast

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016740#comment-17016740 ] Zhenghua Gao commented on FLINK-15546: -- [~lzljs3620320] OK, I will file a PR soon. [~jark] Please

[jira] [Comment Edited] (FLINK-15602) Blink planner does not respect the precision when casting timestamp to varchar

2020-01-16 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016512#comment-17016512 ] Zhenghua Gao edited comment on FLINK-15602 at 1/16/20 9:16 AM: --- Hi

[jira] [Commented] (FLINK-15602) Blink planner does not respect the precision when casting timestamp to varchar

2020-01-15 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016512#comment-17016512 ] Zhenghua Gao commented on FLINK-15602: -- Hi [~dwysakowicz] [~tiwalter] I investigated the behavior

[jira] [Comment Edited] (FLINK-15469) UpsertStreamTableSink should support new type system

2020-01-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014828#comment-17014828 ] Zhenghua Gao edited comment on FLINK-15469 at 1/14/20 3:15 AM: --- Hi

[jira] [Commented] (FLINK-15469) UpsertStreamTableSink should support new type system

2020-01-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014828#comment-17014828 ] Zhenghua Gao commented on FLINK-15469: -- Hi [~lzljs3620320], after re-think the whole thing, we

[jira] [Commented] (FLINK-15546) Obscure error message from ScalarOperatorGens::generateCast

2020-01-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014818#comment-17014818 ] Zhenghua Gao commented on FLINK-15546: -- {code:java} case (from, to) => throw new

[jira] [Commented] (FLINK-15574) DataType to LogicalType conversion issue

2020-01-13 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014804#comment-17014804 ] Zhenghua Gao commented on FLINK-15574: -- HI [~b.hanotte], a reason to keep this deprecated

[jira] [Commented] (FLINK-15509) Use sql cilents create view occur Unexpected exception

2020-01-10 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012596#comment-17012596 ] Zhenghua Gao commented on FLINK-15509: -- What about validate data type mismatch in this phase

[jira] [Commented] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2020-01-09 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17012429#comment-17012429 ] Zhenghua Gao commented on FLINK-15445: -- We come to an agreement that the user should be informed if

[jira] [Commented] (FLINK-15509) Use sql cilents create view occur Unexpected exception

2020-01-09 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011659#comment-17011659 ] Zhenghua Gao commented on FLINK-15509: -- Should we verify whether the properties exist, or whether

[jira] [Commented] (FLINK-15525) HBase connector should use new type system to suppport precision/scale

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011346#comment-17011346 ] Zhenghua Gao commented on FLINK-15525: -- [~lzljs3620320] [~Leonard Xu] Close this and copy the

[jira] [Commented] (FLINK-15363) Hbase connector do not support datatypes with precision like TIMESTAMP(9) and DECIMAL(10,4)

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011343#comment-17011343 ] Zhenghua Gao commented on FLINK-15363: -- Currently *HBaseTableSchema* use TypeInformation to specify

[jira] [Closed] (FLINK-15525) HBase connector should use new type system to suppport precision/scale

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao closed FLINK-15525. Resolution: Duplicate > HBase connector should use new type system to suppport precision/scale >

[jira] [Commented] (FLINK-15525) HBase connector should use new type system to suppport precision/scale

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011328#comment-17011328 ] Zhenghua Gao commented on FLINK-15525: -- [~Leonard Xu] Added a link to old ticket. > HBase

[jira] [Commented] (FLINK-13651) Blink planner should parse char(n)/varchar(n)/decimal(p, s) inside a string to corresponding datatype

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011306#comment-17011306 ] Zhenghua Gao commented on FLINK-13651: -- [~liyu] [~jark] The root cause is 

[jira] [Created] (FLINK-15525) HBase connector should use new type system to suppport precision/scale

2020-01-08 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-15525: Summary: HBase connector should use new type system to suppport precision/scale Key: FLINK-15525 URL: https://issues.apache.org/jira/browse/FLINK-15525 Project:

[jira] [Commented] (FLINK-14925) the return type of TO_TIMESTAMP should be Timestamp(9) instead of Timestamp(3)

2020-01-08 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010512#comment-17010512 ] Zhenghua Gao commented on FLINK-14925: -- [~jark] Make sense. Is there any ticket to track supporting

[jira] [Commented] (FLINK-15509) Use sql cilents create view occur Unexpected exception

2020-01-07 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010331#comment-17010331 ] Zhenghua Gao commented on FLINK-15509: -- Hi [~yesorno], the reason is the table you created is not

[jira] [Commented] (FLINK-15508) support DataType with precision in ExpressionParser

2020-01-07 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010323#comment-17010323 ] Zhenghua Gao commented on FLINK-15508: -- Seem as duplicates of FLINK-13651? The root cause is 

[jira] [Commented] (FLINK-15460) planner dependencies won't be necessary for JDBC connector

2020-01-05 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008583#comment-17008583 ] Zhenghua Gao commented on FLINK-15460: -- [~twalthr] Actually jdbc connector code should not depend

[jira] [Updated] (FLINK-15460) planner dependencies won't be necessary for JDBC connector

2020-01-05 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15460: - Description: remove planner dependencies from JDBC connector by changing the scope to test. >

[jira] [Updated] (FLINK-15460) planner dependencies won't be necessary for JDBC connector

2020-01-05 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15460: - Component/s: (was: Connectors / HBase) > planner dependencies won't be necessary for JDBC

[jira] [Commented] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2020-01-05 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008529#comment-17008529 ] Zhenghua Gao commented on FLINK-15445: -- [~jark] [~twalthr] I have opened a PR to let JDBC source

[jira] [Created] (FLINK-15469) UpsertStreamTableSink should support new type system

2020-01-03 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-15469: Summary: UpsertStreamTableSink should support new type system Key: FLINK-15469 URL: https://issues.apache.org/jira/browse/FLINK-15469 Project: Flink Issue

[jira] [Created] (FLINK-15460) planner dependencies won't be necessary for JDBC connector

2020-01-02 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-15460: Summary: planner dependencies won't be necessary for JDBC connector Key: FLINK-15460 URL: https://issues.apache.org/jira/browse/FLINK-15460 Project: Flink

[jira] [Updated] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2020-01-02 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15445: - Description: {code:java}  public class JDBCSourceExample { public static void main(String[]

[jira] [Updated] (FLINK-15379) JDBC connector return wrong value if defined dataType contains precision

2019-12-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15379: - Description: A mysql table like:   {code:java} // CREATE TABLE `currency` ( `currency_id`

[jira] [Updated] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2019-12-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15445: - Description: {code:java}  public class JDBCSourceExample { public static void main(String[]

[jira] [Updated] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2019-12-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15445: - Description: {code:java}  public class JDBCSourceExample { public static void main(String[]

[jira] [Updated] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2019-12-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenghua Gao updated FLINK-15445: - Description: {code:java} public class JDBCSourceExample { public static void main(String[]

[jira] [Commented] (FLINK-15379) JDBC connector return wrong value if defined dataType contains precision

2019-12-31 Thread Zhenghua Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006047#comment-17006047 ] Zhenghua Gao commented on FLINK-15379: -- [~jark] the issue can't reproduce after FLINK-15168,

[jira] [Created] (FLINK-15445) JDBC Table Source didn't work for Types with precision (or/and scale)

2019-12-31 Thread Zhenghua Gao (Jira)
Zhenghua Gao created FLINK-15445: Summary: JDBC Table Source didn't work for Types with precision (or/and scale) Key: FLINK-15445 URL: https://issues.apache.org/jira/browse/FLINK-15445 Project: Flink

  1   2   3   >