[GitHub] flink issue #6097: [FLINK-9470] Allow querying the key in KeyedProcessFuncti...

2018-05-29 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/6097 +1 Nice! ---

[GitHub] flink issue #6086: [FLINK-9452] Flink 1.5 document version title shows snaps...

2018-05-28 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/6086 @zentol I think the baseurl variable also needs to be changed -- for a stable release, it should not point to master. ---

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-05-25 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r190841926 --- Diff: docs/dev/event_time.md --- @@ -219,4 +219,17 @@ with late elements in event time windows. Please refer to the [Debugging Windows & E

[GitHub] flink pull request #6076: [hotfix][docs] Specify operators behaviour on proc...

2018-05-25 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/6076#discussion_r190841061 --- Diff: docs/dev/event_time.md --- @@ -219,4 +219,17 @@ with late elements in event time windows. Please refer to the [Debugging Windows & E

[GitHub] flink pull request #6010: [FLINK-9359][docs] Update quickstart docs to only ...

2018-05-14 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/6010 [FLINK-9359][docs] Update quickstart docs to only mention Java 8 This is a trivial but important fix to the quickstart setup page in the docs. This fix should be made to the 1.4, 1.5, and 1.6

[GitHub] flink issue #5976: [FLINK-9309] Recommend HA setup on Production Readiness C...

2018-05-09 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5976 +1 ---

[GitHub] flink pull request #5949: [FLINK-9288][docs] clarify the event time / waterm...

2018-05-02 Thread alpinegizmo
GitHub user alpinegizmo reopened a pull request: https://github.com/apache/flink/pull/5949 [FLINK-9288][docs] clarify the event time / watermark docs This PR only affects the documentation (for event time and watermarks). I wanted to make a couple of things clearer, and to provide

[GitHub] flink pull request #5949: [FLINK-9288][docs] clarify the event time / waterm...

2018-05-02 Thread alpinegizmo
Github user alpinegizmo closed the pull request at: https://github.com/apache/flink/pull/5949 ---

[GitHub] flink issue #5949: [FLINK-9288][docs] clarify the event time / watermark doc...

2018-05-02 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5949 @bowenli86 Thanks for the feedback. I've reworked that event time section. Hopefully it's now more complete and accurate without being too complex. ---

[GitHub] flink pull request #5949: [FLINK-9288][docs] clarify the event time / waterm...

2018-05-02 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/5949 [FLINK-9288][docs] clarify the event time / watermark docs This PR only affects the documentation (for event time and watermarks). I wanted to make a couple of things clearer, and to provide a

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184970245 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184969214 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184968333 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184971409 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184969839 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184971516 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5922: [FLINK-8780] [docs] Add Broadcast State documentat...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5922#discussion_r184969718 --- Diff: docs/dev/stream/state/broadcast_state.md --- @@ -0,0 +1,281 @@ +--- +title: "The Broadcast State Pattern" +nav

[GitHub] flink pull request #5913: [FLINK-9181] [docs] [sql-client] Add documentation...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5913#discussion_r184962653 --- Diff: docs/dev/table/sqlClient.md --- @@ -0,0 +1,539 @@ +--- +title: "SQL Client" +nav-parent_id: tableapi +nav-pos: 100

[GitHub] flink pull request #5887: [FLINK-6719] [docs] Add details about fault-tolera...

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5887#discussion_r184960782 --- Diff: docs/dev/stream/operators/process_function.md --- @@ -271,16 +271,39 @@ override def onTimer(timestamp: Long, ctx: OnTimerContext, out

[GitHub] flink issue #5924: [hotfix][README.md] Update building prerequisites

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5924 +1 I frequently see newcomers to Flink getting hung up on this. ---

[GitHub] flink pull request #5928: [hotfix][doc] fix doc of externalized checkpoint

2018-04-30 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5928#discussion_r184959202 --- Diff: docs/dev/stream/state/checkpointing.md --- @@ -137,11 +137,9 @@ Some more parameters and/or defaults may be set via `conf/flink-conf.yaml

[GitHub] flink issue #5785: [FLINK-9108][docs] Fix invalid link

2018-03-30 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5785 +1 ---

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-01 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5395 These lines need to be restored to the Gemfile. The hawkins plugin is needed for the incremental build and live reload feature group :jekyll_plugins do gem 'hawkins

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-01 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5395 Sure. ---

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-02-01 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5395 It looks good, but I haven't tested it. I'm wondering what versions of Ruby this has been tested with. At a minimum it needs to work with whatever version we can get on the produc

[GitHub] flink issue #5395: [FLINK-8308] Remove explicit yajl-ruby dependency, update...

2018-01-31 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5395 It would be lovely to ditch ruby 1.9. However, if I understand correctly, we don't fully control the environment that builds the docs, and the last time we tried this we couldn't g

[GitHub] flink pull request #5317: [FLINK-8458] Add the switch for keeping both the o...

2018-01-22 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5317#discussion_r16290 --- Diff: docs/ops/config.md --- @@ -290,6 +290,12 @@ The following parameters configure Flink's JobManager and TaskMan

[GitHub] flink pull request #5317: [FLINK-8458] Add the switch for keeping both the o...

2018-01-22 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5317#discussion_r162906372 --- Diff: docs/ops/config.md --- @@ -290,6 +290,12 @@ The following parameters configure Flink's JobManager and TaskMan

[GitHub] flink pull request #5277: [hotfix][docs]Review to reduce passive voice, impr...

2018-01-22 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5277#discussion_r162902645 --- Diff: docs/concepts/runtime.md --- @@ -46,19 +46,23 @@ The Flink runtime consists of two types of processes: - The **JobManagers** (also

[GitHub] flink issue #5129: [Hotfix for State doc in 1.4 and 1.5] update State's doc ...

2017-12-11 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5129 +1 ---

[GitHub] flink issue #5119: [FLINK-6590] Integrate automatic docs generation

2017-12-05 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5119 Very pleased to see this coming to fruition. ---

[GitHub] flink pull request #5075: [hotfix] [docs] Fix typos in State Backends doc

2017-11-27 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/5075#discussion_r153149948 --- Diff: docs/ops/state/state_backends.md --- @@ -110,10 +110,10 @@ Limitations of the RocksDBStateBackend: The RocksDBStateBackend is

[GitHub] flink issue #5039: [hotfix][docs] Fix some typos in the documentation.

2017-11-21 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/5039 lgtm ---

[GitHub] flink pull request #4992: [FLINK-6163] Document per-window state in ProcessW...

2017-11-10 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4992#discussion_r150194036 --- Diff: docs/dev/stream/operators/windows.md --- @@ -978,6 +978,24 @@ input +### Using per-window state in ProcessWindowFunction

[GitHub] flink issue #4869: [FLINK-7843][docs] Improve documentation for metrics

2017-10-25 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4869 I can't vouch for the accuracy of the info, but +1 for adding this level of detail. ---

[GitHub] flink pull request #4833: [FLINK-5968] Add documentation for WindowedStream....

2017-10-16 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4833#discussion_r144842788 --- Diff: docs/dev/stream/operators/windows.md --- @@ -721,6 +808,111 @@ input + Incremental Window Aggregation with

[GitHub] flink issue #4816: [hotfix][docs] CEP docs review to remove weasel words, fi...

2017-10-12 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4816 +1 ---

[GitHub] flink issue #4756: [FLINK-7744][docs] Add missing top links to documentation

2017-10-07 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4756 Yes, looks good to me. +1 ---

[GitHub] flink pull request #4760: [hotfix][docs] Polish docs index page for consiste...

2017-10-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4760#discussion_r142630633 --- Diff: docs/index.md --- @@ -25,27 +25,26 @@ under the License. -This documentation is for Apache Flink version

[GitHub] flink pull request #4687: [hotfix][docs][CEP] wrong method name for PatternF...

2017-09-20 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/4687 [hotfix][docs][CEP] wrong method name for PatternFlatSelectFunction The name of the single abstract method in the PatternFlatSelectFunction interface is flatSelect, not select. This PR

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139691882 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139687800 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139685466 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139690107 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139686793 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139692206 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139691118 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139685795 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139687153 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139687994 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139684257 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139689544 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139691558 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139690574 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139687055 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139689818 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4543: [FLINK-7449] [docs] Additional documentation for i...

2017-09-19 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4543#discussion_r139690806 --- Diff: docs/ops/state/checkpoints.md --- @@ -99,3 +99,296 @@ above). ```sh $ bin/flink run -s :checkpointMetaDataPath [:runArgs

[GitHub] flink pull request #4634: [FLINK-7568] Improve Windowing Documentation

2017-09-05 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4634#discussion_r137000137 --- Diff: docs/dev/stream/operators/windows.md --- @@ -663,25 +623,42 @@ input .keyBy() .window() .process(new

[GitHub] flink pull request #4634: [FLINK-7568] Improve Windowing Documentation

2017-09-05 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4634#discussion_r136973577 --- Diff: docs/dev/stream/operators/windows.md --- @@ -460,118 +465,14 @@ The above example appends all input `Long` values to an initially empty

[GitHub] flink pull request #4634: [FLINK-7568] Improve Windowing Documentation

2017-09-05 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4634#discussion_r136972599 --- Diff: docs/dev/stream/operators/windows.md --- @@ -111,6 +111,11 @@ windows) assign elements to windows based on time, which can either be processin

[GitHub] flink pull request #4634: [FLINK-7568] Improve Windowing Documentation

2017-09-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4634#discussion_r136843813 --- Diff: docs/dev/stream/operators/windows.md --- @@ -663,25 +623,42 @@ input .keyBy() .window() .process(new

[GitHub] flink pull request #4634: [FLINK-7568] Improve Windowing Documentation

2017-09-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4634#discussion_r136845008 --- Diff: docs/dev/stream/operators/windows.md --- @@ -490,15 +490,35 @@ public abstract class ProcessWindowFunction impl Iterable

[GitHub] flink issue #4553: [FLINK-7642] [docs] Add very obvious warning about outdat...

2017-08-16 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4553 +1 I like these improvements. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #4480: [FLINK-6995] [docs] Enable is_latest attribute to false

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4480 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131354369 --- Diff: docs/dev/testing.md --- @@ -0,0 +1,189 @@ +--- +title: "Testing" +nav-parent_id: dev +nav-id: testing +n

[GitHub] flink pull request #4454: [hotfix][docs] Add section in docs about writing u...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4454#discussion_r131352677 --- Diff: docs/dev/testing.md --- @@ -90,13 +121,69 @@ public class ExampleIntegrationTest extends StreamingMultipleProgramsTestBase

[GitHub] flink issue #4454: [hotfix][docs] Add section in docs about writing unit/int...

2017-08-04 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4454 +1 for adding this section to the docs. And another +1 for adding something about testing watermarks / timestamps -- this is a very frequently asked question. Could, perhaps, include a

[GitHub] flink issue #4441: [FLINK-7301] [docs] Rework state documentation

2017-08-03 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4441 @twalthr Duh, of course, you're right. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] flink pull request #4441: [FLINK-7301] [docs] Rework state documentation

2017-08-03 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4441#discussion_r131087040 --- Diff: docs/dev/stream/state/index.md --- @@ -0,0 +1,56 @@ +--- +title: "State & Fault Tolerance" +nav-id: streaming_state

[GitHub] flink pull request #4441: [FLINK-7301] [docs] Rework state documentation

2017-08-03 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4441#discussion_r131085493 --- Diff: docs/dev/stream/state/custom_serialization.md --- @@ -0,0 +1,188 @@ +--- +title: "Custom Serialization for Managed State"

[GitHub] flink pull request #4441: [FLINK-7301] [docs] Rework state documentation

2017-08-03 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4441#discussion_r131086039 --- Diff: docs/dev/stream/state/custom_serialization.md --- @@ -0,0 +1,188 @@ +--- +title: "Custom Serialization for Managed State"

[GitHub] flink pull request #4136: [FLINK-6940][docs] Clarify the effect of configuri...

2017-07-10 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4136#discussion_r126431179 --- Diff: docs/ops/state_backends.md --- @@ -123,8 +123,7 @@ RocksDBStateBackend is currently the only backend that offers incremental checkp

[GitHub] flink pull request #4291: [FLINK-7136][docs] Improve search by adding facets...

2017-07-10 Thread alpinegizmo
GitHub user alpinegizmo opened a pull request: https://github.com/apache/flink/pull/4291 [FLINK-7136][docs] Improve search by adding facets and turning off ads This PR expands the custom search engine used by the documentation to include some additional sources, and expands the UI

[GitHub] flink issue #4088: [FLINK-6652] [core] Fix handling of delimiters split by b...

2017-06-16 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4088 FYI, the reference solutions to the batch training exercises are failing, and it looks to me like it's because of this issue. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3720: [FLINK-6302] Documentation build error on ruby 2.4

2017-06-06 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/3720 Yes, let's get this done. On Jun 6, 2017 19:03, "Stephan Ewen" wrote: > @alpinegizmo <https://github.com/alpinegizmo> @zentol > <https://git

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119893904 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119894456 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119894379 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119896766 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119894264 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119893598 --- Diff: docs/dev/table/sql.md --- @@ -22,20 +22,22 @@ specific language governing permissions and limitations under the License

[GitHub] flink pull request #4046: [FLINK-6749] [table] Table API / SQL Docs: SQL Pag...

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4046#discussion_r119894751 --- Diff: docs/dev/table/sql.md --- @@ -82,14 +84,12 @@ val result2 = tableEnv.sql( -**TODO: Add some intro.** - {% top

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119890353 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119886927 --- Diff: docs/dev/libs/cep.md --- @@ -700,26 +995,29 @@ class MyPatternFlatSelectFunction implements PatternFlatSelectFunction

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119885420 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119879015 --- Diff: docs/dev/libs/cep.md --- @@ -168,33 +256,34 @@ start.where( -Attention The call to `Context.getEventsForPattern

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119883989 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +333,118 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119883183 --- Diff: docs/dev/libs/cep.md --- @@ -98,48 +128,106 @@ val result: DataStream[Alert] = patternStream.select(createAlert

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119890712 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119878726 --- Diff: docs/dev/libs/cep.md --- @@ -168,33 +256,34 @@ start.where( -Attention The call to `Context.getEventsForPattern

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119888143 --- Diff: docs/dev/libs/cep.md --- @@ -341,153 +765,67 @@ Pattern start = Pattern.begin("

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119888607 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r11907 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119853002 --- Diff: docs/dev/libs/cep.md --- @@ -98,48 +128,106 @@ val result: DataStream[Alert] = patternStream.select(createAlert

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119889986 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119886720 --- Diff: docs/dev/libs/cep.md --- @@ -700,26 +995,29 @@ class MyPatternFlatSelectFunction implements PatternFlatSelectFunction

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119889674 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119852417 --- Diff: docs/dev/libs/cep.md --- @@ -98,48 +128,105 @@ val result: DataStream[Alert] = patternStream.select(createAlert

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119887736 --- Diff: docs/dev/libs/cep.md --- @@ -511,133 +849,81 @@ val start = Pattern.begin[Event]("

[GitHub] flink pull request #4041: [FLINK-6198] [cep] Update CEP documentation.

2017-06-02 Thread alpinegizmo
Github user alpinegizmo commented on a diff in the pull request: https://github.com/apache/flink/pull/4041#discussion_r119891095 --- Diff: docs/dev/libs/cep.md --- @@ -246,63 +334,399 @@ pattern.where(event => ... /* some condition */).or(event => ... /* or con

  1   2   3   >