Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172497724
Yes there is, and there have been some comments on that.
I am not sure that it's the best approach. I suggested some workarounds.
So actually
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/1291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1291#issuecomment-172458727
Hi @vasia,
This PR contained a bugfix that could have been validated, but I don't mind
closing it!
---
If your project is set up for it, you can rep
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1348
[FLINK-2879] [docs] Fixed broken links on the architecture page
Fixed the links on the general architecture page. They were pointing to
non-existing htmls.
You can merge this pull request
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1291
[FLINK-2634] [gelly] [WIP] Vertex Centric Triangle Count
This PR builds on the code presented in #1105.
Basically, the reduceOn* calls are replaced with groupReduceOn* calls.
As
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/1105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-142625252
Hi,
I agree with the issues raised in this discussion. They most definitely
should be adressed, but unfortunately, I cannot do it. I am handling many
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1149#issuecomment-141905104
Hi @vasia,
As you said, I already reviewed this :P. I left a couple of comments
inline. Please reverify the forwarded fields annotations. If you put them
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39948297
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSP.java
---
@@ -110,24 +105,20 @@ public static void main
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1149#discussion_r39947900
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,486 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-141756735
I've created the two JIRA issues: FLINK-2714 and FLINK-2715.
@vasia, if no other objections, can you have another look at this and merge
it?
---
If
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/1124
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-140133538
Hey you two :)
I suggest that we add this one.
Let the JIRA that @vasia opened handle the keys.
Then add the DataSet example (another JIRA) and a
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1124#issuecomment-140131099
Hi @vasia ,
There was no clear rejection in the discussion, so I thought I'd try my
luck :)
This technique could be enabled by using a flag on
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-139822550
I think it's safe to open a fresh PR... fixing this one would be overkill.
You can also update and rebase #923 so that we can review them.
---
If your proje
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-139820404
If it's okay with you, I'd like to see what @vasia has to say about adding
the Triangle Count example from the DataSet API + a reduce as a library
method.
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1124
[FLINK-2661] Added Node Splitting Methods
Social media graphs, citation networks or even protein networks have a
common property: their degree distribution follows a power-law curve. This
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1105#issuecomment-139564327
The only argument I have for this particular code (as opposed to the one in
the DataSet API) is that his one simulates what Pregel is doing... But since
it
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1105#discussion_r39276971
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/TriangleCount.java
---
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-138692441
It seems the issue was already fixed via #1075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/1058
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-138654987
I asked whether I should change the list initialization. The current commit
fixes the bug reported on the Jira issue, but I understood that you'd like it
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1105
[FLINK-2634] [gelly] Added a vertex-centric Triangle Count Lib Method
This PR adds a vertex centric version of the TriangleCount algorithm as
discussed in #1054.
The main difference is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1054#issuecomment-138497145
Since the bugfix version was released days ago, I guess this is safe to
merge...
---
If your project is set up for it, you can reply to this email and have your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135407258
so you mean something like
`List> offsets =
getRuntimeContext().getBroadcastVariableWithInitializer("counts", new
ArrayList());`?
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135396805
Yup that's what I thought as well.
However, I only tested `zipWithUniqueId` on a cluster.
A student came to me and said that `zipWithIndex` did not work
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135042510
I guess because more parallel instances are trying to access that broadcast
variable.
---
If your project is set up for it, you can reply to this email and have
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135035150
Yes, I am sorry about that. It was a propagated typo. Problem solved!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1058#issuecomment-135027923
excerpt from the JIRA
"This can be fixed by wrapping a concurrent list around the counts variable
e.g. CopyOnWriteArrayList from java.util.concurrrent (i
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1058
[FLINK-2512] [bugfix] Used a concurrent list in the open method
This PR fixes the concurrency issue raised by the elements in the broadcast
set. I instantiated the list to be a
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1054#issuecomment-134847386
okay...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1054#issuecomment-134845522
Great! I'll merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1054#issuecomment-134702560
Hi @vasia,
I clarified the type of input expected. The graph should be undirected.
Without the distinct, you get duplicate edges there(and an erroneous
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1054#issuecomment-134590137
You're right @tillrohrmann. I updated the JIRA to also contain a small
description :)
---
If your project is set up for it, you can reply to this email and
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/1054
[FLINK-2570] [gelly] Added a Triangle Count Library Method
This PR adds a Triangle Count Library Method to Gelly.
I decided to add the GAS version because it is faster than vertex
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1042#issuecomment-134516708
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1042#issuecomment-133881425
Exactly what I had in mind. +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/765#issuecomment-130016029
@vasia , I guess the guys already finished the IMPRO3 course.
What is the status of this PR @mfahimazizi? Do you have time to address the
comments? Are you
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-130014300
Saw this "I will also update the documentation " afterwards... Sorry!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-130013958
Hi @vasia,
Not sure whether this comment was issued for me... Nevertheless I left some
suggestions inline. All in all, it covers the problems discussed in
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/883#issuecomment-130003492
I guess the only request that was not fulfilled for this PR was to squash
the commits. Then it should be fine.
---
If your project is set up for it, you can reply
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/1000#issuecomment-130002982
Apart from the minor comment, this looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/1000#discussion_r36779494
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/GatherSumApplyITCase.java
---
@@ -86,26 +72,35 @@ public void
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-128923829
Hi @shghatge,
Remember the git rebase command we talked about when you were in Berlin?
You should revert the last commit and rebase instead... right now it
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/968#issuecomment-128456801
Nope, no comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-123153943
Hi @shghatge ,
Did you also run the two examples on the cluster to make sure that the
approximate version is faster?
Then you could also add some numbers
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/923#issuecomment-122868758
Could you also do a git ammend to reference the correct jira issue in the
commit?
---
If your project is set up for it, you can reply to this email and have your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121215203
Hmmm :-? but can you pass NullValue to tyes... it expects Something.class.
Can it be overwritten without type erasure getting in the way?
Anyway... I will
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121039562
Yes, but then you would have the following methods: `types`,
`typesNoEdgeValue`, `typesNoVertexValue` and again `types`. So, even if it's
not 100% needed I
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r34504919
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r34504887
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,462 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-121032514
Hi @vasia,
I also saw the types issue, but I had a feeling that this is the way it was
decided in the previous comment. I would rather have different names
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-120856171
Hi,
I just had a closer look at this PR and it made me seriously question the
utility of a `Graph.fromCSV` method. Why? First of all because it's
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-120654787
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/892#issuecomment-119708667
Code-style freak says everything else is fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/892#discussion_r34189351
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java
---
@@ -0,0 +1,243
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/892#discussion_r34189267
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java
---
@@ -0,0 +1,243
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/892#discussion_r34189005
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/AdamicAdarSimilarityMeasure.java
---
@@ -0,0 +1,243
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-118891421
I see the requirements have been fulfilled here. If no objections, I'd like
to merge this by the end of the week :)
---
If your project is set up for it, yo
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/696#discussion_r33924163
--- Diff:
flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala
---
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-118179979
Hihi! Shivani is updating the PR on the fly :) Reminds me of myself back in
the day ;)
If I may tease: If these GSA parameters did not have an example, I
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/881#issuecomment-118177927
I am a bit out of context here, but I believe this PR should be deleted :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/801#issuecomment-118171270
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-117787551
Nice and rebased. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-117785914
LGTM :) @vasia ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/877#issuecomment-117540482
Hi @shghatge ,
This PR looks very nice; I added some minor inline comments to make it look
even nicer :)
One "major" problem: you have an e
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33657394
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAExistenceOfPaths.java
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33657193
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAExistenceOfPaths.java
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33657118
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAExistenceOfPaths.java
---
@@ -0,0 +1,193 @@
+/*
+ * Licensed
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/877#discussion_r33657016
--- Diff: docs/libs/gelly_guide.md ---
@@ -693,6 +693,9 @@ Currently, the following parameters can be specified:
* Number of Vertices: Accessing the
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/801#issuecomment-117112526
Okay, can I get some +1s to merge this :)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/801#issuecomment-116287334
Hi @thvasilo ,
Sorry for the late reply... I stated in the `zipWithIndex` PR that I am
waiting for that to be merged before I update this one :). So, here it
Github user andralungu closed the pull request at:
https://github.com/apache/flink/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-116234551
Perfectly valid comments, thanks! PR Updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-115689621
Hi @shghatge ,
I left my set of comments inline. They are mostly related to coding style
issues. I guess you should revisit the previous comments here
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33355373
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphCreationWithMapperITCase.java
---
@@ -156,4 +181,17
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33355251
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GraphMetrics.java
---
@@ -150,20 +149,15 @@ private static boolean
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33355180
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/ConnectedComponents.java
---
@@ -119,23 +113,32 @@ private static boolean
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354695
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354654
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354571
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354597
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354535
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354309
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/GraphCsvReader.java
---
@@ -0,0 +1,502 @@
+/*
+ * Licensed to the Apache
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354136
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,54 @@ public void flatMap(Edge edge,
Collector>
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33354071
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,54 @@ public void flatMap(Edge edge,
Collector>
Github user andralungu commented on a diff in the pull request:
https://github.com/apache/flink/pull/847#discussion_r33353966
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -282,6 +282,54 @@ public void flatMap(Edge edge,
Collector>
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-115134406
Hey Theo,
Thanks a lot for finding my bug there ^^
PR updated to address the Java issues and to contain a pimped Scala
version of `zipWithIndex
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114883882
Uhmmm... flink.api.scala is imported. That's not the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114878728
Actually, I get a weird compile error: it says missing Type parameter for
the map in DataSet.scala...
I think this is because the map is overriden... and I haven&#
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-114481973
Hey @tillrohrmann ,
Sorry for the incredibly late reply. The last weeks have been very hectic.
Nevertheless, I'd like to properly finish and polish
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/808#issuecomment-114420568
Thanks @aljoscha for reminding me... This slipped my mind for a sec.
I agree that the methods should have Scaladoc (this should be
straightforward to add
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-113880523
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/770#issuecomment-113752297
Meging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-113483077
Mea culpa. No the mapper test is fine;
For the examples comment, I meant to go through the classes in the example
folder and to modify the way the graph is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-113217602
Ah! And I just remembered! Maybe it makes sense to update the examples to
use `fromCSV` when creating the Graph instead of `getEdgesDataSet`.
---
If your project is
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/847#issuecomment-113213190
This looks very nice! Someone deserves a virtual :ice_cream: !
There are some tests missing:
- test `fromCSV` with a Mapper
- you just test `types
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-113149078
Hi @shghatge ,
Don't forget to remove the definition for the public
removeVertices(DataSet) from the documentation.
Up for discussion: shou
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/846#issuecomment-112783592
Hi @shghatge ,
It seems we have a bit of a mess in this PR. Nothing that cannot be fixed.
Let's take it offline.
---
If your project is set up for it
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/799#issuecomment-112373119
PR updated to test the same issue in ApplyCoGroupFunctionOnAllEdges and
ApplyCoGroupFunction.
Also added tests.
---
If your project is set up for it, you can
1 - 100 of 218 matches
Mail list logo
