Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/6391#discussion_r205051308
--- Diff:
flink-connectors/flink-connector-elasticsearch6/src/main/java/org/apache/flink/streaming/connectors/elasticsearch6/Elasticsearch6ApiCallBridge.java
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
@tzulitai I'm unfortunately totally buried under work at the moment so I
don't feel like I will have time in such a short deadline :( Sorry about that.
If for some reason more delays is ad
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
@tzulitai
Happy to see progress is made on this!
> After merging this, I'll also try cherry-picking your 6.x REST-based ES
connector on top. If that works well, will also me
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/3034
@aljoscha
We regularly empty the window because we can get lengthy windows with a lot
of elements, so it is good get rid of elements we already managed. But then if
we have no more elements
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/3034
> It could, but I think we don't want to do this change right now.
we are getting into cases where this feature would be useful. Do you have
any insights on why you finally don't
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
> @cjolif do you think it would be possible that with a clean cut using a
REST implementation, we no longer need to have separate modules anymore for ES
6.x, 7.x, 8.x or so on?
i.e., it wo
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
What I could do if that can help making progress, is to create a second PR
based on this one and introducing the RestHighLevelClient implementation based
on those APIs? This would allow to get an
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
> When planning to switch to REST, are we speaking of an implementation
that works directly against Elasticsearch's REST API? Or are we thinking of
using Elasticsearch's RestHi
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
Overall I think the most important thing to do is do something :) We can't
let Flink elasticsearch in the broken state they are today. There must either
be a purely REST-based solution or make
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/6043
@StephanEwen that is I think more or less what I proposed here:
https://lists.apache.org/thread.html/e7f584e0df9ce510fa5bee8d3a7e59b6df885f7deee36710a1cbb9b1@%3Cdev.flink.apache.org%3E
&qu
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/6043#discussion_r190364900
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/6043#discussion_r190359388
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/BulkProcessorIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/6043#discussion_r190359413
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/6043#discussion_r190359344
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/RequestIndexer.java
GitHub user cjolif opened a pull request:
https://github.com/apache/flink/pull/6043
[FLINK-7386] evolve RequestIndexer API to make it working with Elastic
5.3+, evolve ElasticsearchApiCallBridge API to make it compatible with a
possible RestHighLevelClient implementation
## What
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/5374
@tzulitai sure. done.
---
Github user cjolif closed the pull request at:
https://github.com/apache/flink/pull/5374
---
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/5374
good news the issue reported by @jdewald is now fixed in Elasticsearch
master. Not sure which version of Elasticsearch will contain the fix though.
---
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/4675#discussion_r169568752
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/4675#discussion_r169490640
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/4675#discussion_r169144082
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/5374
@tzulitai did you have a chance to look at this? If you have any question
please let me know?
---
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r165186422
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r165109918
--- Diff:
flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/Elasticsearch53ApiCallBridge.java
Github user cjolif commented on a diff in the pull request:
https://github.com/apache/flink/pull/5374#discussion_r164992369
--- Diff:
flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkBase.java
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/5374
thanks @tzulitai. Let me know if you have any question.
---
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/4675
I have included the exact commits of @zjureel in #5374 as I wanted to build
on top of them. So if #5374 gets in it shouldn't be needed anymore.
---
GitHub user cjolif opened a pull request:
https://github.com/apache/flink/pull/5374
[FLINK-8101][flink-connectors] Elasticsearch 5.3+ (TransportClient) and 6.x
(RestHighLevelClient) support
## What is the purpose of the change
*The purpose of this PR is to
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/4675
FYI I rebased it and got working results on a sample of mine.
---
Github user cjolif commented on the issue:
https://github.com/apache/flink/pull/4675
@zjureel do you have by any chance an updated version of the PR against
latest code (looks like current one conflicts)?
---
30 matches
Mail list logo
