Github user heytitle commented on the pull request:
https://github.com/apache/flink/commit/ff3a35e93e858e30debcb1e85cc056045c1fe2a0#commitcomment-24687576
ð
---
Github user heytitle commented on the pull request:
https://github.com/apache/flink/commit/9016cce503b4d471b5a49f0abccc196945ada97e#commitcomment-24529391
In
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java:
In
flink-runtime/src/main/java
Github user heytitle commented on the pull request:
https://github.com/apache/flink/commit/cce40c5cd4aaff446bb4bec8918d2fda37649e0a#commitcomment-24528598
In
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java:
In
flink-runtime/src/main/java
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140664033
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140662538
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/codegeneration/SorterFactory.java
---
@@ -0,0 +1,198 @@
+/*
+ * Licensed to the
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r140659544
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -190,6 +190,7 @@ private String
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
@ggevay Thanks for the commits. They look good. I also added you to my
repository.
For `FixedLengthRecordSorter`, I agree with you that we should implement
that when #2617 is merged
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @ggevay,
Thanks for the commits. Do you have any plan for `FixedLengthRecordSorter`
implementation?
I'm not sure how much work need to be done there.
---
If your project i
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @ggevay,
I have rebased master and resolved all coding style related issues and
pushed the code to
https://github.com/heytitle/flink/tree/FLINK-5734-rebase-master-temp
For the
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @ggevay,
I'm currently fixing coding style. Maybe you can help me take a look at
what Greg suggested related `FixedLengthRecordSorter`
---
If your project is set up for it, yo
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @greghogan,
Thank very much for the feedback.
> Are you able to continue working on this feature?
Yes, I would like to complete the feature and will take a look i
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3511#discussion_r115130267
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java
---
@@ -47,61 +47,61 @@
public
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
Hi @greghogan,
Thanks for the explanation. I like the idea. I also think we might not need
`NormalizedKeySorterBase`, we can just extend generated sorters from
`NormalizedKeySorter` and
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114009718
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/drivers/DriverBaseITCase.java
---
@@ -41,17 +43,41 @@
@Rule
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114010412
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/link_analysis/HITS.java
---
@@ -60,8 +60,6 @@
*
* http
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3779#discussion_r114007404
--- Diff:
flink-libraries/flink-gelly-examples/src/main/java/org/apache/flink/graph/drivers/input/GridGraph.java
---
@@ -82,11 +81,27 @@ public void
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
I also think about the abstract class but I'm not sure how to do it
properly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
@greghogan May I ask you how to remove `FLINK-3722` commits?. Only way I
can think of is `git rebase -i`, but this will rewrite history of this PR.
---
If your project is set up for it, you can
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/3511
I haven't posted it yet. I will do it next week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3511
Flink 5734 code generation for normalizedkey sorter
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/heytitle/flink
FLINK-5734-code-generation
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3393#discussion_r102675770
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -72,6 +72,15 @@ $ cd build-target # this is where Flink is
installed to
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3393
[FLINK-3903][docs] adding alternative installation documentation for â¦
â¦OSX users
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3080#discussion_r96222848
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/metrics/ScalaGauge.scala
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3080#discussion_r95671339
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/metrics/ScalaGauge.scala
---
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3080#discussion_r95666996
--- Diff:
flink-scala/src/test/scala/org/apache/flink/api/scala/metrics/ScalaGaugeTest.scala
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache
Github user heytitle commented on a diff in the pull request:
https://github.com/apache/flink/pull/3080#discussion_r95347426
--- Diff:
flink-scala/src/main/scala/org/apache/flink/api/scala/metrics/ScalaGauge.scala
---
@@ -0,0 +1,27 @@
+/*
+ * Licensed to the Apache
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/3080
[FLINK-4920] Add a Scala Function Gauge
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes
Github user heytitle commented on the issue:
https://github.com/apache/flink/pull/2611
@fhueske you're welcome ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enable
GitHub user heytitle opened a pull request:
https://github.com/apache/flink/pull/2611
Update the way we call WordCount program in setup/cli.md examples.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into
29 matches
Mail list logo
