[GitHub] flink issue #2941: [FLINK-3555] Web interface does not render job informatio...

2017-01-23 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2941 I agree with @sachingoel0101 as for overrriding classes from `vendor.css` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...

2016-11-19 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2467 @mushketyk do make sure that the generated files are up-to-date (if they're not) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...

2016-11-14 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2457 @greghogan right - missed the generated files. @mushketyk I suppose `gulp`ing will help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink issue #2457: [FLINK-3680][web frontend] Remove "(not set)" text in the...

2016-11-14 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2457 @mushketyk from my side looks good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...

2016-11-13 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk I suppose so, right @rmetzger ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request #2457: [FLINK-3680][web frontend] Remove "(not set)" text...

2016-11-11 Thread iampeter
Github user iampeter commented on a diff in the pull request: https://github.com/apache/flink/pull/2457#discussion_r87659296 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.dir.coffee --- @@ -281,7 +281,8 @@ angular.module('fli

[GitHub] flink pull request #2467: [FLINK-3719][web frontend] Moving the barrier betw...

2016-11-11 Thread iampeter
Github user iampeter commented on a diff in the pull request: https://github.com/apache/flink/pull/2467#discussion_r87658530 --- Diff: flink-runtime-web/web-dashboard/app/scripts/modules/jobs/jobs.dir.coffee --- @@ -168,14 +168,15 @@ angular.module('flinkApp')

[GitHub] flink issue #2431: [FLINK-4521][web frontend] Fix "Submit new Job" panel in ...

2016-11-11 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2431 @mushketyk looks good, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...

2016-10-21 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2448 @rmetzger will you be merging? if so, `flink-runtime-web/web-dashboard/web/js/index.js` just needs a `gulp` --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2448: [FLINK-3030][web frontend] Enhance dashboard to show exec...

2016-10-21 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2448 @mushketyk could you try `npm view gulp-stylus` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...

2016-09-30 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2467 Thanks, that's better @mushketyk, but I think would be even better if you did not identify the elements explicitly by ids ('#canvas', '#job-panel'), but have the directive

[GitHub] flink issue #2467: [FLINK-3719][web frontend] Moving the barrier between gra...

2016-09-22 Thread iampeter
Github user iampeter commented on the issue: https://github.com/apache/flink/pull/2467 @mushketyk thanks for this feature, very useful indeed. I'd like to ask you to reconsider some things: 1. First of all, I think it would be good to wrap split.js in an Angular dire

[GitHub] flink pull request: [FLINK-2928][web-dashboard] Fix confusing job ...

2015-12-07 Thread iampeter
Github user iampeter commented on the pull request: https://github.com/apache/flink/pull/1421#issuecomment-162567139 Maybe a top right action button, triggering a Bootstrap dropdown with the Cancel action? ![action](https://cloud.githubusercontent.com/assets/713801/11631787

[GitHub] flink pull request: Fixed FLINK-2942

2015-11-11 Thread iampeter
GitHub user iampeter opened a pull request: https://github.com/apache/flink/pull/1346 Fixed FLINK-2942 This should fix https://issues.apache.org/jira/browse/FLINK-2942 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iampeter

[GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...

2015-10-07 Thread iampeter
Github user iampeter commented on the pull request: https://github.com/apache/flink/pull/1236#issuecomment-146333800 @sachingoel0101 @aljoscha looks great, but I would make the following changes if possible: 1. Move the 'livechart' directive to a sep

[GitHub] flink pull request: [FLINK-2730][web-dashboard] Adds cpu and memor...

2015-10-07 Thread iampeter
Github user iampeter commented on the pull request: https://github.com/apache/flink/pull/1236#issuecomment-146320512 @aljoscha ok will do --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink pull request: [FLINK-2811][web-dashboard]Add page with Confi...

2015-10-06 Thread iampeter
Github user iampeter commented on the pull request: https://github.com/apache/flink/pull/1219#issuecomment-145842071 @sachingoel0101 unfortunately haven't had time yet, so I guess you can take on it --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: [web-dashboard] Added task managers to the new...

2015-09-22 Thread iampeter
GitHub user iampeter opened a pull request: https://github.com/apache/flink/pull/1164 [web-dashboard] Added task managers to the new web dashboard I transfered the task manager REST API code to a RequestHandler (TaskManagersHandler) and added the JS view. There are no

[GitHub] flink pull request: [FLINK-2357] [web dashboard] Fixed broken plan...

2015-09-19 Thread iampeter
GitHub user iampeter opened a pull request: https://github.com/apache/flink/pull/1148 [FLINK-2357] [web dashboard] Fixed broken plan on second entry Fixed the issue with wrong rendering when entering the plan for the second time. You can merge this pull request into a Git