[GitHub] flink issue #6136: [FLINK-4303] [CEP] Add CEP examples

2018-06-14 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/6136 cc @dawidwys ---

[GitHub] flink pull request #6163: [hotfix][table] Fix a incorrect exception message.

2018-06-14 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/6163 [hotfix][table] Fix a incorrect exception message. Fix a incorrect exception message, `stream` -> `batch` You can merge this pull request into a Git repository by running: $ git pull ht

[GitHub] flink issue #6136: [FLINK-4303] [CEP] Add CEP examples

2018-06-07 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/6136 cc @twalthr ---

[GitHub] flink issue #6136: [FLINK-4303] [CEP] Add CEP examples

2018-06-07 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/6136 @medcv Thanks for your review :) Updated as your suggestions. ---

[GitHub] flink pull request #6136: FLINK-4303] [CEP] Add CEP examples

2018-06-07 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6136#discussion_r193941724 --- Diff: flink-examples/flink-examples-cep/src/main/java/org/apache/flink/cep/examples/java/monitoring/TemperatureMonitoring.java --- @@ -0,0 +1,147

[GitHub] flink issue #6136: FLINK-4303] [CEP] Add CEP examples

2018-06-07 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/6136 cc @kl0u ---

[GitHub] flink pull request #6136: FLINK-4303] [CEP] Add CEP examples

2018-06-07 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/6136 FLINK-4303] [CEP] Add CEP examples ## What is the purpose of the change Currently neither CEP Java nor CEP Scala contain a runnable example. This PR fixes the problem by adding a `flink

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-06-01 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6091#discussion_r192329480 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperator.java --- @@ -209,8 +208,7 @@ public void

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-31 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6091#discussion_r192171522 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala --- @@ -71,6 +71,9 @@ object AsyncDataStream

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-30 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6091#discussion_r192001515 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java --- @@ -648,6 +662,52 @@ public

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-30 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6091#discussion_r191835482 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala --- @@ -71,6 +71,9 @@ object AsyncDataStream

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-30 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/6091#discussion_r191834614 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java --- @@ -648,6 +662,52 @@ public

[GitHub] flink issue #6091: [FLINK-7789][DataStream API] Add handler for Async IO ope...

2018-05-29 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/6091 cc @pnowojski ---

[GitHub] flink pull request #6091: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-29 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/6091 [FLINK-7789][DataStream API] Add handler for Async IO operator timeouts ## What is the purpose of the change Currently Async IO operator does not provide a mechanism to handle timeouts

[GitHub] flink pull request #5983: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-29 Thread kisimple
Github user kisimple closed the pull request at: https://github.com/apache/flink/pull/5983 ---

[GitHub] flink pull request #5983: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-24 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/5983#discussion_r190560531 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java --- @@ -0,0 +1,41

[GitHub] flink pull request #6055: [FLINK-8511][table] Remove legacy code for the Tab...

2018-05-22 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/6055 [FLINK-8511][table] Remove legacy code for the TableType annotation ## What is the purpose of the change TableSource factories had already been used to unify the definition of table

[GitHub] flink pull request #6052: [Documentation] fix a wrong link in dev/table/sql

2018-05-21 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/6052 [Documentation] fix a wrong link in dev/table/sql In [dev/table/sql.html](https://ci.apache.org/projects/flink/flink-docs-master/dev/table/sql.html) there is link to an anchor on [dev/table

[GitHub] flink pull request #5983: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-18 Thread kisimple
Github user kisimple commented on a diff in the pull request: https://github.com/apache/flink/pull/5983#discussion_r189250250 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/async/TimeoutAwareAsyncFunction.java --- @@ -0,0 +1,41

[GitHub] flink issue #5983: [FLINK-7789][DataStream API] Add handler for Async IO ope...

2018-05-10 Thread kisimple
Github user kisimple commented on the issue: https://github.com/apache/flink/pull/5983 cc @tillrohrmann @kl0u ---

[GitHub] flink pull request #5983: [FLINK-7789][DataStream API] Add handler for Async...

2018-05-10 Thread kisimple
GitHub user kisimple opened a pull request: https://github.com/apache/flink/pull/5983 [FLINK-7789][DataStream API] Add handler for Async IO operator timeouts ## What is the purpose of the change *Currently Async IO operator does not provide a mechanism to handle timeouts