Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@tillrohrmann Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys Thanks for your suggestions.
New commit extend `SchemaCoder` with `writeSchema` method that helps to
move the writing schema logic away from `AvroSerializationSchema` as you
suggested
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys
in last commit, I did extend `SchemaCoder` to have `getSchemaId` as you
suggested.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys For second issue I am looking at other Schema registries and
trying to extend `SchemaCoder`
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys Thanks!
As far as I dog on Confluent code, their api needs `subject` to retrieve
the Schema Id and version and it should be provided by consumer.
https://github.com
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys I update the PR, please review
the usage would be like this
` ConfluentRegistryAvroSerializationSchema.forSpecific(User.class, subject,
schemaRegistryUrl)`
as Confluent
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@dawidwys Thanks a lot for the review.
I will start look into both problems that you've pointed out.
Second point would be easy to fix but for the first one I need do some
research and se
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6269
+1
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6270
+1
I rebuilt the 1.5.1 with this changes and now `Upload` jar file from WebUI
working.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6259
@tillrohrmann I implemented `ConfluentRegistryAvroSerializationSchema` in
this PR. I would appreciate if you review.
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6259
[FLINK-9679] Implement AvroSerializationSchema
## What is the purpose of the change
Provides implementation of AvroSerializationSchema that write records
serialized as avro and also provides
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann PR has been updated!
I had to do some changes:
- map `User` object to `String` in `TestAvroConsumerConfluent` class
- use `read_messages_from_kafka` instead of
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann make sense.
I created this ticket https://issues.apache.org/jira/browse/FLINK-9679 for
implementing `AvroSerializationConfluentSchema`. I will make a PR for it
shortly.
Mean
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen I would appreciate it if you do the review after my changes!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol PR has been updated! Please review.
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/5995#discussion_r198150284
--- Diff:
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/5995#discussion_r198150153
--- Diff:
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann
here is my two cents:
By converting the events to `String` and sending them to Kafka there is a
high risk to produce a `bad events` and we will lose the benifit of Schema
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann I made the changes and used
`ConfluentRegistryAvroDeserializationSchema` for the Deserializations.
I still using `AvroSerializationConfluentSchema` as we need to compare each
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6083#discussion_r197994751
--- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
@@ -0,0 +1,228 @@
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6083#discussion_r197994770
--- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
@@ -0,0 +1,155 @@
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@dawidwys do u have an example using
`ConfluentRegistryAvroDeserializationSchema`. I have some difficulties to make
it work
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6083#discussion_r197493383
--- Diff: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml ---
@@ -0,0 +1,155 @@
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann PR is updated please review!
I will also look into `ConfluentRegistryAvroDeserializationSchema`
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6083#discussion_r197128954
--- Diff:
flink-end-to-end-tests/test-scripts/test-confluent-schema-registry.sh ---
@@ -0,0 +1,106 @@
+#!/usr/bin/env bash
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@dawidwys Thanks for the review! I will look into that PR. This test is for
Release 1.4 and 1.5 and provide a proof that Flink V4.0 and V5.0 can work with
ConfluentSchema Registry properly. As PR you
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6138
@dawidwys PR's been updated! Please review.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6138
@dawidwys Thanks for the review!
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6138#discussion_r195749896
--- Diff: docs/dev/libs/cep.md ---
@@ -131,7 +131,7 @@ val result: DataStream[Alert] =
patternStream.select(createAlert(_))
The pattern API allows you to
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6138#discussion_r195749997
--- Diff: docs/dev/libs/cep.md ---
@@ -275,36 +275,38 @@ with "foo", and if the sum of the prices of the
previously accepted ev
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann Thanks for the review! I will go through them and will make
the changes shortly.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@dmpour23 Thanks! I updated the import as`*.util.serialization` was
Deprecated!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6146
+1
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6145
+1
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol sure, will update the PR shortly!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6139
@zentol Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6136
+1
@kisimple Thank you for update!
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6136#discussion_r194052688
--- Diff:
flink-examples/flink-examples-cep/src/main/java/org/apache/flink/cep/examples/java/monitoring/TemperatureMonitoring.java
---
@@ -0,0 +1,147
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6141
@DmitryBe Thank you! is there a Jira ticket associate to this? I suggest
add Jira ticket and update PR title according the Contribution guideline
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6136#discussion_r193934789
--- Diff:
flink-examples/flink-examples-cep/src/main/scala/org/apache/flink/cep/examples/scala/monitoring/TemperatureMonitoring.scala
---
@@ -0,0 +1,107
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6136#discussion_r193934744
--- Diff:
flink-examples/flink-examples-cep/src/main/java/org/apache/flink/cep/examples/java/monitoring/TemperatureMonitoring.java
---
@@ -0,0 +1,147
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6136
@kisimple Recently I started to work on same example. I ran your code on my
local and it did work perfectly. I could see some checkstyle errors that I
think travis might pick them up.
I have
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6138
[FLINK-9550][DOC]FlinkCEP snippet example has some syntax errors
## What is the purpose of the change
Fixing FlinkCEP snippet code syntax errors and data type mismatches
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6128
+1
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6139
[FLINK-9551][DOCS]FlinkCEP Scala Combining Patterns table has a missing
pattern
## What is the purpose of the change
in FlinkCEP documentation section related to Combining Patterns
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6137
[FLINK-9549][DOC]Fix FlickCEP Docs broken link and minor style changes
## What is the purpose of the change
Fixing FlickCEP broken link and minor style changes
## Does this pull
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann Thanks a lot for doing the review!
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol yes, that also works. Do you still need me to change it and extend
`Next Steps` or we can keep this to provide a bit more info for different ways
to submitting jobs.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks for the review. I made the clean up and did some changes to
get the ES dependency from flink-quickstart-test/pom.xml
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r193581841
--- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
@@ -51,12 +59,12 @@ sed -i -e ''"$(($position + 1))"
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r193581372
--- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
@@ -0,0 +1,98 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r193581567
--- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
@@ -0,0 +1,98 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r193581591
--- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
@@ -0,0 +1,98 @@
+
+
+http://maven.apache.org/POM/4.0.0
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR has been updated and usage also changed to
`test_quickstarts.sh `
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6114
[FLINK-9518][Docs] SSL setup Docs config example has wrong keys password
## What is the purpose of the change
In creating keystores and turststore section password is set to `password`
but
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6113
[FLINK-9517][Docs]Fixing broken links on CLI and Upgrade Docs
## What is the purpose of the change
Fixes broken links for CLI and Upgrade docs.
## Does this pull request potentially
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6112
@zentol PR is updated! I would appreciate if you review and again so sorry
for mixing concerns in a PR.
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192697051
--- Diff: docs/dev/execution_configuration.md ---
@@ -45,41 +45,41 @@ The following configuration options are available: (the
default is bold
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192693691
--- Diff: docs/ops/upgrading.md ---
@@ -172,7 +172,7 @@ First major step in job migration is taking a savepoint
of your job running in t
You can do this
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192693807
--- Diff: docs/ops/filesystems.md ---
@@ -112,10 +111,9 @@ To prevent inactive streams from taking up the
complete pool (preventing new con
`fs
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192690554
--- Diff: docs/ops/upgrading.md ---
@@ -183,15 +183,15 @@ In this step, we update the framework version of the
cluster. What this basicall
the Flink
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192689975
--- Diff: docs/ops/security-ssl.md ---
@@ -22,22 +22,22 @@ specific language governing permissions and limitations
under the License
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192689067
--- Diff: docs/ops/filesystems.md ---
@@ -70,21 +70,20 @@ That way, Flink seamlessly supports all of Hadoop file
systems, and all Hadoop-c
- **har
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192689122
--- Diff: docs/ops/filesystems.md ---
@@ -70,21 +70,20 @@ That way, Flink seamlessly supports all of Hadoop file
systems, and all Hadoop-c
- **har
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6112#discussion_r192689028
--- Diff: docs/internals/ide_setup.md ---
@@ -89,7 +89,7 @@ IntelliJ supports checkstyle within the IDE using the
Checkstyle-IDEA plugin.
3. Set the
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6112
@zentol Thanks a lot for review and I am so sorry for causing pain. I will
reduce the scope of this PR and only keep spelling issues for now.
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6112
[FLINK-9508][Docs]General Spell Check on Flink Docs
## What is the purpose of the change
General spell check for Flink docs
## Does this pull request potentially affect one of
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen PR is updated as requested! I would appreciate if you review.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann I would appreciate if you review or assign a reviewer to this
PR.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR is updated with requested changes! Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol PR is updated!
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r191740715
--- Diff: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ---
@@ -75,6 +76,8 @@ function verify_result {
}
function
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r191740903
--- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
@@ -18,29 +18,38
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r191740667
--- Diff: flink-end-to-end-tests/test-scripts/elasticsearch-common.sh ---
@@ -56,13 +56,14 @@ function verify_elasticsearch_process_exist {
function
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks! found them :)
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol I reverted back flink-elasticsearch* modules. Do you think we still
need them as they've never been used?
---
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r191733069
--- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
@@ -86,6 +102,21 @@ under the License
Github user medcv commented on a diff in the pull request:
https://github.com/apache/flink/pull/6089#discussion_r191732783
--- Diff: flink-end-to-end-tests/flink-quickstart-test/pom.xml ---
@@ -20,27 +20,43 @@ under the License.
http://maven.apache.org/POM/4.0.0
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol updated the PR as suggested! Please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol sure! I will update the PR with your requested changes.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks for review!
Yes, I totally agree as the most of test script is duplicated, we need to
refactor them the way you mentioned, I will update the PR with new changes.
QQ: One
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6089
[FLINK-9451]End-to-end test: Scala Quickstarts
## What is the purpose of the change
Added an end-to-end test which verifies Flink's quickstarts scala. It does
the foll
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen I updated the code and used `ExecutionContext.global` which
makes use of threadpool.
I tested it and results showed that the code sent off multiple requests
concurrently
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@zentol
Ok, I created a Jira ticket for Scala Quickstarts end2end test and will
make a PR for it.
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6083
@tillrohrmann please review
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6084
@zentol Please review
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6084
[FLINK-8654][Docs] Extend quickstart docs on how to submit jobs
## Brief change log
The quickstart documentation explains how to setup the project, build the
jar and run things in the IDE
Github user medcv closed the pull request at:
https://github.com/apache/flink/pull/6044
---
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@StephanEwen Thanks for review.
make sense, I will update the client code to use Threadpool and will run
more tests.
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6083
[FLINK-8983] End-to-end test: Confluent schema registry
## Brief change log
Added an end-to-end test which verifies that Flink is able to work together
with the Confluent schema registry. In
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@zentol Thanks for the review.
Make sense to build this `quickstarts.zip` package on Jenkins but the main
concern was test the `.zip` package (included all dependencies) before
uploading it on
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@zentol I would appreciate if you review this. We use this type of example
for enriching our Steam data via API call which is very common use-case and I
think it would be useful for other people to
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6044
@StephanEwen I would appreciate if you review this
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6044
[FLINK-1044] Website: Offer a zip archive with a pre-setup user project
## What is the purpose of the change
This PR will run two tests to build Java and Scala quickstart packages.
After
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5996
@tzulitai I would appreciate if you review this.
---
GitHub user medcv opened a pull request:
https://github.com/apache/flink/pull/6018
[FLINK-9372] Typo on Elasticsearch website link (elastic.io --> elastic.co)
## What is the purpose of the change
Typo on Elasticsearch website link elastic.io --> elastic.co
#
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5823
@tzulitai I agree it should be separate of this PR.
Main challenge is to upload a compiled Quickstart zip file contain all
dependencies for each changes (minor) we do automatically. I was thinking
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5823
@zhangminglei @zentol
I was looking at the ticket
[FLINK-1044](https://issues.apache.org/jira/browse/FLINK-1044) and seems we can
use the output of this test to offer a zip archive with a pre
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/5989
@zentol please review
---
1 - 100 of 110 matches
Mail list logo
