[GitHub] flink issue #2804: [FLINK-5067] Make Flink compile with 1.8 Java compiler

2016-11-24 Thread melentye
Github user melentye commented on the issue: https://github.com/apache/flink/pull/2804 @StephanEwen it seems that the semantics is different when java.version is just defined in pom.xml versus being overriden with -Djava.version=x.y.z argument passed to mvn

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88332568 --- Diff: pom.xml --- @@ -96,7 +96,7 @@ under the License. 1.7.7 18.0 2.3.7 - 1.7

[GitHub] flink issue #2804: [FLINK-5067] Make Flink compile with 1.8 Java compiler

2016-11-16 Thread melentye
Github user melentye commented on the issue: https://github.com/apache/flink/pull/2804 @StephanEwen I initially introduced a new Travis profile so that the coverage would be strictly improved, i.e. all old combinations tests plus the new ones. But I am also fine reusing some

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331708 --- Diff: flink-tests/src/test/java/org/apache/flink/test/windowing/sessionwindows/SessionWindowITCase.java --- @@ -122,11 +122,11 @@ private void runTest

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-16 Thread melentye
Github user melentye commented on a diff in the pull request: https://github.com/apache/flink/pull/2804#discussion_r88331670 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/CollectionExecutionAccumulatorsTest.java --- @@ -35,7 +35,7 @@ @Test

[GitHub] flink pull request #2804: [FLINK-5067] Make Flink compile with 1.8 Java comp...

2016-11-14 Thread melentye
GitHub user melentye opened a pull request: https://github.com/apache/flink/pull/2804 [FLINK-5067] Make Flink compile with 1.8 Java compiler - New type inference rules changed which overloaded methods are picked. - Renamed java.version property in maven to java.minor.version

[GitHub] flink pull request #2760: [FLINK-5014] [RocksDB backend] add toString for Ro...

2016-11-05 Thread melentye
GitHub user melentye opened a pull request: https://github.com/apache/flink/pull/2760 [FLINK-5014] [RocksDB backend] add toString for RocksDBStateBackend Adding toString() for RocksDBStateBackend. Example output 1: > RocksDB State Backend {isInitialized=fa