Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68550234
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -132,9 +132,9 @@
- private final Configuration
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68550224
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -132,9 +132,9 @@
- private final Configuration
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2149#discussion_r68550160
--- Diff: docs/apis/cli.md ---
@@ -187,6 +187,8 @@ Action "run" compiles and runs
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2138
Thank you for the suggestion. I incorporated it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2147
[FLINK-1946] reduce verbosity of Yarn cluster setup
This removes repeated printing of messages retrieved from the Yarn cluster.
Only new messages are printed.
You can merge this pull request into a
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2140
Merged with 3163638a61f49dd2df55467615096918bec3a890.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mxm closed the pull request at:
https://github.com/apache/flink/pull/2140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2140
Travis has passed. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2140
[FLINK-4079] do not load Yarn properties file for per-job Yarn clusters
This is a backported fix for the release-1.0 branch to skip loading of the
Yarn properties file for per-job Yarn clusters.
You
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/c8fed99e3e85a4d27c6134cfa3e07fb3a8e1da2a#commitcomment-17936226
In pom.xml:
In pom.xml on line 972:
It does work fine for most cases. However, there are rare race conditions
which render our
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2139
[FLINK-3838] Upgrade commons-cli to fix parsing of jar args
The jar arguments were not parsed correctly if options were
present. For example, in `./flink run file.jar -arg value` the
jar
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2138
[FLINK-3757] clarify JavaDoc for addAccumulator method
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3757
Alternatively you can
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2132
Merging with a slight change to use the `Closeable` feature:
```java
try (final OutputStream out = new
FileOutputStream(propertiesFile
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2132
Thank you for the pull request!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2137
[FLINK-4041] reduce log level for JobManager->ResourceManager timeouts
These timeouts can be recovered and don't have to be logged as error with
an Exception.
You can merge this pull reques
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2125
The commit message is the JIRA issue subject. I agree that it makes sense
to give a description of the changes instead.
---
If your project is set up for it, you can reply to this email and have your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2125
[FLINK-3864] Yarn tests don't check for prohibited strings in log output
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2123
[FLINK-3904] GlobalConfiguration doesn't ensure config has been loaded
This PR contains two commits. The first commit simply checks whether
`loadConfiguration(..)` has been called. The second c
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Merged. Thank you for your comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2034
Merged. Thank you for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Rebased to the latest master and refined the tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2101
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2101
[FLINK-4030] Revert Surefire version to 2.18.1
The ScalaShellITCase sometimes gets stuck before test execution with no
output
in the logs. We ran about a hundred builds against Surefire 2.18.1
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r67003363
--- Diff: docs/apis/cli.md ---
@@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs.
con
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
I've addressed your comments in another commit. I'd be delighted if you
could try out the changes again!
- remove legacy code from CliFrontend
- change activation code of CustomC
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66806299
--- Diff: docs/apis/cli.md ---
@@ -252,6 +256,12 @@ Action "list" lists running and scheduled programs.
con
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805960
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java
---
@@ -181,11 +198,30 @@ public boolean getPrintStatusDuringExecution
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805953
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CustomCommandLine.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2085
Thanks for the review! I've addressed almost all your comments and will
ping you once the PR get updated. Some more comments:
> (1) When listing the yarn-session.sh cli options, I could
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805706
--- Diff: docs/setup/yarn_setup.md ---
@@ -143,6 +143,34 @@ Note that in this case its not possible to stop the
YARN session using Flink.
Use the YARN
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805492
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -300,18 +309,82 @@ public static boolean allocateResource(int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805499
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -300,18 +309,82 @@ public static boolean allocateResource(int
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805479
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,18 +185,45 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805455
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -415,62 +513,83 @@ public int run(String[] args
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805382
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,18 +185,45 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66805417
--- Diff: docs/apis/cli.md ---
@@ -105,6 +105,10 @@ The command line can be used to
./bin/flink list -r
+- List running Flink jobs
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66628410
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -980,110 +845,41 @@ protected ActorGateway
getJobManagerGateway
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66626302
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -980,110 +845,41 @@ protected ActorGateway
getJobManagerGateway
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2085#discussion_r66626078
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -1275,33 +1071,16 @@ else if (new
File(CONFIG_DIRECTORY_FALLBACK_2).exists
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2085
[FLINK-3937] programmatic resuming of clusters
These changes are based on #1978 and #2034. More specifically, they port
resuming of running Yarn clusters from #2034 to the refactoring of #1978. The
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2082
[FLINK-4031] include sources in Maven snapshot deployment
As per user request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-4031
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2034
Thanks for the update!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65348898
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978
@rmetzger I've updated the pull request and would like to get your opinion
on it again. I've addressed all your comments. Specifically, I've removed all
Yarn code from the Cl
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65349622
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r65348868
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
Done.
---
If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2056
Thanks for fixing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2056
I'm not sure whether the changes fix the problem. I think you were lucky
with the build machine on Travis :) The issue on Travis is that the
`ExecutionEnvironment` defaults to using the numb
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2033#issuecomment-222634611
Thanks for reviewing. Merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-222480544
Thanks for your comments @EronWright. This the the first refactoring of the
client code of both cluster related and job submission related matters. It is a
very good
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2046
[FLINK-3982] let only ResourceManager of leading JobManager register
In HA mode, multiple ResourceManagers may register at the leading
JobManager. They register one after another at the JobManager
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2045
[FLINK-3981] don't log duplicate TaskManager registrations
Duplicate TaskManager registrations shouldn't be logged with Exceptions
in the ResourceManager. Duplicate registrations can hap
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222138890
+1 Looks good to me.
Only wondering, how much will it affect our build time? We might want to
run this in a dedicated profile.
---
If your project is set up for
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2042#issuecomment-222132940
Thanks for the pull request! Could you elaborate on how and where this will
be integrated with our CI or release process?
---
If your project is set up for it, you can
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17644775
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2037#issuecomment-222113016
Rebased to the latest master. Will merge once the tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17643841
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/bf256c7fbe05accdadc8470013879f567341d1aa#commitcomment-17643812
In
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceID.java:
In
flink-runtime/src/main/java
Github user mxm commented on the pull request:
https://github.com/apache/flink/commit/5a7f4e3395bfb06da496584be88501c328f6ac1d#commitcomment-17643795
@StephanEwen I think this has been left there on purpose because the
ExecutionConfig is declared Public and this would break the
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2037
[FLINK-3972] subclasses of ResourceID may not to be serializable
WorkerTypes are currently subclasses of ResourceID. ResourceID implements
Serializable but not necessarily its subclasses. This may lead
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2034#issuecomment-221577444
Thanks for the pull request! Looks good! Do you think we could integrate
with the `FlinkYarnSessionCli` as well? Once we merge this I will port this to
the client changes
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2034#discussion_r64572519
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/FlinkYarnSessionCli.java ---
@@ -91,6 +93,7 @@
public FlinkYarnSessionCli(String
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2033
[FLINK-3887] improve dependency management for building docs
The Flink documentation build process is currently quite messy. These
changes move us to a new build process with proper dependency handling
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2033#issuecomment-221561008
@uce Would you like to check out the changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2026#issuecomment-221251824
Follow-up issue is here: https://issues.apache.org/jira/browse/FLINK-2155
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2026#issuecomment-221250699
+1 going to merge. Let's fix the Checkstyle rule in a separate issue/pull
request.
---
If your project is set up for it, you can reply to this email and have your
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2022
[FLINK-3960] ignore EventTimeWindowCheckpointingITCase for now
Until FLINK-3960 is fixed, we need to disable this test to allow other
tests to execute properly.
You can merge this pull request into
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2019
[FLINK-3953] rename unit-tests execution to default-test
After 38698c0b101cbb48f8c10adf4060983ac07e2f4b, there are now two
executions defined for the Surefire plugin: unit-tests and
integration
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220642391
Merging...we need to fix the RocksDB issue afterwards. In the worst case,
we'll comment out the relevant test cases for now. The test which seems to
cause the segfaul
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220545613
The Travis builds here also segfault in all RocksDB tests. I'm assuming
these test failed silently in the past since I can't make any connection to the
test plug
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220388275
I get segfaults from RocksDB in my Travis tests:
https://travis-ci.org/mxm/flink/builds/131412162
Let's see how the builds here go. All in all, looks ready
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2013
[FLINK-3927][yarn] make container id consistent across Hadoop versions
Fixes a bug where the container id generation would vary across Hadoop
versions of the client/cluster. The ResourceManager assumes
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2012
[FLINK-3938] re-enable Yarn tests
Fixes a regression of #1915.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3938
Alternatively
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220321817
Thanks for looking into the problem and providing a detailed explanation
@markreddy. I think we're good to go with the newest version of the Surefire
plugin. I verifie
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/2009#discussion_r63854760
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/TestingLeaderRetrievalService.java
---
@@ -61,8 +61,6 @@ public void stop() throws
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220284867
Also pushed a version to my local Travis branch with some deliberately
failing tests and debug output to see if the above tests are executed correctly
(and don't
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2009
[FLINK-3893] improve LeaderChangeStateCleanupTest
Fixes discovered in the course of #1978.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2008
[FLINK-3892] return null when hostname unresolvable
Fix discovered in the course of #1978.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220276542
I just replaced Failsafe with Surefire. Also updated the version of
Surefire in a separate commit to see if the classpath issues occur there as
well (after all it'
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220269992
@aljoscha Yes, I think so too :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220269898
If we can't resolve issues with the Failsafe plugin, we could switch to
using the Surefire plugin also for Integration tests. Actually, the only
benefit of the Fai
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/2003#issuecomment-220035850
Tests fail in flink-runtime now. Seem to be class path related problems.
```
CheckpointIDCounterTest
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/2003
[FLINK-3909] update Maven Failsafe version
Failures during execution of the integration tests with the Maven
Failsafe plugin were silently ignored on Travis with Maven version
3.2.5. The problem
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219993662
Thanks for the review. I'll try to incorporate your suggestions. I'll ping
you again for a second look :)
---
If your project is set up for it, you can reply to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63683193
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
@@ -211,14 +191,41 @@ public void run() {
Runtime.getRuntime
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63681079
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -830,53 +797,30 @@ else if (result instanceof DisposeSavepointFailure
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-219989249
> I tried the change on a cluster, but the YARN session is not deploying:
I also tried out the changes on a (local) yarn cluster and everything
worked. I have
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680659
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -100,6 +102,9 @@
*/
private JobID lastJobID
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63680057
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/Client.java ---
@@ -65,31 +73,25 @@
/**
* Encapsulates the functionality
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1978#discussion_r63677960
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -20,8 +20,6 @@
--- End diff --
You're right,
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1945#issuecomment-218993072
Thanks for the PR!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1945#issuecomment-218987472
`GlobalConfiguration` doesn't ensure that the config has been loaded when
you call `get()`. It will give you an empty `Configuration` if you do not call
`loadConfigur
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1913#issuecomment-218821172
There are some subtle consequences of the fact that the `ExecutionConfig`
must not be modified after it has been passed to the `JobGraph` (because it has
been serialized
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1945#issuecomment-218736435
Looks good. Do you think we could make this more explicit by passing the
loaded configuration object to the `fetchConnectionInfo` method? That way we
don't depend on g
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1913#issuecomment-218719709
That's right. Actually we have the user class loader available at that
point in time. I fixed that.
---
If your project is set up for it, you can reply to this emai
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1978#issuecomment-218712827
One test run failed but it's unrelated to the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1913#issuecomment-218710671
@tillrohrmann @StephanEwen I've made the proposed changes. Could you have
another look and see if it is in a mergeable state?
---
If your project is set up for it, yo
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1913#issuecomment-218483592
Thanks for for your remarks. Instead of serializing/deserializing parts of
the `ExecutionConfig` whenever the usercode class loader needs to be passed, I
would like to
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1945#discussion_r62857420
--- Diff:
flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkShell.scala ---
@@ -141,7 +141,7 @@ object FlinkShell {
): (String, Int, Option
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1945#issuecomment-218476654
Thanks for the pull request. Looks good. Have you tested that the
configuration is loaded correctly?
---
If your project is set up for it, you can reply to this email and
801 - 900 of 1927 matches
Mail list logo
