Github user sbcd90 commented on the issue:
https://github.com/apache/flink/pull/1962
Hello @tzulitai ,
I have rebased the changes. Can you please review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sbcd90 commented on the issue:
https://github.com/apache/flink/pull/1962
Hi @tzulitai , thanks for the updates. I'll refactor the code & will rebase
the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user sbcd90 closed the pull request at:
https://github.com/apache/flink/pull/2644
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sbcd90 commented on the issue:
https://github.com/apache/flink/pull/2644
Hello @rmetzger ,
I'll open a new PR in bahir. Closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/2644
[FLINK-4837] flink-streaming-akka source connector
This PR is created to propose the idea of having a `flink-streaming-akka
source connector`.
The source connector can be used to receive
Github user sbcd90 commented on the issue:
https://github.com/apache/flink/pull/1962
Hello @tzulitai ,
I think default value for int in Java is 0.
The check if connection is lost or not & then retry for connection is a
good suggestion. Made the change.
separated
Github user sbcd90 commented on the issue:
https://github.com/apache/flink/pull/1962
Hello @StephanEwen ,
I have removed a timer & doing the retry logic directly now. The backoff is
3s. Please have a look.
---
If your project is set up for it, you can reply to this e
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217540405
Hello @rmetzger ,
I added a testcase now to the `ElasticsearchSinkITCase.java` list of tests.
Can you kindly have a look once?
---
If your project is set up
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217342680
Hello @rmetzger ,
Looking at the test case `ElasticsearchSinkItCase.testTransportClient`, I
think to test the re-connect scenario the `hasFailure` may need to be
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-217298024
Hello @rmetzger ,
Thanks a lot for reviewing the PR.
I have made all the changes mentioned by you as inline comments as well as
added some documentation
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1962#issuecomment-216874916
Hello @fhueske , The tests do not fail because of the changes made in the
PR. I tested the Junits for elasticsearch connector & all of them runs fine.
Can you ki
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1962
[FLINK-3857][Streaming Connectors]Add reconnect attempt to Elasticsearch
host
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-3857] Add
reconnect attem
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-187515384
Hello @mjsax , it is possible to use Travis for testing the redis. Travis
can start Redis during build. Please check out an example
[here](https://github.com/sbcd90
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1617#issuecomment-182688977
@mjsax Would you open a new thread in dev-mailing-list for discussion on
redis-state-backend. I'm really interested in the topic. & would like to work
o
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1617
[FLINK-3035] Redis as State Backend
@mjsax please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sbcd90/flink FLINK-3035
Alternatively
Github user sbcd90 closed the pull request at:
https://github.com/apache/flink/pull/1566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-180152337
Hello @tillrohrmann please review the commit as the work to be done is
nearly complete I believe. Please comment.
---
If your project is set up for it, you can reply to
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-179599473
Hello @tillrohrmann ..I have made all the changes you have mentioned.
- support for CompositeType.
- added test cases for both primitive type & compo
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-178174969
@tillrohrmann Thanks for the review. I had a few questions based on your
comments. Kindly help me in getting the questions answered so that I can
proceed.
---
If your
Github user sbcd90 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51476344
--- Diff:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparatorTest.java
---
@@ -0,0 +1,82 @@
+/*
+ * Licensed
Github user sbcd90 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1566#discussion_r51476173
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/GenericArrayComparator.java
---
@@ -0,0 +1,205 @@
+/*
+ * Licensed to
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1566#issuecomment-178034715
@StephanEwen could you also help reviewing the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1566
[FLINK-2678]DataSet API does not support multi-dimensional arrays as keys
Hello,
@tillrohrmann I have added support for multi-dimensional arrays as keys in
Dataset api. Please review
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-176153352
Hello zentol,
I dont see any updates from your side. Can you kindly let me know if this
PR is good to be merged so that I can close the issue?
---
If your
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175810825
Hello zentol,
I have squashed all changes. Can you please merge now?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175653356
Hello zentol,
Can you check the code changes now? The changes look exactly similar to
what you suggest. Can you let me know if this can be merged? or do I
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175592466
Hello zentol,
To answer your initial question,
```
is there any way to check which createStatement method is supported? what
happens if you use the
Github user sbcd90 commented on the pull request:
https://github.com/apache/flink/pull/1551#issuecomment-175589833
Hello zentol,
I made changes according to your post. Kindly review now.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sbcd90 opened a pull request:
https://github.com/apache/flink/pull/1551
[FLINK-3292]Fix for Bug in flink-jdbc. Not all JDBC drivers supported
Hello,
Here is the fix for issue FLINK-3292. Kindly review & merge.
Thanks & regards,
Subhobrata
29 matches
Mail list logo
