[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-07-27 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/853#issuecomment-125108629 Of couse, I will do it. 2015-07-22 14:31 GMT+02:00 Matthias J. Sax : > Can you also extend documentation for this feature? (I followed a > &

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-07-11 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/853#issuecomment-120652832 No, it is finished and waiting for acceptance. As I remember, Márton wanted to review the code, before merging it into the master. Peter 2015-07-11 16

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32925004 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/singlejoin

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32913535 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/wordcount

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-22 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/853#discussion_r32913023 --- Diff: flink-contrib/flink-storm-compatibility/flink-storm-compatibility-examples/src/main/java/org/apache/flink/stormcompatibility/util

[GitHub] flink pull request: [FLINK-2243] [storm-compat] Added finite spout...

2015-06-20 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/853 [FLINK-2243] [storm-compat] Added finite spout functionality to Storm compatibility layer Added finite spout functionality to Storm compatibility layer Storm spouts emit infinite streams. It

[GitHub] flink pull request: [contrib] Storm compatibility

2015-06-03 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/764#issuecomment-108298555 Okay then, it will remain as it is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink pull request: [contrib] Storm compatibility

2015-06-03 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/764#issuecomment-108284180 The first 10 commits are not rebased on the current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] flink pull request: [contrib] Storm compatibility

2015-06-03 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/764#issuecomment-108256209 This branch has a broken history. I will rewrite the commits. Please do not push anything until then. --- If your project is set up for it, you can reply to this email

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-05-20 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/521#issuecomment-103842766 Thank you Robert. Unfortunately, I didn't have much time this week to review the code. As soon as I'm done with the storm compatibility examples, I will

[GitHub] flink pull request: [FLINK-1595] [streaming] Complex integration t...

2015-05-04 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/520#issuecomment-98689457 Of course, I'm on it. I agree, separate tests would be much better. I'll try MiltipleProgramsTestBase for that purpose. Peter 2015-05-04

[GitHub] flink pull request: [FLINK-1911] [streaming] Streaming projection ...

2015-04-27 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/630 [FLINK-1911] [streaming] Streaming projection without types Since the DataSet projection has been reworked to not require the .types(...) call the Streaming and Batch methods were out of sync. So

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-04-22 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/521#issuecomment-95303397 @gyfora Of, course, no problem. It will make the source API cleaner. Peter --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-26 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-86582509 It runs just fine on my computer. Did you pull the latest state of the branch? The TwitterStreamData class was updated not so long ago. Also, the IterateExample isn&#

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-26 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-86565008 I tried to fix issue FLINK-1662, that is related to IterateExample. Gyula, what do you think? To see the actual bug, run IterateExample with parallelism 1 without the

[GitHub] flink pull request: [FLINK-1595] [streaming] Complex integration t...

2015-03-24 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/520#discussion_r27015100 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/complex/ComplexIntegrationTest.java --- @@ -0,0

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-03-24 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/521#issuecomment-85409807 Only new methods are added. There are two versions of generateSequence: a new parallel one, as in the batch API, but the old, sequential one is also useful for testing

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-03-24 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/521#issuecomment-85406974 I completeness checking between the streaming and batch java API sounds to be a great idea. I wouldn't force syncing in any other way, because there can be source me

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-03-24 Thread szape
Github user szape commented on a diff in the pull request: https://github.com/apache/flink/pull/521#discussion_r27010053 --- Diff: flink-staging/flink-streaming/flink-streaming-examples/src/main/java/org/apache/flink/streaming/examples/ReadFileExample.java --- @@ -0,0 +1,37

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread szape
Github user szape commented on the pull request: https://github.com/apache/flink/pull/519#issuecomment-85075533 Thank you guys! I corrected the errors. Updating the ITCases for parallelism 4 will be easier than I thought, but windowing makes it hard to test WindowJoin and

[GitHub] flink pull request: [FLINK-1687] [streaming] Syncing streaming sou...

2015-03-23 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/521 [FLINK-1687] [streaming] Syncing streaming source API with batch source API It is important to keep the streaming and the batch user facing API synchronised in regard of the source and sink functions

[GitHub] flink pull request: [FLINK-1595] [streaming] Complex integration t...

2015-03-23 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/520 [FLINK-1595] [streaming] Complex integration test wip Flink Streaming's complex integration test will test interactions of different streaming operators and settings. The test topology

[GitHub] flink pull request: FLINK-1560 - Add ITCases for streaming example...

2015-03-23 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/519 FLINK-1560 - Add ITCases for streaming examples ITCases for streaming examples have been added, except for IterateExample and StockPrices. I replaced the IterateExample with one that generates

[GitHub] flink pull request: [FLINK-1544] [streaming] POJO types added to A...

2015-03-23 Thread szape
GitHub user szape opened a pull request: https://github.com/apache/flink/pull/517 [FLINK-1544] [streaming] POJO types added to AggregationFunctionTest Testing aggragation functions with POJO types. The AggregationFunctionTest covered min, max, sum, minBy and maxBy aggregations