Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@twalthr Sure, please go ahead and let me know if anything I can help
further.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@suez1224 @twalthr any update please?
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
The latest commit uses **Types.OBJECT_ARRAY** to map Avro array type.
Hence, Avro **GenericData.Array** has to be converted into regular java arrays
back (see **AvroRowSerializationSchema
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@fhueske Great, let me take a look and commit another version later.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Hi @fhueske ,
Avro array type actually is mapped to Java List type, specifically the
class **org.apache.avro.generic.GenericData.Array** extends
**java.util.AbstractList**. I tried
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Particularly I suggest that we add LIST in org.apache.flink.table.api.Types
to support Avro array types. I can submit it in next commits if you guys think
the same.
---
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193168591
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks @suez1224 @twalthr for reviewing. Plz see my comments and latest
commits as per your comments.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thanks @suez1224 @twalthr for reviewing. Plz see my comments and latest
commits as per your comments.
---
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193137905
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193132257
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193102162
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193101536
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Thans @suez1224 @twalthr for reviewing. I've moved the unit tests from
KafkaAvroTableSourceTestBase to AvroRowDeSerializationSchemaTest. As for other
comments, plz see my comments.
---
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193092151
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193084082
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSourceTestBase.java
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6082#discussion_r193039834
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/typeutils/AvroRecordClassConverter.java
---
@@ -73,9 +75,37 @@ private
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
@twalthr @suez1224 would you please review on this?
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
I encountered another exception working with string type in Avro map/array,
any advice whether I should open a separate issue or just reusing this one.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6082
Please ignore previous commits, only the latest commit is relevant to this
issue.
---
GitHub user tragicjun opened a pull request:
https://github.com/apache/flink/pull/6082
[FLINK-9444] KafkaAvroTableSource failed to work for map fields
## What is the purpose of the change
Once some Avro schema has map fields, an exception will be thrown when
registering
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr the latest commit could be merged which contains all the changes.
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr sure, just a second, I never did this before, let me try
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
@twalthr Thanks for the comment. I've commited a new version as per your
suggestion. Particularly, I agree that TypeInfomation should always be derived
from the 'avroRecrodClass
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r189437091
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java
---
@@ -110,6 +116,8 @@ private void
Github user tragicjun commented on a diff in the pull request:
https://github.com/apache/flink/pull/6026#discussion_r189437087
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/KafkaAvroTableSource.java
---
@@ -81,7
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
Hi @suez1224, I've added some checks in the unit
tests(KafkaAvroTableSourceTestBase), which would fail before the fix.
Meanwhile, I found an issue in the previous version (specifically
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/6026
Thanks @suez1224 for reviewing. I've committed a new patch as per your
suggestions. As for the unit test, the issue was exposed in my integration
tests which requires a kafka setup, any advice
GitHub user tragicjun opened a pull request:
https://github.com/apache/flink/pull/6026
[FLINK-9384]KafkaAvroTableSource failed to work due to type mismatch
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
any progress on this?
---
Github user tragicjun commented on the issue:
https://github.com/apache/flink/pull/5897
encountered the same issue, any progress on this?
---
31 matches
Mail list logo
