[
https://issues.apache.org/jira/browse/FLINK-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14509124#comment-14509124
]
Vasia Kalavri commented on FLINK-1930:
--
Ok, so now the program fails with
[
https://issues.apache.org/jira/browse/FLINK-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507189#comment-14507189
]
Vasia Kalavri commented on FLINK-1930:
--
Hi [~rmetzger]! No, I'm not sure w
Vasia Kalavri created FLINK-1930:
Summary: NullPointerException in vertex-centric iteration
Key: FLINK-1930
URL: https://issues.apache.org/jira/browse/FLINK-1930
Project: Flink
Issue Type
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28769333
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -40,7 +42,37 @@
VertexValue extends
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94606828
Hi @balidani!
I pulled your changes and made some improvements, mainly to the examples,
so that they are consistent with the rest of Gelly's examples. You ca
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94183509
Thanks @balidani for the update! I left some inline comments which should
be fairly easy to address.
I would like to merge this soon and then we should open separate
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645615
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/RichEdge.java
---
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645524
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSASingleSourceShortestPathsExample.java
---
@@ -0,0 +1,216
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645507
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/GSAConnectedComponentsExample.java
---
@@ -0,0 +1,190
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645478
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -914,7 +919,7 @@ public long numberOfVertices() throws Exception
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645482
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1011,6 +1016,13 @@ public void reduce(Iterable> values,
Collec
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645462
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -79,7 +83,8 @@
private final DataSet> ed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/408#discussion_r28645450
--- Diff: flink-staging/flink-gelly/pom.xml ---
@@ -57,4 +57,35 @@ under the License.
${guava.version
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/596#discussion_r28645013
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/ConnectedComponents.java
---
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/600#issuecomment-94175152
I like it that you are using the example to show the migration process, but
I think it would also be helpful to add a section with more general guidelines,
describing all
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-94167112
Hi @andralungu! Thanks for the update :-)
I left a few inline comments. Overall it looks good, I just had a little
trouble following the logic in
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28644150
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -38,25 +42,57 @@
* @param The type of the
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28644140
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -40,7 +42,37 @@
VertexValue extends
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28644120
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/example/IncrementalSSSPITCase.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28644051
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -38,25 +42,57 @@
* @param The type of the
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643940
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
@@ -228,48 +213,92 @@ public void setInput
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643926
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
@@ -138,69 +146,46 @@ public void setInput
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643920
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
@@ -138,69 +146,46 @@ public void setInput
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643695
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
@@ -86,7 +92,9 @@
private DataSet
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643683
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexCentricIteration.java
---
@@ -24,18 +24,24 @@
import
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643520
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/IterationConfiguration.java
---
@@ -189,4 +199,33 @@ public void
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643494
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/SingleSourceShortestPaths.java
---
@@ -77,7 +77,7 @@ public Double map(Vertex
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643473
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643463
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643470
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643459
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643447
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643442
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643441
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643437
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/IncrementalSSSPExample.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643395
--- Diff: docs/gelly_guide.md ---
@@ -430,6 +440,46 @@ public static final class Messenger extends
MessagingFunction {...}
{% endhighlight
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643385
--- Diff: docs/gelly_guide.md ---
@@ -430,6 +440,46 @@ public static final class Messenger extends
MessagingFunction {...}
{% endhighlight
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643344
--- Diff: docs/gelly_guide.md ---
@@ -380,6 +380,16 @@ all aggregates globally once per superstep and makes
them available in the next
* Broadcast
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643290
--- Diff: docs/gelly_guide.md ---
@@ -380,6 +380,16 @@ all aggregates globally once per superstep and makes
them available in the next
* Broadcast
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r28643293
--- Diff: docs/gelly_guide.md ---
@@ -380,6 +380,16 @@ all aggregates globally once per superstep and makes
them available in the next
* Broadcast
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-94020543
Thanks @balidani! I'll try to review asap :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/598#issuecomment-94013714
Aha I see! I totally misunderstood your intention :-)
I'll take a look as soon as I finish a few more reviews. Thanks!
---
If your project is set up for it, yo
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/598#issuecomment-94002207
Hi @markus-h!
I see the point in having a bulk iteration in Gelly, however I'm not sure I
would add it as a "mode" in vertex-centric iteration. VertexC
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-93996607
Hi @andralungu! Thanks for the quick update ^^
The result looks good, but I have a few more comments/suggestions (apart
from the inline ones).
- +1 for the
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594561
--- Diff: docs/gelly_guide.md ---
@@ -316,28 +327,49 @@ DataSet> verticesWithSum =
graph.reduceOnNeighbors(
new SumVal
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28595115
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/EdgeDirection.java
---
@@ -20,10 +20,10 @@
/**
* The EdgeDirection is
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594425
--- Diff: docs/gelly_guide.md ---
@@ -282,25 +290,28 @@ The following code will collect the out-edges for
each vertex and apply the `Sel
{% highlight java
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594318
--- Diff: docs/gelly_guide.md ---
@@ -282,25 +290,28 @@ The following code will collect the out-edges for
each vertex and apply the `Sel
{% highlight java
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/576#discussion_r28594064
--- Diff: docs/gelly_guide.md ---
@@ -269,7 +269,15 @@ Neighborhood Methods
Neighborhood methods allow vertices to perform an aggregation on their
Vasia Kalavri created FLINK-1884:
Summary: Outdated Spargel docs
Key: FLINK-1884
URL: https://issues.apache.org/jira/browse/FLINK-1884
Project: Flink
Issue Type: Bug
Components
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/596#issuecomment-92494915
Hey @andralungu!
This is actually the connected components algorithm. You can rename it to
that.
And take a look at the corresponding [Spargel
example](https
[
https://issues.apache.org/jira/browse/FLINK-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492247#comment-14492247
]
Vasia Kalavri commented on FLINK-1871:
--
Great, thanks for taking care of
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-92301058
Hey @andralungu!
Now that #547 is merged, the degrees, total number of vertices and
direction can be added as configuration options. This should also simplify
writing
Vasia Kalavri created FLINK-1871:
Summary: Add a Spargel to Gelly migration guide
Key: FLINK-1871
URL: https://issues.apache.org/jira/browse/FLINK-1871
Project: Flink
Issue Type: Task
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-91048962
Thanks so much for the review @fhueske, @StephanEwen!
I'll make the suggested changes and merge :-)
---
If your project is set up for it, you can reply to this
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/576#issuecomment-90749788
Thanks for the PR @andralungu!
The idea for this issue is to (a) use a combinable reduce for the simple
(without vertex value) reduceOn* methods, because it will be
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/547#issuecomment-90745094
Hi,
any opinions on this?
I would like to merge it soon because it changes the api and vertex-centric
related issues depend on it.
Thanks!
---
If your project
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-90740868
Thank you @andralungu! This looks great now ^^
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-90233701
Hey @andralungu! Thanks a lot for your work on this :)
I only took a quick look at your changes for now, but it seems that all
issues are fixed.
This PR
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-90201652
Hey @andralungu. I agree that the code in `GatherNeighbors` might be
confusing. In my opinion, we could do the following to simplify it a bit:
- get rid of the Iterator
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/562#issuecomment-88851563
wow that was quick :)) Thanks a lot @tillrohrmann!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/545#issuecomment-88834217
Hi @tillrohrmann! Thanks for the heads up :)
The failing test is `DegreesWithExceptionITCase` and it seems that it fails
because of not throwing the excepted exception
[
https://issues.apache.org/jira/browse/FLINK-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri updated FLINK-1815:
-
Assignee: Faye Beligianni
> Add methods to read and write a Graph as adjacency l
[
https://issues.apache.org/jira/browse/FLINK-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392377#comment-14392377
]
Vasia Kalavri commented on FLINK-1815:
--
Thanks [~fobeligi]! I'll assign
Vasia Kalavri created FLINK-1815:
Summary: Add methods to read and write a Graph as adjacency list
Key: FLINK-1815
URL: https://issues.apache.org/jira/browse/FLINK-1815
Project: Flink
Issue
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-88104306
Yes, actually that is the correct behavior imo.
I mean, if you have a directed edge [4, 5], 4 is the source and 5 is the
target and these should not be swapped
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-88062186
Hey @andralungu, I'm not sure I understand what's the problem with
reduceOnEdges and EmitOneEdgePerNode. Can you elaborate a little bit please?
Thanks :)
-
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27408604
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-87751974
Hey @andralungu! Thanks a lot for this PR. I have left some inline
comments. Basically, it's not very clear (at least to me) whether you're
working on a d
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27408463
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27409101
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27408830
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27408109
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/544#discussion_r27407901
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/JaccardSimilarityMeasureExample.java
---
@@ -0,0 +1,207
[
https://issues.apache.org/jira/browse/FLINK-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri reassigned FLINK-1522:
Assignee: Vasia Kalavri (was: Daniel Bali)
> Add tests for the library methods
[
https://issues.apache.org/jira/browse/FLINK-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386865#comment-14386865
]
Vasia Kalavri commented on FLINK-1522:
--
[~balidani], [~andralungu] if I&#
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/547
[FLINK-1694] [gelly] added IterationConfiguration as a way to configure ...
...a VertexCentricIteration and avoid the split between create and run
methods.
You can merge this pull request into a Git
[
https://issues.apache.org/jira/browse/FLINK-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri resolved FLINK-1633.
--
Resolution: Implemented
Fix Version/s: 0.9
> Add getTriplets() Gelly met
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/452#issuecomment-87615727
Thanks @rmetzger! Just a heads up in case you hadn't seen this failure
before. Merging :-)
---
If your project is set up for it, you can reply to this email and have
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/452#issuecomment-87475338
Hi,
I got the following in my local Travis setup:
`Failed tests:
ChainTaskTest>TaskTestBase.shutdownMemoryManager:163 Memory Manager
managed memory
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-87462312
Hi @andralungu!
Regarding (2), I think you could do that inside VertexCentricIteration
instead of inside a method of Graph.
Regarding (3), I agree that adding
[
https://issues.apache.org/jira/browse/FLINK-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri reassigned FLINK-1694:
Assignee: Vasia Kalavri
> Change the split between create/run of a vertex-cent
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/452#issuecomment-87024583
Ha! This seems like travis is pending but it has actually finished o.O
There is the following failure for hadoop1 / openjdk 6:
`Failed tests
[
https://issues.apache.org/jira/browse/FLINK-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri resolved FLINK-1726.
--
Resolution: Implemented
Fix Version/s: 0.9
> Add Community Detection Library and Exam
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/537#issuecomment-86727594
Hey @andralungu! Thanks for this PR. I know it took more effort than you
might have thought initially :-)
I have a few comments:
- In my opinion, the degrees
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27257390
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/VertexUpdateFunction.java
---
@@ -40,7 +41,22 @@
VertexValue extends
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27256989
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/spargel/MessagingFunction.java
---
@@ -38,11 +41,41 @@
* @param The type of the
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27256784
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/LabelPropagation.java
---
@@ -68,12 +70,12 @@ public LabelPropagation(int
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27256701
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/LabelPropagation.java
---
@@ -68,12 +70,12 @@ public LabelPropagation(int
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27256440
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1141,8 +1185,33 @@ public boolean filter(Edge edge
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/537#discussion_r27255825
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/Graph.java ---
@@ -1118,17 +1118,61 @@ public boolean filter(Edge edge
[
https://issues.apache.org/jira/browse/FLINK-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382620#comment-14382620
]
Vasia Kalavri commented on FLINK-1694:
--
Thanks for the input guys!
[~balidani] r
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/505#issuecomment-86449745
Thank you @andralungu! Will merge later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/505#issuecomment-86007328
Thanks a lot for the updates @andralungu and for testing this on a cluster
environment :-)
The example code looks much nicer now ^-^.
Only minor issue is that the
[
https://issues.apache.org/jira/browse/FLINK-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379694#comment-14379694
]
Vasia Kalavri commented on FLINK-1694:
--
Any more opinions on this?
I know it
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/420#issuecomment-85487676
Hi @balidani! I think it's still a bit confusing how this example works.
As far as I understand, you expect a directed graph as input, but then you
convert it
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/505#discussion_r27017460
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/SimpleCommunityDetection.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/505#discussion_r27017296
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/library/SimpleCommunityDetection.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/505#discussion_r27017030
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/SimpleCommunityDetectionExample.java
---
@@ -0,0 +1,159
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/505#discussion_r27016738
--- Diff:
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/example/SimpleCommunityDetectionExample.java
---
@@ -0,0 +1,159
1001 - 1100 of 1270 matches
Mail list logo
