Re: [PR] [FLINK-33389][runtime] Support tasks balancing at slot level for Adaptive Scheduler [flink]

2024-11-07 Thread via GitHub
huyuanfeng2018 commented on code in PR #25504: URL: https://github.com/apache/flink/pull/25504#discussion_r1833781059 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/allocator/TaskBalancedSlotSharingStrategy.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed t

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463886561 CI failure,I will recheck the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [FLINK-16155][docs] Translate "Operator/Process Function" into Chinese [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25624: URL: https://github.com/apache/flink/pull/25624#issuecomment-2463886857 ## CI report: * 8ac73127b9537a3a543f0e4848ad156f1ae84f54 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-16155][docs] Translate "Operator/Process Function" into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 opened a new pull request, #25624: URL: https://github.com/apache/flink/pull/25624 What is the purpose of the change --- Translate Process Function page into Chinese Verifying this change --- This change is a trivial rework / code cleanup without any test covera

Re: [PR] [FLINK-36654] [table] Fix wrong cast when decimal divide integer [flink]

2024-11-07 Thread via GitHub
lincoln-lil commented on PR #25604: URL: https://github.com/apache/flink/pull/25604#issuecomment-2463875356 @xishuaidelin Could you also backport this fix into release-1.20? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [FLINK-36654] [table] Fix wrong cast when decimal divide integer [flink]

2024-11-07 Thread via GitHub
lincoln-lil merged PR #25604: URL: https://github.com/apache/flink/pull/25604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463867357 > @MOBIN-F Could you kindly rebase again? done~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463861429 @MOBIN-F Could you kindly rebase again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 commented on code in PR #3590: URL: https://github.com/apache/flink-cdc/pull/3590#discussion_r1833761648 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableP

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang merged PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696#issuecomment-2463843675 CI passed ,merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833746011 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [hotfix] Fix SUBSTR built-in function testcases [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3696: URL: https://github.com/apache/flink-cdc/pull/3696#issuecomment-2463839653 Done, all passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-36247][cdc-connector][mysql] Fix potential transaction leak du… [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 opened a new pull request, #3699: URL: https://github.com/apache/flink-cdc/pull/3699 …ring MySQL snapshot phase (#3602) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
GOODBOY008 commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833740746 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [FLINK-36247][cdc-connector] Fix potential transaction leak during MySQL snapshot phase [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3602: URL: https://github.com/apache/flink-cdc/pull/3602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-36282][pipeline-connector][cdc-connector][mysql]fix incorrect data type of TINYINT(1) in mysql pipeline connector [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 commented on code in PR #3608: URL: https://github.com/apache/flink-cdc/pull/3608#discussion_r1833670840 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/test/java/org/apache/flink/cdc/connectors/mysql/source/assigners/MySqlSnapshotSplitAssigne

Re: [PR] [hotfix] Fix Java 11 target compatibility & add tests [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on code in PR #3633: URL: https://github.com/apache/flink-cdc/pull/3633#discussion_r1833645373 ## .github/workflows/flink_cdc_migration_test.yml: ## @@ -28,7 +28,7 @@ jobs: submodules: true - uses: actions/setup-java@v4 with: -

Re: [PR] [BP-3.2][FLINK-36221] Add `CAST ... AS ...` documentations [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3694: URL: https://github.com/apache/flink-cdc/pull/3694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-36635][runtime] Remove PhysicalSlotRequestBulkImpl as it is not used [flink]

2024-11-07 Thread via GitHub
eemario commented on PR #25596: URL: https://github.com/apache/flink/pull/25596#issuecomment-2463645061 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2463611452 CI failure,It seems that this PR(https://github.com/apache/flink-cdc/pull/3696) should be merged first -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] commented on PR #3366: URL: https://github.com/apache/flink-cdc/pull/3366#issuecomment-2463458855 This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encou

Re: [PR] [minor][test] Remove duplicate test code [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] commented on PR #3460: URL: https://github.com/apache/flink-cdc/pull/3460#issuecomment-2463458749 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode [flink-cdc]

2024-11-07 Thread via GitHub
github-actions[bot] closed pull request #3366: [FLINK-35360] Submit Flink CDC pipeline job yarn Application mode URL: https://github.com/apache/flink-cdc/pull/3366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [FLINK-35414] Rework last-state upgrade mode to support job cancellation as suspend mechanism [flink-kubernetes-operator]

2024-11-07 Thread via GitHub
sap1ens commented on PR #871: URL: https://github.com/apache/flink-kubernetes-operator/pull/871#issuecomment-2463446748 @gyfora FYI, I think I found a regression: https://issues.apache.org/jira/browse/FLINK-36673 -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25623: URL: https://github.com/apache/flink/pull/25623#issuecomment-2463118913 ## CI report: * fb4ed527c0c31f58b7022d083449245d1936f0c8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25623: URL: https://github.com/apache/flink/pull/25623 This is a cherry-pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [BP-1.20][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25622: URL: https://github.com/apache/flink/pull/25622#issuecomment-2463111350 ## CI report: * a80b23046e5f37b007b5bdd13b8dabcbfac02eae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25622: URL: https://github.com/apache/flink/pull/25622 This is a cherry-pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin closed pull request #25621: [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner URL: https://github.com/apache/flink/pull/25621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] [BP-1.19][FLINK-36417][table] Add support for hints in WatermarkAssigner [flink]

2024-11-07 Thread via GitHub
snuyanzin opened a new pull request, #25621: URL: https://github.com/apache/flink/pull/25621 This is a cherr0pick of https://github.com/apache/flink/commit/4101316ef37d3a7082bff57cb732f4e9e0349d09 -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
nicusX commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833225006 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

[PR] [bp release-3.2][FLINK-36211][pipeline-connector/kafka] shade org.apache.flink.streaming.connectors.kafka to avoid conflict with flink-connector-kafka jar. (#3595) [flink-cdc]

2024-11-07 Thread via GitHub
lvyanquan opened a new pull request, #3697: URL: https://github.com/apache/flink-cdc/pull/3697 cherry picked from commit f24399cf5a32f4c79bbb6a86e3a3399f17bfbbe0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832523859 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833155289 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158443 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833163366 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connecto

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833159382 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158725 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833158015 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833157483 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833156129 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -123,6 +158,430 @@ WITH ( Connector Options - + + + +Option +

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833154045 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connecto

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833153362 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -40,10 +40,40 @@ Dependencies The Kinesis connector is not part of the binary distribution. See ho

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832536416 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832519329 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
nicusX commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1833085942 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -57,16 +87,21 @@ CREATE TABLE KinesisTable ( PARTITIONED BY (user_id, item_id) WITH ( 'connector'

Re: [PR] [BP-3.2][FLINK-36221] Add `CAST ... AS ...` documentations [flink-cdc]

2024-11-07 Thread via GitHub
GOODBOY008 commented on PR #3694: URL: https://github.com/apache/flink-cdc/pull/3694#issuecomment-2462185587 @yuxiqian Can you help fix https://github.com/apache/flink-cdc/actions/runs/11719299368/job/32655114796?pr=3694#step:4:399 ? -- This is an automated message from the Apache Git Se

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832538357 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832537388 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832527875 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832543911 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-35628][docs] Provide a Chinese translation of datagen.md [flink]

2024-11-07 Thread via GitHub
hlteoh37 commented on PR #25128: URL: https://github.com/apache/flink/pull/25128#issuecomment-2462653401 Looks good. Could we squash the commits to have a single commit with name `[FLINK-35628][docs] Provide a Chinese translation of datagen.md`? -- This is an automated message from the Ap

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832518101 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832515104 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-36592][state/forst] Support file cache for ForStStateBackend [flink]

2024-11-07 Thread via GitHub
fredia merged PR #25561: URL: https://github.com/apache/flink/pull/25561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-36635][runtime] Remove PhysicalSlotRequestBulkImpl as it is not used [flink]

2024-11-07 Thread via GitHub
eemario commented on PR #25596: URL: https://github.com/apache/flink/pull/25596#issuecomment-2461971637 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36502] [TABLE-SQL] Remove deprecated methods in FactoryUtil. [flink]

2024-11-07 Thread via GitHub
Sud0x67 commented on PR #25559: URL: https://github.com/apache/flink/pull/25559#issuecomment-2462556454 @fsk119 Thanks for your comments, I have updated this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832529448 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

[PR] [hotfix] Fix SUBSTR built-in function syntax (it is 1-based index now.) [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian opened a new pull request, #3696: URL: https://github.com/apache/flink-cdc/pull/3696 PR #3537 and #3592 has some implicit conflicts that will cause CI failure. #3537 changes `SUBSTR` function to 1-based index and corresponding test cases in #3592 didn't get updated yet. --

Re: [PR] [FLINK-36502] [TABLE-SQL] Remove deprecated methods in FactoryUtil. [flink]

2024-11-07 Thread via GitHub
Sud0x67 closed pull request #25559: [FLINK-36502] [TABLE-SQL] Remove deprecated methods in FactoryUtil. URL: https://github.com/apache/flink/pull/25559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-36502] [TABLE-SQL] Remove deprecated methods in FactoryUtil. [flink]

2024-11-07 Thread via GitHub
Sud0x67 commented on PR #25559: URL: https://github.com/apache/flink/pull/25559#issuecomment-2462559190 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832525097 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [BP-3.2][FLINK-36221] Add `CAST ... AS ...` documentations [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3694: URL: https://github.com/apache/flink-cdc/pull/3694#issuecomment-2462272056 Sure, done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832571255 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832520124 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832521188 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832527875 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832527361 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832515617 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832514730 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -27,644 +27,348 @@ under the License. # Amazon Kinesis Data Streams Connector -The Kinesis

Re: [PR] [FLINK-36266][table] Insert into as select * behaves incorrect [flink]

2024-11-07 Thread via GitHub
snuyanzin merged PR #25316: URL: https://github.com/apache/flink/pull/25316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832495432 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -141,7 +268,7 @@ annotations see [here](https://docs.aws.amazon.com/sdk-for-java/latest/devel

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832494228 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832477326 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832476673 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832475620 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
hlteoh37 commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1832475173 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -23,16 +23,143 @@ KIND, either express or implied. See the License for the specific language

Re: [PR] [FLINK-36662][table-planner] Port CALCITE-6317 to fix the incorrectly constant pullup when group keys in aggregate are NULL [flink]

2024-11-07 Thread via GitHub
lincoln-lil merged PR #25612: URL: https://github.com/apache/flink/pull/25612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-36662][table-planner] Port CALCITE-6317 to fix the incorrectly constant pullup when group keys in aggregate are NULL [flink]

2024-11-07 Thread via GitHub
lincoln-lil commented on PR #25612: URL: https://github.com/apache/flink/pull/25612#issuecomment-2461879314 > LGTM thanks for addressing feedback @snuyanzin Thank you! Merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
MOBIN-F commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2461897844 > @MOBIN-F Could you help rebase this PR? @leonardBang done~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Adding AWS Connectors v5.0.0 [flink-web]

2024-11-07 Thread via GitHub
dannycranmer commented on code in PR #760: URL: https://github.com/apache/flink-web/pull/760#discussion_r1832431016 ## docs/data/release_archive.yml: ## @@ -641,6 +641,11 @@ release_archive: version: 3.3.0 release_date: "2024-10-17" filename: "kafka" +-

Re: [PR] [FLINK-36408] Fix MySQL pipeline connector failed to parse FLOAT type with precision [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 commented on code in PR #3625: URL: https://github.com/apache/flink-cdc/pull/3625#discussion_r1832419660 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/utils/MySqlTypeUtils.java:

Re: [PR] [hotfix][metrics] Fix default value of endTsMillis in SpanBuilder [flink]

2024-11-07 Thread via GitHub
pnowojski commented on PR #25580: URL: https://github.com/apache/flink/pull/25580#issuecomment-2461841052 Thanks for fixing the issue! Merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [hotfix][metrics] Fix default value of endTsMillis in SpanBuilder [flink]

2024-11-07 Thread via GitHub
pnowojski merged PR #25580: URL: https://github.com/apache/flink/pull/25580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

Re: [PR] [FLINK-36105] Fix unable to restore from checkpoint with Flink 1.20 [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3564: URL: https://github.com/apache/flink-cdc/pull/3564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

Re: [PR] [FLINK-35980][tests] Add transform-related test cases [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian closed pull request #3509: [FLINK-35980][tests] Add transform-related test cases URL: https://github.com/apache/flink-cdc/pull/3509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [FLINK-35980][tests] Add transform-related test cases [flink-cdc]

2024-11-07 Thread via GitHub
yuxiqian commented on PR #3509: URL: https://github.com/apache/flink-cdc/pull/3509#issuecomment-2461825412 Closed by #3592. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-36093][transform] fix preTransformoperator wrongly filters columns when multiple transform [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on PR #3572: URL: https://github.com/apache/flink-cdc/pull/3572#issuecomment-2461825121 @MOBIN-F Could you help rebase this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-35985][transform] transform rules support substring function [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang merged PR #3537: URL: https://github.com/apache/flink-cdc/pull/3537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-35982] Fix transform metadata config doesn't work if no projection block was provided [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang merged PR #3592: URL: https://github.com/apache/flink-cdc/pull/3592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-36668][docs] Udpate AWS docs for v5.0 [flink]

2024-11-07 Thread via GitHub
hlteoh37 commented on PR #25615: URL: https://github.com/apache/flink/pull/25615#issuecomment-2461727622 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-31989][docs] Update english docs for KinesisStreamsSource and DynamoDbStreamsSource [flink-connector-aws]

2024-11-07 Thread via GitHub
nicusX commented on code in PR #179: URL: https://github.com/apache/flink-connector-aws/pull/179#discussion_r1831490695 ## docs/content/docs/connectors/datastream/dynamodb.md: ## @@ -141,7 +268,7 @@ annotations see [here](https://docs.aws.amazon.com/sdk-for-java/latest/develop

Re: [PR] [FLINK-36670][core] Optimize port range out-of-bounds exception log [flink]

2024-11-07 Thread via GitHub
flinkbot commented on PR #25620: URL: https://github.com/apache/flink/pull/25620#issuecomment-2461687110 ## CI report: * de798b7f22ccf9fc8731debfdf9f86d3856f3f25 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36461] Fix schema evolution failure with un-transformed tables [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on code in PR #3632: URL: https://github.com/apache/flink-cdc/pull/3632#discussion_r1832296112 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformOperator.java: ## @@ -265,12 +260,31 @@ private SchemaChangeEvent

[PR] [FLINK-36670][core] Optimize port range out-of-bounds exception log [flink]

2024-11-07 Thread via GitHub
Gianzie opened a new pull request, #25620: URL: https://github.com/apache/flink/pull/25620 ## What is the purpose of the change *It's better to add a space between "0" and "and"。 eg: "Port must be between 0and 65535" -> "Port must be between 0 and 65535"*

Re: [PR] [FLINK-16077][docs] Translate "Custom State Serialization" page into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 commented on PR #25617: URL: https://github.com/apache/flink/pull/25617#issuecomment-2461646602 Hi, @leonardBang @fredia . I'm sorry, but I had to close this PR because I mistakenly committed other code to the master branch. I will create a new PR to submit the changes related t

Re: [PR] [FLINK-16077][docs] Translate "Custom State Serialization" page into Chinese [flink]

2024-11-07 Thread via GitHub
liboshuai01 closed pull request #25617: [FLINK-16077][docs] Translate "Custom State Serialization" page into Chinese URL: https://github.com/apache/flink/pull/25617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-36178][pipeline-connector/mysql] Parse `CREATE TABLE ... LIKE …` syntax. [flink-cdc]

2024-11-07 Thread via GitHub
leonardBang commented on code in PR #3590: URL: https://github.com/apache/flink-cdc/pull/3590#discussion_r1832247695 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTablePa

Re: [PR] [FLINK-36221] Add `CAST ... AS ...` documentations [flink-cdc]

2024-11-07 Thread via GitHub
ruanhang1993 merged PR #3596: URL: https://github.com/apache/flink-cdc/pull/3596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flin

  1   2   3   4   5   6   7   8   9   10   >